[GitHub] [skywalking] kezhenxu94 commented on issue #4962: use 'make -f Makefile install' install skywalking-python occurred error?

2020-06-22 Thread GitBox
kezhenxu94 commented on issue #4962: URL: https://github.com/apache/skywalking/issues/4962#issuecomment-647947042 To be clear, run `git submodule update --init` before `make install` This is an automated message from the Apac

[GitHub] [skywalking] kezhenxu94 closed issue #4962: use 'make -f Makefile install' install skywalking-python occurred error?

2020-06-22 Thread GitBox
kezhenxu94 closed issue #4962: URL: https://github.com/apache/skywalking/issues/4962 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [skywalking] kezhenxu94 commented on issue #4962: use 'make -f Makefile install' install skywalking-python occurred error?

2020-06-22 Thread GitBox
kezhenxu94 commented on issue #4962: URL: https://github.com/apache/skywalking/issues/4962#issuecomment-647946556 @yue-chao it's my fault to miss one step in the docs, but please clone the submodule first before running `make install` --

[GitHub] [skywalking] yue-chao opened a new issue #4962: use 'make -f Makefile install' install skywalking-python occurred error?

2020-06-22 Thread GitBox
yue-chao opened a new issue #4962: URL: https://github.com/apache/skywalking/issues/4962 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [ *] Bug - [ ] Requirement - [ ] Feature or performance impro

[GitHub] [skywalking] mrproliu opened a new issue #4961: Provide server-side meter system

2020-06-22 Thread GitBox
mrproliu opened a new issue #4961: URL: https://github.com/apache/skywalking/issues/4961 Follow the [mail list discussion](https://lists.apache.org/thread.html/r428cf4727773414be80f26640110b9a089c9defd44c31f3de5ded86f%40%3Cdev.skywalking.apache.org%3E) and [design doc](https://docs.google

[GitHub] [skywalking] IanCao edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
IanCao edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647902479 > > Also, I noticed, there is brpc 3.x, do you plan to support it too? > > ok, let me investigate This seems a bit difficult ![image](https://user-imag

[GitHub] [skywalking] IanCao commented on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
IanCao commented on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647902479 > > Also, I noticed, there is brpc 3.x, do you plan to support it too? > > ok, let me investigate This seems a bit difficult ![image](https://user-images.gith

[skywalking-rocketbot-ui] branch master updated: feat: add status color (#320)

2020-06-22 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-rocketbot-ui.git The following commit(s) were added to refs/heads/master by this push: new 7bd1094 feat: add status colo

[GitHub] [skywalking] wu-sheng closed issue #4861: Incorrect state in link tracing: ERROR in one stage but whole stage link tracing shows SUCCESS

2020-06-22 Thread GitBox
wu-sheng closed issue #4861: URL: https://github.com/apache/skywalking/issues/4861 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [skywalking-rocketbot-ui] wu-sheng merged pull request #320: Feat: Add status color in trace table

2020-06-22 Thread GitBox
wu-sheng merged pull request #320: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/320 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [skywalking-rocketbot-ui] Fine0830 opened a new pull request #320: Feat: Add status color in trace table

2020-06-22 Thread GitBox
Fine0830 opened a new pull request #320: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/320 Reference https://github.com/apache/skywalking/issues/4861 screenshots ![trace](https://user-images.githubusercontent.com/20871783/85359399-b5c3c400-b548-11ea-8ab2-d8b53e93f414

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr&el=h1) Report > Merging [#4958](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr&el=h1) Report > Merging [#4958](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr&el=h1) Report > Merging [#4958](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr&el=h1) Report > Merging [#4958](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr&el=h1) Report > Merging [#4958](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr&el=h1) Report > Merging [#4958](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr&el=h1) Report > Merging [#4958](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr&el=h1) Report > Merging [#4958](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr&el=h1) Report > Merging [#4958](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr&e

[GitHub] [skywalking] wu-sheng commented on issue #4861: Incorrect state in link tracing: ERROR in one stage but whole stage link tracing shows SUCCESS

2020-06-22 Thread GitBox
wu-sheng commented on issue #4861: URL: https://github.com/apache/skywalking/issues/4861#issuecomment-647887880 Oh, I think that is the case, let's add it in 8.1.0 This is an automated message from the Apache Git Service. To

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr&el=h1) Report > Merging [#4958](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr&e

[GitHub] [skywalking] Fine0830 commented on issue #4861: Incorrect state in link tracing: ERROR in one stage but whole stage link tracing shows SUCCESS

2020-06-22 Thread GitBox
Fine0830 commented on issue #4861: URL: https://github.com/apache/skywalking/issues/4861#issuecomment-647887500 Probably there is another possibility that @regardfs misunderstand the trace table. Now the trace table doesn't show error status, like trace list. If it's necessary, I can add

[GitHub] [skywalking] IanCao commented on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
IanCao commented on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647887378 > Also, I noticed, there is brpc 3.x, do you plan to support it too? ok, let me investigate This is an

[GitHub] [skywalking] IanCao commented on a change in pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
IanCao commented on a change in pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#discussion_r443941693 ## File path: oap-server/server-core/src/test/resources/component-libraries.yml ## @@ -266,6 +266,9 @@ InfluxDB: influxdb-java: id: 90 languages:

[GitHub] [skywalking] IanCao commented on a change in pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
IanCao commented on a change in pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#discussion_r443941636 ## File path: oap-server/server-bootstrap/src/main/resources/component-libraries.yml ## @@ -302,6 +302,9 @@ InfluxDB: influxdb-java: id: 90 lang

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr&el=h1) Report > Merging [#4958](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr&e

[GitHub] [skywalking] wu-sheng commented on issue #4861: Incorrect state in link tracing: ERROR in one stage but whole stage link tracing shows SUCCESS

2020-06-22 Thread GitBox
wu-sheng commented on issue #4861: URL: https://github.com/apache/skywalking/issues/4861#issuecomment-647884645 @regardfs If you could the trace query result(Graphql response), it would be helpful to identify the issue. This

[GitHub] [skywalking] Fine0830 commented on issue #4861: Incorrect state in link tracing: ERROR in one stage but whole stage link tracing shows SUCCESS

2020-06-22 Thread GitBox
Fine0830 commented on issue #4861: URL: https://github.com/apache/skywalking/issues/4861#issuecomment-647879190 @regardfs Now, UI according to `isError` from server data to visualize trace list. I didn't find this error case. Could you check if your data that `isError` is true but logs are

[GitHub] [skywalking] dmsolr commented on a change in pull request #4847: [WIP]Provide kafka as collector/reporter

2020-06-22 Thread GitBox
dmsolr commented on a change in pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#discussion_r443930241 ## File path: oap-server/server-receiver-plugin/skywalking-mq-receiver-plugins/kafka-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/ka

[GitHub] [skywalking] dmsolr commented on a change in pull request #4847: [WIP]Provide kafka as collector/reporter

2020-06-22 Thread GitBox
dmsolr commented on a change in pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#discussion_r443929097 ## File path: apm-sniffer/optional-producer-plugins/kafka-producer-plugin/src/main/java/org/apache/skywalking/apm/agent/core/kafka/KafkaProfileTaskService.java

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4847: [WIP]Provide kafka as collector/reporter

2020-06-22 Thread GitBox
wu-sheng commented on a change in pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#discussion_r443915063 ## File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/jvm/JVMServiceSenderImpl.java ## @@ -0,0 +1,109 @@ +/* +

[skywalking-kubernetes] tag v3.0.0 created (now 25ca1ba)

2020-06-22 Thread innerpeacez
This is an automated email from the ASF dual-hosted git repository. innerpeacez pushed a change to tag v3.0.0 in repository https://gitbox.apache.org/repos/asf/skywalking-kubernetes.git. at 25ca1ba (commit) No new revisions were added by this update.

[GitHub] [skywalking] wu-sheng closed issue #4749: [Python] Add agent plugin test tool to the Python repo

2020-06-22 Thread GitBox
wu-sheng closed issue #4749: URL: https://github.com/apache/skywalking/issues/4749 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [skywalking] wu-sheng commented on issue #4749: [Python] Add agent plugin test tool to the Python repo

2020-06-22 Thread GitBox
wu-sheng commented on issue #4749: URL: https://github.com/apache/skywalking/issues/4749#issuecomment-647848481 Fixed through https://github.com/apache/skywalking-python/pull/10 This is an automated message from the Apache Gi

[GitHub] [skywalking] wu-sheng closed issue #4872: When the redis operation is abnormal, the span information is lost

2020-06-22 Thread GitBox
wu-sheng closed issue #4872: URL: https://github.com/apache/skywalking/issues/4872 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [skywalking] wu-sheng commented on issue #4872: When the redis operation is abnormal, the span information is lost

2020-06-22 Thread GitBox
wu-sheng commented on issue #4872: URL: https://github.com/apache/skywalking/issues/4872#issuecomment-647847817 No update in 15 days, closing. This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [skywalking] wu-sheng commented on issue #4808: Provide client-side meter system

2020-06-22 Thread GitBox
wu-sheng commented on issue #4808: URL: https://github.com/apache/skywalking/issues/4808#issuecomment-647846882 Is there a server-side meter system issue? We need to track the process. @mrproliu This is an automated message

[GitHub] [skywalking] wu-sheng closed issue #4808: Provide client-side meter system

2020-06-22 Thread GitBox
wu-sheng closed issue #4808: URL: https://github.com/apache/skywalking/issues/4808 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [skywalking-python] wu-sheng merged pull request #21: Add docs for how to build from sources and fail the builds when flake8 fails

2020-06-22 Thread GitBox
wu-sheng merged pull request #21: URL: https://github.com/apache/skywalking-python/pull/21 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[skywalking-python] branch master updated: Add docs for how to build from sources and fail the builds when flake8 fails (#21)

2020-06-22 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-python.git The following commit(s) were added to refs/heads/master by this push: new 0466f56 Add docs for how to build f

[GitHub] [skywalking-python] kezhenxu94 opened a new pull request #21: Add docs for how to build from sources and fail the builds when flake8 fails

2020-06-22 Thread GitBox
kezhenxu94 opened a new pull request #21: URL: https://github.com/apache/skywalking-python/pull/21 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[skywalking-python] branch doc-and-chore created (now e3f435c)

2020-06-22 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch doc-and-chore in repository https://gitbox.apache.org/repos/asf/skywalking-python.git. at e3f435c Add docs for how to build from sources and fail the builds when flake8 fails This br

[skywalking-python] 01/01: Add docs for how to build from sources and fail the builds when flake8 fails

2020-06-22 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a commit to branch doc-and-chore in repository https://gitbox.apache.org/repos/asf/skywalking-python.git commit e3f435c9fffe361d23bc19d61773d842213f387a Author: kezhenxu94 AuthorDate: Mon Jun 22 23:37:38 2020 +

[GitHub] [skywalking-python] kezhenxu94 merged pull request #20: Add werkzeug support to sw_http_server plugin

2020-06-22 Thread GitBox
kezhenxu94 merged pull request #20: URL: https://github.com/apache/skywalking-python/pull/20 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[skywalking-python] branch master updated: Add werkzeug support to sw_http_server plugin (#20)

2020-06-22 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-python.git The following commit(s) were added to refs/heads/master by this push: new 5f04fcd Add werkzeug support to

[GitHub] [skywalking] wu-sheng commented on issue #4957: skywalking has some problem with webflux

2020-06-22 Thread GitBox
wu-sheng commented on issue #4957: URL: https://github.com/apache/skywalking/issues/4957#issuecomment-647583665 A suggestion, once you have the SpringMVC, you could remove the webflux plugin and you should be fine. This is a

[GitHub] [skywalking] HowlsCastle commented on issue #4957: skywalking has some problem with webflux

2020-06-22 Thread GitBox
HowlsCastle commented on issue #4957: URL: https://github.com/apache/skywalking/issues/4957#issuecomment-647574391 I have seen the test case, there is only http request.when I use redis,mysql,mongo in project,the trace is really broken. ![code](https://user-images.githubusercontent.

[GitHub] [skywalking] songzhendong opened a new issue #4960: I'm going to add Nacos into SkyWalking main dependency

2020-06-22 Thread GitBox
songzhendong opened a new issue #4960: URL: https://github.com/apache/skywalking/issues/4960 I'm going to add Nacos into SkyWalking main dependency This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr&el=h1) Report > Merging [#4958](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr&el=h1) Report > Merging [#4958](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr&el=h1) Report > Merging [#4958](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr&e

[GitHub] [skywalking] EvanLjp commented on a change in pull request #4959: Configmap configuration

2020-06-22 Thread GitBox
EvanLjp commented on a change in pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#discussion_r443522852 ## File path: oap-server/server-configuration/configuration-configmap/pom.xml ## @@ -0,0 +1,31 @@ + Review comment: sorry, i would be fix later

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr&el=h1) Report > Merging [#4958](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr&el=h1) Report > Merging [#4958](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr&el=h1) Report > Merging [#4958](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr&el=h1) Report > Merging [#4958](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr&el=h1) Report > Merging [#4958](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr&el=h1) Report > Merging [#4958](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr&e

[GitHub] [skywalking] wu-sheng commented on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
wu-sheng commented on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647483228 Also, I noticed, there is brpc 3.x, do you plan to support it too? This is an automated message from the Apa

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr&el=h1) Report > Merging [#4958](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr&el=h1) Report > Merging [#4958](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr&el=h1) Report > Merging [#4958](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr&el=h1) Report > Merging [#4958](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr&el=h1) Report > Merging [#4958](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr&el=h1) Report > Merging [#4958](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr&el=h1) Report > Merging [#4958](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr&e

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
wu-sheng commented on a change in pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#discussion_r443514451 ## File path: oap-server/server-bootstrap/src/main/resources/component-libraries.yml ## @@ -302,6 +302,9 @@ InfluxDB: influxdb-java: id: 90 la

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr&el=h1) Report > Merging [#4958](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr&el=h1) Report > Merging [#4958](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr&el=h1) Report > Merging [#4958](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr&el=h1) Report > Merging [#4958](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr&e

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4959: Configmap configuration

2020-06-22 Thread GitBox
wu-sheng commented on a change in pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#discussion_r443512419 ## File path: oap-server/server-configuration/configuration-configmap/pom.xml ## @@ -0,0 +1,31 @@ + Review comment: I think you missed this li

[GitHub] [skywalking] wu-sheng commented on pull request #4959: Configmap configuration

2020-06-22 Thread GitBox
wu-sheng commented on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647475836 Please run rat check, is there ASF 2.0 header missing? This is an automated message from the Apache Git Serv

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr&el=h1) Report > Merging [#4958](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr&el=h1) Report > Merging [#4959](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr&el=h1) Report > Merging [#4959](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr&el=h1) Report > Merging [#4958](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr&el=h1) Report > Merging [#4959](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr&el=h1) Report > Merging [#4959](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr&el=h1) Report > Merging [#4959](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr&el=h1) Report > Merging [#4959](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr&el=h1) Report > Merging [#4959](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr&el=h1) Report > Merging [#4959](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr&el=h1) Report > Merging [#4959](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr&el=h1) Report > Merging [#4958](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr&el=h1) Report > Merging [#4959](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr&el=h1) Report > Merging [#4959](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr&el=h1) Report > Merging [#4959](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4958: add brpc-java plugin

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4958: URL: https://github.com/apache/skywalking/pull/4958#issuecomment-647381194 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr&el=h1) Report > Merging [#4958](https://codecov.io/gh/apache/skywalking/pull/4958?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr&el=h1) Report > Merging [#4959](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr&el=h1) Report > Merging [#4959](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr&el=h1) Report > Merging [#4959](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-06-22 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr&el=h1) Report > Merging [#4959](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr&e

  1   2   3   >