[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5084: #4907 - Duplicate Spring MVC endpoint fix

2020-07-13 Thread GitBox
codecov[bot] edited a comment on pull request #5084: URL: https://github.com/apache/skywalking/pull/5084#issuecomment-657068955 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5084?src=pr&el=h1) Report > Merging [#5084](https://codecov.io/gh/apache/skywalking/pull/5084?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5084: #4907 - Duplicate Spring MVC endpoint fix

2020-07-13 Thread GitBox
codecov[bot] edited a comment on pull request #5084: URL: https://github.com/apache/skywalking/pull/5084#issuecomment-657068955 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5084?src=pr&el=h1) Report > Merging [#5084](https://codecov.io/gh/apache/skywalking/pull/5084?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5084: #4907 - Duplicate Spring MVC endpoint fix

2020-07-13 Thread GitBox
codecov[bot] edited a comment on pull request #5084: URL: https://github.com/apache/skywalking/pull/5084#issuecomment-657068955 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5084?src=pr&el=h1) Report > Merging [#5084](https://codecov.io/gh/apache/skywalking/pull/5084?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5084: #4907 - Duplicate Spring MVC endpoint fix

2020-07-13 Thread GitBox
codecov[bot] edited a comment on pull request #5084: URL: https://github.com/apache/skywalking/pull/5084#issuecomment-657068955 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5084?src=pr&el=h1) Report > Merging [#5084](https://codecov.io/gh/apache/skywalking/pull/5084?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5084: #4907 - Duplicate Spring MVC endpoint fix

2020-07-13 Thread GitBox
codecov[bot] edited a comment on pull request #5084: URL: https://github.com/apache/skywalking/pull/5084#issuecomment-657068955 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5084?src=pr&el=h1) Report > Merging [#5084](https://codecov.io/gh/apache/skywalking/pull/5084?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5084: #4907 - Duplicate Spring MVC endpoint fix

2020-07-13 Thread GitBox
codecov[bot] edited a comment on pull request #5084: URL: https://github.com/apache/skywalking/pull/5084#issuecomment-657068955 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5084: #4907 - Duplicate Spring MVC endpoint fix

2020-07-13 Thread GitBox
codecov[bot] edited a comment on pull request #5084: URL: https://github.com/apache/skywalking/pull/5084#issuecomment-657068955 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5084?src=pr&el=h1) Report > Merging [#5084](https://codecov.io/gh/apache/skywalking/pull/5084?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5084: #4907 - Duplicate Spring MVC endpoint fix

2020-07-13 Thread GitBox
codecov[bot] edited a comment on pull request #5084: URL: https://github.com/apache/skywalking/pull/5084#issuecomment-657068955 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5084: #4907 - Duplicate Spring MVC endpoint fix

2020-07-13 Thread GitBox
codecov[bot] edited a comment on pull request #5084: URL: https://github.com/apache/skywalking/pull/5084#issuecomment-657068955 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5084?src=pr&el=h1) Report > Merging [#5084](https://codecov.io/gh/apache/skywalking/pull/5084?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5084: #4907 - Duplicate Spring MVC endpoint fix

2020-07-13 Thread GitBox
codecov[bot] edited a comment on pull request #5084: URL: https://github.com/apache/skywalking/pull/5084#issuecomment-657068955 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5084?src=pr&el=h1) Report > Merging [#5084](https://codecov.io/gh/apache/skywalking/pull/5084?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5084: #4907 - Duplicate Spring MVC endpoint fix

2020-07-13 Thread GitBox
codecov[bot] edited a comment on pull request #5084: URL: https://github.com/apache/skywalking/pull/5084#issuecomment-657068955 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5084?src=pr&el=h1) Report > Merging [#5084](https://codecov.io/gh/apache/skywalking/pull/5084?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5084: #4907 - Duplicate Spring MVC endpoint fix

2020-07-13 Thread GitBox
codecov[bot] edited a comment on pull request #5084: URL: https://github.com/apache/skywalking/pull/5084#issuecomment-657068955 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5084?src=pr&el=h1) Report > Merging [#5084](https://codecov.io/gh/apache/skywalking/pull/5084?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5084: #4907 - Duplicate Spring MVC endpoint fix

2020-07-13 Thread GitBox
codecov[bot] edited a comment on pull request #5084: URL: https://github.com/apache/skywalking/pull/5084#issuecomment-657068955 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5084?src=pr&el=h1) Report > Merging [#5084](https://codecov.io/gh/apache/skywalking/pull/5084?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5084: #4907 - Duplicate Spring MVC endpoint fix

2020-07-13 Thread GitBox
codecov[bot] edited a comment on pull request #5084: URL: https://github.com/apache/skywalking/pull/5084#issuecomment-657068955 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5084?src=pr&el=h1) Report > Merging [#5084](https://codecov.io/gh/apache/skywalking/pull/5084?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5084: #4907 - Duplicate Spring MVC endpoint fix

2020-07-13 Thread GitBox
codecov[bot] edited a comment on pull request #5084: URL: https://github.com/apache/skywalking/pull/5084#issuecomment-657068955 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5084?src=pr&el=h1) Report > Merging [#5084](https://codecov.io/gh/apache/skywalking/pull/5084?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5084: #4907 - Duplicate Spring MVC endpoint fix

2020-07-13 Thread GitBox
codecov[bot] edited a comment on pull request #5084: URL: https://github.com/apache/skywalking/pull/5084#issuecomment-657068955 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5084?src=pr&el=h1) Report > Merging [#5084](https://codecov.io/gh/apache/skywalking/pull/5084?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5084: #4907 - Duplicate Spring MVC endpoint fix

2020-07-13 Thread GitBox
codecov[bot] edited a comment on pull request #5084: URL: https://github.com/apache/skywalking/pull/5084#issuecomment-657068955 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5084?src=pr&el=h1) Report > Merging [#5084](https://codecov.io/gh/apache/skywalking/pull/5084?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5084: #4907 - Duplicate Spring MVC endpoint fix

2020-07-13 Thread GitBox
codecov[bot] edited a comment on pull request #5084: URL: https://github.com/apache/skywalking/pull/5084#issuecomment-657068955 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5084?src=pr&el=h1) Report > Merging [#5084](https://codecov.io/gh/apache/skywalking/pull/5084?src=pr&e

[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on issue #330: Add the same menu search, but the filter always jumps to the previous search URL

2020-07-13 Thread GitBox
wu-sheng commented on issue #330: URL: https://github.com/apache/skywalking-rocketbot-ui/issues/330#issuecomment-657441555 Local dev issue should be fixed by yourself. This is an automated message from the Apache Git Service

[GitHub] [skywalking-rocketbot-ui] wu-sheng closed issue #330: Add the same menu search, but the filter always jumps to the previous search URL

2020-07-13 Thread GitBox
wu-sheng closed issue #330: URL: https://github.com/apache/skywalking-rocketbot-ui/issues/330 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [skywalking] weihuaxiong opened a new issue #5089: dynamic configuration consul, does "Config Key" can change to other

2020-07-13 Thread GitBox
weihuaxiong opened a new issue #5089: URL: https://github.com/apache/skywalking/issues/5089 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ 1] Question or discussion - [ ] Bug - [ ] Requirement - [ ] Feature or performance im

[GitHub] [skywalking] wu-sheng closed issue #5089: dynamic configuration consul, does "Config Key" can change to other

2020-07-13 Thread GitBox
wu-sheng closed issue #5089: URL: https://github.com/apache/skywalking/issues/5089 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [skywalking] wu-sheng commented on issue #5089: dynamic configuration consul, does "Config Key" can change to other

2020-07-13 Thread GitBox
wu-sheng commented on issue #5089: URL: https://github.com/apache/skywalking/issues/5089#issuecomment-657492801 Is that isolated by app or namespace? Key should not be changed in any case. This is an automated message from th

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5086: Add support for spring webclient

2020-07-13 Thread GitBox
codecov[bot] edited a comment on pull request #5086: URL: https://github.com/apache/skywalking/pull/5086#issuecomment-657164063 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5086?src=pr&el=h1) Report > Merging [#5086](https://codecov.io/gh/apache/skywalking/pull/5086?src=pr&e

[GitHub] [skywalking] wu-sheng commented on a change in pull request #5086: Add support for spring webclient

2020-07-13 Thread GitBox
wu-sheng commented on a change in pull request #5086: URL: https://github.com/apache/skywalking/pull/5086#discussion_r453683353 ## File path: apm-sniffer/apm-sdk-plugin/spring-plugins/spring-webflux-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/spring/webflux/v5/DefaultExc

[GitHub] [skywalking] wu-sheng commented on a change in pull request #5086: Add support for spring webclient

2020-07-13 Thread GitBox
wu-sheng commented on a change in pull request #5086: URL: https://github.com/apache/skywalking/pull/5086#discussion_r453683353 ## File path: apm-sniffer/apm-sdk-plugin/spring-plugins/spring-webflux-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/spring/webflux/v5/DefaultExc

[GitHub] [skywalking] arugal commented on a change in pull request #5086: Add support for spring webclient

2020-07-13 Thread GitBox
arugal commented on a change in pull request #5086: URL: https://github.com/apache/skywalking/pull/5086#discussion_r453692365 ## File path: apm-sniffer/apm-sdk-plugin/spring-plugins/spring-webflux-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/spring/webflux/v5/DefaultExcha

[GitHub] [skywalking] wu-sheng commented on a change in pull request #5086: Add support for spring webclient

2020-07-13 Thread GitBox
wu-sheng commented on a change in pull request #5086: URL: https://github.com/apache/skywalking/pull/5086#discussion_r453683353 ## File path: apm-sniffer/apm-sdk-plugin/spring-plugins/spring-webflux-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/spring/webflux/v5/DefaultExc

[GitHub] [skywalking] arugal commented on a change in pull request #5086: Add support for spring webclient

2020-07-13 Thread GitBox
arugal commented on a change in pull request #5086: URL: https://github.com/apache/skywalking/pull/5086#discussion_r453705177 ## File path: test/plugin/scenarios/webflux-scenario/config/expectedData.yaml ## @@ -193,6 +193,66 @@ segmentItems: parentSpanId: 8, parentTrac

[GitHub] [skywalking-rocketbot-ui] Jtrust commented on issue #327: When you enter a Service filter that doesn't match anything, nothing changes on the page UI

2020-07-13 Thread GitBox
Jtrust commented on issue #327: URL: https://github.com/apache/skywalking-rocketbot-ui/issues/327#issuecomment-657610414 For example, enter `projectd` first and then enter `test`, the case appeares. ![31594647806_ pic_hd](https://user-images.githubusercontent.com/21056967/87318703-49425

[GitHub] [skywalking] wu-sheng commented on a change in pull request #5086: Add support for spring webclient

2020-07-13 Thread GitBox
wu-sheng commented on a change in pull request #5086: URL: https://github.com/apache/skywalking/pull/5086#discussion_r453712160 ## File path: test/plugin/scenarios/webflux-scenario/config/expectedData.yaml ## @@ -193,6 +193,66 @@ segmentItems: parentSpanId: 8, parentTr

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5086: Add support for spring webclient

2020-07-13 Thread GitBox
codecov[bot] edited a comment on pull request #5086: URL: https://github.com/apache/skywalking/pull/5086#issuecomment-657164063 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5086?src=pr&el=h1) Report > Merging [#5086](https://codecov.io/gh/apache/skywalking/pull/5086?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5086: Add support for spring webclient

2020-07-13 Thread GitBox
codecov[bot] edited a comment on pull request #5086: URL: https://github.com/apache/skywalking/pull/5086#issuecomment-657164063 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5086?src=pr&el=h1) Report > Merging [#5086](https://codecov.io/gh/apache/skywalking/pull/5086?src=pr&e

[GitHub] [skywalking] dengliming commented on pull request #5086: Add support for spring webclient

2020-07-13 Thread GitBox
dengliming commented on pull request #5086: URL: https://github.com/apache/skywalking/pull/5086#issuecomment-657615049 > @dengliming I think you haven't updated `Supported-list.md`. Could you update it? Only test 2.1.x, 2.2.x and 2.3 not test yet. --

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5086: Add support for spring webclient

2020-07-13 Thread GitBox
codecov[bot] edited a comment on pull request #5086: URL: https://github.com/apache/skywalking/pull/5086#issuecomment-657164063 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5086?src=pr&el=h1) Report > Merging [#5086](https://codecov.io/gh/apache/skywalking/pull/5086?src=pr&e

[GitHub] [skywalking] wu-sheng commented on a change in pull request #5086: Add support for spring webclient

2020-07-13 Thread GitBox
wu-sheng commented on a change in pull request #5086: URL: https://github.com/apache/skywalking/pull/5086#discussion_r453718649 ## File path: test/plugin/scenarios/webflux-scenario/config/expectedData.yaml ## @@ -193,6 +193,66 @@ segmentItems: parentSpanId: 8, parentTr

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5086: Add support for spring webclient

2020-07-13 Thread GitBox
codecov[bot] edited a comment on pull request #5086: URL: https://github.com/apache/skywalking/pull/5086#issuecomment-657164063 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5086?src=pr&el=h1) Report > Merging [#5086](https://codecov.io/gh/apache/skywalking/pull/5086?src=pr&e

[GitHub] [skywalking] wu-sheng commented on a change in pull request #5086: Add support for spring webclient

2020-07-13 Thread GitBox
wu-sheng commented on a change in pull request #5086: URL: https://github.com/apache/skywalking/pull/5086#discussion_r453719393 ## File path: test/plugin/scenarios/webflux-scenario/config/expectedData.yaml ## @@ -193,6 +193,66 @@ segmentItems: parentSpanId: 8, parentTr

[GitHub] [skywalking] wu-sheng commented on a change in pull request #5086: Add support for spring webclient

2020-07-13 Thread GitBox
wu-sheng commented on a change in pull request #5086: URL: https://github.com/apache/skywalking/pull/5086#discussion_r453720031 ## File path: test/plugin/scenarios/webflux-scenario/webflux-projectA-scenario/src/main/java/org/apache/skywalking/apm/testcase/sc/webflux/projectA/controlle

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5086: Add support for spring webclient

2020-07-13 Thread GitBox
codecov[bot] edited a comment on pull request #5086: URL: https://github.com/apache/skywalking/pull/5086#issuecomment-657164063 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5086?src=pr&el=h1) Report > Merging [#5086](https://codecov.io/gh/apache/skywalking/pull/5086?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5086: Add support for spring webclient

2020-07-13 Thread GitBox
codecov[bot] edited a comment on pull request #5086: URL: https://github.com/apache/skywalking/pull/5086#issuecomment-657164063 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5086?src=pr&el=h1) Report > Merging [#5086](https://codecov.io/gh/apache/skywalking/pull/5086?src=pr&e

[GitHub] [skywalking] wu-sheng commented on a change in pull request #5086: Add support for spring webclient

2020-07-13 Thread GitBox
wu-sheng commented on a change in pull request #5086: URL: https://github.com/apache/skywalking/pull/5086#discussion_r453722841 ## File path: test/plugin/scenarios/webflux-scenario/config/expectedData.yaml ## @@ -193,6 +193,66 @@ segmentItems: parentSpanId: 8, parentTr

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5086: Add support for spring webclient

2020-07-13 Thread GitBox
codecov[bot] edited a comment on pull request #5086: URL: https://github.com/apache/skywalking/pull/5086#issuecomment-657164063 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5086?src=pr&el=h1) Report > Merging [#5086](https://codecov.io/gh/apache/skywalking/pull/5086?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5086: Add support for spring webclient

2020-07-13 Thread GitBox
codecov[bot] edited a comment on pull request #5086: URL: https://github.com/apache/skywalking/pull/5086#issuecomment-657164063 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5086?src=pr&el=h1) Report > Merging [#5086](https://codecov.io/gh/apache/skywalking/pull/5086?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5086: Add support for spring webclient

2020-07-13 Thread GitBox
codecov[bot] edited a comment on pull request #5086: URL: https://github.com/apache/skywalking/pull/5086#issuecomment-657164063 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5086?src=pr&el=h1) Report > Merging [#5086](https://codecov.io/gh/apache/skywalking/pull/5086?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5086: Add support for spring webclient

2020-07-13 Thread GitBox
codecov[bot] edited a comment on pull request #5086: URL: https://github.com/apache/skywalking/pull/5086#issuecomment-657164063 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5086?src=pr&el=h1) Report > Merging [#5086](https://codecov.io/gh/apache/skywalking/pull/5086?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5086: Add support for spring webclient

2020-07-13 Thread GitBox
codecov[bot] edited a comment on pull request #5086: URL: https://github.com/apache/skywalking/pull/5086#issuecomment-657164063 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5086?src=pr&el=h1) Report > Merging [#5086](https://codecov.io/gh/apache/skywalking/pull/5086?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5086: Add support for spring webclient

2020-07-13 Thread GitBox
codecov[bot] edited a comment on pull request #5086: URL: https://github.com/apache/skywalking/pull/5086#issuecomment-657164063 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5086?src=pr&el=h1) Report > Merging [#5086](https://codecov.io/gh/apache/skywalking/pull/5086?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5086: Add support for spring webclient

2020-07-13 Thread GitBox
codecov[bot] edited a comment on pull request #5086: URL: https://github.com/apache/skywalking/pull/5086#issuecomment-657164063 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5086?src=pr&el=h1) Report > Merging [#5086](https://codecov.io/gh/apache/skywalking/pull/5086?src=pr&e

[GitHub] [skywalking] wu-sheng commented on a change in pull request #5086: Add support for spring webclient

2020-07-13 Thread GitBox
wu-sheng commented on a change in pull request #5086: URL: https://github.com/apache/skywalking/pull/5086#discussion_r453727127 ## File path: test/plugin/scenarios/webflux-scenario/config/expectedData.yaml ## @@ -193,6 +193,66 @@ segmentItems: parentSpanId: 8, parentTr

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5086: Add support for spring webclient

2020-07-13 Thread GitBox
codecov[bot] edited a comment on pull request #5086: URL: https://github.com/apache/skywalking/pull/5086#issuecomment-657164063 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5086?src=pr&el=h1) Report > Merging [#5086](https://codecov.io/gh/apache/skywalking/pull/5086?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5086: Add support for spring webclient

2020-07-13 Thread GitBox
codecov[bot] edited a comment on pull request #5086: URL: https://github.com/apache/skywalking/pull/5086#issuecomment-657164063 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5086?src=pr&el=h1) Report > Merging [#5086](https://codecov.io/gh/apache/skywalking/pull/5086?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5086: Add support for spring webclient

2020-07-13 Thread GitBox
codecov[bot] edited a comment on pull request #5086: URL: https://github.com/apache/skywalking/pull/5086#issuecomment-657164063 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5086?src=pr&el=h1) Report > Merging [#5086](https://codecov.io/gh/apache/skywalking/pull/5086?src=pr&e

[GitHub] [skywalking] dengliming commented on a change in pull request #5086: Add support for spring webclient

2020-07-13 Thread GitBox
dengliming commented on a change in pull request #5086: URL: https://github.com/apache/skywalking/pull/5086#discussion_r453729211 ## File path: test/plugin/scenarios/webflux-scenario/config/expectedData.yaml ## @@ -193,6 +193,66 @@ segmentItems: parentSpanId: 8, parent

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5086: Add support for spring webclient

2020-07-13 Thread GitBox
codecov[bot] edited a comment on pull request #5086: URL: https://github.com/apache/skywalking/pull/5086#issuecomment-657164063 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5086?src=pr&el=h1) Report > Merging [#5086](https://codecov.io/gh/apache/skywalking/pull/5086?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5086: Add support for spring webclient

2020-07-13 Thread GitBox
codecov[bot] edited a comment on pull request #5086: URL: https://github.com/apache/skywalking/pull/5086#issuecomment-657164063 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5086?src=pr&el=h1) Report > Merging [#5086](https://codecov.io/gh/apache/skywalking/pull/5086?src=pr&e

[GitHub] [skywalking] dengliming commented on a change in pull request #5086: Add support for spring webclient

2020-07-13 Thread GitBox
dengliming commented on a change in pull request #5086: URL: https://github.com/apache/skywalking/pull/5086#discussion_r453733342 ## File path: test/plugin/scenarios/webflux-scenario/config/expectedData.yaml ## @@ -193,6 +193,66 @@ segmentItems: parentSpanId: 8, parent

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5086: Add support for spring webclient

2020-07-13 Thread GitBox
codecov[bot] edited a comment on pull request #5086: URL: https://github.com/apache/skywalking/pull/5086#issuecomment-657164063 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5086?src=pr&el=h1) Report > Merging [#5086](https://codecov.io/gh/apache/skywalking/pull/5086?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5086: Add support for spring webclient

2020-07-13 Thread GitBox
codecov[bot] edited a comment on pull request #5086: URL: https://github.com/apache/skywalking/pull/5086#issuecomment-657164063 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5086?src=pr&el=h1) Report > Merging [#5086](https://codecov.io/gh/apache/skywalking/pull/5086?src=pr&e

[GitHub] [skywalking] dengliming commented on a change in pull request #5086: Add support for spring webclient

2020-07-13 Thread GitBox
dengliming commented on a change in pull request #5086: URL: https://github.com/apache/skywalking/pull/5086#discussion_r453736742 ## File path: test/plugin/scenarios/webflux-scenario/config/expectedData.yaml ## @@ -193,6 +193,66 @@ segmentItems: parentSpanId: 8, parent

[GitHub] [skywalking-python] alonelaval opened a new pull request #35: add PyMsql Plugin

2020-07-13 Thread GitBox
alonelaval opened a new pull request #35: URL: https://github.com/apache/skywalking-python/pull/35 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [skywalking] dengliming commented on a change in pull request #5086: Add support for spring webclient

2020-07-13 Thread GitBox
dengliming commented on a change in pull request #5086: URL: https://github.com/apache/skywalking/pull/5086#discussion_r453733342 ## File path: test/plugin/scenarios/webflux-scenario/config/expectedData.yaml ## @@ -193,6 +193,66 @@ segmentItems: parentSpanId: 8, parent

[GitHub] [skywalking] dengliming commented on a change in pull request #5086: Add support for spring webclient

2020-07-13 Thread GitBox
dengliming commented on a change in pull request #5086: URL: https://github.com/apache/skywalking/pull/5086#discussion_r453834665 ## File path: test/plugin/scenarios/webflux-scenario/config/expectedData.yaml ## @@ -193,6 +193,66 @@ segmentItems: parentSpanId: 8, parent

[GitHub] [skywalking] Universe-Milky opened a new issue #5090: How to get the slowest span in each level of the tree?

2020-07-13 Thread GitBox
Universe-Milky opened a new issue #5090: URL: https://github.com/apache/skywalking/issues/5090 Please answer these questions before submitting your issue. - Why do you submit this issue? - [x] Question or discussion - [ ] Bug - [ ] Requirement - [ ] Feature or performance

[GitHub] [skywalking] arugal commented on a change in pull request #5086: Add support for spring webclient

2020-07-13 Thread GitBox
arugal commented on a change in pull request #5086: URL: https://github.com/apache/skywalking/pull/5086#discussion_r454042259 ## File path: test/plugin/scenarios/webflux-scenario/config/expectedData.yaml ## @@ -193,6 +193,66 @@ segmentItems: parentSpanId: 8, parentTrac

[GitHub] [skywalking] haolanzhong opened a new issue #5091: Front end compatibility issues

2020-07-13 Thread GitBox
haolanzhong opened a new issue #5091: URL: https://github.com/apache/skywalking/issues/5091 Hello, is there a browser compatibility issue with version 8.0.1? At present, I find that only Google and Firefox are compatible. And in the performance analysis, the console will report errors. -

[skywalking] branch zipkin created (now 9b65221)

2020-07-13 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch zipkin in repository https://gitbox.apache.org/repos/asf/skywalking.git. at 9b65221 Zipkin tracer context implementation draft. This branch includes the following new commits: new

[skywalking] 01/01: Zipkin tracer context implementation draft.

2020-07-13 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch zipkin in repository https://gitbox.apache.org/repos/asf/skywalking.git commit 9b65221ba05318613613202b5611a4af307f9fa8 Author: Wu Sheng AuthorDate: Tue Jul 14 09:44:13 2020 +0800 Zipkin tr

[GitHub] [skywalking] wu-sheng commented on issue #5090: How to get the slowest span in each level of the tree?

2020-07-13 Thread GitBox
wu-sheng commented on issue #5090: URL: https://github.com/apache/skywalking/issues/5090#issuecomment-657923825 No, there isn't. What you asked is just scanning the whole trace. This is an automated message from the Apache Gi

[skywalking-rocketbot-ui] branch master updated: Bugfix: Handle the case where the service returns an empty array (#328)

2020-07-13 Thread qiuxiafan
This is an automated email from the ASF dual-hosted git repository. qiuxiafan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-rocketbot-ui.git The following commit(s) were added to refs/heads/master by this push: new eb7c54b Bugfix: Handle the

[GitHub] [skywalking-rocketbot-ui] Fine0830 merged pull request #328: Bugfix: Handle the case where the service returns an empty array

2020-07-13 Thread GitBox
Fine0830 merged pull request #328: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/328 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [skywalking] wu-sheng closed issue #5090: How to get the slowest span in each level of the tree?

2020-07-13 Thread GitBox
wu-sheng closed issue #5090: URL: https://github.com/apache/skywalking/issues/5090 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [skywalking] wu-sheng commented on issue #5091: Front end compatibility issues

2020-07-13 Thread GitBox
wu-sheng commented on issue #5091: URL: https://github.com/apache/skywalking/issues/5091#issuecomment-657924111 We mainly focus on Chrome and Firefox only, as they are popular. We don't have enough frontend contributors to check across all browsers. ---

[GitHub] [skywalking] wu-sheng closed issue #5091: Front end compatibility issues

2020-07-13 Thread GitBox
wu-sheng closed issue #5091: URL: https://github.com/apache/skywalking/issues/5091 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [skywalking] wu-sheng commented on pull request #5080: Branch quarzt scheduler

2020-07-13 Thread GitBox
wu-sheng commented on pull request #5080: URL: https://github.com/apache/skywalking/pull/5080#issuecomment-657924731 @Patrick0308 I don't have feedback(code or word) about this PR for 3 days, you could consider submitting your own PR too with plugin tests if you are ready to go.

[GitHub] [skywalking] wu-sheng commented on a change in pull request #5086: Add support for spring webclient

2020-07-13 Thread GitBox
wu-sheng commented on a change in pull request #5086: URL: https://github.com/apache/skywalking/pull/5086#discussion_r454056838 ## File path: test/plugin/scenarios/webflux-scenario/config/expectedData.yaml ## @@ -193,6 +193,66 @@ segmentItems: parentSpanId: 8, parentTr

[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #328: Bugfix: Handle the case where the service returns an empty array

2020-07-13 Thread GitBox
wu-sheng commented on pull request #328: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/328#issuecomment-657926596 @Jtrust A submodule update in main repo, please. This is an automated message from the Apache Gi

[GitHub] [skywalking-rocketbot-ui] wu-sheng closed issue #327: When you enter a Service filter that doesn't match anything, nothing changes on the page UI

2020-07-13 Thread GitBox
wu-sheng closed issue #327: URL: https://github.com/apache/skywalking-rocketbot-ui/issues/327 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [skywalking] Dongzai1005 opened a new issue #5092: I have a service, two instances,but the index endpoint_avg indicator does not follow the instance statistics, How do I configure it, or is t

2020-07-13 Thread GitBox
entity_id:40, service_instance_id: 47,time_bucket:202007132359 entity_id:40, service_instance_id: 46,time_bucket:202007132358 ``` ``` json { "_index" : "sw7_endpoint_avg-20200713", "_type" : "_doc", "_id&quo

[GitHub] [skywalking] wu-sheng commented on issue #5092: I have a service, two instances,but the index endpoint_avg indicator does not follow the instance statistics, How do I configure it, is this a

2020-07-13 Thread GitBox
wu-sheng commented on issue #5092: URL: https://github.com/apache/skywalking/issues/5092#issuecomment-657940426 Endpoint is not belonging to the instance, it is the service level metrics. We declared these term very clearly in our documentation. This is a misunderstanding, nothing related

[GitHub] [skywalking] wu-sheng closed issue #5092: I have a service, two instances,but the index endpoint_avg indicator does not follow the instance statistics, How do I configure it, is this a bug?

2020-07-13 Thread GitBox
wu-sheng closed issue #5092: URL: https://github.com/apache/skywalking/issues/5092 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [skywalking] Dongzai1005 commented on issue #5092: I have a service, two instances,but the index endpoint_avg indicator does not follow the instance statistics, How do I configure it, is this

2020-07-13 Thread GitBox
Dongzai1005 commented on issue #5092: URL: https://github.com/apache/skywalking/issues/5092#issuecomment-657945196 this is contrary to the dashboard query condition (current instance) This is an automated message from the Apa

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: [WIP]Provide kafka as collector/reporter

2020-07-13 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr&el=h1) Report > Merging [#4847](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: [WIP]Provide kafka as collector/reporter

2020-07-13 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr&el=h1) Report > Merging [#4847](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: [WIP]Provide kafka as collector/reporter

2020-07-13 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: [WIP]Provide kafka as collector/reporter

2020-07-13 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr&el=h1) Report > Merging [#4847](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: [WIP]Provide kafka as collector/reporter

2020-07-13 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: [WIP]Provide kafka as collector/reporter

2020-07-13 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr&el=h1) Report > Merging [#4847](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: [WIP]Provide kafka as collector/reporter

2020-07-13 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr&el=h1) Report > Merging [#4847](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: [WIP]Provide kafka as collector/reporter

2020-07-13 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr&el=h1) Report > Merging [#4847](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: [WIP]Provide kafka as collector/reporter

2020-07-13 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr&el=h1) Report > Merging [#4847](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: [WIP]Provide kafka as collector/reporter

2020-07-13 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: [WIP]Provide kafka as collector/reporter

2020-07-13 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr&el=h1) Report > Merging [#4847](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: [WIP]Provide kafka as collector/reporter

2020-07-13 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr&el=h1) Report > Merging [#4847](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: [WIP]Provide kafka as collector/reporter

2020-07-13 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: [WIP]Provide kafka as collector/reporter

2020-07-13 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr&el=h1) Report > Merging [#4847](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: [WIP]Provide kafka as collector/reporter

2020-07-13 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr&el=h1) Report > Merging [#4847](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: [WIP]Provide kafka as collector/reporter

2020-07-13 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr&el=h1) Report > Merging [#4847](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: [WIP]Provide kafka as collector/reporter

2020-07-13 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr&el=h1) Report > Merging [#4847](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: [WIP]Provide kafka as collector/reporter

2020-07-13 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr&el=h1) Report > Merging [#4847](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr&e

  1   2   >