[GitHub] [skywalking] wangriyue001 opened a new issue #5439: init_worker_by_lua error: init_worker_by_lua:6: unexpected symbol near '#'

2020-09-04 Thread GitBox
wangriyue001 opened a new issue #5439: URL: https://github.com/apache/skywalking/issues/5439 Please answer these questions before submitting your issue. 发生问题的版本 openresty-1.17.8.2 apache-skywalking-apm-es7-8.1.0.tar.gz skywalking-nginx-lua-0.2.0.zip

[GitHub] [skywalking] lzhaoyang opened a new issue #5440: bug with ui

2020-09-04 Thread GitBox
lzhaoyang opened a new issue #5440: URL: https://github.com/apache/skywalking/issues/5440 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [* ] Bug - [ ] Requirement - [ ] Feature or performance impr

[GitHub] [skywalking-rocketbot-ui] O-ll-O opened a new issue #351: I find a problem in file of localtime.ts

2020-09-04 Thread GitBox
O-ll-O opened a new issue #351: URL: https://github.com/apache/skywalking-rocketbot-ui/issues/351 I found a problem in the queryOAPTimeInfo function of the file named localtime.ts,It is recommended to modify: export const queryOAPTimeInfo = async () => { let utc = window.localStorag

[GitHub] [skywalking] wu-sheng closed issue #5440: bug with ui

2020-09-04 Thread GitBox
wu-sheng closed issue #5440: URL: https://github.com/apache/skywalking/issues/5440 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [skywalking] wu-sheng commented on issue #5440: bug with ui

2020-09-04 Thread GitBox
wu-sheng commented on issue #5440: URL: https://github.com/apache/skywalking/issues/5440#issuecomment-686978931 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [skywalking] wu-sheng closed issue #5439: init_worker_by_lua error: init_worker_by_lua:6: unexpected symbol near '#'

2020-09-04 Thread GitBox
wu-sheng closed issue #5439: URL: https://github.com/apache/skywalking/issues/5439 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [skywalking] wu-sheng commented on issue #5439: init_worker_by_lua error: init_worker_by_lua:6: unexpected symbol near '#'

2020-09-04 Thread GitBox
wu-sheng commented on issue #5439: URL: https://github.com/apache/skywalking/issues/5439#issuecomment-686980227 This kind of description isn't helpful. This is like an LUA grammar issue. This is an automated message from the

[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on issue #351: I find a problem in file of localtime.ts

2020-09-04 Thread GitBox
wu-sheng commented on issue #351: URL: https://github.com/apache/skywalking-rocketbot-ui/issues/351#issuecomment-686981066 Submit a pull request if you want to change or improve anything. Thanks. This is an automated message

[GitHub] [skywalking-rocketbot-ui] wu-sheng closed issue #351: I find a problem in file of localtime.ts

2020-09-04 Thread GitBox
wu-sheng closed issue #351: URL: https://github.com/apache/skywalking-rocketbot-ui/issues/351 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [skywalking-rocketbot-ui] O-ll-O opened a new pull request #352: Update localtime.ts

2020-09-04 Thread GitBox
O-ll-O opened a new pull request #352: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/352 if bankend services info is Empty ,browser have a error :res.data.data.getTimeInfo.timezone undefined This is an automat

[GitHub] [skywalking] timandy commented on issue #4759: not support springmvc [server.servlet.context-path]

2020-09-04 Thread GitBox
timandy commented on issue #4759: URL: https://github.com/apache/skywalking/issues/4759#issuecomment-686999782 I have the same confuse. How to change the context path of skywalking-ui? This is an automated message from the A

[GitHub] [skywalking] wu-sheng commented on issue #4759: not support springmvc [server.servlet.context-path]

2020-09-04 Thread GitBox
wu-sheng commented on issue #4759: URL: https://github.com/apache/skywalking/issues/4759#issuecomment-687002517 > I have the same confuse. How to change the context path of skywalking-ui? Off topic. This is an automate

[GitHub] [skywalking] wu-sheng closed issue #4759: not support springmvc [server.servlet.context-path]

2020-09-04 Thread GitBox
wu-sheng closed issue #4759: URL: https://github.com/apache/skywalking/issues/4759 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [skywalking-rocketbot-ui] Fine0830 merged pull request #352: Update localtime.ts

2020-09-04 Thread GitBox
Fine0830 merged pull request #352: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/352 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[skywalking-rocketbot-ui] branch master updated: Fix: Update localtime.ts (#352)

2020-09-04 Thread qiuxiafan
This is an automated email from the ASF dual-hosted git repository. qiuxiafan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-rocketbot-ui.git The following commit(s) were added to refs/heads/master by this push: new 2302eab Fix: Update localti

[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #352: Update localtime.ts

2020-09-04 Thread GitBox
wu-sheng commented on pull request #352: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/352#issuecomment-687004195 @O-ll-O Please submit pull request to the main repo to update the git submodule for UI. This is

[GitHub] [skywalking] a6205206z opened a new issue #5441: About envoy ALS receiver

2020-09-04 Thread GitBox
a6205206z opened a new issue #5441: URL: https://github.com/apache/skywalking/issues/5441 - Why do you submit this issue? - [ x] Question or discussion - [ ] Bug - [ ] Requirement - [] Feature or performance improvement ___ ### Question - When enable envoy ALS to col

[GitHub] [skywalking] wu-sheng commented on issue #5441: About envoy ALS receiver

2020-09-04 Thread GitBox
wu-sheng commented on issue #5441: URL: https://github.com/apache/skywalking/issues/5441#issuecomment-687018263 This is k8s API, read their documents. This is an automated message from the Apache Git Service. To respond to th

[GitHub] [skywalking] wu-sheng closed issue #5441: About envoy ALS receiver

2020-09-04 Thread GitBox
wu-sheng closed issue #5441: URL: https://github.com/apache/skywalking/issues/5441 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[skywalking] branch telemetry-ssl updated (ffbc260 -> 527c5e1)

2020-09-04 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch telemetry-ssl in repository https://gitbox.apache.org/repos/asf/skywalking.git. from ffbc260 Merge branch 'master' into telemetry-ssl add 1473c04 Introduce label system to histogram (

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

2020-09-04 Thread GitBox
codecov[bot] edited a comment on pull request #5431: URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

2020-09-04 Thread GitBox
codecov[bot] edited a comment on pull request #5431: URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&e

[GitHub] [skywalking] wu-sheng closed pull request #5086: Add support for spring webclient

2020-09-04 Thread GitBox
wu-sheng closed pull request #5086: URL: https://github.com/apache/skywalking/pull/5086 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

2020-09-04 Thread GitBox
codecov[bot] edited a comment on pull request #5431: URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

2020-09-04 Thread GitBox
codecov[bot] edited a comment on pull request #5431: URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&e

[GitHub] [skywalking] wu-sheng commented on pull request #5085: Include request method type in rest mapping annotations

2020-09-04 Thread GitBox
wu-sheng commented on pull request #5085: URL: https://github.com/apache/skywalking/pull/5085#issuecomment-687024127 @BFergerson Any update of this PR? This is an automated message from the Apache Git Service. To respond to

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

2020-09-04 Thread GitBox
codecov[bot] edited a comment on pull request #5431: URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

2020-09-04 Thread GitBox
codecov[bot] edited a comment on pull request #5431: URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

2020-09-04 Thread GitBox
codecov[bot] edited a comment on pull request #5431: URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

2020-09-04 Thread GitBox
codecov[bot] edited a comment on pull request #5431: URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

2020-09-04 Thread GitBox
codecov[bot] edited a comment on pull request #5431: URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

2020-09-04 Thread GitBox
codecov[bot] edited a comment on pull request #5431: URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

2020-09-04 Thread GitBox
codecov[bot] edited a comment on pull request #5431: URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

2020-09-04 Thread GitBox
codecov[bot] edited a comment on pull request #5431: URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

2020-09-04 Thread GitBox
codecov[bot] edited a comment on pull request #5431: URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

2020-09-04 Thread GitBox
codecov[bot] edited a comment on pull request #5431: URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

2020-09-04 Thread GitBox
codecov[bot] edited a comment on pull request #5431: URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

2020-09-04 Thread GitBox
codecov[bot] edited a comment on pull request #5431: URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

2020-09-04 Thread GitBox
codecov[bot] edited a comment on pull request #5431: URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

2020-09-04 Thread GitBox
codecov[bot] edited a comment on pull request #5431: URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5431: Support SSL for prometheus telemetry and prometheus fetcher

2020-09-04 Thread GitBox
codecov[bot] edited a comment on pull request #5431: URL: https://github.com/apache/skywalking/pull/5431#issuecomment-686227631 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&el=h1) Report > Merging [#5431](https://codecov.io/gh/apache/skywalking/pull/5431?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5426: exception-ignore-plugin

2020-09-04 Thread GitBox
codecov[bot] edited a comment on pull request #5426: URL: https://github.com/apache/skywalking/pull/5426#issuecomment-685056500 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5426?src=pr&el=h1) Report > Merging [#5426](https://codecov.io/gh/apache/skywalking/pull/5426?src=pr&e

[GitHub] [skywalking] wu-sheng commented on a change in pull request #5426: exception-ignore-plugin

2020-09-04 Thread GitBox
wu-sheng commented on a change in pull request #5426: URL: https://github.com/apache/skywalking/pull/5426#discussion_r483506537 ## File path: apm-application-toolkit/apm-toolkit-trace/src/main/java/org/apache/skywalking/apm/toolkit/trace/IgnoredException.java ## @@ -0,0 +1,36

[GitHub] [skywalking] wu-sheng commented on a change in pull request #5426: exception-ignore-plugin

2020-09-04 Thread GitBox
wu-sheng commented on a change in pull request #5426: URL: https://github.com/apache/skywalking/pull/5426#discussion_r483507287 ## File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/status/StatusCheckService.java ## @@ -0,0 +1,68 @

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5426: exception-ignore-plugin

2020-09-04 Thread GitBox
codecov[bot] edited a comment on pull request #5426: URL: https://github.com/apache/skywalking/pull/5426#issuecomment-685056500 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [skywalking] wu-sheng commented on pull request #5426: exception-ignore-plugin

2020-09-04 Thread GitBox
wu-sheng commented on pull request #5426: URL: https://github.com/apache/skywalking/pull/5426#issuecomment-687041245 @kezhenxu94 Please recheck, I thin basically this is good. This is an automated message from the Apache Git

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5426: exception-ignore-plugin

2020-09-04 Thread GitBox
codecov[bot] edited a comment on pull request #5426: URL: https://github.com/apache/skywalking/pull/5426#issuecomment-685056500 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5426?src=pr&el=h1) Report > Merging [#5426](https://codecov.io/gh/apache/skywalking/pull/5426?src=pr&e

[GitHub] [skywalking] xbkaishui commented on issue #4256: [Agent Plugin] Lambda instrumentation

2020-09-04 Thread GitBox
xbkaishui commented on issue #4256: URL: https://github.com/apache/skywalking/issues/4256#issuecomment-687041284 I found the entry point (LambdaMetafactory class) base on this article [lambda-inspection](https://ruediste.github.io/bytecode/2017/02/25/lambda-inspection.html) I will try to

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5426: exception-ignore-plugin

2020-09-04 Thread GitBox
codecov[bot] edited a comment on pull request #5426: URL: https://github.com/apache/skywalking/pull/5426#issuecomment-685056500 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5426?src=pr&el=h1) Report > Merging [#5426](https://codecov.io/gh/apache/skywalking/pull/5426?src=pr&e

[GitHub] [skywalking] xbkaishui commented on issue #5430: Agent support dynamic load config without restart instance

2020-09-04 Thread GitBox
xbkaishui commented on issue #5430: URL: https://github.com/apache/skywalking/issues/5430#issuecomment-687042133 Yes, I agree it's better to config through backend command This is an automated message from the Apache Git Serv

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5426: exception-ignore-plugin

2020-09-04 Thread GitBox
codecov[bot] edited a comment on pull request #5426: URL: https://github.com/apache/skywalking/pull/5426#issuecomment-685056500 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5426?src=pr&el=h1) Report > Merging [#5426](https://codecov.io/gh/apache/skywalking/pull/5426?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5426: exception-ignore-plugin

2020-09-04 Thread GitBox
codecov[bot] edited a comment on pull request #5426: URL: https://github.com/apache/skywalking/pull/5426#issuecomment-685056500 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5426?src=pr&el=h1) Report > Merging [#5426](https://codecov.io/gh/apache/skywalking/pull/5426?src=pr&e

[GitHub] [skywalking] EvanLjp commented on a change in pull request #5426: exception-ignore-plugin

2020-09-04 Thread GitBox
EvanLjp commented on a change in pull request #5426: URL: https://github.com/apache/skywalking/pull/5426#discussion_r483510511 ## File path: apm-application-toolkit/apm-toolkit-trace/src/main/java/org/apache/skywalking/apm/toolkit/trace/IgnoredException.java ## @@ -0,0 +1,36 @

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5426: exception-ignore-plugin

2020-09-04 Thread GitBox
codecov[bot] edited a comment on pull request #5426: URL: https://github.com/apache/skywalking/pull/5426#issuecomment-685056500 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5426?src=pr&el=h1) Report > Merging [#5426](https://codecov.io/gh/apache/skywalking/pull/5426?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5426: exception-ignore-plugin

2020-09-04 Thread GitBox
codecov[bot] edited a comment on pull request #5426: URL: https://github.com/apache/skywalking/pull/5426#issuecomment-685056500 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5426: exception-ignore-plugin

2020-09-04 Thread GitBox
codecov[bot] edited a comment on pull request #5426: URL: https://github.com/apache/skywalking/pull/5426#issuecomment-685056500 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5426?src=pr&el=h1) Report > Merging [#5426](https://codecov.io/gh/apache/skywalking/pull/5426?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5426: exception-ignore-plugin

2020-09-04 Thread GitBox
codecov[bot] edited a comment on pull request #5426: URL: https://github.com/apache/skywalking/pull/5426#issuecomment-685056500 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5426?src=pr&el=h1) Report > Merging [#5426](https://codecov.io/gh/apache/skywalking/pull/5426?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5426: exception-ignore-plugin

2020-09-04 Thread GitBox
codecov[bot] edited a comment on pull request #5426: URL: https://github.com/apache/skywalking/pull/5426#issuecomment-685056500 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5426?src=pr&el=h1) Report > Merging [#5426](https://codecov.io/gh/apache/skywalking/pull/5426?src=pr&e

[GitHub] [skywalking] wu-sheng commented on pull request #5426: exception-ignore-plugin

2020-09-04 Thread GitBox
wu-sheng commented on pull request #5426: URL: https://github.com/apache/skywalking/pull/5426#issuecomment-687044825 Twitter about this feature, https://twitter.com/ASFSkyWalking/status/1301818654661595136 This is an automat

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5426: exception-ignore-plugin

2020-09-04 Thread GitBox
codecov[bot] edited a comment on pull request #5426: URL: https://github.com/apache/skywalking/pull/5426#issuecomment-685056500 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5426?src=pr&el=h1) Report > Merging [#5426](https://codecov.io/gh/apache/skywalking/pull/5426?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5426: exception-ignore-plugin

2020-09-04 Thread GitBox
codecov[bot] edited a comment on pull request #5426: URL: https://github.com/apache/skywalking/pull/5426#issuecomment-685056500 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5426?src=pr&el=h1) Report > Merging [#5426](https://codecov.io/gh/apache/skywalking/pull/5426?src=pr&e

[GitHub] [skywalking] wu-sheng commented on a change in pull request #5426: exception-ignore-plugin

2020-09-04 Thread GitBox
wu-sheng commented on a change in pull request #5426: URL: https://github.com/apache/skywalking/pull/5426#discussion_r483512711 ## File path: apm-application-toolkit/apm-toolkit-trace/src/main/java/org/apache/skywalking/apm/toolkit/trace/IgnoredException.java ## @@ -0,0 +1,36

[GitHub] [skywalking] wu-sheng commented on pull request #5426: exception-ignore-plugin

2020-09-04 Thread GitBox
wu-sheng commented on pull request #5426: URL: https://github.com/apache/skywalking/pull/5426#issuecomment-687045953 Also, you should add plugin tests for this feature, one on Spring, the other on Tomcat, through 2 ways of configuration. ---

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5426: exception-ignore-plugin

2020-09-04 Thread GitBox
codecov[bot] edited a comment on pull request #5426: URL: https://github.com/apache/skywalking/pull/5426#issuecomment-685056500 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5426?src=pr&el=h1) Report > Merging [#5426](https://codecov.io/gh/apache/skywalking/pull/5426?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5426: exception-ignore-plugin

2020-09-04 Thread GitBox
codecov[bot] edited a comment on pull request #5426: URL: https://github.com/apache/skywalking/pull/5426#issuecomment-685056500 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5426?src=pr&el=h1) Report > Merging [#5426](https://codecov.io/gh/apache/skywalking/pull/5426?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5426: exception-ignore-plugin

2020-09-04 Thread GitBox
codecov[bot] edited a comment on pull request #5426: URL: https://github.com/apache/skywalking/pull/5426#issuecomment-685056500 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5426?src=pr&el=h1) Report > Merging [#5426](https://codecov.io/gh/apache/skywalking/pull/5426?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5426: exception-ignore-plugin

2020-09-04 Thread GitBox
codecov[bot] edited a comment on pull request #5426: URL: https://github.com/apache/skywalking/pull/5426#issuecomment-685056500 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5426?src=pr&el=h1) Report > Merging [#5426](https://codecov.io/gh/apache/skywalking/pull/5426?src=pr&e

[GitHub] [skywalking] O-ll-O opened a new pull request #5442: skywalking-ui submodule update

2020-09-04 Thread GitBox
O-ll-O opened a new pull request #5442: URL: https://github.com/apache/skywalking/pull/5442 Please answer these questions before submitting a pull request - Why submit this pull request? - [x] Bug fix - [ ] New feature provided - [ ] Improve performance - Related issue

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5426: exception-ignore-plugin

2020-09-04 Thread GitBox
codecov[bot] edited a comment on pull request #5426: URL: https://github.com/apache/skywalking/pull/5426#issuecomment-685056500 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5426?src=pr&el=h1) Report > Merging [#5426](https://codecov.io/gh/apache/skywalking/pull/5426?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5426: exception-ignore-plugin

2020-09-04 Thread GitBox
codecov[bot] edited a comment on pull request #5426: URL: https://github.com/apache/skywalking/pull/5426#issuecomment-685056500 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5426?src=pr&el=h1) Report > Merging [#5426](https://codecov.io/gh/apache/skywalking/pull/5426?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5426: exception-ignore-plugin

2020-09-04 Thread GitBox
codecov[bot] edited a comment on pull request #5426: URL: https://github.com/apache/skywalking/pull/5426#issuecomment-685056500 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5426?src=pr&el=h1) Report > Merging [#5426](https://codecov.io/gh/apache/skywalking/pull/5426?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5426: exception-ignore-plugin

2020-09-04 Thread GitBox
codecov[bot] edited a comment on pull request #5426: URL: https://github.com/apache/skywalking/pull/5426#issuecomment-685056500 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5426?src=pr&el=h1) Report > Merging [#5426](https://codecov.io/gh/apache/skywalking/pull/5426?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5426: exception-ignore-plugin

2020-09-04 Thread GitBox
codecov[bot] edited a comment on pull request #5426: URL: https://github.com/apache/skywalking/pull/5426#issuecomment-685056500 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5426?src=pr&el=h1) Report > Merging [#5426](https://codecov.io/gh/apache/skywalking/pull/5426?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5426: exception-ignore-plugin

2020-09-04 Thread GitBox
codecov[bot] edited a comment on pull request #5426: URL: https://github.com/apache/skywalking/pull/5426#issuecomment-685056500 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5426?src=pr&el=h1) Report > Merging [#5426](https://codecov.io/gh/apache/skywalking/pull/5426?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5426: exception-ignore-plugin

2020-09-04 Thread GitBox
codecov[bot] edited a comment on pull request #5426: URL: https://github.com/apache/skywalking/pull/5426#issuecomment-685056500 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5426?src=pr&el=h1) Report > Merging [#5426](https://codecov.io/gh/apache/skywalking/pull/5426?src=pr&e

[GitHub] [skywalking] BFergerson edited a comment on pull request #5085: Include request method type in rest mapping annotations

2020-09-04 Thread GitBox
BFergerson edited a comment on pull request #5085: URL: https://github.com/apache/skywalking/pull/5085#issuecomment-675112178 I'm not able to successfully run e2e tests locally. I'm running: ```sh git clone --recurse-submodules https://github.com/apache/skywalking.git cd skyw

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5426: exception-ignore-plugin

2020-09-04 Thread GitBox
codecov[bot] edited a comment on pull request #5426: URL: https://github.com/apache/skywalking/pull/5426#issuecomment-685056500 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5426?src=pr&el=h1) Report > Merging [#5426](https://codecov.io/gh/apache/skywalking/pull/5426?src=pr&e

[GitHub] [skywalking] bjdonny commented on issue #4965: InstMethodsInter : class[class com.mysql.cj.jdbc.ClientPreparedStatement] before method[executeQuery] intercept java.lang.NullPointerException

2020-09-04 Thread GitBox
bjdonny commented on issue #4965: URL: https://github.com/apache/skywalking/issues/4965#issuecomment-687052836 Update to 8.1.0 also has this problem This is an automated message from the Apache Git Service. To respond to the

[GitHub] [skywalking] BFergerson commented on pull request #5085: Include request method type in rest mapping annotations

2020-09-04 Thread GitBox
BFergerson commented on pull request #5085: URL: https://github.com/apache/skywalking/pull/5085#issuecomment-687053224 @wu-sheng, I'm willing to fix this if I can run these tests necessary to confirm it works. However, I'm not even able to get the correct e2e tests to run successfully. The

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5426: exception-ignore-plugin

2020-09-04 Thread GitBox
codecov[bot] edited a comment on pull request #5426: URL: https://github.com/apache/skywalking/pull/5426#issuecomment-685056500 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5426?src=pr&el=h1) Report > Merging [#5426](https://codecov.io/gh/apache/skywalking/pull/5426?src=pr&e

[GitHub] [skywalking] EvanLjp commented on pull request #5426: exception-ignore-plugin

2020-09-04 Thread GitBox
EvanLjp commented on pull request #5426: URL: https://github.com/apache/skywalking/pull/5426#issuecomment-687053008 > Also, you should add plugin tests for this feature, one on Spring, the other on Tomcat, through 2 ways of configuration. will do it on weekend -

[GitHub] [skywalking] BFergerson edited a comment on pull request #5085: Include request method type in rest mapping annotations

2020-09-04 Thread GitBox
BFergerson edited a comment on pull request #5085: URL: https://github.com/apache/skywalking/pull/5085#issuecomment-687053224 @wu-sheng, I'm willing to fix this if I can run these tests necessary to confirm it works. However, I'm not even able to get the correct e2e tests to run successful

[GitHub] [skywalking] codecov[bot] commented on pull request #5442: skywalking-ui submodule update

2020-09-04 Thread GitBox
codecov[bot] commented on pull request #5442: URL: https://github.com/apache/skywalking/pull/5442#issuecomment-687054607 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5442?src=pr&el=h1) Report > Merging [#5442](https://codecov.io/gh/apache/skywalking/pull/5442?src=pr&el=desc)

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5442: skywalking-ui submodule update

2020-09-04 Thread GitBox
codecov[bot] edited a comment on pull request #5442: URL: https://github.com/apache/skywalking/pull/5442#issuecomment-687054607 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [skywalking] bjdonny commented on issue #4965: InstMethodsInter : class[class com.mysql.cj.jdbc.ClientPreparedStatement] before method[executeQuery] intercept java.lang.NullPointerException

2020-09-04 Thread GitBox
bjdonny commented on issue #4965: URL: https://github.com/apache/skywalking/issues/4965#issuecomment-687055525 `[2020-09-04 18:02:24:870] [skywalking] [main] [ERROR] [InstMethodsInter] - class[class com.mysql.cj.jdbc.ClientPreparedStatement] before method[setNull] intercept failure jav

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5442: skywalking-ui submodule update

2020-09-04 Thread GitBox
codecov[bot] edited a comment on pull request #5442: URL: https://github.com/apache/skywalking/pull/5442#issuecomment-687054607 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5442?src=pr&el=h1) Report > Merging [#5442](https://codecov.io/gh/apache/skywalking/pull/5442?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5442: skywalking-ui submodule update

2020-09-04 Thread GitBox
codecov[bot] edited a comment on pull request #5442: URL: https://github.com/apache/skywalking/pull/5442#issuecomment-687054607 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5442?src=pr&el=h1) Report > Merging [#5442](https://codecov.io/gh/apache/skywalking/pull/5442?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5442: skywalking-ui submodule update

2020-09-04 Thread GitBox
codecov[bot] edited a comment on pull request #5442: URL: https://github.com/apache/skywalking/pull/5442#issuecomment-687054607 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5442?src=pr&el=h1) Report > Merging [#5442](https://codecov.io/gh/apache/skywalking/pull/5442?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5442: skywalking-ui submodule update

2020-09-04 Thread GitBox
codecov[bot] edited a comment on pull request #5442: URL: https://github.com/apache/skywalking/pull/5442#issuecomment-687054607 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5442?src=pr&el=h1) Report > Merging [#5442](https://codecov.io/gh/apache/skywalking/pull/5442?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5442: skywalking-ui submodule update

2020-09-04 Thread GitBox
codecov[bot] edited a comment on pull request #5442: URL: https://github.com/apache/skywalking/pull/5442#issuecomment-687054607 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5442?src=pr&el=h1) Report > Merging [#5442](https://codecov.io/gh/apache/skywalking/pull/5442?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5426: exception-ignore-plugin

2020-09-04 Thread GitBox
codecov[bot] edited a comment on pull request #5426: URL: https://github.com/apache/skywalking/pull/5426#issuecomment-685056500 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5426?src=pr&el=h1) Report > Merging [#5426](https://codecov.io/gh/apache/skywalking/pull/5426?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5442: skywalking-ui submodule update

2020-09-04 Thread GitBox
codecov[bot] edited a comment on pull request #5442: URL: https://github.com/apache/skywalking/pull/5442#issuecomment-687054607 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5442?src=pr&el=h1) Report > Merging [#5442](https://codecov.io/gh/apache/skywalking/pull/5442?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5442: skywalking-ui submodule update

2020-09-04 Thread GitBox
codecov[bot] edited a comment on pull request #5442: URL: https://github.com/apache/skywalking/pull/5442#issuecomment-687054607 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5442?src=pr&el=h1) Report > Merging [#5442](https://codecov.io/gh/apache/skywalking/pull/5442?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5442: skywalking-ui submodule update

2020-09-04 Thread GitBox
codecov[bot] edited a comment on pull request #5442: URL: https://github.com/apache/skywalking/pull/5442#issuecomment-687054607 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5442: skywalking-ui submodule update

2020-09-04 Thread GitBox
codecov[bot] edited a comment on pull request #5442: URL: https://github.com/apache/skywalking/pull/5442#issuecomment-687054607 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5442?src=pr&el=h1) Report > Merging [#5442](https://codecov.io/gh/apache/skywalking/pull/5442?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5442: skywalking-ui submodule update

2020-09-04 Thread GitBox
codecov[bot] edited a comment on pull request #5442: URL: https://github.com/apache/skywalking/pull/5442#issuecomment-687054607 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5442?src=pr&el=h1) Report > Merging [#5442](https://codecov.io/gh/apache/skywalking/pull/5442?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5442: skywalking-ui submodule update

2020-09-04 Thread GitBox
codecov[bot] edited a comment on pull request #5442: URL: https://github.com/apache/skywalking/pull/5442#issuecomment-687054607 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5442?src=pr&el=h1) Report > Merging [#5442](https://codecov.io/gh/apache/skywalking/pull/5442?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5442: skywalking-ui submodule update

2020-09-04 Thread GitBox
codecov[bot] edited a comment on pull request #5442: URL: https://github.com/apache/skywalking/pull/5442#issuecomment-687054607 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5442?src=pr&el=h1) Report > Merging [#5442](https://codecov.io/gh/apache/skywalking/pull/5442?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5442: skywalking-ui submodule update

2020-09-04 Thread GitBox
codecov[bot] edited a comment on pull request #5442: URL: https://github.com/apache/skywalking/pull/5442#issuecomment-687054607 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5442?src=pr&el=h1) Report > Merging [#5442](https://codecov.io/gh/apache/skywalking/pull/5442?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5442: skywalking-ui submodule update

2020-09-04 Thread GitBox
codecov[bot] edited a comment on pull request #5442: URL: https://github.com/apache/skywalking/pull/5442#issuecomment-687054607 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5442?src=pr&el=h1) Report > Merging [#5442](https://codecov.io/gh/apache/skywalking/pull/5442?src=pr&e

  1   2   3   4   >