[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5690: Add async-http-client plugin

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5690: URL: https://github.com/apache/skywalking/pull/5690#issuecomment-712138953 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5690?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5690: Add async-http-client plugin

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5690: URL: https://github.com/apache/skywalking/pull/5690#issuecomment-712138953 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5690?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5690: Add async-http-client plugin

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5690: URL: https://github.com/apache/skywalking/pull/5690#issuecomment-712138953 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5690?src=pr=h1) Report > Merging

[GitHub] [skywalking] zifeihan commented on pull request #5690: Add async-http-client plugin

2020-11-03 Thread GitBox
zifeihan commented on pull request #5690: URL: https://github.com/apache/skywalking/pull/5690#issuecomment-721570325 Something modified, please help review it again. This is an automated message from the Apache Git Service.

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5690: Add async-http-client plugin

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5690: URL: https://github.com/apache/skywalking/pull/5690#issuecomment-712138953 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5690?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5788: shardingsphere scenario remove commons-dbcp

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5788: URL: https://github.com/apache/skywalking/pull/5788#issuecomment-721540741 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5788?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5690: Add async-http-client plugin

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5690: URL: https://github.com/apache/skywalking/pull/5690#issuecomment-712138953 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5690?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5690: Add async-http-client plugin

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5690: URL: https://github.com/apache/skywalking/pull/5690#issuecomment-712138953 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5690?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5690: Add async-http-client plugin

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5690: URL: https://github.com/apache/skywalking/pull/5690#issuecomment-712138953 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5690?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5690: Add async-http-client plugin

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5690: URL: https://github.com/apache/skywalking/pull/5690#issuecomment-712138953 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5690?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5690: Add async-http-client plugin

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5690: URL: https://github.com/apache/skywalking/pull/5690#issuecomment-712138953 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5690?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5690: Add async-http-client plugin

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5690: URL: https://github.com/apache/skywalking/pull/5690#issuecomment-712138953 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5690?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5690: Add async-http-client plugin

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5690: URL: https://github.com/apache/skywalking/pull/5690#issuecomment-712138953 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5690?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5788: shardingsphere scenario remove commons-dbcp

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5788: URL: https://github.com/apache/skywalking/pull/5788#issuecomment-721540741 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5788?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5690: Add async-http-client plugin

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5690: URL: https://github.com/apache/skywalking/pull/5690#issuecomment-712138953 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5690?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5788: shardingsphere scenario remove commons-dbcp

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5788: URL: https://github.com/apache/skywalking/pull/5788#issuecomment-721540741 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5788?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5690: Add async-http-client plugin

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5690: URL: https://github.com/apache/skywalking/pull/5690#issuecomment-712138953 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5690?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5690: Add async-http-client plugin

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5690: URL: https://github.com/apache/skywalking/pull/5690#issuecomment-712138953 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5690?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5690: Add async-http-client plugin

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5690: URL: https://github.com/apache/skywalking/pull/5690#issuecomment-712138953 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5690?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5690: Add async-http-client plugin

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5690: URL: https://github.com/apache/skywalking/pull/5690#issuecomment-712138953 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5690: Add async-http-client plugin

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5690: URL: https://github.com/apache/skywalking/pull/5690#issuecomment-712138953 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] wu-sheng commented on issue #5790: ServletContextPropertyPlaceholderConfigurer is not found in some new version for springframework 4

2020-11-03 Thread GitBox
wu-sheng commented on issue #5790: URL: https://github.com/apache/skywalking/issues/5790#issuecomment-721560604 Should consider using this tool https://github.com/SkyAPM/uranus to find a new suitable witness class. @lagudomeze I could assign this issue to you if you want to resolve and

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5690: Add async-http-client plugin

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5690: URL: https://github.com/apache/skywalking/pull/5690#issuecomment-712138953 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5690?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5690: Add async-http-client plugin

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5690: URL: https://github.com/apache/skywalking/pull/5690#issuecomment-712138953 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5690?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5690: Add async-http-client plugin

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5690: URL: https://github.com/apache/skywalking/pull/5690#issuecomment-712138953 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5690?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5690: Add async-http-client plugin

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5690: URL: https://github.com/apache/skywalking/pull/5690#issuecomment-712138953 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5690?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5690: Add async-http-client plugin

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5690: URL: https://github.com/apache/skywalking/pull/5690#issuecomment-712138953 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5690?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5690: Add async-http-client plugin

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5690: URL: https://github.com/apache/skywalking/pull/5690#issuecomment-712138953 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5690?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5690: Add async-http-client plugin

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5690: URL: https://github.com/apache/skywalking/pull/5690#issuecomment-712138953 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5690?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5690: Add async-http-client plugin

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5690: URL: https://github.com/apache/skywalking/pull/5690#issuecomment-712138953 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5690?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5788: shardingsphere scenario remove commons-dbcp

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5788: URL: https://github.com/apache/skywalking/pull/5788#issuecomment-721540741 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5788?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5788: shardingsphere scenario remove commons-dbcp

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5788: URL: https://github.com/apache/skywalking/pull/5788#issuecomment-721540741 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5788?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5788: shardingsphere scenario remove commons-dbcp

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5788: URL: https://github.com/apache/skywalking/pull/5788#issuecomment-721540741 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5788?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5788: shardingsphere scenario remove commons-dbcp

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5788: URL: https://github.com/apache/skywalking/pull/5788#issuecomment-721540741 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5788?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5690: Add async-http-client plugin

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5690: URL: https://github.com/apache/skywalking/pull/5690#issuecomment-712138953 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5690?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5788: shardingsphere scenario remove commons-dbcp

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5788: URL: https://github.com/apache/skywalking/pull/5788#issuecomment-721540741 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5788?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5690: Add async-http-client plugin

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5690: URL: https://github.com/apache/skywalking/pull/5690#issuecomment-712138953 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5690: Add async-http-client plugin

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5690: URL: https://github.com/apache/skywalking/pull/5690#issuecomment-712138953 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5690?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5690: Add async-http-client plugin

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5690: URL: https://github.com/apache/skywalking/pull/5690#issuecomment-712138953 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5690?src=pr=h1) Report > Merging

[GitHub] [skywalking] lagudomeze opened a new issue #5790: ServletContextPropertyPlaceholderConfigurer is not found in some new version for springframework 4

2020-11-03 Thread GitBox
lagudomeze opened a new issue #5790: URL: https://github.com/apache/skywalking/issues/5790 skywalking-api.log ``` org.apache.skywalking.apm.plugin.spring.mvc.v4.define.RestControllerForLowVersionInstrumentation is not working. Because witness class

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5788: shardingsphere scenario remove commons-dbcp

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5788: URL: https://github.com/apache/skywalking/pull/5788#issuecomment-721540741 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5788?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5788: shardingsphere scenario remove commons-dbcp

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5788: URL: https://github.com/apache/skywalking/pull/5788#issuecomment-721540741 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5788?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5788: shardingsphere scenario remove commons-dbcp

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5788: URL: https://github.com/apache/skywalking/pull/5788#issuecomment-721540741 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5788?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5788: shardingsphere scenario remove commons-dbcp

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5788: URL: https://github.com/apache/skywalking/pull/5788#issuecomment-721540741 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5788?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5788: shardingsphere scenario remove commons-dbcp

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5788: URL: https://github.com/apache/skywalking/pull/5788#issuecomment-721540741 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5788?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5788: shardingsphere scenario remove commons-dbcp

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5788: URL: https://github.com/apache/skywalking/pull/5788#issuecomment-721540741 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5788?src=pr=h1) Report > Merging

[GitHub] [skywalking] wu-sheng closed issue #5789: UI timezone default value problem

2020-11-03 Thread GitBox
wu-sheng closed issue #5789: URL: https://github.com/apache/skywalking/issues/5789 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [skywalking] wu-sheng commented on issue #5789: UI timezone default value problem

2020-11-03 Thread GitBox
wu-sheng commented on issue #5789: URL: https://github.com/apache/skywalking/issues/5789#issuecomment-721552747 The setting is based on your browser's local cache. The default is 15 mins. This is an automated message from

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5788: shardingsphere scenario remove commons-dbcp

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5788: URL: https://github.com/apache/skywalking/pull/5788#issuecomment-721540741 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5788?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5788: shardingsphere scenario remove commons-dbcp

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5788: URL: https://github.com/apache/skywalking/pull/5788#issuecomment-721540741 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5788?src=pr=h1) Report > Merging

[GitHub] [skywalking] zhyhzhylove opened a new issue #5789: UI timezone default value problem

2020-11-03 Thread GitBox
zhyhzhylove opened a new issue #5789: URL: https://github.com/apache/skywalking/issues/5789 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [ ] Bug - [x] Requirement - [ ] Feature or performance

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5788: shardingsphere scenario remove commons-dbcp

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5788: URL: https://github.com/apache/skywalking/pull/5788#issuecomment-721540741 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5788?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5788: shardingsphere scenario remove commons-dbcp

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5788: URL: https://github.com/apache/skywalking/pull/5788#issuecomment-721540741 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5788?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5788: shardingsphere scenario remove commons-dbcp

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5788: URL: https://github.com/apache/skywalking/pull/5788#issuecomment-721540741 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5788?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5788: shardingsphere scenario remove commons-dbcp

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5788: URL: https://github.com/apache/skywalking/pull/5788#issuecomment-721540741 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5788?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5788: shardingsphere scenario remove commons-dbcp

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5788: URL: https://github.com/apache/skywalking/pull/5788#issuecomment-721540741 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5788?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5788: shardingsphere scenario remove commons-dbcp

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5788: URL: https://github.com/apache/skywalking/pull/5788#issuecomment-721540741 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5788?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5788: shardingsphere scenario remove commons-dbcp

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5788: URL: https://github.com/apache/skywalking/pull/5788#issuecomment-721540741 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5788?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5690: Add async-http-client plugin

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5690: URL: https://github.com/apache/skywalking/pull/5690#issuecomment-712138953 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5690?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5788: shardingsphere scenario remove commons-dbcp

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5788: URL: https://github.com/apache/skywalking/pull/5788#issuecomment-721540741 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5788?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5788: shardingsphere scenario remove commons-dbcp

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5788: URL: https://github.com/apache/skywalking/pull/5788#issuecomment-721540741 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5788?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5788: shardingsphere scenario remove commons-dbcp

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5788: URL: https://github.com/apache/skywalking/pull/5788#issuecomment-721540741 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5788?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5788: shardingsphere scenario remove commons-dbcp

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5788: URL: https://github.com/apache/skywalking/pull/5788#issuecomment-721540741 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5788?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5788: shardingsphere scenario remove commons-dbcp

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5788: URL: https://github.com/apache/skywalking/pull/5788#issuecomment-721540741 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5788: shardingsphere scenario remove commons-dbcp

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5788: URL: https://github.com/apache/skywalking/pull/5788#issuecomment-721540741 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5788?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5788: shardingsphere scenario remove commons-dbcp

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5788: URL: https://github.com/apache/skywalking/pull/5788#issuecomment-721540741 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5788?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5788: shardingsphere scenario remove commons-dbcp

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5788: URL: https://github.com/apache/skywalking/pull/5788#issuecomment-721540741 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5788?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5788: shardingsphere scenario remove commons-dbcp

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5788: URL: https://github.com/apache/skywalking/pull/5788#issuecomment-721540741 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5788?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5788: shardingsphere scenario remove commons-dbcp

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5788: URL: https://github.com/apache/skywalking/pull/5788#issuecomment-721540741 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5788?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5788: shardingsphere scenario remove commons-dbcp

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5788: URL: https://github.com/apache/skywalking/pull/5788#issuecomment-721540741 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5788?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5788: shardingsphere scenario remove commons-dbcp

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5788: URL: https://github.com/apache/skywalking/pull/5788#issuecomment-721540741 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5788?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5788: shardingsphere scenario remove commons-dbcp

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5788: URL: https://github.com/apache/skywalking/pull/5788#issuecomment-721540741 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5788: shardingsphere scenario remove commons-dbcp

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5788: URL: https://github.com/apache/skywalking/pull/5788#issuecomment-721540741 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5788?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5788: shardingsphere scenario remove commons-dbcp

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5788: URL: https://github.com/apache/skywalking/pull/5788#issuecomment-721540741 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5788?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5788: shardingsphere scenario remove commons-dbcp

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5788: URL: https://github.com/apache/skywalking/pull/5788#issuecomment-721540741 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5788: shardingsphere scenario remove commons-dbcp

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5788: URL: https://github.com/apache/skywalking/pull/5788#issuecomment-721540741 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5788?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5788: shardingsphere scenario remove commons-dbcp

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5788: URL: https://github.com/apache/skywalking/pull/5788#issuecomment-721540741 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5788?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5788: shardingsphere scenario remove commons-dbcp

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5788: URL: https://github.com/apache/skywalking/pull/5788#issuecomment-721540741 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5788?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5788: shardingsphere scenario remove commons-dbcp

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5788: URL: https://github.com/apache/skywalking/pull/5788#issuecomment-721540741 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5788?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5788: shardingsphere scenario remove commons-dbcp

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5788: URL: https://github.com/apache/skywalking/pull/5788#issuecomment-721540741 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5788?src=pr=h1) Report > Merging

[GitHub] [skywalking] wu-sheng commented on pull request #5788: shardingsphere scenario remove commons-dbcp

2020-11-03 Thread GitBox
wu-sheng commented on pull request #5788: URL: https://github.com/apache/skywalking/pull/5788#issuecomment-721542923 Relate to #5550, try to remove DBCP from the test demo. This is an automated message from the Apache Git

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5788: shardingsphere scenario remove commons-dbcp

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5788: URL: https://github.com/apache/skywalking/pull/5788#issuecomment-721540741 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5788?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] commented on pull request #5788: shardingsphere scenario remove commons-dbcp

2020-11-03 Thread GitBox
codecov[bot] commented on pull request #5788: URL: https://github.com/apache/skywalking/pull/5788#issuecomment-721540741 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5788?src=pr=h1) Report > Merging [#5788](https://codecov.io/gh/apache/skywalking/pull/5788?src=pr=desc) into

[GitHub] [skywalking] yu199195 opened a new pull request #5788: shardingsphere scenario remove commons-dbcp

2020-11-03 Thread GitBox
yu199195 opened a new pull request #5788: URL: https://github.com/apache/skywalking/pull/5788 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [ ] Update the [`CHANGES`

[GitHub] [skywalking] Jargon96 commented on pull request #5550: add support for dbcp 2.x plugin

2020-11-03 Thread GitBox
Jargon96 commented on pull request #5550: URL: https://github.com/apache/skywalking/pull/5550#issuecomment-721494083 > @Jargon96 I think you have to modify the shardingsphere's expected data file. Because you added the DBCP plugin, and they use it in their plugin too. As this is a new

[GitHub] [skywalking] JaredTan95 closed issue #5785: storage-jdbc isExists not set dbname

2020-11-03 Thread GitBox
JaredTan95 closed issue #5785: URL: https://github.com/apache/skywalking/issues/5785 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[skywalking] branch master updated: fix storage-jdbc isExists not set dbname (#5786)

2020-11-03 Thread tanjian
This is an automated email from the ASF dual-hosted git repository. tanjian pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new 9042ce6 fix storage-jdbc isExists not set

[GitHub] [skywalking] JaredTan95 merged pull request #5786: fix storage-jdbc isExists not set dbname

2020-11-03 Thread GitBox
JaredTan95 merged pull request #5786: URL: https://github.com/apache/skywalking/pull/5786 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5786: fix storage-jdbc isExists not set dbname

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5786: URL: https://github.com/apache/skywalking/pull/5786#issuecomment-721483126 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5786?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5786: fix storage-jdbc isExists not set dbname

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5786: URL: https://github.com/apache/skywalking/pull/5786#issuecomment-721483126 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5786?src=pr=h1) Report > Merging

[GitHub] [skywalking] wu-sheng commented on issue #5787: lastest version - compile error (File not found)

2020-11-03 Thread GitBox
wu-sheng commented on issue #5787: URL: https://github.com/apache/skywalking/issues/5787#issuecomment-721490784 Please read the compiling doc. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [skywalking] wu-sheng closed issue #5787: lastest version - compile error (File not found)

2020-11-03 Thread GitBox
wu-sheng closed issue #5787: URL: https://github.com/apache/skywalking/issues/5787 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [skywalking] wu-sheng commented on pull request #5550: add support for dbcp 2.x plugin

2020-11-03 Thread GitBox
wu-sheng commented on pull request #5550: URL: https://github.com/apache/skywalking/pull/5550#issuecomment-721489338 @Jargon96 I think you have to modify the shardingsphere's expected data file. Because you added the DBCP plugin, and they use it in their plugin too. As this is a new

[GitHub] [skywalking] Lynda-Li opened a new issue #5787: lastest version - compile error (File not found)

2020-11-03 Thread GitBox
Lynda-Li opened a new issue #5787: URL: https://github.com/apache/skywalking/issues/5787 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [ ] Bug - [ ] Requirement - [ ] Feature or performance

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5786: fix storage-jdbc isExists not set dbname

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5786: URL: https://github.com/apache/skywalking/pull/5786#issuecomment-721483126 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5786?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5786: fix storage-jdbc isExists not set dbname

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5786: URL: https://github.com/apache/skywalking/pull/5786#issuecomment-721483126 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5786?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5786: fix storage-jdbc isExists not set dbname

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5786: URL: https://github.com/apache/skywalking/pull/5786#issuecomment-721483126 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5786: fix storage-jdbc isExists not set dbname

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5786: URL: https://github.com/apache/skywalking/pull/5786#issuecomment-721483126 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5786?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5786: fix storage-jdbc isExists not set dbname

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5786: URL: https://github.com/apache/skywalking/pull/5786#issuecomment-721483126 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5786?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5786: fix storage-jdbc isExists not set dbname

2020-11-03 Thread GitBox
codecov[bot] edited a comment on pull request #5786: URL: https://github.com/apache/skywalking/pull/5786#issuecomment-721483126 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5786?src=pr=h1) Report > Merging

  1   2   3   4   5   >