[GitHub] [skywalking] 1314cc commented on issue #5862: Cross-room monitoring service

2020-11-18 Thread GitBox
1314cc commented on issue #5862: URL: https://github.com/apache/skywalking/issues/5862#issuecomment-730195869 Some services at IDC, some services in the customer motor room. This is an automated message from the Apache Git Se

[GitHub] [skywalking] wu-sheng commented on issue #5858: how to use the log, why the log is empty?

2020-11-18 Thread GitBox
wu-sheng commented on issue #5858: URL: https://github.com/apache/skywalking/issues/5858#issuecomment-730190577 I don't know what do you mean by custom. As an open source project, you could try by yourself. If you want a specific question, we could help. Don't count on us to help you step

[GitHub] [skywalking] auqf commented on issue #5858: how to use the log, why the log is empty?

2020-11-18 Thread GitBox
auqf commented on issue #5858: URL: https://github.com/apache/skywalking/issues/5858#issuecomment-730184624 the dashboard how to custom by myself? This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [skywalking] wu-sheng commented on issue #5858: how to use the log, why the log is empty?

2020-11-18 Thread GitBox
wu-sheng commented on issue #5858: URL: https://github.com/apache/skywalking/issues/5858#issuecomment-730182823 Not provided, it may come in 2021. This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [skywalking] auqf commented on issue #5858: how to use the log, why the log is empty?

2020-11-18 Thread GitBox
auqf commented on issue #5858: URL: https://github.com/apache/skywalking/issues/5858#issuecomment-730181993 and the service log how to use, it's empty too ![image](https://user-images.githubusercontent.com/8895540/99634023-cd14c800-2a7a-11eb-938a-472b68e046e5.png) -

[GitHub] [skywalking] wu-sheng commented on issue #5863: What format should we have in mind for logging to spans?

2020-11-18 Thread GitBox
wu-sheng commented on issue #5863: URL: https://github.com/apache/skywalking/issues/5863#issuecomment-730178645 First logs should be cataloged as a `log`, rather than a `tag`. And about the format, how about taking a reference from here? https://github.com/apache/skywalking/blob/mast

[skywalking-website] branch asf-site updated (d6f4d5e -> 9f86226)

2020-11-18 Thread tanjian
This is an automated email from the ASF dual-hosted git repository. tanjian pushed a change to branch asf-site in repository https://gitbox.apache.org/repos/asf/skywalking-website.git. discard d6f4d5e Update asf-site new 9f86226 Update asf-site This update added new revisions after undo

[GitHub] [skywalking-website] kezhenxu94 merged pull request #133: Revert "Release Python 0.4.0"

2020-11-18 Thread GitBox
kezhenxu94 merged pull request #133: URL: https://github.com/apache/skywalking-website/pull/133 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[skywalking-website] branch master updated: Revert "Release Python 0.4.0 (#132)" (#133)

2020-11-18 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-website.git The following commit(s) were added to refs/heads/master by this push: new b97e3c9 Revert "Release Python

[GitHub] [skywalking-website] kezhenxu94 opened a new pull request #133: Revert "Release Python 0.4.0"

2020-11-18 Thread GitBox
kezhenxu94 opened a new pull request #133: URL: https://github.com/apache/skywalking-website/pull/133 Reverts apache/skywalking-website#132 This is an automated message from the Apache Git Service. To respond to the message,

[skywalking-website] branch revert-132-release/python/0.4.0 created (now 4c6845f)

2020-11-18 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch revert-132-release/python/0.4.0 in repository https://gitbox.apache.org/repos/asf/skywalking-website.git. at 4c6845f Revert "Release Python 0.4.0 (#132)" No new revisions were added b

[GitHub] [skywalking-python] wu-sheng commented on pull request #81: Bump up the version to 0.4.0

2020-11-18 Thread GitBox
wu-sheng commented on pull request #81: URL: https://github.com/apache/skywalking-python/pull/81#issuecomment-730175499 Then we need another release vote. This is an automated message from the Apache Git Service. To respond t

[GitHub] [skywalking-python] kezhenxu94 commented on pull request #81: Bump up the version to 0.4.0

2020-11-18 Thread GitBox
kezhenxu94 commented on pull request #81: URL: https://github.com/apache/skywalking-python/pull/81#issuecomment-730171899 > I am assuming this file is in the release tar ball, right? Yes it is This is an automated mess

[skywalking-python] branch master updated: Bump up the version to 0.4.0 (#81)

2020-11-18 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-python.git The following commit(s) were added to refs/heads/master by this push: new 5dbb9db Bump up the version to 0.4.

[skywalking-python] branch master updated: Bump up the version to 0.4.0 (#81)

2020-11-18 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-python.git The following commit(s) were added to refs/heads/master by this push: new 5dbb9db Bump up the version to 0.4.

[GitHub] [skywalking] vcjmhg opened a new issue #5863: What format should we have in mind for logging to spans?

2020-11-18 Thread GitBox
vcjmhg opened a new issue #5863: URL: https://github.com/apache/skywalking/issues/5863 Please answer these questions before submitting your issue. - Why do you submit this issue? - [X] Question or discussion - [ ] Bug - [ ] Requirement - [ ] Feature or performance improvem

[GitHub] [skywalking] wu-sheng commented on issue #5862: Cross-room monitoring service

2020-11-18 Thread GitBox
wu-sheng commented on issue #5862: URL: https://github.com/apache/skywalking/issues/5862#issuecomment-730164218 What do you mean room? AZ, IDC or something? This is an automated message from the Apache Git Service. To respond

[GitHub] [skywalking-python] wu-sheng commented on pull request #81: Bump up the version to 0.4.0

2020-11-18 Thread GitBox
wu-sheng commented on pull request #81: URL: https://github.com/apache/skywalking-python/pull/81#issuecomment-730163998 I am assuming this file is in the release tar ball, right? This is an automated message from the Apache G

[GitHub] [skywalking-python] wu-sheng merged pull request #81: Bump up the version to 0.4.0

2020-11-18 Thread GitBox
wu-sheng merged pull request #81: URL: https://github.com/apache/skywalking-python/pull/81 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [skywalking] 1314cc opened a new issue #5862: Cross-room monitoring service

2020-11-18 Thread GitBox
1314cc opened a new issue #5862: URL: https://github.com/apache/skywalking/issues/5862 Please answer these questions before submitting your issue. - Why do you submit this issue? Question or discussion ___ ### Question - What do you want to know? There are mul

[GitHub] [skywalking] wu-sheng commented on issue #4545: add error log(log4j,logback) to span log event

2020-11-18 Thread GitBox
wu-sheng commented on issue #4545: URL: https://github.com/apache/skywalking/issues/4545#issuecomment-730106337 Please submit an issue or pull request about the definition of logging integration, specific keys and values. Th

[GitHub] [skywalking] BFergerson removed a comment on issue #4545: add error log(log4j,logback) to span log event

2020-11-18 Thread GitBox
BFergerson removed a comment on issue #4545: URL: https://github.com/apache/skywalking/issues/4545#issuecomment-730099205 It took me a second to figure out how to get `EnhancedInstance` to `Logger` too lol. This is probably the first time I've come across a situation where double casting w

[GitHub] [skywalking] BFergerson commented on issue #4545: add error log(log4j,logback) to span log event

2020-11-18 Thread GitBox
BFergerson commented on issue #4545: URL: https://github.com/apache/skywalking/issues/4545#issuecomment-730099205 It took me a second to figure out how to get `EnhancedInstance` to `Logger` too lol. This is probably the first time I've come across a situation where double casting was neces

[GitHub] [skywalking] vcjmhg commented on issue #4545: add error log(log4j,logback) to span log event

2020-11-18 Thread GitBox
vcjmhg commented on issue #4545: URL: https://github.com/apache/skywalking/issues/4545#issuecomment-730098783 > What format did you have in mind for logging to spans? > * `AbstractSpan` only has `log(Throwable)` and `log(long, Map)`. What type of map would you put there? Just a single key

[GitHub] [skywalking] kezhenxu94 edited a comment on issue #5861: java agent启动报错

2020-11-18 Thread GitBox
kezhenxu94 edited a comment on issue #5861: URL: https://github.com/apache/skywalking/issues/5861#issuecomment-730097716 > ERROR 2020-11-19 10:36:32:079 main PluginBootstrap : load plugin [org.apache.skywalking.apm.plugin.thrift.define.client.TServiceClientReceiveInstrumentation] failure.

[GitHub] [skywalking] kezhenxu94 commented on issue #5861: java agent启动报错

2020-11-18 Thread GitBox
kezhenxu94 commented on issue #5861: URL: https://github.com/apache/skywalking/issues/5861#issuecomment-730097716 > ERROR 2020-11-19 10:36:32:079 main PluginBootstrap : load plugin [org.apache.skywalking.apm.plugin.thrift.define.client.TServiceClientReceiveInstrumentation] failure. java.la

[GitHub] [skywalking] vcjmhg commented on issue #4545: add error log(log4j,logback) to span log event

2020-11-18 Thread GitBox
vcjmhg commented on issue #4545: URL: https://github.com/apache/skywalking/issues/4545#issuecomment-730096563 > What's the need for starting and stopping a span for adding logging? > * Couldn't you just do `if (ContextManager.isActive()) ContextManager.activeSpan().log(...)` Your

[GitHub] [skywalking] BFergerson edited a comment on issue #4545: add error log(log4j,logback) to span log event

2020-11-18 Thread GitBox
BFergerson edited a comment on issue #4545: URL: https://github.com/apache/skywalking/issues/4545#issuecomment-730095874 > > Why does `LogbakLoggerFactoryInstrumentation` need to know about `org.slf4j.LoggerFactory`? > > > > * I would assume slf4j wouldn't come into the picture as un

[GitHub] [skywalking] BFergerson commented on issue #4545: add error log(log4j,logback) to span log event

2020-11-18 Thread GitBox
BFergerson commented on issue #4545: URL: https://github.com/apache/skywalking/issues/4545#issuecomment-730095874 > > Why does `LogbakLoggerFactoryInstrumentation` need to know about `org.slf4j.LoggerFactory`? > > > > * I would assume slf4j wouldn't come into the picture as under the

[GitHub] [skywalking] vcjmhg commented on issue #4545: add error log(log4j,logback) to span log event

2020-11-18 Thread GitBox
vcjmhg commented on issue #4545: URL: https://github.com/apache/skywalking/issues/4545#issuecomment-730095830 > * Why save `LoggerContext` to a thread local map instead of pulling it from `objInst`? I don't quite understand what does `objInst` mean? Any method as long as it can obta

[GitHub] [skywalking] wu-sheng commented on issue #5861: java agent启动报错

2020-11-18 Thread GitBox
wu-sheng commented on issue #5861: URL: https://github.com/apache/skywalking/issues/5861#issuecomment-730094787 I can't see what your codes like, our tests are here, https://github.com/apache/skywalking/tree/master/test/plugin/scenarios

[skywalking-python] branch chore/bump-up-version created (now 49c5797)

2020-11-18 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch chore/bump-up-version in repository https://gitbox.apache.org/repos/asf/skywalking-python.git. at 49c5797 Bump up the version to 0.4.0 No new revisions were added by this update.

[GitHub] [skywalking] taoyuyu commented on issue #5861: java agent启动报错

2020-11-18 Thread GitBox
taoyuyu commented on issue #5861: URL: https://github.com/apache/skywalking/issues/5861#issuecomment-730093789 how i start agent ```shell java -server -Dio.netty.noPreferDirect=true \ -Djava.net.preferIPv4Stack=true \ -javaagent:/data/

[GitHub] [skywalking] vcjmhg edited a comment on issue #4545: add error log(log4j,logback) to span log event

2020-11-18 Thread GitBox
vcjmhg edited a comment on issue #4545: URL: https://github.com/apache/skywalking/issues/4545#issuecomment-730090278 > How did you plan on testing all of these logging frameworks? > * The test class you've created depends on spring-boot-starter-web which defaults to logback. Did you plan

[GitHub] [skywalking] taoyuyu commented on issue #5861: java agent启动报错

2020-11-18 Thread GitBox
taoyuyu commented on issue #5861: URL: https://github.com/apache/skywalking/issues/5861#issuecomment-730091967 以及这种异常 ```java ERROR 2020-11-19 10:36:37:082 main SkyWalkingAgent : Enhance class org.apache.http.impl.client.DefaultRequestDirector error. org.apache.skywalking.apm.agen

[skywalking-python] branch chore/bump-up-version created (now 49c5797)

2020-11-18 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch chore/bump-up-version in repository https://gitbox.apache.org/repos/asf/skywalking-python.git. at 49c5797 Bump up the version to 0.4.0 No new revisions were added by this update.

[skywalking-website] branch asf-site updated (ee100a5 -> d6f4d5e)

2020-11-18 Thread tanjian
This is an automated email from the ASF dual-hosted git repository. tanjian pushed a change to branch asf-site in repository https://gitbox.apache.org/repos/asf/skywalking-website.git. discard ee100a5 Update asf-site new d6f4d5e Update asf-site This update added new revisions after undo

[skywalking-website] branch master updated: Release Python 0.4.0 (#132)

2020-11-18 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-website.git The following commit(s) were added to refs/heads/master by this push: new 970ed6d Release Python 0.4.0 (#

[skywalking-website] branch asf-site updated (80ad4fa -> ee100a5)

2020-11-18 Thread tanjian
This is an automated email from the ASF dual-hosted git repository. tanjian pushed a change to branch asf-site in repository https://gitbox.apache.org/repos/asf/skywalking-website.git. discard 80ad4fa Update asf-site new ee100a5 Update asf-site This update added new revisions after undo

[skywalking-website] branch release/python/0.4.0 updated (db28621 -> 9260ea5)

2020-11-18 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch release/python/0.4.0 in repository https://gitbox.apache.org/repos/asf/skywalking-website.git. discard db28621 Release Python 0.4.0 add 9260ea5 Release Python 0.4.0 This update added

[skywalking-website] branch asf-site updated (d11d225 -> 80ad4fa)

2020-11-18 Thread tanjian
This is an automated email from the ASF dual-hosted git repository. tanjian pushed a change to branch asf-site in repository https://gitbox.apache.org/repos/asf/skywalking-website.git. discard d11d225 Update asf-site new 80ad4fa Update asf-site This update added new revisions after undo

[skywalking-website] 01/01: Release Python 0.4.0

2020-11-18 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a commit to branch release/python/0.4.0 in repository https://gitbox.apache.org/repos/asf/skywalking-website.git commit db28621ee68ab5507a6ca51cfe61576ff10fe897 Author: kezhenxu94 AuthorDate: Thu Nov 19 10:22:1

[skywalking-website] branch release/python/0.4.0 created (now db28621)

2020-11-18 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch release/python/0.4.0 in repository https://gitbox.apache.org/repos/asf/skywalking-website.git. at db28621 Release Python 0.4.0 This branch includes the following new commits: ne

[GitHub] [skywalking] wu-sheng closed issue #5861: java agent启动报错

2020-11-18 Thread GitBox
wu-sheng closed issue #5861: URL: https://github.com/apache/skywalking/issues/5861 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [skywalking] wu-sheng commented on issue #5861: java agent启动报错

2020-11-18 Thread GitBox
wu-sheng commented on issue #5861: URL: https://github.com/apache/skywalking/issues/5861#issuecomment-730091415 Please use English on the github. And, you may use extend class loader or custom class loader This is an automat

[GitHub] [skywalking] taoyuyu opened a new issue #5861: java agent启动报错

2020-11-18 Thread GitBox
taoyuyu opened a new issue #5861: URL: https://github.com/apache/skywalking/issues/5861 Question or discussion ___ ### Question java agent启动的时候agent/logs/skywalking-api.log里面有这个错是为什么 ` ERROR 2020-11-19 10:36:32:079 main PluginBootstrap : load plugin [org.apache.skywalking

[GitHub] [skywalking] vcjmhg edited a comment on issue #4545: add error log(log4j,logback) to span log event

2020-11-18 Thread GitBox
vcjmhg edited a comment on issue #4545: URL: https://github.com/apache/skywalking/issues/4545#issuecomment-730090278 > How did you plan on testing all of these logging frameworks? > * The test class you've created depends on spring-boot-starter-web which defaults to logback. Did you plan

[GitHub] [skywalking] vcjmhg commented on issue #4545: add error log(log4j,logback) to span log event

2020-11-18 Thread GitBox
vcjmhg commented on issue #4545: URL: https://github.com/apache/skywalking/issues/4545#issuecomment-730090278 > How did you plan on testing all of these logging frameworks? > * The test class you've created depends on spring-boot-starter-web which defaults to logback. Did you plan on tes

[GitHub] [skywalking-python] kezhenxu94 opened a new pull request #81: Bump up the version to 0.4.0

2020-11-18 Thread GitBox
kezhenxu94 opened a new pull request #81: URL: https://github.com/apache/skywalking-python/pull/81 Forgot to update the version number before the release 😢 @wu-sheng do we need another round voting? I hope no This is an auto

[skywalking-website] branch asf-site updated (80ad4fa -> ee100a5)

2020-11-18 Thread tanjian
This is an automated email from the ASF dual-hosted git repository. tanjian pushed a change to branch asf-site in repository https://gitbox.apache.org/repos/asf/skywalking-website.git. discard 80ad4fa Update asf-site new ee100a5 Update asf-site This update added new revisions after undo

[skywalking-website] branch release/python/0.4.0 updated (db28621 -> 9260ea5)

2020-11-18 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch release/python/0.4.0 in repository https://gitbox.apache.org/repos/asf/skywalking-website.git. discard db28621 Release Python 0.4.0 add 9260ea5 Release Python 0.4.0 This update added

[skywalking-website] branch asf-site updated (d11d225 -> 80ad4fa)

2020-11-18 Thread tanjian
This is an automated email from the ASF dual-hosted git repository. tanjian pushed a change to branch asf-site in repository https://gitbox.apache.org/repos/asf/skywalking-website.git. discard d11d225 Update asf-site new 80ad4fa Update asf-site This update added new revisions after undo

[skywalking-website] 01/01: Release Python 0.4.0

2020-11-18 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a commit to branch release/python/0.4.0 in repository https://gitbox.apache.org/repos/asf/skywalking-website.git commit db28621ee68ab5507a6ca51cfe61576ff10fe897 Author: kezhenxu94 AuthorDate: Thu Nov 19 10:22:1

[skywalking-website] branch release/python/0.4.0 created (now db28621)

2020-11-18 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch release/python/0.4.0 in repository https://gitbox.apache.org/repos/asf/skywalking-website.git. at db28621 Release Python 0.4.0 This branch includes the following new commits: ne

[GitHub] [skywalking-website] kezhenxu94 merged pull request #132: Release Python 0.4.0

2020-11-18 Thread GitBox
kezhenxu94 merged pull request #132: URL: https://github.com/apache/skywalking-website/pull/132 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[skywalking-website] branch asf-site updated (d11d225 -> 80ad4fa)

2020-11-18 Thread tanjian
This is an automated email from the ASF dual-hosted git repository. tanjian pushed a change to branch asf-site in repository https://gitbox.apache.org/repos/asf/skywalking-website.git. discard d11d225 Update asf-site new 80ad4fa Update asf-site This update added new revisions after undo

[skywalking-website] branch release/python/0.4.0 created (now db28621)

2020-11-18 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch release/python/0.4.0 in repository https://gitbox.apache.org/repos/asf/skywalking-website.git. at db28621 Release Python 0.4.0 This branch includes the following new commits: ne

[skywalking-website] 01/01: Release Python 0.4.0

2020-11-18 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a commit to branch release/python/0.4.0 in repository https://gitbox.apache.org/repos/asf/skywalking-website.git commit db28621ee68ab5507a6ca51cfe61576ff10fe897 Author: kezhenxu94 AuthorDate: Thu Nov 19 10:22:1

[GitHub] [skywalking] vcjmhg commented on issue #4545: add error log(log4j,logback) to span log event

2020-11-18 Thread GitBox
vcjmhg commented on issue #4545: URL: https://github.com/apache/skywalking/issues/4545#issuecomment-730085599 > Why does `LogbakLoggerFactoryInstrumentation` need to know about `org.slf4j.LoggerFactory`? > * I would assume slf4j wouldn't come into the picture as under the hood it is usi

[skywalking-website] branch release/python/0.4.0 created (now db28621)

2020-11-18 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch release/python/0.4.0 in repository https://gitbox.apache.org/repos/asf/skywalking-website.git. at db28621 Release Python 0.4.0 No new revisions were added by this update.

[GitHub] [skywalking-website] kezhenxu94 opened a new pull request #132: Release Python 0.4.0

2020-11-18 Thread GitBox
kezhenxu94 opened a new pull request #132: URL: https://github.com/apache/skywalking-website/pull/132 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [skywalking] wu-sheng commented on issue #5860: Upgrade Envoy API to V3

2020-11-18 Thread GitBox
wu-sheng commented on issue #5860: URL: https://github.com/apache/skywalking/issues/5860#issuecomment-730072558 Most codes should not have to change, and e2e should pass, if there is something unexpected, please let me know. Also, add 1.7+ Istio recommended in our ALS log as v3 started wit

[GitHub] [skywalking] wu-sheng commented on issue #5860: Upgrade Envoy API to V3

2020-11-18 Thread GitBox
wu-sheng commented on issue #5860: URL: https://github.com/apache/skywalking/issues/5860#issuecomment-730071769 v3 should have been activated in the Istio 1.7 and 1.8 already. Due to the back forward compatibility, our codes still work. Therefore, let's use the latest v3 from https://gith

[GitHub] [skywalking] hanahmily opened a new issue #5860: Upgrade Envoy API to V3

2020-11-18 Thread GitBox
hanahmily opened a new issue #5860: URL: https://github.com/apache/skywalking/issues/5860 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [ ] Bug - [ ] Requirement - [x] Feature or performance impro

[GitHub] [skywalking-rocketbot-ui] masterxxo opened a new pull request #372: Moved magic strings to constants file

2020-11-18 Thread GitBox
masterxxo opened a new pull request #372: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/372 This pull request moving magic strings from timeFormat file to a separate constant file. It's also moving the constants file to the new directory.

[GitHub] [skywalking] BFergerson commented on issue #4545: add error log(log4j,logback) to span log event

2020-11-18 Thread GitBox
BFergerson commented on issue #4545: URL: https://github.com/apache/skywalking/issues/4545#issuecomment-729843248 @vcjmhg, thanks for all of the above information. It is very helpful. I've taken a look at the work you've done and it does seem to be pretty much there for Logback. Btw,

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5835: Observing Istio control plane

2020-11-18 Thread GitBox
codecov[bot] edited a comment on pull request #5835: URL: https://github.com/apache/skywalking/pull/5835#issuecomment-726062733 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=h1) Report > Merging [#5835](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5835: Observing Istio control plane

2020-11-18 Thread GitBox
codecov[bot] edited a comment on pull request #5835: URL: https://github.com/apache/skywalking/pull/5835#issuecomment-726062733 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=h1) Report > Merging [#5835](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&e

[GitHub] [skywalking] muse-dev[bot] commented on a change in pull request #5835: Observing Istio control plane

2020-11-18 Thread GitBox
muse-dev[bot] commented on a change in pull request #5835: URL: https://github.com/apache/skywalking/pull/5835#discussion_r526139611 ## File path: oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/dsl/Expression.java ## @@ -23,18 +23,35

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5835: Observing Istio control plane

2020-11-18 Thread GitBox
codecov[bot] edited a comment on pull request #5835: URL: https://github.com/apache/skywalking/pull/5835#issuecomment-726062733 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=h1) Report > Merging [#5835](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5835: Observing Istio control plane

2020-11-18 Thread GitBox
codecov[bot] edited a comment on pull request #5835: URL: https://github.com/apache/skywalking/pull/5835#issuecomment-726062733 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=h1) Report > Merging [#5835](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5835: Observing Istio control plane

2020-11-18 Thread GitBox
codecov[bot] edited a comment on pull request #5835: URL: https://github.com/apache/skywalking/pull/5835#issuecomment-726062733 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=h1) Report > Merging [#5835](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5835: Observing Istio control plane

2020-11-18 Thread GitBox
codecov[bot] edited a comment on pull request #5835: URL: https://github.com/apache/skywalking/pull/5835#issuecomment-726062733 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=h1) Report > Merging [#5835](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5835: Observing Istio control plane

2020-11-18 Thread GitBox
codecov[bot] edited a comment on pull request #5835: URL: https://github.com/apache/skywalking/pull/5835#issuecomment-726062733 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=h1) Report > Merging [#5835](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5835: Observing Istio control plane

2020-11-18 Thread GitBox
codecov[bot] edited a comment on pull request #5835: URL: https://github.com/apache/skywalking/pull/5835#issuecomment-726062733 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=h1) Report > Merging [#5835](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5835: Observing Istio control plane

2020-11-18 Thread GitBox
codecov[bot] edited a comment on pull request #5835: URL: https://github.com/apache/skywalking/pull/5835#issuecomment-726062733 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=h1) Report > Merging [#5835](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5835: Observing Istio control plane

2020-11-18 Thread GitBox
codecov[bot] edited a comment on pull request #5835: URL: https://github.com/apache/skywalking/pull/5835#issuecomment-726062733 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=h1) Report > Merging [#5835](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5835: Observing Istio control plane

2020-11-18 Thread GitBox
codecov[bot] edited a comment on pull request #5835: URL: https://github.com/apache/skywalking/pull/5835#issuecomment-726062733 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=h1) Report > Merging [#5835](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5835: Observing Istio control plane

2020-11-18 Thread GitBox
codecov[bot] edited a comment on pull request #5835: URL: https://github.com/apache/skywalking/pull/5835#issuecomment-726062733 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=h1) Report > Merging [#5835](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5835: Observing Istio control plane

2020-11-18 Thread GitBox
codecov[bot] edited a comment on pull request #5835: URL: https://github.com/apache/skywalking/pull/5835#issuecomment-726062733 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5835: Observing Istio control plane

2020-11-18 Thread GitBox
codecov[bot] edited a comment on pull request #5835: URL: https://github.com/apache/skywalking/pull/5835#issuecomment-726062733 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=h1) Report > Merging [#5835](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5835: Observing Istio control plane

2020-11-18 Thread GitBox
codecov[bot] edited a comment on pull request #5835: URL: https://github.com/apache/skywalking/pull/5835#issuecomment-726062733 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=h1) Report > Merging [#5835](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5835: Observing Istio control plane

2020-11-18 Thread GitBox
codecov[bot] edited a comment on pull request #5835: URL: https://github.com/apache/skywalking/pull/5835#issuecomment-726062733 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=h1) Report > Merging [#5835](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5835: Observing Istio control plane

2020-11-18 Thread GitBox
codecov[bot] edited a comment on pull request #5835: URL: https://github.com/apache/skywalking/pull/5835#issuecomment-726062733 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=h1) Report > Merging [#5835](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5835: Observing Istio control plane

2020-11-18 Thread GitBox
codecov[bot] edited a comment on pull request #5835: URL: https://github.com/apache/skywalking/pull/5835#issuecomment-726062733 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=h1) Report > Merging [#5835](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5835: Observing Istio control plane

2020-11-18 Thread GitBox
codecov[bot] edited a comment on pull request #5835: URL: https://github.com/apache/skywalking/pull/5835#issuecomment-726062733 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=h1) Report > Merging [#5835](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&e

[skywalking] branch otel-istio updated (51251d5 -> b3a6ba6)

2020-11-18 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch otel-istio in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 51251d5 Merge branch 'otel-istio' of github.com:apache/skywalking into otel-istio add 00b23cf Crea

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5835: Observing Istio control plane

2020-11-18 Thread GitBox
codecov[bot] edited a comment on pull request #5835: URL: https://github.com/apache/skywalking/pull/5835#issuecomment-726062733 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=h1) Report > Merging [#5835](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&e

[GitHub] [skywalking] JaredTan95 edited a comment on pull request #5844: add Tidb provider module.

2020-11-18 Thread GitBox
JaredTan95 edited a comment on pull request #5844: URL: https://github.com/apache/skywalking/pull/5844#issuecomment-729643655 > > There is some problem creating a new database when there starting with tidb. :-P > > Need any help? Feel free to ping me if anything I can help Yes

[GitHub] [skywalking] JaredTan95 commented on pull request #5844: add Tidb provider module.

2020-11-18 Thread GitBox
JaredTan95 commented on pull request #5844: URL: https://github.com/apache/skywalking/pull/5844#issuecomment-729643655 > > There is some problem creating a new database when there starting with tidb. :-P > > Need any help? Feel free to ping me if anything I can help Yes, There

[GitHub] [skywalking] wu-sheng commented on issue #5838: Leverage ShardingSphere's SQL parser to get table's read/write level metrics

2020-11-18 Thread GitBox
wu-sheng commented on issue #5838: URL: https://github.com/apache/skywalking/issues/5838#issuecomment-729634691 I set up the benchmarks to test the performance, https://github.com/apache/shardingsphere/issues/8208. We need a deeper discussion and maybe optimization as right now, it seems w

[GitHub] [skywalking] liuhonglin commented on issue #5481: service list can't click

2020-11-18 Thread GitBox
liuhonglin commented on issue #5481: URL: https://github.com/apache/skywalking/issues/5481#issuecomment-729581144 ![image](https://user-images.githubusercontent.com/13495924/99517659-967f7480-29ca-11eb-974e-634e3b7b7461.png) ![image](https://user-images.githubusercontent.com/13495924/99

[GitHub] [skywalking] liuhonglin commented on issue #5481: service list can't click

2020-11-18 Thread GitBox
liuhonglin commented on issue #5481: URL: https://github.com/apache/skywalking/issues/5481#issuecomment-729579277 I have the same problem This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [skywalking] wu-sheng commented on issue #5859: use threadpool,‘trace cross thread’ can print tid,but tid not change all the time

2020-11-18 Thread GitBox
wu-sheng commented on issue #5859: URL: https://github.com/apache/skywalking/issues/5859#issuecomment-729573162 Tracing context is working with thread/stack. So, basically, we don't care about the thread id, only thread stack matters. Across threads propagation belongs to the plugins or ma

[GitHub] [skywalking] wu-sheng closed issue #5859: use threadpool,‘trace cross thread’ can print tid,but tid not change all the time

2020-11-18 Thread GitBox
wu-sheng closed issue #5859: URL: https://github.com/apache/skywalking/issues/5859 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [skywalking] wu-sheng commented on issue #5859: use threadpool,‘trace cross thread’ can print tid,but tid not change all the time

2020-11-18 Thread GitBox
wu-sheng commented on issue #5859: URL: https://github.com/apache/skywalking/issues/5859#issuecomment-729572533 I can't understand your meaning. I don't know what change and unchanged mean. This is an automated message from t

[GitHub] [skywalking] killGC opened a new issue #5859: use threadpool,‘trace cross thread’ can print tid,but tid not change all the time

2020-11-18 Thread GitBox
killGC opened a new issue #5859: URL: https://github.com/apache/skywalking/issues/5859 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [ ] Bug - [ ] Requirement - [ ] Feature or performance improvem

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5844: add Tidb provider module.

2020-11-18 Thread GitBox
codecov[bot] edited a comment on pull request #5844: URL: https://github.com/apache/skywalking/pull/5844#issuecomment-727203629 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=h1) Report > Merging [#5844](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5844: add Tidb provider module.

2020-11-18 Thread GitBox
codecov[bot] edited a comment on pull request #5844: URL: https://github.com/apache/skywalking/pull/5844#issuecomment-727203629 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=h1) Report > Merging [#5844](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5844: add Tidb provider module.

2020-11-18 Thread GitBox
codecov[bot] edited a comment on pull request #5844: URL: https://github.com/apache/skywalking/pull/5844#issuecomment-727203629 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=h1) Report > Merging [#5844](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&e

  1   2   >