wu-sheng commented on pull request #7367:
URL: https://github.com/apache/skywalking/pull/7367#issuecomment-886005439
> @wu-sheng Yes, our Grafana UI already has these.
@Switch-vov You don't need to take care of Grafana. It is there. Please
follow other comments.
--
This is an
Ax1an commented on pull request #7367:
URL: https://github.com/apache/skywalking/pull/7367#issuecomment-886004970
@Switch-vov Please recheck the tests, it fails somehow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
Ax1an commented on pull request #7367:
URL: https://github.com/apache/skywalking/pull/7367#issuecomment-886004155
@wu-sheng Yes, our Grafana UI already has these.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
qsliu2017 commented on pull request #7363:
URL: https://github.com/apache/skywalking/pull/7363#issuecomment-886004145
> You haven't gotten my point. If spans could be duplicate, then both
plugins work, then the only possibility a trace breaks, because the context
doesn't propagate(across
codecov[bot] edited a comment on pull request #7367:
URL: https://github.com/apache/skywalking/pull/7367#issuecomment-885995984
#
zgfh opened a new pull request #135:
URL: https://github.com/apache/skywalking-python/pull/135
update init param name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
codecov[bot] edited a comment on pull request #7367:
URL: https://github.com/apache/skywalking/pull/7367#issuecomment-885995984
#
codecov[bot] edited a comment on pull request #7367:
URL: https://github.com/apache/skywalking/pull/7367#issuecomment-885995984
#
codecov[bot] edited a comment on pull request #7367:
URL: https://github.com/apache/skywalking/pull/7367#issuecomment-885995984
#
codecov[bot] edited a comment on pull request #7367:
URL: https://github.com/apache/skywalking/pull/7367#issuecomment-885995984
#
codecov[bot] edited a comment on pull request #7367:
URL: https://github.com/apache/skywalking/pull/7367#issuecomment-885995984
#
codecov[bot] edited a comment on pull request #7367:
URL: https://github.com/apache/skywalking/pull/7367#issuecomment-885995984
#
codecov[bot] edited a comment on pull request #7367:
URL: https://github.com/apache/skywalking/pull/7367#issuecomment-885995984
#
codecov[bot] edited a comment on pull request #7367:
URL: https://github.com/apache/skywalking/pull/7367#issuecomment-885995984
#
codecov[bot] edited a comment on pull request #7367:
URL: https://github.com/apache/skywalking/pull/7367#issuecomment-885995984
#
codecov[bot] edited a comment on pull request #7367:
URL: https://github.com/apache/skywalking/pull/7367#issuecomment-885995984
#
codecov[bot] edited a comment on pull request #7367:
URL: https://github.com/apache/skywalking/pull/7367#issuecomment-885995984
#
codecov[bot] edited a comment on pull request #7367:
URL: https://github.com/apache/skywalking/pull/7367#issuecomment-885995984
#
codecov[bot] edited a comment on pull request #7367:
URL: https://github.com/apache/skywalking/pull/7367#issuecomment-885995984
#
codecov[bot] edited a comment on pull request #7367:
URL: https://github.com/apache/skywalking/pull/7367#issuecomment-885995984
#
codecov[bot] edited a comment on pull request #7367:
URL: https://github.com/apache/skywalking/pull/7367#issuecomment-885995984
#
codecov[bot] edited a comment on pull request #7367:
URL: https://github.com/apache/skywalking/pull/7367#issuecomment-885995984
#
codecov[bot] edited a comment on pull request #7367:
URL: https://github.com/apache/skywalking/pull/7367#issuecomment-885995984
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
codecov[bot] edited a comment on pull request #7367:
URL: https://github.com/apache/skywalking/pull/7367#issuecomment-885995984
#
wu-sheng commented on pull request #7367:
URL: https://github.com/apache/skywalking/pull/7367#issuecomment-885999744
Grafana UI provides that. @Ax1an Please confirm whether we have these
already.
--
This is an automated message from the Apache Git Service.
To respond to the message,
codecov[bot] edited a comment on pull request #7367:
URL: https://github.com/apache/skywalking/pull/7367#issuecomment-885995984
#
codecov[bot] edited a comment on pull request #7367:
URL: https://github.com/apache/skywalking/pull/7367#issuecomment-885995984
#
codecov[bot] edited a comment on pull request #7367:
URL: https://github.com/apache/skywalking/pull/7367#issuecomment-885995984
#
Switch-vov commented on pull request #7367:
URL: https://github.com/apache/skywalking/pull/7367#issuecomment-885998016
@wu-sheng Only update OC receiver MAL settings.
Because I don't known how generate the grafana settings
`docs/en/setup/backend/grafana-cluster.json` and
codecov[bot] edited a comment on pull request #7367:
URL: https://github.com/apache/skywalking/pull/7367#issuecomment-885995984
#
codecov[bot] edited a comment on pull request #7367:
URL: https://github.com/apache/skywalking/pull/7367#issuecomment-885995984
#
codecov[bot] edited a comment on pull request #7367:
URL: https://github.com/apache/skywalking/pull/7367#issuecomment-885995984
#
codecov[bot] edited a comment on pull request #7367:
URL: https://github.com/apache/skywalking/pull/7367#issuecomment-885995984
#
codecov[bot] edited a comment on pull request #7367:
URL: https://github.com/apache/skywalking/pull/7367#issuecomment-885995984
#
codecov[bot] edited a comment on pull request #7367:
URL: https://github.com/apache/skywalking/pull/7367#issuecomment-885995984
#
codecov[bot] edited a comment on pull request #7367:
URL: https://github.com/apache/skywalking/pull/7367#issuecomment-885995984
#
codecov[bot] edited a comment on pull request #7367:
URL: https://github.com/apache/skywalking/pull/7367#issuecomment-885995984
#
codecov[bot] edited a comment on pull request #7367:
URL: https://github.com/apache/skywalking/pull/7367#issuecomment-885995984
#
codecov[bot] edited a comment on pull request #7367:
URL: https://github.com/apache/skywalking/pull/7367#issuecomment-885995984
#
codecov[bot] edited a comment on pull request #7367:
URL: https://github.com/apache/skywalking/pull/7367#issuecomment-885995984
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
codecov[bot] edited a comment on pull request #7367:
URL: https://github.com/apache/skywalking/pull/7367#issuecomment-885995984
#
codecov[bot] edited a comment on pull request #7367:
URL: https://github.com/apache/skywalking/pull/7367#issuecomment-885995984
#
codecov[bot] edited a comment on pull request #7367:
URL: https://github.com/apache/skywalking/pull/7367#issuecomment-885995984
#
codecov[bot] edited a comment on pull request #7367:
URL: https://github.com/apache/skywalking/pull/7367#issuecomment-885995984
#
codecov[bot] edited a comment on pull request #7367:
URL: https://github.com/apache/skywalking/pull/7367#issuecomment-885995984
#
codecov[bot] edited a comment on pull request #7367:
URL: https://github.com/apache/skywalking/pull/7367#issuecomment-885995984
#
codecov[bot] edited a comment on pull request #7367:
URL: https://github.com/apache/skywalking/pull/7367#issuecomment-885995984
#
wu-sheng commented on pull request #7367:
URL: https://github.com/apache/skywalking/pull/7367#issuecomment-885996129
FYI @wankai123 @Ax1an Please review this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
codecov[bot] edited a comment on pull request #7367:
URL: https://github.com/apache/skywalking/pull/7367#issuecomment-885995984
#
codecov[bot] edited a comment on pull request #7367:
URL: https://github.com/apache/skywalking/pull/7367#issuecomment-885995984
#
codecov[bot] commented on pull request #7367:
URL: https://github.com/apache/skywalking/pull/7367#issuecomment-885995984
#
Switch-vov commented on pull request #7367:
URL: https://github.com/apache/skywalking/pull/7367#issuecomment-885995090
> You also should update OC receiver MAL settings, and grafana settings
ok.
--
This is an automated message from the Apache Git Service.
To respond to the
Switch-vov commented on pull request #7367:
URL: https://github.com/apache/skywalking/pull/7367#issuecomment-885995038
![image](https://user-images.githubusercontent.com/11993575/126856537-2d7ead6f-2c00-4a8f-8055-26069fde2d4f.png)
Switch-vov opened a new pull request #7367:
URL: https://github.com/apache/skywalking/pull/7367
###
- [x] Tests(including UT, IT, E2E) are added to verify the new feature.
- [x] If it's UI related, attach the screenshots below.
- [x] Update the [`CHANGES`
wu-sheng commented on pull request #48:
URL: https://github.com/apache/skywalking-eyes/pull/48#issuecomment-885974857
You should update the doc to show how to use this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
zooltd opened a new pull request #48:
URL: https://github.com/apache/skywalking-eyes/pull/48
1. Parse the project package.json file to gather the required packages
2. Run command 'npm install' to install or update the required node packages
(can skip)
3. Walk through each package's
zooltd closed pull request #45:
URL: https://github.com/apache/skywalking-eyes/pull/45
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
wu-sheng merged pull request #7366:
URL: https://github.com/apache/skywalking/pull/7366
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git
The following commit(s) were added to refs/heads/master by this push:
new 90de9f9 add sending Envoy Metrics to OAP
codecov[bot] edited a comment on pull request #7366:
URL: https://github.com/apache/skywalking/pull/7366#issuecomment-885675613
#
codecov[bot] edited a comment on pull request #7366:
URL: https://github.com/apache/skywalking/pull/7366#issuecomment-885675613
#
codecov[bot] edited a comment on pull request #7366:
URL: https://github.com/apache/skywalking/pull/7366#issuecomment-885675613
#
codecov[bot] edited a comment on pull request #7366:
URL: https://github.com/apache/skywalking/pull/7366#issuecomment-885675613
#
codecov[bot] edited a comment on pull request #7361:
URL: https://github.com/apache/skywalking/pull/7361#issuecomment-885372767
#
codecov[bot] edited a comment on pull request #7366:
URL: https://github.com/apache/skywalking/pull/7366#issuecomment-885675613
#
codecov[bot] commented on pull request #7366:
URL: https://github.com/apache/skywalking/pull/7366#issuecomment-885675613
#
wu-sheng commented on a change in pull request #58:
URL:
https://github.com/apache/skywalking-satellite/pull/58#discussion_r675593672
##
File path: .github/workflows/e2e.yaml
##
@@ -0,0 +1,34 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
wu-sheng commented on pull request #519:
URL:
https://github.com/apache/skywalking-rocketbot-ui/pull/519#issuecomment-885663840
16.3k is too large, please compress it. And provide the topology screenshot.
--
This is an automated message from the Apache Git Service.
To respond to the
wu-sheng edited a comment on pull request #7363:
URL: https://github.com/apache/skywalking/pull/7363#issuecomment-885662803
You haven't gotten my point. If spans could be duplicate, then both plugins
work, then the only possibility a trace breaks, because the context doesn't
wu-sheng commented on pull request #7363:
URL: https://github.com/apache/skywalking/pull/7363#issuecomment-885662803
You haven't gotten my point. If spans could be duplicate, then both plugins
work, then the only possibility a trace breaks, because the context doesn't
propagate, you just
This is an automated email from the ASF dual-hosted git repository.
tanjian pushed a change to branch envoy_stats_sink_config
in repository https://gitbox.apache.org/repos/asf/skywalking.git.
from 8c5abd1 update CHANGES.md
add 8820287 Improve okhttp plugin performance by optimizing
wu-sheng merged pull request #7364:
URL: https://github.com/apache/skywalking/pull/7364
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git.
from a7abb1f remove the logic of generated instance name in
KafkaServiceManagementServiceClient prepare
JaredTan95 opened a new pull request #7366:
URL: https://github.com/apache/skywalking/pull/7366
add sending Envoy Metrics to OAP in envoy 1.19 example and bump up to
Envoy V3 api.
- [ ] If this pull request closes/resolves/fixes an existing issue,
This is an automated email from the ASF dual-hosted git repository.
tanjian pushed a commit to branch envoy_stats_sink_config
in repository https://gitbox.apache.org/repos/asf/skywalking.git
The following commit(s) were added to refs/heads/envoy_stats_sink_config by
this push:
new 8c5abd1
This is an automated email from the ASF dual-hosted git repository.
tanjian pushed a commit to branch envoy_stats_sink_config
in repository https://gitbox.apache.org/repos/asf/skywalking.git
The following commit(s) were added to refs/heads/envoy_stats_sink_config by
this push:
new 01631fd
codecov[bot] edited a comment on pull request #7361:
URL: https://github.com/apache/skywalking/pull/7361#issuecomment-885372767
#
This is an automated email from the ASF dual-hosted git repository.
tanjian pushed a commit to branch envoy_stats_sink_config
in repository https://gitbox.apache.org/repos/asf/skywalking.git
commit 35ce622028dad2015ffb28ed1b0274adcf6a081c
Author: JaredTan95
AuthorDate: Fri Jul 23 21:31:57 2021
This is an automated email from the ASF dual-hosted git repository.
tanjian pushed a change to branch envoy_stats_sink_config
in repository https://gitbox.apache.org/repos/asf/skywalking.git.
at 35ce622 bump up envoy metrics service sinks version. and update
envoy.yaml config for demo.
codecov[bot] edited a comment on pull request #7361:
URL: https://github.com/apache/skywalking/pull/7361#issuecomment-885372767
#
qsliu2017 commented on pull request #7363:
URL: https://github.com/apache/skywalking/pull/7363#issuecomment-885634819
> > The existing plugin enhances rabbitmq java client interface so it works
for all rabbitmq client implementations. But this plugin only enhances the
implementation of
codecov[bot] edited a comment on pull request #7364:
URL: https://github.com/apache/skywalking/pull/7364#issuecomment-885600485
#
vcjmhg commented on issue #7360:
URL: https://github.com/apache/skywalking/issues/7360#issuecomment-885622157
ok, I find it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
wu-sheng commented on issue #7360:
URL: https://github.com/apache/skywalking/issues/7360#issuecomment-885618621
There is a docker compose out there. Have you checked?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
wu-sheng commented on pull request #7363:
URL: https://github.com/apache/skywalking/pull/7363#issuecomment-885618138
> The existing plugin enhances rabbitmq java client interface so it works
for all rabbitmq client implementations. But this plugin only enhances the
implementation of
vcjmhg opened a new pull request #519:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/519
Related issue: apache/skywalking#7360
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
qsliu2017 commented on pull request #7363:
URL: https://github.com/apache/skywalking/pull/7363#issuecomment-885615117
The existing plugin enhances rabbitmq java client interface so it works for
all rabbitmq client implementations. But this plugin only enhances the
implementation of
vcjmhg commented on issue #7360:
URL: https://github.com/apache/skywalking/issues/7360#issuecomment-885609758
And I want to know how to mock the server in my test project.
In `activemq-scenario`, I don't find the URL of server . It has a
`brokenUrl` but is not injected in the project.
vcjmhg commented on issue #7360:
URL: https://github.com/apache/skywalking/issues/7360#issuecomment-885606778
Yes, it's open-sourced. And I will do it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
wu-sheng commented on issue #7360:
URL: https://github.com/apache/skywalking/issues/7360#issuecomment-885603667
And is the Zeebe open sourced? Does it have an icon to contribute to UI repo?
Then the topology could show the node with an meaningful icon, rather than
current cloud icon.
vcjmhg edited a comment on issue #7360:
URL: https://github.com/apache/skywalking/issues/7360#issuecomment-885602304
> What is create instance?
The error result when the peer was not set correctly before, after
restarting the OAP, the display is as follows:
vcjmhg commented on issue #7360:
URL: https://github.com/apache/skywalking/issues/7360#issuecomment-885602304
The error result when the peer was not set correctly before, after
restarting the OAP, the display is as follows:
codecov[bot] edited a comment on pull request #7364:
URL: https://github.com/apache/skywalking/pull/7364#issuecomment-885600485
#
codecov[bot] commented on pull request #7364:
URL: https://github.com/apache/skywalking/pull/7364#issuecomment-885600485
#
wu-sheng commented on pull request #7363:
URL: https://github.com/apache/skywalking/pull/7363#issuecomment-885597780
This doesn't make sense. You said there is duplicate spans, then these is at
least one case both plugins work.
--
This is an automated message from the Apache Git
wu-sheng commented on pull request #7364:
URL: https://github.com/apache/skywalking/pull/7364#issuecomment-885596762
Once all tests passed, this at least improves a little, but limited.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
wu-sheng commented on pull request #7364:
URL: https://github.com/apache/skywalking/pull/7364#issuecomment-885596126
> > The big performance impact is mostly because reflect execution. But
getting field is not very slow. Are you facing real issue?
>
>
>
> I am not facing the
wu-sheng commented on issue #7360:
URL: https://github.com/apache/skywalking/issues/7360#issuecomment-885595609
What is create instance?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
vcjmhg commented on issue #7360:
URL: https://github.com/apache/skywalking/issues/7360#issuecomment-885593825
like this?
![image](https://user-images.githubusercontent.com/55177318/126779616-b1ae1d0d-fa73-44ea-9b72-9d71f78cecf5.png)
--
This is an automated message from the Apache
wu-sheng commented on issue #7360:
URL: https://github.com/apache/skywalking/issues/7360#issuecomment-885576629
If you set it as MQ, and have correct peer IP, then it should have a node i.
topology.
--
This is an automated message from the Apache Git Service.
To respond to the message,
1 - 100 of 130 matches
Mail list logo