[GitHub] [skywalking-satellite] mrproliu opened a new pull request #69: Support load-balance GRPC client with Kubenetes selector

mrproliu opened a new pull request #69: URL: https://github.com/apache/skywalking-satellite/pull/69 Follow https://github.com/apache/skywalking/issues/7247 I found the Kubernetes selector is similar to the [Prometheus Kubernetes config](https://prometheus.io/docs/prometheus/latest/config

[GitHub] [skywalking-java] wuguanyu opened a new pull request #36: 2021 09 22 fix bug

wuguanyu opened a new pull request #36: URL: https://github.com/apache/skywalking-java/pull/36 Fix NumberFormat in MysqlURLParser https://github.com/apache/skywalking/issues/7758 -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [skywalking-satellite] wu-sheng commented on a change in pull request #69: Support load-balance GRPC client with Kubenetes selector

wu-sheng commented on a change in pull request #69: URL: https://github.com/apache/skywalking-satellite/pull/69#discussion_r715380621 ## File path: docs/en/setup/examples/grpc-load-balance-client/README.md ## @@ -0,0 +1,84 @@ +# GRPC load balance client + +GRPC client support

[GitHub] [skywalking-satellite] wu-sheng commented on a change in pull request #69: Support load-balance GRPC client with Kubenetes selector

wu-sheng commented on a change in pull request #69: URL: https://github.com/apache/skywalking-satellite/pull/69#discussion_r715381169 ## File path: docs/en/setup/examples/grpc-load-balance-client/README.md ## @@ -0,0 +1,84 @@ +# GRPC load balance client + +GRPC client support

[GitHub] [skywalking-java] wuguanyu closed pull request #36: fix NumberFormat exception in MysqlURLParser

wuguanyu closed pull request #36: URL: https://github.com/apache/skywalking-java/pull/36 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificat

[GitHub] [skywalking-satellite] wu-sheng commented on a change in pull request #69: Support load-balance GRPC client with Kubenetes selector

wu-sheng commented on a change in pull request #69: URL: https://github.com/apache/skywalking-satellite/pull/69#discussion_r715381543 ## File path: docs/en/setup/examples/grpc-load-balance-client/README.md ## @@ -0,0 +1,84 @@ +# GRPC load balance client + +GRPC client support

[GitHub] [skywalking-java] wu-sheng commented on pull request #36: fix NumberFormat exception in MysqlURLParser

wu-sheng commented on pull request #36: URL: https://github.com/apache/skywalking-java/pull/36#issuecomment-926410853 changes.md in the root should be updated too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[skywalking] branch fix-meter-name created (now 7bdd2f3)

This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch fix-meter-name in repository https://gitbox.apache.org/repos/asf/skywalking.git. at 7bdd2f3 Fix entity naming mechanism failure in MAL This branch includes the following new commits:

[skywalking] 01/01: Fix entity naming mechanism failure in MAL

This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch fix-meter-name in repository https://gitbox.apache.org/repos/asf/skywalking.git commit 7bdd2f3497cf2e4b3968551a2bdd791e84d571a9 Author: Wu Sheng AuthorDate: Fri Sep 24 15:45:58 2021 +0800 F

[GitHub] [skywalking] wu-sheng opened a new pull request #7790: Fix entity naming mechanism failure in MAL

wu-sheng opened a new pull request #7790: URL: https://github.com/apache/skywalking/pull/7790 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [x] Update the [`CHANGES` log](https://github.com/apach

[GitHub] [skywalking-java] wu-sheng commented on a change in pull request #35: Add Fastjson plugin

wu-sheng commented on a change in pull request #35: URL: https://github.com/apache/skywalking-java/pull/35#discussion_r715392189 ## File path: apm-sniffer/optional-plugins/fastjson-1.2.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/fastjson/define/FastjsonInstrumentation.java

[GitHub] [skywalking-satellite] mrproliu commented on a change in pull request #69: Support load-balance GRPC client with Kubenetes selector

mrproliu commented on a change in pull request #69: URL: https://github.com/apache/skywalking-satellite/pull/69#discussion_r715392682 ## File path: docs/en/setup/examples/grpc-load-balance-client/README.md ## @@ -0,0 +1,84 @@ +# GRPC load balance client + +GRPC client support

[GitHub] [skywalking-satellite] mrproliu commented on a change in pull request #69: Support load-balance GRPC client with Kubenetes selector

mrproliu commented on a change in pull request #69: URL: https://github.com/apache/skywalking-satellite/pull/69#discussion_r715393620 ## File path: docs/en/setup/examples/grpc-load-balance-client/README.md ## @@ -0,0 +1,84 @@ +# GRPC load balance client + +GRPC client support

[GitHub] [skywalking-satellite] wu-sheng commented on a change in pull request #69: Support load-balance GRPC client with Kubenetes selector

wu-sheng commented on a change in pull request #69: URL: https://github.com/apache/skywalking-satellite/pull/69#discussion_r715393953 ## File path: docs/en/setup/examples/grpc-load-balance-client/README.md ## @@ -0,0 +1,84 @@ +# GRPC load balance client + +GRPC client support

[GitHub] [skywalking-satellite] mrproliu commented on a change in pull request #69: Support load-balance GRPC client with Kubenetes selector

mrproliu commented on a change in pull request #69: URL: https://github.com/apache/skywalking-satellite/pull/69#discussion_r715395060 ## File path: docs/en/setup/examples/grpc-load-balance-client/README.md ## @@ -0,0 +1,84 @@ +# GRPC load balance client + +GRPC client support

[GitHub] [skywalking-satellite] wu-sheng commented on pull request #69: Support load-balance GRPC client with Kubenetes selector

wu-sheng commented on pull request #69: URL: https://github.com/apache/skywalking-satellite/pull/69#issuecomment-926426040 > I found the plugin could not auto-generate the plugin settings, only has default settings, but some options config are not declared in the documentation. Noti

[GitHub] [skywalking-java] VictorZeng commented on a change in pull request #35: Add Fastjson plugin

VictorZeng commented on a change in pull request #35: URL: https://github.com/apache/skywalking-java/pull/35#discussion_r715402685 ## File path: apm-sniffer/optional-plugins/fastjson-1.2.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/fastjson/define/FastjsonInstrumentation.ja

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #7790: Fix entity naming mechanism failure in MAL

kezhenxu94 commented on a change in pull request #7790: URL: https://github.com/apache/skywalking/pull/7790#discussion_r715403315 ## File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/meter/MeterEntity.java ## @@ -35,6 +36,8 @@ @Get

[GitHub] [skywalking-java] wu-sheng commented on a change in pull request #36: fix NumberFormat exception in MysqlURLParser

wu-sheng commented on a change in pull request #36: URL: https://github.com/apache/skywalking-java/pull/36#discussion_r715403723 ## File path: apm-sniffer/apm-sdk-plugin/jdbc-commons/src/main/java/org/apache/skywalking/apm/plugin/jdbc/connectionurl/parser/MysqlURLParser.java #

[skywalking] branch fix-meter-name updated (7bdd2f3 -> 9a876c8)

This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch fix-meter-name in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 7bdd2f3 Fix entity naming mechanism failure in MAL add 9a876c8 Fix missing parts. No new revisio

[GitHub] [skywalking] wu-sheng commented on a change in pull request #7790: Fix entity naming mechanism failure in MAL

wu-sheng commented on a change in pull request #7790: URL: https://github.com/apache/skywalking/pull/7790#discussion_r715405741 ## File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/meter/MeterEntity.java ## @@ -35,6 +36,8 @@ @Gette

[GitHub] [skywalking-java] kezhenxu94 commented on a change in pull request #35: Add Fastjson plugin

kezhenxu94 commented on a change in pull request #35: URL: https://github.com/apache/skywalking-java/pull/35#discussion_r715350465 ## File path: apm-sniffer/optional-plugins/fastjson-1.2.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/fastjson/define/FastjsonInstrumentation.ja

[skywalking-satellite] branch main updated: Support load-balance GRPC client with Kubenetes selector (#69)

This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/skywalking-satellite.git The following commit(s) were added to refs/heads/main by this push: new 6292e2f Support load-balance GRPC cl

[GitHub] [skywalking-satellite] wu-sheng merged pull request #69: Support load-balance GRPC client with Kubenetes selector

wu-sheng merged pull request #69: URL: https://github.com/apache/skywalking-satellite/pull/69 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: noti

[GitHub] [skywalking-java] VictorZeng commented on a change in pull request #35: Add Fastjson plugin

VictorZeng commented on a change in pull request #35: URL: https://github.com/apache/skywalking-java/pull/35#discussion_r71542 ## File path: apm-sniffer/optional-plugins/fastjson-1.2.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/fastjson/define/FastjsonInstrumentation.ja

[GitHub] [skywalking-java] wu-sheng commented on a change in pull request #35: Add Fastjson plugin

wu-sheng commented on a change in pull request #35: URL: https://github.com/apache/skywalking-java/pull/35#discussion_r715411949 ## File path: apm-sniffer/optional-plugins/fastjson-1.2.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/fastjson/define/FastjsonInstrumentation.java

[GitHub] [skywalking-java] VictorZeng commented on a change in pull request #35: Add Fastjson plugin

VictorZeng commented on a change in pull request #35: URL: https://github.com/apache/skywalking-java/pull/35#discussion_r715417956 ## File path: apm-sniffer/optional-plugins/fastjson-1.2.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/fastjson/define/FastjsonInstrumentation.ja

[GitHub] [skywalking-java] wu-sheng commented on a change in pull request #35: Add Fastjson plugin

wu-sheng commented on a change in pull request #35: URL: https://github.com/apache/skywalking-java/pull/35#discussion_r715418718 ## File path: apm-sniffer/optional-plugins/fastjson-1.2.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/fastjson/define/FastjsonInstrumentation.java

[GitHub] [skywalking-java] wu-sheng commented on a change in pull request #35: Add Fastjson plugin

wu-sheng commented on a change in pull request #35: URL: https://github.com/apache/skywalking-java/pull/35#discussion_r715419344 ## File path: apm-sniffer/optional-plugins/fastjson-1.2.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/fastjson/define/FastjsonInstrumentation.java

[GitHub] [skywalking-java] VictorZeng commented on a change in pull request #35: Add Fastjson plugin

VictorZeng commented on a change in pull request #35: URL: https://github.com/apache/skywalking-java/pull/35#discussion_r715421235 ## File path: apm-sniffer/optional-plugins/fastjson-1.2.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/fastjson/define/FastjsonInstrumentation.ja

[GitHub] [skywalking] wuwen5 opened a new issue #7793: [Client JS] TypeError: Cannot read properties of null (reading 'stack')

wuwen5 opened a new issue #7793: URL: https://github.com/apache/skywalking/issues/7793 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar issues. ### Apache SkyWalking Component

[GitHub] [skywalking-java] VictorZeng commented on pull request #35: Add Fastjson plugin

VictorZeng commented on pull request #35: URL: https://github.com/apache/skywalking-java/pull/35#issuecomment-926454137 @wu-sheng @kezhenxu94 Thank you for review, I will contributing jackson's plug-ins next. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [skywalking-client-js] wuwen5 opened a new pull request #72: fix window.onerror TypeError

wuwen5 opened a new pull request #72: URL: https://github.com/apache/skywalking-client-js/pull/72 Fix apache/skywalking#7793 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [skywalking] macaty opened a new pull request #7795: SW_STORAGE default is elasticsearch7

macaty opened a new pull request #7795: URL: https://github.com/apache/skywalking/pull/7795 SW_STORAGE default is elasticsearch7 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [skywalking] wu-sheng commented on a change in pull request #7795: SW_STORAGE default is elasticsearch7

wu-sheng commented on a change in pull request #7795: URL: https://github.com/apache/skywalking/pull/7795#discussion_r715459634 ## File path: docker/README.md ## @@ -55,6 +55,6 @@ From the output, we can find out the building tool adopts the files stored in `o We can start up

[GitHub] [skywalking] wu-sheng commented on a change in pull request #7795: SW_STORAGE default is elasticsearch7

wu-sheng commented on a change in pull request #7795: URL: https://github.com/apache/skywalking/pull/7795#discussion_r715460671 ## File path: docker/README.md ## @@ -55,6 +55,6 @@ From the output, we can find out the building tool adopts the files stored in `o We can start up

[GitHub] [skywalking] kezhenxu94 commented on pull request #7795: SW_STORAGE default is elasticsearch7

kezhenxu94 commented on pull request #7795: URL: https://github.com/apache/skywalking/pull/7795#issuecomment-926484061 Please check the Chang log , there is no elasticsearch7 in master branch anymore, if you are using old version , check the corresponding tag -- This is an automated mes

[GitHub] [skywalking] kezhenxu94 closed pull request #7795: SW_STORAGE default is elasticsearch7

kezhenxu94 closed pull request #7795: URL: https://github.com/apache/skywalking/pull/7795 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifica

[GitHub] [skywalking] wu-sheng commented on pull request #7790: Fix entity naming mechanism failure in MAL

wu-sheng commented on pull request #7790: URL: https://github.com/apache/skywalking/pull/7790#issuecomment-926486958 @kezhenxu94 I removed `@Builder` and fixed the tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[skywalking] branch fix-meter-name updated (9a876c8 -> 377bb63)

This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch fix-meter-name in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 9a876c8 Fix missing parts. add 377bb63 Polish fix No new revisions were added by this update. S

[GitHub] [skywalking-java] wu-sheng merged pull request #35: Add Fastjson plugin

wu-sheng merged pull request #35: URL: https://github.com/apache/skywalking-java/pull/35 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificat

[skywalking-java] branch main updated: Add Fastjson plugin (#35)

This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/skywalking-java.git The following commit(s) were added to refs/heads/main by this push: new c5657e8 Add Fastjson plugin (#35) c5657e8

[GitHub] [skywalking-rocketbot-ui] Fine0830 opened a new pull request #542: feat: implement Alerts for query errors

Fine0830 opened a new pull request #542: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/542 Close https://github.com/apache/skywalking/issues/7711 Screenshots 

[skywalking-client-js] branch master updated: fix window.onerror TypeError (#72)

This is an automated email from the ASF dual-hosted git repository. qiuxiafan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-client-js.git The following commit(s) were added to refs/heads/master by this push: new 883aa1d fix window.onerror Typ

[GitHub] [skywalking] Fine0830 closed issue #7793: [Client JS] TypeError: Cannot read properties of null (reading 'stack')

Fine0830 closed issue #7793: URL: https://github.com/apache/skywalking/issues/7793 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-u

[GitHub] [skywalking-client-js] Fine0830 merged pull request #72: fix window.onerror TypeError

Fine0830 merged pull request #72: URL: https://github.com/apache/skywalking-client-js/pull/72 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: noti

[GitHub] [skywalking] wu-sheng merged pull request #7790: Fix entity naming mechanism failure in MAL

wu-sheng merged pull request #7790: URL: https://github.com/apache/skywalking/pull/7790 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificati

[skywalking] branch master updated: Fix entity naming mechanism failure in MAL (#7790)

This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new b7ba282 Fix entity naming mechanism failur

[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #542: feat: implement Alerts for query errors

wu-sheng commented on pull request #542: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/542#issuecomment-926556649 > 2 min seems too long for me, I think 30 seconds is enough? 30s should be enough. -- This is an automated message from the Apache Git Service. To respon

[GitHub] [skywalking] wallezhang commented on issue #7658: [Bug] Skywalking + SpringCloud Gateway : Can not do async finish for the span repeatedly

wallezhang commented on issue #7658: URL: https://github.com/apache/skywalking/issues/7658#issuecomment-926557096 @Hlenn Could you provide a project sample code that can reproduce this error? -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[skywalking-rocketbot-ui] branch master updated: feat: implement Alerts for query errors (#542)

This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-rocketbot-ui.git The following commit(s) were added to refs/heads/master by this push: new c49ea82 feat: implement Alert

[GitHub] [skywalking] wu-sheng closed issue #7711: [Feature] Make UI showing backend error

wu-sheng closed issue #7711: URL: https://github.com/apache/skywalking/issues/7711 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-u

[GitHub] [skywalking-rocketbot-ui] wu-sheng merged pull request #542: feat: implement Alerts for query errors

wu-sheng merged pull request #542: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/542 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #542: feat: implement Alerts for query errors

wu-sheng commented on pull request #542: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/542#issuecomment-926580178 Let's sync to main repo. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [skywalking] Fine0830 opened a new pull request #7797: Sync ui

Fine0830 opened a new pull request #7797: URL: https://github.com/apache/skywalking/pull/7797 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [x] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/CHANGES

[GitHub] [skywalking] wu-sheng merged pull request #7797: Sync ui

wu-sheng merged pull request #7797: URL: https://github.com/apache/skywalking/pull/7797 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificati

[skywalking] branch master updated: sync ui (#7797)

This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new 24aa9b1 sync ui (#7797) 24aa9b1 is describ

[skywalking-banyandb] branch stream-test created (now 48d72e8)

This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch stream-test in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git. at 48d72e8 Add more functions to support test This branch includes the following new commits:

[skywalking-banyandb] 01/01: Add more functions to support test

This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a commit to branch stream-test in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git commit 48d72e800cf69e9fef9357f01c15ba77163c4124 Author: Gao Hongtao AuthorDate: Fri Sep 24 21:17:56 2021 +

[skywalking] branch enhance/socketTimeout created (now b6007c4)

This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch enhance/socketTimeout in repository https://gitbox.apache.org/repos/asf/skywalking.git. at b6007c4 Add `socketTimeout` back to the new implementation This branch includes the followin

[skywalking] 01/01: Add `socketTimeout` back to the new implementation

This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a commit to branch enhance/socketTimeout in repository https://gitbox.apache.org/repos/asf/skywalking.git commit b6007c480963c1c7bcc2f3d6395624b38db3fb08 Author: kezhenxu94 AuthorDate: Fri Sep 24 16:03:15 2021

[GitHub] [skywalking-banyandb] hanahmily opened a new pull request #52: Add more functions to support test

hanahmily opened a new pull request #52: URL: https://github.com/apache/skywalking-banyandb/pull/52 These changes introduce some functions to support query module testing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[skywalking] branch enhance/socketTimeout updated (b6007c4 -> 2a2bbfd)

This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch enhance/socketTimeout in repository https://gitbox.apache.org/repos/asf/skywalking.git. discard b6007c4 Add `socketTimeout` back to the new implementation new 2a2bbfd Add `socketTimeo

[skywalking] 01/01: Add `socketTimeout` back to the new implementation

This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a commit to branch enhance/socketTimeout in repository https://gitbox.apache.org/repos/asf/skywalking.git commit 2a2bbfd035cc2bf03ffa25e19cce4a3f9228aa23 Author: kezhenxu94 AuthorDate: Fri Sep 24 16:03:15 2021

[GitHub] [skywalking-banyandb] hanahmily commented on a change in pull request #52: Add more functions to support test

hanahmily commented on a change in pull request #52: URL: https://github.com/apache/skywalking-banyandb/pull/52#discussion_r715609688 ## File path: banyand/stream/stream_query.go ## @@ -39,8 +41,12 @@ type Query interface { } type Stream interface { + io.Closer +

[GitHub] [skywalking] kezhenxu94 opened a new pull request #7798: Add `socketTimeout` back to the new implementation

kezhenxu94 opened a new pull request #7798: URL: https://github.com/apache/skywalking/pull/7798 Related to #7634 , which ignored the config `socketTimeout`, now I add it back. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[skywalking] branch enhance/socketTimeout updated (2a2bbfd -> 57e3ed4)

This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch enhance/socketTimeout in repository https://gitbox.apache.org/repos/asf/skywalking.git. discard 2a2bbfd Add `socketTimeout` back to the new implementation add fdbbd5a Move grouping do

[GitHub] [skywalking-banyandb] hanahmily commented on a change in pull request #52: Add more functions to support test

hanahmily commented on a change in pull request #52: URL: https://github.com/apache/skywalking-banyandb/pull/52#discussion_r715612594 ## File path: banyand/stream/stream_query.go ## @@ -39,8 +41,12 @@ type Query interface { } type Stream interface { + io.Closer +

[GitHub] [skywalking-banyandb] hanahmily commented on pull request #51: Move legacy implementations to v1 packages

hanahmily commented on pull request #51: URL: https://github.com/apache/skywalking-banyandb/pull/51#issuecomment-926625836 https://github.com/apache/skywalking-banyandb/pull/52 might fix test issues, would you sync it to check? -- This is an automated message from the Apache Git Service

[GitHub] [skywalking] wu-sheng commented on pull request #7798: Add `socketTimeout` back to the new implementation

wu-sheng commented on pull request #7798: URL: https://github.com/apache/skywalking/pull/7798#issuecomment-926637490 Please fix code style -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [skywalking-banyandb] hanahmily commented on pull request #52: Add more functions to support test

hanahmily commented on pull request #52: URL: https://github.com/apache/skywalking-banyandb/pull/52#issuecomment-926623248 @liuhaoyang Please take a look, do these changes support your need? -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[skywalking] branch enhance/socketTimeout updated (57e3ed4 -> 43f43e7)

This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch enhance/socketTimeout in repository https://gitbox.apache.org/repos/asf/skywalking.git. discard 57e3ed4 Add `socketTimeout` back to the new implementation add 43f43e7 Add `socketTimeo

[GitHub] [skywalking-banyandb] lujiajing1126 commented on pull request #52: Add more functions to support test

lujiajing1126 commented on pull request #52: URL: https://github.com/apache/skywalking-banyandb/pull/52#issuecomment-926654473 https://github.com/apache/skywalking-banyandb/blob/main/banyand/stream/service.go#L103 Seems issue with this line. I guess we have to setup `writeListener`

[GitHub] [skywalking-banyandb] lujiajing1126 commented on pull request #51: Move legacy implementations to v1 packages

lujiajing1126 commented on pull request #51: URL: https://github.com/apache/skywalking-banyandb/pull/51#issuecomment-926655802 > #52 might fix test issues, would you sync it to check? I would sync after merge -- This is an automated message from the Apache Git Service. To respond

[GitHub] [skywalking-swck] hanahmily commented on a change in pull request #33: Add java agent injector manual.

hanahmily commented on a change in pull request #33: URL: https://github.com/apache/skywalking-swck/pull/33#discussion_r715624082 ## File path: config/operator/configmap/configmap.yaml ## @@ -45,17 +45,16 @@ data: # The service name in UI Review comment: As we diss

[GitHub] [skywalking] wu-sheng merged pull request #7798: Add `socketTimeout` back to the new implementation

wu-sheng merged pull request #7798: URL: https://github.com/apache/skywalking/pull/7798 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificati

[skywalking] branch master updated: Add `socketTimeout` back to the new implementation (#7798)

This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new ad9d616 Add `socketTimeout` back to the ne

[skywalking-banyandb] branch stream-test updated (48d72e8 -> fce2f47)

This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch stream-test in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git. from 48d72e8 Add more functions to support test add fce2f47 Remove redundant line No new revi

[GitHub] [skywalking-banyandb] hanahmily commented on pull request #52: Add more functions to support test

hanahmily commented on pull request #52: URL: https://github.com/apache/skywalking-banyandb/pull/52#issuecomment-926689758 > https://github.com/apache/skywalking-banyandb/blob/main/banyand/stream/service.go#L103 > > Seems issue with this line. I guess we have to setup `writeListener

[skywalking-banyandb] branch main updated: Add more functions to support test (#52)

This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git The following commit(s) were added to refs/heads/main by this push: new 60f753b Add more functions to suppo

[GitHub] [skywalking-banyandb] hanahmily merged pull request #52: Add more functions to support test

hanahmily merged pull request #52: URL: https://github.com/apache/skywalking-banyandb/pull/52 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: noti

[GitHub] [skywalking] kezhenxu94 opened a new pull request #7799: Upgrade netty version to 4.1.68.Final avoid cve-2021-37136

kezhenxu94 opened a new pull request #7799: URL: https://github.com/apache/skywalking/pull/7799 - [x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [x] Update the [`CHANGES` log](https://github.com/apa

[skywalking] branch cve/netty created (now 577f230)

This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch cve/netty in repository https://gitbox.apache.org/repos/asf/skywalking.git. at 577f230 Upgrade netty version to 4.1.68.Final avoid cve-2021-37136 No new revisions were added by this u

[GitHub] [skywalking] kezhenxu94 commented on pull request #7799: Upgrade netty version to 4.1.68.Final to avoid cve-2021-37136

kezhenxu94 commented on pull request #7799: URL: https://github.com/apache/skywalking/pull/7799#issuecomment-926990728 Waiting for https://github.com/line/armeria/issues/3832 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [skywalking] wu-sheng commented on pull request #7799: Upgrade netty version to 4.1.68.Final to avoid cve-2021-37136

wu-sheng commented on pull request #7799: URL: https://github.com/apache/skywalking/pull/7799#issuecomment-926993048 Are they going to release shortly? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [skywalking-banyandb] lujiajing1126 commented on pull request #51: Move legacy implementations to v1 packages

lujiajing1126 commented on pull request #51: URL: https://github.com/apache/skywalking-banyandb/pull/51#issuecomment-926997978 @hanahmily Merge #52 . Now all tests have passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [skywalking-swck] dashanji commented on a change in pull request #33: Add java agent injector manual.

dashanji commented on a change in pull request #33: URL: https://github.com/apache/skywalking-swck/pull/33#discussion_r715978633 ## File path: config/operator/configmap/configmap.yaml ## @@ -45,17 +45,16 @@ data: # The service name in UI Review comment: ok ,

[GitHub] [skywalking-swck] dashanji commented on a change in pull request #33: Add java agent injector manual.

dashanji commented on a change in pull request #33: URL: https://github.com/apache/skywalking-swck/pull/33#discussion_r715978633 ## File path: config/operator/configmap/configmap.yaml ## @@ -45,17 +45,16 @@ data: # The service name in UI Review comment: > The c

[GitHub] [skywalking-swck] wu-sheng commented on pull request #33: Add java agent injector manual.

wu-sheng commented on pull request #33: URL: https://github.com/apache/skywalking-swck/pull/33#issuecomment-926998898 @hanahmily Is it better to add menu filr and reorganize this repo docs folder, in order to host docs on the website? More and more repositories have been using this mode.

[GitHub] [skywalking-swck] hanahmily commented on pull request #33: Add java agent injector manual.

hanahmily commented on pull request #33: URL: https://github.com/apache/skywalking-swck/pull/33#issuecomment-927003014 Noted with thanks, I am gonna add one On Sat, Sep 25, 2021 at 10:45 AM 吴晟 Wu Sheng ***@***.***> wrote: > @hanahmily Is it bet

[GitHub] [skywalking-java] wuguanyu commented on a change in pull request #36: fix NumberFormat exception in MysqlURLParser

wuguanyu commented on a change in pull request #36: URL: https://github.com/apache/skywalking-java/pull/36#discussion_r715985497 ## File path: apm-sniffer/apm-sdk-plugin/jdbc-commons/src/main/java/org/apache/skywalking/apm/plugin/jdbc/connectionurl/parser/MysqlURLParser.java #

[skywalking-banyandb] branch main updated: move legacy impl to v1 packages (#51)

This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git The following commit(s) were added to refs/heads/main by this push: new 06fa02d move legacy impl to v1 pack

[GitHub] [skywalking-banyandb] hanahmily merged pull request #51: Move legacy implementations to v1 packages

hanahmily merged pull request #51: URL: https://github.com/apache/skywalking-banyandb/pull/51 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: noti