[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #8004: Add a GraphQL query to get OAP version, display OAP version in startup message and error logs

2021-10-25 Thread GitBox
kezhenxu94 commented on a change in pull request #8004: URL: https://github.com/apache/skywalking/pull/8004#discussion_r736208085 ## File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/version/Version.java ## @@ -0,0 +1,57 @@ +/* + * Licensed

[GitHub] [skywalking] CalvinKirs commented on a change in pull request #8003: move the codes in apm-commons into server-library

2021-10-25 Thread GitBox
CalvinKirs commented on a change in pull request #8003: URL: https://github.com/apache/skywalking/pull/8003#discussion_r736206438 ## File path: changes/changes-8.4.0.md ## @@ -22,7 +22,7 @@ Release Notes. * Update `byte-buddy` to 1.10.19. * Fix thrift plugin trace link broken

[GitHub] [skywalking] wu-sheng commented on pull request #8004: Add a GraphQL query to get OAP version, display OAP version in startup message and error logs

2021-10-25 Thread GitBox
wu-sheng commented on pull request #8004: URL: https://github.com/apache/skywalking/pull/8004#issuecomment-951617155 > The version format is `projectVersion-gitSha (buildTime)` such as `8.9.0-abcdefg (202110261213)` For dev version, it would be `8.9.0-SNAPSHOT- (y)`, right?

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #8004: Add a GraphQL query to get OAP version, display OAP version in startup message and error logs

2021-10-25 Thread GitBox
kezhenxu94 commented on a change in pull request #8004: URL: https://github.com/apache/skywalking/pull/8004#discussion_r736206507 ## File path: oap-server/server-query-plugin/query-graphql-plugin/src/main/java/org/apache/skywalking/oap/query/graphql/resolver/Query.java ## @@ -

[GitHub] [skywalking] wu-sheng commented on a change in pull request #8004: Add a GraphQL query to get OAP version, display OAP version in startup message and error logs

2021-10-25 Thread GitBox
wu-sheng commented on a change in pull request #8004: URL: https://github.com/apache/skywalking/pull/8004#discussion_r736205734 ## File path: oap-server/server-query-plugin/query-graphql-plugin/src/main/java/org/apache/skywalking/oap/query/graphql/resolver/Query.java ## @@ -19

[GitHub] [skywalking] kezhenxu94 commented on pull request #8004: Add a GraphQL query to get OAP version, display OAP version in startup message and error logs

2021-10-25 Thread GitBox
kezhenxu94 commented on pull request #8004: URL: https://github.com/apache/skywalking/pull/8004#issuecomment-951616451 The version format is `projectVersion-gitSha (buildTime)` such as `8.9.0-abcdefg (202110261213)` -- This is an automated message from the Apache Git Service. To respond

[GitHub] [skywalking] wu-sheng commented on a change in pull request #8004: Add a GraphQL query to get OAP version, display OAP version in startup message and error logs

2021-10-25 Thread GitBox
wu-sheng commented on a change in pull request #8004: URL: https://github.com/apache/skywalking/pull/8004#discussion_r736204670 ## File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/version/Version.java ## @@ -0,0 +1,57 @@ +/* + * Licensed to

[GitHub] [skywalking] wu-sheng closed issue #8006: skywalking dashboard K8s

2021-10-25 Thread GitBox
wu-sheng closed issue #8006: URL: https://github.com/apache/skywalking/issues/8006 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-u

[GitHub] [skywalking] wu-sheng commented on a change in pull request #8003: move the codes in apm-commons into server-library

2021-10-25 Thread GitBox
wu-sheng commented on a change in pull request #8003: URL: https://github.com/apache/skywalking/pull/8003#discussion_r736195831 ## File path: changes/changes-8.4.0.md ## @@ -22,7 +22,7 @@ Release Notes. * Update `byte-buddy` to 1.10.19. * Fix thrift plugin trace link broken w

[GitHub] [skywalking] wu-sheng commented on a change in pull request #8005: Support JDK 16 and 17.

2021-10-25 Thread GitBox
wu-sheng commented on a change in pull request #8005: URL: https://github.com/apache/skywalking/pull/8005#discussion_r736194732 ## File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/meter/MeterSystem.java ## @@ -230,7 +234,11 @@ publ

[skywalking] branch jdk17 updated (4f8919c -> ef8a632)

2021-10-25 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch jdk17 in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 4f8919c Support JDK 16 and 17. add ef8a632 Fix. No new revisions were added by this update. Summary of c

[GitHub] [skywalking-infra-e2e] mrproliu commented on pull request #61: Fix trigger and `KinD` environment port export bug

2021-10-25 Thread GitBox
mrproliu commented on pull request #61: URL: https://github.com/apache/skywalking-infra-e2e/pull/61#issuecomment-951599532 > times for duration, not count. Currently, the `trigger.times` means the retry count before the trigger request success. The `trigger.interval` mean the durati

[GitHub] [skywalking] chenqinwei opened a new issue #8006: skywalking dashboard K8s

2021-10-25 Thread GitBox
chenqinwei opened a new issue #8006: URL: https://github.com/apache/skywalking/issues/8006 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement. ### Description

[GitHub] [skywalking-infra-e2e] wu-sheng commented on pull request #61: Fix trigger and `KinD` environment port export bug

2021-10-25 Thread GitBox
wu-sheng commented on pull request #61: URL: https://github.com/apache/skywalking-infra-e2e/pull/61#issuecomment-951573361 times for duration, not count. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [skywalking-infra-e2e] mrproliu commented on pull request #61: Fix trigger and `KinD` environment port export bug

2021-10-25 Thread GitBox
mrproliu commented on pull request #61: URL: https://github.com/apache/skywalking-infra-e2e/pull/61#issuecomment-951570024 > I think the changelog means it wouldn't stop after over retry times? Yes. The trigger could not be stopped when over the retry times. -- This is an automate

[GitHub] [skywalking-infra-e2e] mrproliu commented on pull request #61: Fix trigger and `KinD` environment port export bug

2021-10-25 Thread GitBox
mrproliu commented on pull request #61: URL: https://github.com/apache/skywalking-infra-e2e/pull/61#issuecomment-951569563 > > * Fix the trigger could not stop when reaching the `times` > > I think this is by design, the `times` actually means how many times to retry before (if succ

[GitHub] [skywalking-infra-e2e] wu-sheng commented on pull request #61: Fix trigger and `KinD` environment port export bug

2021-10-25 Thread GitBox
wu-sheng commented on pull request #61: URL: https://github.com/apache/skywalking-infra-e2e/pull/61#issuecomment-951566520 I think the changelog means it wouldn't stop after over retry times? -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [skywalking-infra-e2e] kezhenxu94 commented on pull request #61: Fix trigger and `KinD` environment port export bug

2021-10-25 Thread GitBox
kezhenxu94 commented on pull request #61: URL: https://github.com/apache/skywalking-infra-e2e/pull/61#issuecomment-951562937 > * Fix the trigger could not stop when reaching the `times` I think this is by design, the `times` actually means how many times to retry before (if succeed)

[GitHub] [skywalking-infra-e2e] mrproliu opened a new pull request #61: Fix trigger and `KinD` environment port export bug

2021-10-25 Thread GitBox
mrproliu opened a new pull request #61: URL: https://github.com/apache/skywalking-infra-e2e/pull/61 1. Fix the program cannot be closed when `KinD` environment has exported multiple ports 2. Fix the trigger could not stop when reaching the `times` 3. Fix HTTP trigger is closed the str

[GitHub] [skywalking] wu-sheng commented on a change in pull request #8005: Support JDK 16 and 17.

2021-10-25 Thread GitBox
wu-sheng commented on a change in pull request #8005: URL: https://github.com/apache/skywalking/pull/8005#discussion_r736136169 ## File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/meter/MeterSystem.java ## @@ -230,7 +234,11 @@ publ

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #8005: Support JDK 16 and 17.

2021-10-25 Thread GitBox
kezhenxu94 commented on a change in pull request #8005: URL: https://github.com/apache/skywalking/pull/8005#discussion_r736131597 ## File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/meter/MeterSystem.java ## @@ -230,7 +234,11 @@ pu

[GitHub] [skywalking] wu-sheng commented on a change in pull request #8005: Support JDK 16 and 17.

2021-10-25 Thread GitBox
wu-sheng commented on a change in pull request #8005: URL: https://github.com/apache/skywalking/pull/8005#discussion_r736131100 ## File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/meter/MeterSystem.java ## @@ -230,7 +234,11 @@ publ

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #8005: Support JDK 16 and 17.

2021-10-25 Thread GitBox
kezhenxu94 commented on a change in pull request #8005: URL: https://github.com/apache/skywalking/pull/8005#discussion_r736130036 ## File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/meter/MeterSystem.java ## @@ -230,7 +234,11 @@ pu

[GitHub] [skywalking] wu-sheng commented on issue #7943: [Feature] Add OpenJDK 17 (LTS) test for backend server runtime

2021-10-25 Thread GitBox
wu-sheng commented on issue #7943: URL: https://github.com/apache/skywalking/issues/7943#issuecomment-951534926 As adoptopenjdk has moved into Eclipse foundation, the latest image including 17 has been hosted https://hub.docker.com/_/eclipse-temurin?tab=tags&page=1&name=17 -- This is an

[GitHub] [skywalking] wu-sheng opened a new pull request #8005: Support JDK 16 and 17.

2021-10-25 Thread GitBox
wu-sheng opened a new pull request #8005: URL: https://github.com/apache/skywalking/pull/8005 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [x] Update the [`CHANGES` log](https://github.com/apach

[skywalking] 01/01: Support JDK 16 and 17.

2021-10-25 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch jdk17 in repository https://gitbox.apache.org/repos/asf/skywalking.git commit 4f8919c5c5324343358a4621eff2444de1a193b8 Author: Wu Sheng AuthorDate: Tue Oct 26 11:45:21 2021 +0800 Support JD

[skywalking] branch jdk17 created (now 4f8919c)

2021-10-25 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch jdk17 in repository https://gitbox.apache.org/repos/asf/skywalking.git. at 4f8919c Support JDK 16 and 17. This branch includes the following new commits: new 4f8919c Support JDK 1

[GitHub] [skywalking] kezhenxu94 opened a new pull request #8004: Add a GraphQL query to get OAP version, display OAP version in startup message and error logs

2021-10-25 Thread GitBox
kezhenxu94 opened a new pull request #8004: URL: https://github.com/apache/skywalking/pull/8004 - [x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Related to #7931 (UI part is left to @Fine0830 ). - [x] Up

[GitHub] [skywalking] CalvinKirs commented on a change in pull request #7985: [WIP]Add MicroBench module to make it easier for developers to write JMH Test

2021-10-25 Thread GitBox
CalvinKirs commented on a change in pull request #7985: URL: https://github.com/apache/skywalking/pull/7985#discussion_r736097364 ## File path: apm-commons/apm-datacarrier/src/test/java/org/apache/skywalking/apm/commons/datacarrier/LinkedArrayBenchmark.java ## @@ -35,7 +37,7 @

[GitHub] [skywalking] CalvinKirs opened a new pull request #8003: move the codes in apm-commons into server-library

2021-10-25 Thread GitBox
CalvinKirs opened a new pull request #8003: URL: https://github.com/apache/skywalking/pull/8003 move the codes in apm-commons into server-library -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [skywalking] wu-sheng removed a comment on issue #7943: [Feature] Add OpenJDK 17 (LTS) test for backend server runtime

2021-10-25 Thread GitBox
wu-sheng removed a comment on issue #7943: URL: https://github.com/apache/skywalking/issues/7943#issuecomment-944888796 After plugin test tool container and a new plugin(JDK17 compiling and runtime), this doc should be updated, https://skywalking.apache.org/docs/skywalking-java/latest/en/s

[GitHub] [skywalking-banyandb-java-client] lujiajing1126 opened a new pull request #3: Feat: new stream api

2021-10-25 Thread GitBox
lujiajing1126 opened a new pull request #3: URL: https://github.com/apache/skywalking-banyandb-java-client/pull/3 This PR introduces the new stream API which has been merge thru https://github.com/apache/skywalking-banyandb/pull/49. This intends to replace the legacy trace API. --

[GitHub] [skywalking] kwanhur opened a new issue #8002: [INFRA/EYE] Support to show differences between file's header and license-eye's pattern content

2021-10-25 Thread GitBox
kwanhur opened a new issue #8002: URL: https://github.com/apache/skywalking/issues/8002 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement. ### Description

[skywalking] branch master updated: Replace e2e cases to e2e-v2: Client-JS (#7999)

2021-10-25 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new 3470f7f Replace e2e cases to e2e-v2: Clien

[GitHub] [skywalking] wu-sheng merged pull request #7999: Replace e2e cases to e2e-v2: Client-JS

2021-10-25 Thread GitBox
wu-sheng merged pull request #7999: URL: https://github.com/apache/skywalking/pull/7999 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificati

[GitHub] [skywalking] wu-sheng commented on a change in pull request #7985: [WIP]Add MicroBench module to make it easier for developers to write JMH Test

2021-10-25 Thread GitBox
wu-sheng commented on a change in pull request #7985: URL: https://github.com/apache/skywalking/pull/7985#discussion_r735721333 ## File path: apm-commons/apm-datacarrier/src/test/java/org/apache/skywalking/apm/commons/datacarrier/LinkedArrayBenchmark.java ## @@ -35,7 +37,7 @@

[GitHub] [skywalking] wu-sheng opened a new issue #8001: [Bug] Netty socketio CI failing

2021-10-25 Thread GitBox
wu-sheng opened a new issue #8001: URL: https://github.com/apache/skywalking/issues/8001 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar issues. ### Apache SkyWalking Component

[GitHub] [skywalking] CalvinKirs commented on a change in pull request #7985: [WIP]Add MicroBench module to make it easier for developers to write JMH Test

2021-10-25 Thread GitBox
CalvinKirs commented on a change in pull request #7985: URL: https://github.com/apache/skywalking/pull/7985#discussion_r735692830 ## File path: apm-commons/apm-datacarrier/src/test/java/org/apache/skywalking/apm/commons/datacarrier/LinkedArrayBenchmark.java ## @@ -35,7 +37,7 @

[GitHub] [skywalking] wu-sheng merged pull request #8000: Fix unexpected deleting due to TTL mechanism bug

2021-10-25 Thread GitBox
wu-sheng merged pull request #8000: URL: https://github.com/apache/skywalking/pull/8000 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificati

[skywalking] branch master updated: Fix unexpected deleting due to TTL mechanism bug (#8000)

2021-10-25 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new a68503b Fix unexpected deleting due to TTL

[GitHub] [skywalking] CalvinKirs commented on pull request #7985: [WIP]Add MicroBench module to make it easier for developers to write JMH Test

2021-10-25 Thread GitBox
CalvinKirs commented on pull request #7985: URL: https://github.com/apache/skywalking/pull/7985#issuecomment-951008124 > `oap-server` is already almost the top besides the legacy protocol module. > > `server-testing` includes class for backend modularization core only. Is there somet

[GitHub] [skywalking] wu-sheng commented on pull request #7985: [WIP]Add MicroBench module to make it easier for developers to write JMH Test

2021-10-25 Thread GitBox
wu-sheng commented on pull request #7985: URL: https://github.com/apache/skywalking/pull/7985#issuecomment-951003223 `oap-server` is already almost the top besides the legacy protocol module. `server-testing` includes class for backend modularization core only. Is there something yo

[GitHub] [skywalking-java] wu-sheng merged pull request #49: Add okhttp2.x plugin

2021-10-25 Thread GitBox
wu-sheng merged pull request #49: URL: https://github.com/apache/skywalking-java/pull/49 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificat

[skywalking-java] branch main updated: Add okhttp2.x plugin (#49)

2021-10-25 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/skywalking-java.git The following commit(s) were added to refs/heads/main by this push: new 9101f69 Add okhttp2.x plugin (#49) 9101f6

[GitHub] [skywalking-java] wu-sheng commented on pull request #49: Add okhttp2.x plugin

2021-10-25 Thread GitBox
wu-sheng commented on pull request #49: URL: https://github.com/apache/skywalking-java/pull/49#issuecomment-950995234 > i do not change that plugin== I know you didn't change that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [skywalking-java] xu1009 commented on pull request #49: Add okhttp2.x plugin

2021-10-25 Thread GitBox
xu1009 commented on pull request #49: URL: https://github.com/apache/skywalking-java/pull/49#issuecomment-950994623 the master branch failed too -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [skywalking] CalvinKirs edited a comment on pull request #7985: [WIP]Add MicroBench module to make it easier for developers to write JMH Test

2021-10-25 Thread GitBox
CalvinKirs edited a comment on pull request #7985: URL: https://github.com/apache/skywalking/pull/7985#issuecomment-950987510 > > Moving the benchmark classes into another separate module makes me feeling super strange. Could you explain why? This module could be excluded(in default) from

[GitHub] [skywalking] CalvinKirs commented on pull request #7985: [WIP]Add MicroBench module to make it easier for developers to write JMH Test

2021-10-25 Thread GitBox
CalvinKirs commented on pull request #7985: URL: https://github.com/apache/skywalking/pull/7985#issuecomment-950987510 > > Moving the benchmark classes into another separate module makes me feeling super strange. Could you explain why? This module could be excluded(in default) from dist bi

[GitHub] [skywalking-java] xu1009 commented on pull request #49: Add okhttp2.x plugin

2021-10-25 Thread GitBox
xu1009 commented on pull request #49: URL: https://github.com/apache/skywalking-java/pull/49#issuecomment-950981059 i will try the master branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [skywalking-java] xu1009 commented on pull request #49: Add okhttp2.x plugin

2021-10-25 Thread GitBox
xu1009 commented on pull request #49: URL: https://github.com/apache/skywalking-java/pull/49#issuecomment-950975063 i do not change that plugin== -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [skywalking-java] wu-sheng commented on pull request #49: Add okhttp2.x plugin

2021-10-25 Thread GitBox
wu-sheng commented on pull request #49: URL: https://github.com/apache/skywalking-java/pull/49#issuecomment-950962555 Strange, that plugin can't pass even I have tried many times. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [skywalking] wu-sheng opened a new pull request #8000: Fix unexpected deleting due to TTL mechanism bug

2021-10-25 Thread GitBox
wu-sheng opened a new pull request #8000: URL: https://github.com/apache/skywalking/pull/8000 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [x] Update the [`CHANGES` log](https://github.com/apach

[skywalking] branch ttl-bug created (now 29fd189)

2021-10-25 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch ttl-bug in repository https://gitbox.apache.org/repos/asf/skywalking.git. at 29fd189 Fix unexpected deleting due to TTL mechanism bug This branch includes the following new commits:

[skywalking] 01/01: Fix unexpected deleting due to TTL mechanism bug

2021-10-25 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch ttl-bug in repository https://gitbox.apache.org/repos/asf/skywalking.git commit 29fd1895e4e6beecd3f0579b024983fe7585e0fd Author: Wu Sheng AuthorDate: Mon Oct 25 21:53:20 2021 +0800 Fix unex

[GitHub] [skywalking] sonatype-lift[bot] commented on a change in pull request #7999: Replace e2e cases to e2e-v2: Client-JS

2021-10-25 Thread GitBox
sonatype-lift[bot] commented on a change in pull request #7999: URL: https://github.com/apache/skywalking/pull/7999#discussion_r735618977 ## File path: test/e2e-v2/cases/browser/docker/index.js ## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [skywalking-java] wu-sheng removed a comment on pull request #49: Add okhttp2.x plugin

2021-10-25 Thread GitBox
wu-sheng removed a comment on pull request #49: URL: https://github.com/apache/skywalking-java/pull/49#issuecomment-950926122 It seems netty-io case keeps failing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [skywalking-infra-e2e] mrproliu removed a comment on pull request #59: Support create kind cluster from local `kind` command

2021-10-25 Thread GitBox
mrproliu removed a comment on pull request #59: URL: https://github.com/apache/skywalking-infra-e2e/pull/59#issuecomment-950929140 kjk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [skywalking-infra-e2e] mrproliu commented on pull request #59: Support create kind cluster from local `kind` command

2021-10-25 Thread GitBox
mrproliu commented on pull request #59: URL: https://github.com/apache/skywalking-infra-e2e/pull/59#issuecomment-950929140 kjk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [skywalking-infra-e2e] mrproliu closed pull request #59: Support create kind cluster from local `kind` command

2021-10-25 Thread GitBox
mrproliu closed pull request #59: URL: https://github.com/apache/skywalking-infra-e2e/pull/59 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: noti

[GitHub] [skywalking-infra-e2e] kezhenxu94 merged pull request #60: Migrate timeout config to Duration style and wait for node ready in KinD setup

2021-10-25 Thread GitBox
kezhenxu94 merged pull request #60: URL: https://github.com/apache/skywalking-infra-e2e/pull/60 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: no

[skywalking-infra-e2e] branch main updated: Migrate timeout config to Duration style and wait for node ready in KinD setup (#60)

2021-10-25 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/skywalking-infra-e2e.git The following commit(s) were added to refs/heads/main by this push: new 7f03637 Migrate timeout config to

[GitHub] [skywalking-java] wu-sheng commented on pull request #49: Add okhttp2.x plugin

2021-10-25 Thread GitBox
wu-sheng commented on pull request #49: URL: https://github.com/apache/skywalking-java/pull/49#issuecomment-950926122 It seems netty-io case keeps failing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [skywalking-infra-e2e] mrproliu commented on pull request #60: Migrate timeout config to Duration style and wait for node ready in KinD setup

2021-10-25 Thread GitBox
mrproliu commented on pull request #60: URL: https://github.com/apache/skywalking-infra-e2e/pull/60#issuecomment-950921225 > @mrproliu another problem is the kind version, I've also upgraded the kind version in this PR, please check https://github.com/kezhenxu94/skywalking/runs/3996739384

[GitHub] [skywalking-rocketbot-ui] Fine0830 merged pull request #556: feat: query task logs with task ID for viewing task details

2021-10-25 Thread GitBox
Fine0830 merged pull request #556: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/556 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[skywalking-rocketbot-ui] branch master updated: feat: query task logs with task ID for viewing task details (#556)

2021-10-25 Thread qiuxiafan
This is an automated email from the ASF dual-hosted git repository. qiuxiafan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-rocketbot-ui.git The following commit(s) were added to refs/heads/master by this push: new c766ad5 feat: query task lo

[GitHub] [skywalking-rocketbot-ui] Fine0830 opened a new pull request #556: feat: query task logs with task ID for viewing task details

2021-10-25 Thread GitBox
Fine0830 opened a new pull request #556: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/556 Query task logs with task ID for viewing task details. Screenshot ![1](https://user-images.githubusercontent.com/20871783/138699443-ad6e34a1-1d80-484d-a22c-cb841288a2b6.png)

[GitHub] [skywalking-infra-e2e] kezhenxu94 commented on pull request #60: Migrate timeout config to Duration style and wait for node ready in KinD setup

2021-10-25 Thread GitBox
kezhenxu94 commented on pull request #60: URL: https://github.com/apache/skywalking-infra-e2e/pull/60#issuecomment-950882586 @mrproliu another problem is the kind version, I've also upgraded the kind version in this PR, please check https://github.com/kezhenxu94/skywalking/runs/3996739384

[GitHub] [skywalking-java] xu1009 commented on pull request #49: Add okhttp2.x plugin

2021-10-25 Thread GitBox
xu1009 commented on pull request #49: URL: https://github.com/apache/skywalking-java/pull/49#issuecomment-950867186 yes, i find the problem, fix it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[skywalking-infra-e2e] branch bugfix/kind/ready updated (298936e -> 32446f0)

2021-10-25 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch bugfix/kind/ready in repository https://gitbox.apache.org/repos/asf/skywalking-infra-e2e.git. discard 298936e Migrate timeout config to Duration style and wait for node ready in KinD setup

[GitHub] [skywalking-java] wu-sheng commented on pull request #49: Add okhttp2.x plugin

2021-10-25 Thread GitBox
wu-sheng commented on pull request #49: URL: https://github.com/apache/skywalking-java/pull/49#issuecomment-950861408 > the failed ci task is not my change I rerun those. But it seems you missed some UTs? -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [skywalking] arugal opened a new pull request #7999: Replace e2e cases to e2e-v2: Client-JS

2021-10-25 Thread GitBox
arugal opened a new pull request #7999: URL: https://github.com/apache/skywalking/pull/7999 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [x] Update the [`CHANGES` log](https://github.com/apache/

[GitHub] [skywalking-java] xu1009 commented on pull request #49: Add okhttp2.x plugin

2021-10-25 Thread GitBox
xu1009 commented on pull request #49: URL: https://github.com/apache/skywalking-java/pull/49#issuecomment-950854696 the failed ci task is not my change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [skywalking-java] xu1009 commented on pull request #49: Add okhttp2.x plugin

2021-10-25 Thread GitBox
xu1009 commented on pull request #49: URL: https://github.com/apache/skywalking-java/pull/49#issuecomment-950830901 ok, okhttp4.x use kt, it looks internal method name is diff in running time -- This is an automated message from the Apache Git Service. To respond to the message, please l

[skywalking-infra-e2e] branch bugfix/kind/ready updated (335947e -> 298936e)

2021-10-25 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch bugfix/kind/ready in repository https://gitbox.apache.org/repos/asf/skywalking-infra-e2e.git. discard 335947e Migrate timeout config to Duration style and wait for node ready in KinD setup

[GitHub] [skywalking-java] wu-sheng commented on pull request #49: Add okhttp2.x plugin

2021-10-25 Thread GitBox
wu-sheng commented on pull request #49: URL: https://github.com/apache/skywalking-java/pull/49#issuecomment-950814038 Please fix CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [skywalking-infra-e2e] wu-sheng commented on pull request #60: Migrate timeout config to Duration style and wait for node ready in KinD setup

2021-10-25 Thread GitBox
wu-sheng commented on pull request #60: URL: https://github.com/apache/skywalking-infra-e2e/pull/60#issuecomment-950813698 Seems some CI failure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [skywalking-infra-e2e] kezhenxu94 commented on pull request #60: Migrate timeout config to Duration style and wait for node ready in KinD setup

2021-10-25 Thread GitBox
kezhenxu94 commented on pull request #60: URL: https://github.com/apache/skywalking-infra-e2e/pull/60#issuecomment-950808401 @mrproliu can you please verify? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[skywalking-infra-e2e] branch bugfix/kind/ready updated (3dbe47f -> 335947e)

2021-10-25 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch bugfix/kind/ready in repository https://gitbox.apache.org/repos/asf/skywalking-infra-e2e.git. omit 3dbe47f Migrate timeout config to Duration style and wait for node ready in KinD setup

[GitHub] [skywalking-infra-e2e] kezhenxu94 commented on pull request #59: Support create kind cluster from local `kind` command

2021-10-25 Thread GitBox
kezhenxu94 commented on pull request #59: URL: https://github.com/apache/skywalking-infra-e2e/pull/59#issuecomment-950806650 And this https://github.com/apache/skywalking-infra-e2e/pull/60 -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking-infra-e2e] kezhenxu94 commented on pull request #59: Support create kind cluster from local `kind` command

2021-10-25 Thread GitBox
kezhenxu94 commented on pull request #59: URL: https://github.com/apache/skywalking-infra-e2e/pull/59#issuecomment-950805641 Turns out to be the cluster is not ready when applying resources. Check this https://github.com/kezhenxu94/skywalking/runs/3995203614?check_suite_focus=true -- Th

[GitHub] [skywalking-infra-e2e] kezhenxu94 opened a new pull request #60: Migrate timeout config to Duration style and wait for node ready in KinD setup

2021-10-25 Thread GitBox
kezhenxu94 opened a new pull request #60: URL: https://github.com/apache/skywalking-infra-e2e/pull/60 KinD setup doesn't wait for nodes to be ready, causing subsequent resources cannot be applied successfully. -- This is an automated message from the Apache Git Service. To respond to the

[skywalking-infra-e2e] 01/01: Migrate timeout config to Duration style and wait for node ready in KinD setup

2021-10-25 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a commit to branch bugfix/kind/ready in repository https://gitbox.apache.org/repos/asf/skywalking-infra-e2e.git commit 3dbe47f3c00e607d35bf513161dcf9b28c7605e5 Author: kezhenxu94 AuthorDate: Mon Oct 25 17:16:46

[skywalking-infra-e2e] branch bugfix/kind/ready updated (31aa9e9 -> 3dbe47f)

2021-10-25 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch bugfix/kind/ready in repository https://gitbox.apache.org/repos/asf/skywalking-infra-e2e.git. discard 31aa9e9 Migrate timeout config to Duration style and wait for node ready in KinD setup

[skywalking-infra-e2e] branch bugfix/kind/ready created (now 31aa9e9)

2021-10-25 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch bugfix/kind/ready in repository https://gitbox.apache.org/repos/asf/skywalking-infra-e2e.git. at 31aa9e9 Migrate timeout config to Duration style and wait for node ready in KinD setup

[skywalking-infra-e2e] 01/01: Migrate timeout config to Duration style and wait for node ready in KinD setup

2021-10-25 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a commit to branch bugfix/kind/ready in repository https://gitbox.apache.org/repos/asf/skywalking-infra-e2e.git commit 31aa9e974d61846612fa47f9896d456d53279d75 Author: kezhenxu94 AuthorDate: Mon Oct 25 17:16:46

[GitHub] [skywalking-java] xu1009 commented on a change in pull request #49: Add okhttp2.x plugin

2021-10-25 Thread GitBox
xu1009 commented on a change in pull request #49: URL: https://github.com/apache/skywalking-java/pull/49#discussion_r735409037 ## File path: CHANGES.md ## @@ -37,6 +37,7 @@ Release Notes. * Fix version compatibility for JsonRPC4J plugin. * Add plugin to support Apache Kylin-j

[GitHub] [skywalking-java] wu-sheng commented on a change in pull request #49: Add okhttp2.x plugin

2021-10-25 Thread GitBox
wu-sheng commented on a change in pull request #49: URL: https://github.com/apache/skywalking-java/pull/49#discussion_r735407097 ## File path: CHANGES.md ## @@ -37,6 +37,7 @@ Release Notes. * Fix version compatibility for JsonRPC4J plugin. * Add plugin to support Apache Kylin

[GitHub] [skywalking] wu-sheng commented on issue #7997: [Bug] Inaccurate data

2021-10-25 Thread GitBox
wu-sheng commented on issue #7997: URL: https://github.com/apache/skywalking/issues/7997#issuecomment-950697882 Again, these are not the same thing. The IP node(19200) should be the upstream of your service, not downstream. Please read the data more clearly. SkyWalking never generate downs

[GitHub] [skywalking] erdengzhazha edited a comment on issue #7997: [Bug] Inaccurate data

2021-10-25 Thread GitBox
erdengzhazha edited a comment on issue #7997: URL: https://github.com/apache/skywalking/issues/7997#issuecomment-950695647 The first picture is zero ![image](https://user-images.githubusercontent.com/43720808/138667164-67c811cf-2e4f-4ca2-8315-0ff1c7542d43.png) ![image](https://us

[GitHub] [skywalking] erdengzhazha commented on issue #7997: [Bug] Inaccurate data

2021-10-25 Thread GitBox
erdengzhazha commented on issue #7997: URL: https://github.com/apache/skywalking/issues/7997#issuecomment-950695647 Zero on the picture ![image](https://user-images.githubusercontent.com/43720808/138667164-67c811cf-2e4f-4ca2-8315-0ff1c7542d43.png) ![image](https://user-images.git

[GitHub] [skywalking] wu-sheng commented on issue #7997: [Bug] Inaccurate data

2021-10-25 Thread GitBox
wu-sheng commented on issue #7997: URL: https://github.com/apache/skywalking/issues/7997#issuecomment-950686775 I am not sure what is the relationship between 2 graphs. 1. Segments are traces 2. The node on the lines is for out bound traffic. And it shows CPM(calls per minute). It isn

[GitHub] [skywalking] wu-sheng closed issue #7997: [Bug] Inaccurate data

2021-10-25 Thread GitBox
wu-sheng closed issue #7997: URL: https://github.com/apache/skywalking/issues/7997 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-u

[GitHub] [skywalking] erdengzhazha opened a new issue #7997: [Bug] Inaccurate data

2021-10-25 Thread GitBox
erdengzhazha opened a new issue #7997: URL: https://github.com/apache/skywalking/issues/7997 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar issues. ### Apache SkyWalking Componen

[GitHub] [skywalking-infra-e2e] wu-sheng commented on pull request #59: Support create kind cluster from local `kind` command

2021-10-25 Thread GitBox
wu-sheng commented on pull request #59: URL: https://github.com/apache/skywalking-infra-e2e/pull/59#issuecomment-950628891 I agree. We should not switch to local command system which reply on user's local setup or GHA setup. In-built KinD should be recommended only. It is better to locate

[GitHub] [skywalking-infra-e2e] kezhenxu94 commented on pull request #59: Support create kind cluster from local `kind` command

2021-10-25 Thread GitBox
kezhenxu94 commented on pull request #59: URL: https://github.com/apache/skywalking-infra-e2e/pull/59#issuecomment-950624607 > > > * When I tried to add the Istio E2E test to the main repo, I found we could not use the `build-in` kind to build the Kubernetes cluster, need to use the `kind

[GitHub] [skywalking-infra-e2e] wu-sheng commented on a change in pull request #59: Support create kind cluster from local `kind` command

2021-10-25 Thread GitBox
wu-sheng commented on a change in pull request #59: URL: https://github.com/apache/skywalking-infra-e2e/pull/59#discussion_r735335073 ## File path: internal/components/setup/kind.go ## @@ -140,23 +141,42 @@ func KindShouldWaitSignal() bool { // KindCleanNotify notify when cle

[GitHub] [skywalking-infra-e2e] mrproliu commented on pull request #59: Support create kind cluster from local `kind` command

2021-10-25 Thread GitBox
mrproliu commented on pull request #59: URL: https://github.com/apache/skywalking-infra-e2e/pull/59#issuecomment-950608259 > > * When I tried to add the Istio E2E test to the main repo, I found we could not use the `build-in` kind to build the Kubernetes cluster, need to use the `kind` co

[GitHub] [skywalking-infra-e2e] kezhenxu94 commented on pull request #59: Support create kind cluster from local `kind` command

2021-10-25 Thread GitBox
kezhenxu94 commented on pull request #59: URL: https://github.com/apache/skywalking-infra-e2e/pull/59#issuecomment-950599450 > * When I tried to add the Istio E2E test to the main repo, I found we could not use the `build-in` kind to build the Kubernetes cluster, need to use the `kind` co

[GitHub] [skywalking-infra-e2e] mrproliu opened a new pull request #59: Support create kind cluster from local `kind` command

2021-10-25 Thread GitBox
mrproliu opened a new pull request #59: URL: https://github.com/apache/skywalking-infra-e2e/pull/59 1. When I tried to add the Istio E2E test to the main repo, I found we could not use the `build-in` kind to build the Kubernetes cluster, need to use the `kind` command line from the host.