[GitHub] [skywalking-satellite] mrproliu commented on a change in pull request #90: Add documentation for help user deploy the Satellite as Gateway

2021-11-30 Thread GitBox
mrproliu commented on a change in pull request #90: URL: https://github.com/apache/skywalking-satellite/pull/90#discussion_r759932715 ## File path: docs/en/setup/examples/deploy/kubernetes/README.md ## @@ -0,0 +1,28 @@ +# Kubernetes Deploy + +It could help you run the

[GitHub] [skywalking] chanjarster commented on issue #8221: [Bug] ProfileTaskChannelService.snapshotQueue full then Notify profile task finish to backend fail

2021-11-30 Thread GitBox
chanjarster commented on issue #8221: URL: https://github.com/apache/skywalking/issues/8221#issuecomment-983372576 @mrproliu thanks. So let me summarize: * queue size `50` with `10ms` dump interval = max `500ms` window size * and Java Agent drain the queue every `500ms`

[GitHub] [skywalking-java] wallezhang opened a new pull request #76: feat: Support version 2.8.0+ of pulsar client

2021-11-30 Thread GitBox
wallezhang opened a new pull request #76: URL: https://github.com/apache/skywalking-java/pull/76 ### Fix - [x] Add a unit test to verify that the fix works. - [x] Explain briefly why the bug exists and how to fix it. The pulsar client has changed the generator of the

[GitHub] [skywalking] wu-sheng commented on issue #8221: [Bug] ProfileTaskChannelService.snapshotQueue full then Notify profile task finish to backend fail

2021-11-30 Thread GitBox
wu-sheng commented on issue #8221: URL: https://github.com/apache/skywalking/issues/8221#issuecomment-983371668 OK then, what is recommended value? We could change to it accordingly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [skywalking] mrproliu edited a comment on issue #8221: [Bug] ProfileTaskChannelService.snapshotQueue full then Notify profile task finish to backend fail

2021-11-30 Thread GitBox
mrproliu edited a comment on issue #8221: URL: https://github.com/apache/skywalking/issues/8221#issuecomment-983359354 This depends on the Profile Task configuration at the time. It may happen if the number of threads to be monitored is large and the monitoring time is short. The Java

[GitHub] [skywalking] mrproliu commented on issue #8221: [Bug] ProfileTaskChannelService.snapshotQueue full then Notify profile task finish to backend fail

2021-11-30 Thread GitBox
mrproliu commented on issue #8221: URL: https://github.com/apache/skywalking/issues/8221#issuecomment-983359354 This depends on the Profile Task configuration at the time. It may happen if the number of threads to be monitored is large and the monitoring time is short. The Java Agent

[GitHub] [skywalking] wu-sheng commented on issue #8221: [Bug] ProfileTaskChannelService.snapshotQueue full then Notify profile task finish to backend fail

2021-11-30 Thread GitBox
wu-sheng commented on issue #8221: URL: https://github.com/apache/skywalking/issues/8221#issuecomment-983342170 @mrproliu Could you take a look about this? Personally, I think currently 50 seems not a big issue, unless OAP server or network performance is low. -- This is an automated

[GitHub] [skywalking] chanjarster opened a new issue #8221: [Bug] ProfileTaskChannelService.snapshotQueue full then Notify profile task finish to backend fail

2021-11-30 Thread GitBox
chanjarster opened a new issue #8221: URL: https://github.com/apache/skywalking/issues/8221 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar issues. ### Apache SkyWalking

[GitHub] [skywalking-satellite] wu-sheng commented on a change in pull request #90: Add documentation for help user deploy the Satellite as Gateway

2021-11-30 Thread GitBox
wu-sheng commented on a change in pull request #90: URL: https://github.com/apache/skywalking-satellite/pull/90#discussion_r759830787 ## File path: docs/en/setup/README.md ## @@ -19,10 +19,15 @@ bin/startup.sh ## Examples You can quickly build your satellite according to

[GitHub] [skywalking-satellite] mrproliu opened a new pull request #90: Add documentation for help user deploy the Satellite as Gateway

2021-11-30 Thread GitBox
mrproliu opened a new pull request #90: URL: https://github.com/apache/skywalking-satellite/pull/90 Follow https://github.com/apache/skywalking/issues/8185 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [skywalking] wu-sheng commented on issue #2145: dubbo 使用hessian协议,在UI拓扑图中不会形成调用链

2021-11-30 Thread GitBox
wu-sheng commented on issue #2145: URL: https://github.com/apache/skywalking/issues/2145#issuecomment-983255086 > It's dubbo bug, I make a PATCH, using skywalking plugin enhance to fix the bug. > > https://github.com/nileblack/dubbo25-hessian-patch Thank you so much to

[GitHub] [skywalking] nileblack edited a comment on issue #2145: dubbo 使用hessian协议,在UI拓扑图中不会形成调用链

2021-11-30 Thread GitBox
nileblack edited a comment on issue #2145: URL: https://github.com/apache/skywalking/issues/2145#issuecomment-983250290 It's dubbo bug, I make a PATCH, using skywalking plugin enhance to fix the bug. https://github.com/nileblack/dubbo25-hessian-patch -- This is an automated message

[GitHub] [skywalking] nileblack commented on issue #2145: dubbo 使用hessian协议,在UI拓扑图中不会形成调用链

2021-11-30 Thread GitBox
nileblack commented on issue #2145: URL: https://github.com/apache/skywalking/issues/2145#issuecomment-983250290 It's dubbo bug, here is a PATCH, use skywalking plugin enhance to fix the bug. https://github.com/nileblack/dubbo25-hessian-patch -- This is an automated message from the

[skywalking] branch wu-sheng-patch-1 created (now a24bc4d)

2021-11-30 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch wu-sheng-patch-1 in repository https://gitbox.apache.org/repos/asf/skywalking.git. at a24bc4d Adjust go2sky version. No new revisions were added by this update.

[GitHub] [skywalking] wu-sheng closed pull request #8219: Adjust go2sky version.

2021-11-30 Thread GitBox
wu-sheng closed pull request #8219: URL: https://github.com/apache/skywalking/pull/8219 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [skywalking] wu-sheng opened a new pull request #8219: Adjust go2sky version.

2021-11-30 Thread GitBox
wu-sheng opened a new pull request #8219: URL: https://github.com/apache/skywalking/pull/8219 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [ ] Update the [`CHANGES`

[GitHub] [skywalking] wu-sheng merged pull request #8218: Fix a wrong check about entity if GraphQL at endpoint relation level.

2021-11-30 Thread GitBox
wu-sheng merged pull request #8218: URL: https://github.com/apache/skywalking/pull/8218 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[skywalking] branch master updated: Fix a wrong check about entity if GraphQL at the endpoint relation level. (#8218)

2021-11-30 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new df75eb7 Fix a wrong check about entity if

[GitHub] [skywalking] wu-sheng commented on pull request #8215: Support disables the verification of server's TLS certificate chain for specific hosts

2021-11-30 Thread GitBox
wu-sheng commented on pull request #8215: URL: https://github.com/apache/skywalking/pull/8215#issuecomment-983195283 > > No TLS verification should be fine, but don't need through us, actually. They could put a Nginx/Envoy in the front of ElasticSearch server, then OAP server could access

[GitHub] [skywalking] JaredTan95 closed pull request #8215: Support disables the verification of server's TLS certificate chain for specific hosts

2021-11-30 Thread GitBox
JaredTan95 closed pull request #8215: URL: https://github.com/apache/skywalking/pull/8215 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [skywalking] JaredTan95 edited a comment on pull request #8215: Support disables the verification of server's TLS certificate chain for specific hosts

2021-11-30 Thread GitBox
JaredTan95 edited a comment on pull request #8215: URL: https://github.com/apache/skywalking/pull/8215#issuecomment-983192410 > No TLS verification should be fine, but don't need through us, actually. They could put a Nginx/Envoy in the front of ElasticSearch server, then OAP server could

[GitHub] [skywalking] JaredTan95 commented on pull request #8215: Support disables the verification of server's TLS certificate chain for specific hosts

2021-11-30 Thread GitBox
JaredTan95 commented on pull request #8215: URL: https://github.com/apache/skywalking/pull/8215#issuecomment-983192410 > No TLS verification should be fine, but don't need through us, actually. They could put a Nginx/Envoy in the front of ElasticSearch server, then OAP server could access

[skywalking] branch fix created (now 5fbd508)

2021-11-30 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch fix in repository https://gitbox.apache.org/repos/asf/skywalking.git. at 5fbd508 Fix a wrong check about entity if GraphQL at the endpoint relation level. No new revisions were added

[GitHub] [skywalking] wu-sheng opened a new pull request #8218: Fix a wrong check about entity if GraphQL at endpoint relation level.

2021-11-30 Thread GitBox
wu-sheng opened a new pull request #8218: URL: https://github.com/apache/skywalking/pull/8218 …vel. - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [x] Update the [`CHANGES`

[skywalking-website] branch asf-site updated: deploy: 3ab703e62792b8b07797a378dd7ad4e241499588

2021-11-30 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/skywalking-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 8d9949a deploy:

[GitHub] [skywalking] wu-sheng merged pull request #8216: Add a guidance doc about the logic endpoint

2021-11-30 Thread GitBox
wu-sheng merged pull request #8216: URL: https://github.com/apache/skywalking/pull/8216 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[skywalking] branch master updated: Add a guidance doc about the logic endpoint (#8216)

2021-11-30 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new 00ffdf7 Add a guidance doc about the

[GitHub] [skywalking] wu-sheng opened a new pull request #8216: Add a guidance doc about the logic endpoint

2021-11-30 Thread GitBox
wu-sheng opened a new pull request #8216: URL: https://github.com/apache/skywalking/pull/8216 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [x] Update the [`CHANGES`

[skywalking] branch logic-span-doc created (now 1876fea)

2021-11-30 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch logic-span-doc in repository https://gitbox.apache.org/repos/asf/skywalking.git. at 1876fea Add a guidance doc about the logic endpoint This branch includes the following new commits:

[skywalking] 01/01: Add a guidance doc about the logic endpoint

2021-11-30 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch logic-span-doc in repository https://gitbox.apache.org/repos/asf/skywalking.git commit 1876fea52ce654e561c5102f522ee5e3008383be Author: Wu Sheng AuthorDate: Tue Nov 30 21:00:08 2021 +0800

[GitHub] [skywalking] wu-sheng commented on pull request #8215: Support disables the verification of server's TLS certificate chain for specific hosts

2021-11-30 Thread GitBox
wu-sheng commented on pull request #8215: URL: https://github.com/apache/skywalking/pull/8215#issuecomment-982549308 No TLS verification should be fine, but don't need through us, actually. They could put a Nginx/Envoy in the front of ElasticSearch server, then OAP server could access

[GitHub] [skywalking] JaredTan95 edited a comment on pull request #8215: Support disables the verification of server's TLS certificate chain for specific hosts

2021-11-30 Thread GitBox
JaredTan95 edited a comment on pull request #8215: URL: https://github.com/apache/skywalking/pull/8215#issuecomment-982545408 Okay, I missed this https://github.com/apache/skywalking/pull/8179 issue. Feedback from some users, in some user cases, they don't bind domain on elasticseach

[GitHub] [skywalking] JaredTan95 edited a comment on pull request #8215: Support disables the verification of server's TLS certificate chain for specific hosts

2021-11-30 Thread GitBox
JaredTan95 edited a comment on pull request #8215: URL: https://github.com/apache/skywalking/pull/8215#issuecomment-982545408 Okay, I missed this https://github.com/apache/skywalking/pull/8179 issue. Feedback from some users, in some user cases, they don't bind domain on elasticseach

[GitHub] [skywalking] JaredTan95 commented on pull request #8215: Support disables the verification of server's TLS certificate chain for specific hosts

2021-11-30 Thread GitBox
JaredTan95 commented on pull request #8215: URL: https://github.com/apache/skywalking/pull/8215#issuecomment-982545408 Okay, I missed this https://github.com/apache/skywalking/pull/8179 issue. Feedback from some customers, in some user cases, they don't bind domain on elasticseach

[skywalking] branch support_insecure_hosts updated (58a7710 -> 4654db3)

2021-11-30 Thread tanjian
This is an automated email from the ASF dual-hosted git repository. tanjian pushed a change to branch support_insecure_hosts in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 58a7710 Merge branch 'master' into support_insecure_hosts add cb2dfee revert default

[GitHub] [skywalking] wu-sheng commented on pull request #8215: Support disables the verification of server's TLS certificate chain for specific hosts

2021-11-30 Thread GitBox
wu-sheng commented on pull request #8215: URL: https://github.com/apache/skywalking/pull/8215#issuecomment-982537010 Notice, #8179 got rejected due to skipping the secure checking. This is an insecure way for general use. Couldn't you explain more? -- This is an automated message

[GitHub] [skywalking] JaredTan95 opened a new pull request #8215: Support disables the verification of server's TLS certificate chain for specific hosts

2021-11-30 Thread GitBox
JaredTan95 opened a new pull request #8215: URL: https://github.com/apache/skywalking/pull/8215 ### Support disables the verification of server's TLS certificate chain for specific hosts by `SW_STORAGE_ES_SSL_INSECURE_HOSTS` env. **NOTE**: You should never

[skywalking] branch support_insecure_hosts updated (00c77e2 -> 58a7710)

2021-11-30 Thread tanjian
This is an automated email from the ASF dual-hosted git repository. tanjian pushed a change to branch support_insecure_hosts in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 00c77e2 Support disables the verification of server's TLS certificate chain for specific

[skywalking] branch support_insecure_hosts created (now 00c77e2)

2021-11-30 Thread tanjian
This is an automated email from the ASF dual-hosted git repository. tanjian pushed a change to branch support_insecure_hosts in repository https://gitbox.apache.org/repos/asf/skywalking.git. at 00c77e2 Support disables the verification of server's TLS certificate chain for specific

[skywalking] 01/01: Support disables the verification of server's TLS certificate chain for specific hosts

2021-11-30 Thread tanjian
This is an automated email from the ASF dual-hosted git repository. tanjian pushed a commit to branch support_insecure_hosts in repository https://gitbox.apache.org/repos/asf/skywalking.git commit 00c77e235c8350d529a5a1cb760c031e659b8038 Author: JaredTan95 AuthorDate: Tue Nov 30 19:04:19 2021

[skywalking] branch master updated: Highlight profiling blogs (#8214)

2021-11-30 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new fb69094 Highlight profiling blogs (#8214)

[GitHub] [skywalking] wu-sheng merged pull request #8214: Highlight profiling blogs

2021-11-30 Thread GitBox
wu-sheng merged pull request #8214: URL: https://github.com/apache/skywalking/pull/8214 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[skywalking-website] branch asf-site updated: deploy: 3ab703e62792b8b07797a378dd7ad4e241499588

2021-11-30 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/skywalking-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 709bc59 deploy:

[GitHub] [skywalking] wu-sheng opened a new pull request #8214: Highlight profiling blogs

2021-11-30 Thread GitBox
wu-sheng opened a new pull request #8214: URL: https://github.com/apache/skywalking/pull/8214 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [ ] Update the [`CHANGES`

[skywalking] branch profile-blog created (now 3865ec0)

2021-11-30 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch profile-blog in repository https://gitbox.apache.org/repos/asf/skywalking.git. at 3865ec0 Highlight profiling blogs This branch includes the following new commits: new 3865ec0

[skywalking] 01/01: Highlight profiling blogs

2021-11-30 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch profile-blog in repository https://gitbox.apache.org/repos/asf/skywalking.git commit 3865ec0a70b36868b23e53c3c7e831382607f48a Author: Wu Sheng AuthorDate: Tue Nov 30 17:58:48 2021 +0800

[GitHub] [skywalking] wu-sheng commented on issue #6244: Profile stopped working in 8.3.0

2021-11-30 Thread GitBox
wu-sheng commented on issue #6244: URL: https://github.com/apache/skywalking/issues/6244#issuecomment-982468243 https://skywalking.apache.org/blog/2020-04-13-apache-skywalking-profiling/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [skywalking] chanjarster commented on issue #6244: Profile stopped working in 8.3.0

2021-11-30 Thread GitBox
chanjarster commented on issue #6244: URL: https://github.com/apache/skywalking/issues/6244#issuecomment-982467098 Not really know what profiling is. Any docs besides [this][1]? [1]: https://skywalking.apache.org/docs/main/v8.8.1/en/ui/readme/#profile -- This is an automated

[GitHub] [skywalking] wu-sheng commented on issue #6244: Profile stopped working in 8.3.0

2021-11-30 Thread GitBox
wu-sheng commented on issue #6244: URL: https://github.com/apache/skywalking/issues/6244#issuecomment-982455326 You should learn what is profiling. There is no point to profile a `1ms` access. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [skywalking] chanjarster commented on issue #6244: Profile stopped working in 8.3.0

2021-11-30 Thread GitBox
chanjarster commented on issue #6244: URL: https://github.com/apache/skywalking/issues/6244#issuecomment-982433899 SkyWalking 8.8.1, Java Agent 8.8.0 (apache/skywalking-java-agent:8.8.0-alpine) Same issue, start a Profile task from 2021-11-30 16:56:57 for 5 min:

[GitHub] [skywalking] wallezhang commented on issue #8175: [Feature] java.lang.NoSuchMethodError occurred when I use pulsar plugin with pulsar client v2.8.1

2021-11-30 Thread GitBox
wallezhang commented on issue #8175: URL: https://github.com/apache/skywalking/issues/8175#issuecomment-982384821 > > OK, if this is the only gap, then common module seems making sense. > > OK, thanks for your advice. Hi there, I'd like to know the planned completion time of