[GitHub] [skywalking-banyandb] hanahmily commented on a diff in pull request #130: Add bydbctl and ui projects

2022-06-06 Thread GitBox
hanahmily commented on code in PR #130: URL: https://github.com/apache/skywalking-banyandb/pull/130#discussion_r890833115 ## dist/LICENSE: ## @@ -201,58 +216,6 @@ BSD-3-Clause and Apache-2.0 and MIT and BSD-3-Clause and MIT licenses github.com/klauspost/compress v1.15.6

[GitHub] [skywalking] wankai123 commented on a diff in pull request #9177: Support Zipkin traces collect and zipkin traces query API.

2022-06-06 Thread GitBox
wankai123 commented on code in PR #9177: URL: https://github.com/apache/skywalking/pull/9177#discussion_r890821209 ## docs/en/setup/backend/zipkin-trace.md: ## @@ -15,9 +14,35 @@ receiver-zipkin: restMaxThreads: ${SW_RECEIVER_ZIPKIN_REST_MAX_THREADS:200} restIdleTimeOu

[GitHub] [skywalking] sonatype-lift[bot] commented on a diff in pull request #9177: Support Zipkin traces collect and zipkin traces query API.

2022-06-06 Thread GitBox
sonatype-lift[bot] commented on code in PR #9177: URL: https://github.com/apache/skywalking/pull/9177#discussion_r890814813 ## oap-server/server-receiver-plugin/zipkin-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/zipkin/trace/SpanForward.java: ## @@ -1

[skywalking] branch master updated: Add dashboard configuration for on demand log (#9178)

2022-06-06 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new fd1313f181 Add dashboard configuration for

[GitHub] [skywalking] wu-sheng merged pull request #9178: Add dashboard configuration for on demand log

2022-06-06 Thread GitBox
wu-sheng merged PR #9178: URL: https://github.com/apache/skywalking/pull/9178 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

[GitHub] [skywalking-banyandb] lujiajing1126 commented on a diff in pull request #130: Add bydbctl and ui projects

2022-06-06 Thread GitBox
lujiajing1126 commented on code in PR #130: URL: https://github.com/apache/skywalking-banyandb/pull/130#discussion_r890797064 ## dist/LICENSE: ## @@ -174,6 +174,20 @@ of your accepting any such warranty or additional liability. +==

[GitHub] [skywalking-banyandb] wu-sheng commented on a diff in pull request #130: Add bydbctl and ui projects

2022-06-06 Thread GitBox
wu-sheng commented on code in PR #130: URL: https://github.com/apache/skywalking-banyandb/pull/130#discussion_r890792788 ## dist/LICENSE: ## @@ -201,58 +216,6 @@ BSD-3-Clause and Apache-2.0 and MIT and BSD-3-Clause and MIT licenses github.com/klauspost/compress v1.15.6

[GitHub] [skywalking] Superskyyy closed issue #9165: [Bug] something went wrong when use Router in expressjs with skywalking

2022-06-06 Thread GitBox
Superskyyy closed issue #9165: [Bug] something went wrong when use Router in expressjs with skywalking URL: https://github.com/apache/skywalking/issues/9165 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [skywalking] Superskyyy commented on issue #9165: [Bug] something went wrong when use Router in expressjs with skywalking

2022-06-06 Thread GitBox
Superskyyy commented on issue #9165: URL: https://github.com/apache/skywalking/issues/9165#issuecomment-1148199869 Closing as fixed ^ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [skywalking] kezhenxu94 commented on pull request #9178: Add dashboard configuration for on demand log

2022-06-06 Thread GitBox
kezhenxu94 commented on PR #9178: URL: https://github.com/apache/skywalking/pull/9178#issuecomment-1148187299 https://user-images.githubusercontent.com/15965696/172297085-a8bc3b18-c718-4aab-bb5e-b293da16fa25.png";> https://user-images.githubusercontent.com/15965696/172297031-f1c43e

[GitHub] [skywalking] kezhenxu94 opened a new pull request, #9178: Add dashboard configuration for on demand log

2022-06-06 Thread GitBox
kezhenxu94 opened a new pull request, #9178: URL: https://github.com/apache/skywalking/pull/9178 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [ ] Update the [`CHANGES` log](https://github.com/apa

[skywalking] 01/01: Add dashboard configuration for on demand log

2022-06-06 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a commit to branch dashboard/ondemandlog in repository https://gitbox.apache.org/repos/asf/skywalking.git commit e545a872a3db4736e658c5997261d4c1526dc6b8 Author: kezhenxu94 AuthorDate: Tue Jun 7 12:29:47 2022 +

[skywalking] branch dashboard/ondemandlog updated (67c773145b -> e545a872a3)

2022-06-06 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch dashboard/ondemandlog in repository https://gitbox.apache.org/repos/asf/skywalking.git discard 67c773145b Add dashboard configuration for on demand log new e545a872a3 Add dashboard conf

[skywalking-banyandb] branch new-projects updated (29e63f5 -> 8687cb8)

2022-06-06 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch new-projects in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git from 29e63f5 Add header add 8687cb8 Check data before flushing No new revisions were added by

[skywalking] 01/01: Add dashboard configuration for on demand log

2022-06-06 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a commit to branch dashboard/ondemandlog in repository https://gitbox.apache.org/repos/asf/skywalking.git commit 67c773145b9ccb8b678bfd41f575a757d6fda410 Author: kezhenxu94 AuthorDate: Tue Jun 7 12:29:47 2022 +

[skywalking] branch dashboard/ondemandlog created (now 67c773145b)

2022-06-06 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch dashboard/ondemandlog in repository https://gitbox.apache.org/repos/asf/skywalking.git at 67c773145b Add dashboard configuration for on demand log This branch includes the following ne

[GitHub] [skywalking-banyandb] hanahmily commented on a diff in pull request #130: [WIP]Add bydbctl and ui projects

2022-06-06 Thread GitBox
hanahmily commented on code in PR #130: URL: https://github.com/apache/skywalking-banyandb/pull/130#discussion_r890748705 ## dist/LICENSE: ## @@ -174,6 +174,20 @@ of your accepting any such warranty or additional liability. +==

[skywalking-banyandb] branch new-projects updated (f5775c2 -> 29e63f5)

2022-06-06 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch new-projects in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git from f5775c2 Move webapp to liaison add 29e63f5 Add header No new revisions were added by thi

[skywalking-banyandb] branch new-projects updated (1001899 -> f5775c2)

2022-06-06 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch new-projects in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git from 1001899 Add go dependencies cache add f5775c2 Move webapp to liaison No new revisions we

[GitHub] [skywalking] sonatype-lift[bot] commented on a diff in pull request #9177: Support Zipkin traces collect and zipkin traces query API.

2022-06-06 Thread GitBox
sonatype-lift[bot] commented on code in PR #9177: URL: https://github.com/apache/skywalking/pull/9177#discussion_r890736882 ## oap-server/server-receiver-plugin/zipkin-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/zipkin/trace/SpanForward.java: ## @@ -1

[skywalking-banyandb] branch new-projects updated (d9b5c7c -> 1001899)

2022-06-06 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch new-projects in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git discard d9b5c7c Add go dependencies cache add 1001899 Add go dependencies cache This update adde

[GitHub] [skywalking-banyandb] hanahmily commented on a diff in pull request #130: [WIP]Add bydbctl and ui projects

2022-06-06 Thread GitBox
hanahmily commented on code in PR #130: URL: https://github.com/apache/skywalking-banyandb/pull/130#discussion_r890734174 ## banyand/webapp/webapp.go: ## @@ -0,0 +1,153 @@ +// Licensed to Apache Software Foundation (ASF) under one or more contributor +// license agreements. See

[skywalking-banyandb] branch new-projects updated (7eb89ea -> d9b5c7c)

2022-06-06 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch new-projects in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git from 7eb89ea Add UI related licenses add d9b5c7c Add go dependencies cache No new revisions w

[GitHub] [skywalking] wu-sheng commented on a diff in pull request #9177: Support Zipkin traces collect and zipkin traces query API.

2022-06-06 Thread GitBox
wu-sheng commented on code in PR #9177: URL: https://github.com/apache/skywalking/pull/9177#discussion_r890726764 ## docs/en/setup/backend/zipkin-trace.md: ## @@ -15,9 +14,35 @@ receiver-zipkin: restMaxThreads: ${SW_RECEIVER_ZIPKIN_REST_MAX_THREADS:200} restIdleTimeOut

[GitHub] [skywalking] wu-sheng commented on a diff in pull request #9177: Support Zipkin traces collect and zipkin traces query API.

2022-06-06 Thread GitBox
wu-sheng commented on code in PR #9177: URL: https://github.com/apache/skywalking/pull/9177#discussion_r890726657 ## oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/query/IZipkinQueryDAO.java: ## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache

[GitHub] [skywalking] sonatype-lift[bot] commented on a diff in pull request #9177: Support Zipkin traces collect and zipkin traces query API.

2022-06-06 Thread GitBox
sonatype-lift[bot] commented on code in PR #9177: URL: https://github.com/apache/skywalking/pull/9177#discussion_r890725596 ## oap-server/server-starter/pom.xml: ## @@ -106,6 +106,11 @@ zipkin-receiver-plugin ${project.version} + Revi

[GitHub] [skywalking] wu-sheng commented on a diff in pull request #9177: Support Zipkin traces collect and zipkin traces query API.

2022-06-06 Thread GitBox
wu-sheng commented on code in PR #9177: URL: https://github.com/apache/skywalking/pull/9177#discussion_r890725062 ## docs/en/changes/changes.md: ## @@ -76,6 +76,7 @@ * Remove OAL for events. * Simplify the format index name logical in ES storage. * Add instance properties ext

[GitHub] [skywalking] wu-sheng commented on a diff in pull request #9177: Support Zipkin traces collect and zipkin traces query API.

2022-06-06 Thread GitBox
wu-sheng commented on code in PR #9177: URL: https://github.com/apache/skywalking/pull/9177#discussion_r890724899 ## docs/en/setup/backend/zipkin-trace.md: ## @@ -15,9 +14,35 @@ receiver-zipkin: restMaxThreads: ${SW_RECEIVER_ZIPKIN_REST_MAX_THREADS:200} restIdleTimeOut

[GitHub] [skywalking] wu-sheng commented on a diff in pull request #9177: Support Zipkin traces collect and zipkin traces query API.

2022-06-06 Thread GitBox
wu-sheng commented on code in PR #9177: URL: https://github.com/apache/skywalking/pull/9177#discussion_r890724674 ## docs/en/setup/backend/zipkin-trace.md: ## @@ -15,9 +14,35 @@ receiver-zipkin: restMaxThreads: ${SW_RECEIVER_ZIPKIN_REST_MAX_THREADS:200} restIdleTimeOut

[GitHub] [skywalking] wankai123 opened a new pull request, #9177: Support Zipkin traces collect and zipkin traces query API.

2022-06-06 Thread GitBox
wankai123 opened a new pull request, #9177: URL: https://github.com/apache/skywalking/pull/9177 ### Zipkin server alternative - [ ] If this is non-trivial feature, paste the links/URLs to the design doc. - [ ] Update the documentation to include this new feature. - [X] Tests(includin

[GitHub] [skywalking-banyandb] lujiajing1126 commented on a diff in pull request #130: [WIP]Add bydbctl and ui projects

2022-06-06 Thread GitBox
lujiajing1126 commented on code in PR #130: URL: https://github.com/apache/skywalking-banyandb/pull/130#discussion_r890711533 ## banyand/webapp/webapp.go: ## @@ -0,0 +1,153 @@ +// Licensed to Apache Software Foundation (ASF) under one or more contributor +// license agreements.

[skywalking-banyandb] branch new-projects updated (a6bcc99 -> 7eb89ea)

2022-06-06 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch new-projects in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git from a6bcc99 Update e2e docker add 7eb89ea Add UI related licenses No new revisions were adde

[GitHub] [skywalking-banyandb] hanahmily commented on a diff in pull request #130: [WIP]Add bydbctl and ui projects

2022-06-06 Thread GitBox
hanahmily commented on code in PR #130: URL: https://github.com/apache/skywalking-banyandb/pull/130#discussion_r890709044 ## banyand/webapp/webapp.go: ## @@ -0,0 +1,153 @@ +// Licensed to Apache Software Foundation (ASF) under one or more contributor +// license agreements. See

[skywalking-nodejs] branch master updated: Fix issue #9165 express router entry duplicated (#84)

2022-06-06 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-nodejs.git The following commit(s) were added to refs/heads/master by this push: new d26f01b Fix issue #9165 express

[GitHub] [skywalking-nodejs] kezhenxu94 merged pull request #84: Fix issue #9165 express router entry duplicated

2022-06-06 Thread GitBox
kezhenxu94 merged PR #84: URL: https://github.com/apache/skywalking-nodejs/pull/84 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

[GitHub] [skywalking-banyandb] lujiajing1126 commented on a diff in pull request #130: [WIP]Add bydbctl and ui projects

2022-06-06 Thread GitBox
lujiajing1126 commented on code in PR #130: URL: https://github.com/apache/skywalking-banyandb/pull/130#discussion_r890686828 ## banyand/webapp/webapp.go: ## @@ -0,0 +1,153 @@ +// Licensed to Apache Software Foundation (ASF) under one or more contributor +// license agreements.

[GitHub] [skywalking-banyandb] lujiajing1126 commented on a diff in pull request #130: [WIP]Add bydbctl and ui projects

2022-06-06 Thread GitBox
lujiajing1126 commented on code in PR #130: URL: https://github.com/apache/skywalking-banyandb/pull/130#discussion_r890686507 ## banyand/webapp/webapp.go: ## @@ -0,0 +1,153 @@ +// Licensed to Apache Software Foundation (ASF) under one or more contributor +// license agreements.

[skywalking-banyandb] branch new-projects updated (88eaf46 -> a6bcc99)

2022-06-06 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch new-projects in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git discard 88eaf46 Update e2e docker add a6bcc99 Update e2e docker This update added new revisions

[skywalking-banyandb] branch new-projects updated (ba4e9df -> 88eaf46)

2022-06-06 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch new-projects in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git from ba4e9df Skip ui docker.push add 88eaf46 Update e2e docker No new revisions were added by

[GitHub] [skywalking-banyandb] hanahmily commented on a diff in pull request #130: [WIP]Add bydbctl and ui projects

2022-06-06 Thread GitBox
hanahmily commented on code in PR #130: URL: https://github.com/apache/skywalking-banyandb/pull/130#discussion_r890656454 ## .github/workflows/publish-docker.yml: ## @@ -58,12 +63,12 @@ jobs: docker image ls - name: Log in to the Container registry us

[GitHub] [skywalking-banyandb] wu-sheng commented on a diff in pull request #130: [WIP]Add bydbctl and ui projects

2022-06-06 Thread GitBox
wu-sheng commented on code in PR #130: URL: https://github.com/apache/skywalking-banyandb/pull/130#discussion_r890655621 ## .github/workflows/publish-docker.yml: ## @@ -58,12 +63,12 @@ jobs: docker image ls - name: Log in to the Container registry use

[skywalking-banyandb] branch new-projects updated (22531c9 -> ba4e9df)

2022-06-06 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch new-projects in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git from 22531c9 Test docker push add ba4e9df Skip ui docker.push No new revisions were added by

[GitHub] [skywalking-banyandb] wu-sheng commented on pull request #130: [WIP]Add bydbctl and ui projects

2022-06-06 Thread GitBox
wu-sheng commented on PR #130: URL: https://github.com/apache/skywalking-banyandb/pull/130#issuecomment-1148048200 Because you are adding vue into this repo as well as further release, you have to keep binary license updated as well. -- This is an automated message from the Apache Git Se

[skywalking-banyandb] branch new-projects updated (6bc26e6 -> 22531c9)

2022-06-06 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch new-projects in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git omit 6bc26e6 Test docker push add 22531c9 Test docker push This update added new revisions af

[skywalking-banyandb] branch new-projects updated (8f97ef8 -> 6bc26e6)

2022-06-06 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch new-projects in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git discard 8f97ef8 Test docker push add 6bc26e6 Test docker push This update added new revisions af

[skywalking-banyandb] branch new-projects updated (8400eb9 -> 8f97ef8)

2022-06-06 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch new-projects in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git from 8400eb9 Update docker CI add 8f97ef8 Test docker push No new revisions were added by thi

[skywalking-banyandb] branch new-projects updated (f1f27e3 -> 8400eb9)

2022-06-06 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch new-projects in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git discard f1f27e3 Update docker CI add 8400eb9 Update docker CI This update added new revisions af

[skywalking-banyandb] branch new-projects updated (06559aa -> f1f27e3)

2022-06-06 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch new-projects in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git from 06559aa Update UI generator phase add f1f27e3 Update docker CI No new revisions were add

[GitHub] [skywalking-banyandb] hanahmily commented on a diff in pull request #130: [WIP]Add bydbctl and ui projects

2022-06-06 Thread GitBox
hanahmily commented on code in PR #130: URL: https://github.com/apache/skywalking-banyandb/pull/130#discussion_r890631062 ## banyand/webapp/webapp.go: ## @@ -0,0 +1,153 @@ +// Licensed to Apache Software Foundation (ASF) under one or more contributor +// license agreements. See

[skywalking-banyandb] branch new-projects updated (c44fd86 -> 06559aa)

2022-06-06 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch new-projects in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git from c44fd86 Add docker building scripts add 06559aa Update UI generator phase No new revisio

[GitHub] [skywalking-banyandb] hanahmily commented on a diff in pull request #130: [WIP]Add bydbctl and ui projects

2022-06-06 Thread GitBox
hanahmily commented on code in PR #130: URL: https://github.com/apache/skywalking-banyandb/pull/130#discussion_r890631062 ## banyand/webapp/webapp.go: ## @@ -0,0 +1,153 @@ +// Licensed to Apache Software Foundation (ASF) under one or more contributor +// license agreements. See

[skywalking-banyandb] branch new-projects updated (de746d1 -> c44fd86)

2022-06-06 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch new-projects in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git from de746d1 Add bydctl and ui projects add c44fd86 Add docker building scripts No new revisi

[GitHub] [skywalking-nodejs] tom-pytel commented on pull request #84: Fix issue #9165 express router entry duplicated

2022-06-06 Thread GitBox
tom-pytel commented on PR #84: URL: https://github.com/apache/skywalking-nodejs/pull/84#issuecomment-1147718782 Have tested with our fork and works. Someone should test vanilla. P.S. The linter being used by this project currently is pure evil incarnate. If evil could be distilled in

[GitHub] [skywalking-nodejs] tom-pytel opened a new pull request, #84: Fix issue #9165 express router entry duplicated

2022-06-06 Thread GitBox
tom-pytel opened a new pull request, #84: URL: https://github.com/apache/skywalking-nodejs/pull/84 See said issue: https://github.com/apache/skywalking/issues/9165#event-6729419470 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [skywalking] wu-sheng commented on issue #9160: [Feature] [SWCK] Add Instrument CRD to config and operate instruments.

2022-06-06 Thread GitBox
wu-sheng commented on issue #9160: URL: https://github.com/apache/skywalking/issues/9160#issuecomment-1147559535 One another, the current swck doesn't work for optional plugins properly. The plugin.mount is being used, but only set for default values, then it works for nothing. swck shou

[GitHub] [skywalking] wu-sheng commented on issue #9160: [Feature] [SWCK] Add Instrument CRD to config and operate instruments.

2022-06-06 Thread GitBox
wu-sheng commented on issue #9160: URL: https://github.com/apache/skywalking/issues/9160#issuecomment-1147549184 >Because the app level env keys might be added or removed in any version update, it may cause many compatibility problem. A little context, config keys and system environm

[GitHub] [skywalking-banyandb] lujiajing1126 commented on a diff in pull request #130: [WIP]Add bydbctl and ui projects

2022-06-06 Thread GitBox
lujiajing1126 commented on code in PR #130: URL: https://github.com/apache/skywalking-banyandb/pull/130#discussion_r890241913 ## banyand/webapp/webapp.go: ## @@ -0,0 +1,153 @@ +// Licensed to Apache Software Foundation (ASF) under one or more contributor +// license agreements.

[GitHub] [skywalking-banyandb] lujiajing1126 commented on a diff in pull request #130: [WIP]Add bydbctl and ui projects

2022-06-06 Thread GitBox
lujiajing1126 commented on code in PR #130: URL: https://github.com/apache/skywalking-banyandb/pull/130#discussion_r890241913 ## banyand/webapp/webapp.go: ## @@ -0,0 +1,153 @@ +// Licensed to Apache Software Foundation (ASF) under one or more contributor +// license agreements.

[GitHub] [skywalking] Duncan-tree-zhou commented on issue #9160: [Feature] [SWCK] Add Instrument CRD to config and operate instruments.

2022-06-06 Thread GitBox
Duncan-tree-zhou commented on issue #9160: URL: https://github.com/apache/skywalking/issues/9160#issuecomment-1147509895 @dashanji, When moving the annotation to CR spec, its not a good way to hardcode the mapping from CR spec fields to skywalking app env keys. Because the app level env key

[skywalking-banyandb] branch new-projects updated (d9808bd -> de746d1)

2022-06-06 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch new-projects in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git discard d9808bd Add bydctl and ui projects add de746d1 Add bydctl and ui projects This update ad

[skywalking-banyandb] branch new-projects updated (87a740d -> d9808bd)

2022-06-06 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch new-projects in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git omit 87a740d Add bydctl and ui projects add d9808bd Add bydctl and ui projects This update ad

[GitHub] [skywalking-banyandb] hanahmily opened a new pull request, #130: [WIP]Add bydctl and ui projects

2022-06-06 Thread GitBox
hanahmily opened a new pull request, #130: URL: https://github.com/apache/skywalking-banyandb/pull/130 Fixes https://github.com/apache/skywalking/issues/9162 Signed-off-by: Gao Hongtao -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[skywalking-banyandb] branch new-projects updated (b775dc7 -> 87a740d)

2022-06-06 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch new-projects in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git discard b775dc7 Add bydctl and ui projects new 87a740d Add bydctl and ui projects This update ad

[skywalking-banyandb] branch new-projects created (now b775dc7)

2022-06-06 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch new-projects in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git at b775dc7 Add bydctl and ui projects This branch includes the following new commits: new b

[GitHub] [skywalking-java] wu-sheng commented on pull request #191: string "/eureka" should match pattern "/eureka/*" or "/eureka/**"

2022-06-06 Thread GitBox
wu-sheng commented on PR #191: URL: https://github.com/apache/skywalking-java/pull/191#issuecomment-1147437991 Closing due to support @devkanro 's opinion(original author) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [skywalking-java] wu-sheng closed pull request #191: string "/eureka" should match pattern "/eureka/*" or "/eureka/**"

2022-06-06 Thread GitBox
wu-sheng closed pull request #191: string "/eureka" should match pattern "/eureka/*" or "/eureka/**" URL: https://github.com/apache/skywalking-java/pull/191 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [skywalking-java] wu-sheng commented on pull request #191: string "/eureka" should match pattern "/eureka/*" or "/eureka/**"

2022-06-06 Thread GitBox
wu-sheng commented on PR #191: URL: https://github.com/apache/skywalking-java/pull/191#issuecomment-1147425632 I am not sure why AntPathMatcher works like that, but to be honest, I don't think it is the standard. `/eureka/**` ignoring `/eureka` seems unreasonable. Maybe Spring team has

[GitHub] [skywalking] BruceAn1978 commented on issue #9176: [Bug] UI docker image start failed

2022-06-06 Thread GitBox
BruceAn1978 commented on issue #9176: URL: https://github.com/apache/skywalking/issues/9176#issuecomment-1147395144 I solved the problem by modify the docker file with this line: `ENTRYPOINT ["bash", "docker-entrypoint.sh"]` -- This is an automated message from the Apache Git Service. T

[GitHub] [skywalking-swck] dashanji commented on pull request #65: Add CRD, Controller, e2e for OAPServer's configuration

2022-06-06 Thread GitBox
dashanji commented on PR #65: URL: https://github.com/apache/skywalking-swck/pull/65#issuecomment-1147382694 Still coding ^_^ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [skywalking] dashanji commented on issue #9160: [Feature] [SWCK] Add Instrument CRD to config and operate instruments.

2022-06-06 Thread GitBox
dashanji commented on issue #9160: URL: https://github.com/apache/skywalking/issues/9160#issuecomment-1147379885 Agree! Configuration through CR is indeed clearer than configmap. However, the current agent configuration is mounted through configmap. We can use CR to manage the original co

[GitHub] [skywalking] dashanji commented on issue #9160: [Feature] [SWCK] Add Instrument CRD to config and operate instruments.

2022-06-06 Thread GitBox
dashanji commented on issue #9160: URL: https://github.com/apache/skywalking/issues/9160#issuecomment-1147379765 Agree! Configuration through CR is indeed clearer than configmap. However, the current agent configuration is mounted through configmap. We can use CR to manage the original co

[GitHub] [skywalking] wu-sheng commented on issue #9176: [Bug] UI docker image start failed

2022-06-06 Thread GitBox
wu-sheng commented on issue #9176: URL: https://github.com/apache/skywalking/issues/9176#issuecomment-1147368969 Support docker is not our scope. Sorry. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [skywalking] BruceAn1978 commented on issue #9176: [Bug] UI docker image start failed

2022-06-06 Thread GitBox
BruceAn1978 commented on issue #9176: URL: https://github.com/apache/skywalking/issues/9176#issuecomment-1147368280 > The docker file is only pull and rebuild it and then can run the pipeline job to deploy it to the correct k8s cluster, so we can not use the official helm and oprator.

[GitHub] [skywalking] wu-sheng closed issue #9176: [Bug] UI docker image start failed

2022-06-06 Thread GitBox
wu-sheng closed issue #9176: [Bug] UI docker image start failed URL: https://github.com/apache/skywalking/issues/9176 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[GitHub] [skywalking] wu-sheng commented on issue #9176: [Bug] UI docker image start failed

2022-06-06 Thread GitBox
wu-sheng commented on issue #9176: URL: https://github.com/apache/skywalking/issues/9176#issuecomment-1147358662 What you did on a docker file is your own responsibility. We have provided official docker image as well as helm and operator. -- This is an automated message from the Apache G

[GitHub] [skywalking] BruceAn1978 opened a new issue, #9176: [Bug] UI docker image start failed

2022-06-06 Thread GitBox
BruceAn1978 opened a new issue, #9176: URL: https://github.com/apache/skywalking/issues/9176 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar issues. ### Apache SkyWalking Component

[skywalking-website] branch asf-site updated: deploy: d039a86ddce739405e2363239a4d50223c9104b3

2022-06-06 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/skywalking-website.git The following commit(s) were added to refs/heads/asf-site by this push: new d3f668af86 deploy: d039a86dd

[GitHub] [skywalking] zhangam commented on issue #4809: apm-trace-ignore-plugin failed to filter interface /actuator/health

2022-06-06 Thread GitBox
zhangam commented on issue #4809: URL: https://github.com/apache/skywalking/issues/4809#issuecomment-1147203665 > Try to use this config. > > ``` > trace.ignore_path=GET:/actuator/* > ``` nb!!! -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [skywalking] zhangam commented on issue #4809: apm-trace-ignore-plugin failed to filter interface /actuator/health

2022-06-06 Thread GitBox
zhangam commented on issue #4809: URL: https://github.com/apache/skywalking/issues/4809#issuecomment-1147202830 > nb!!! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [skywalking-booster-ui] Fine0830 merged pull request #103: fix: activate the correct tab index after renaming a Tabs name

2022-06-06 Thread GitBox
Fine0830 merged PR #103: URL: https://github.com/apache/skywalking-booster-ui/pull/103 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-uns

[skywalking-booster-ui] branch main updated: fix: activate the correct tab index after renaming a Tabs name (#103)

2022-06-06 Thread qiuxiafan
This is an automated email from the ASF dual-hosted git repository. qiuxiafan pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/skywalking-booster-ui.git The following commit(s) were added to refs/heads/main by this push: new c875c95 fix: activate the correct

[GitHub] [skywalking-booster-ui] Fine0830 opened a new pull request, #103: fix: activate the correct tab index after renaming a Tabs name

2022-06-06 Thread GitBox
Fine0830 opened a new pull request, #103: URL: https://github.com/apache/skywalking-booster-ui/pull/103 Fixes activate the correct tab index after renaming a Tabs name. Video https://user-images.githubusercontent.com/20871783/172124240-8d62eeac-3ebf-477f-b4e3-ad69235f5597.mov

[skywalking-showcase] branch main updated: Update the rover image and fix missing the path of host environment (#42)

2022-06-06 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/skywalking-showcase.git The following commit(s) were added to refs/heads/main by this push: new dcb5449 Update the rover image and

[GitHub] [skywalking-showcase] kezhenxu94 merged pull request #42: Update the rover image and fix environment variable that missing host path

2022-06-06 Thread GitBox
kezhenxu94 merged PR #42: URL: https://github.com/apache/skywalking-showcase/pull/42 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsub

[GitHub] [skywalking-swck] hanahmily commented on pull request #65: Add CRD, Controller, e2e for OAPServer's configuration

2022-06-06 Thread GitBox
hanahmily commented on PR #65: URL: https://github.com/apache/skywalking-swck/pull/65#issuecomment-1147122882 @dashanji, any updates here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec