[GitHub] [skywalking-java] wu-sheng commented on pull request #302: Add plugin to support impala jdbc driver

2022-09-02 Thread GitBox
wu-sheng commented on PR #302: URL: https://github.com/apache/skywalking-java/pull/302#issuecomment-1236047896 OK, then you should submit another pull request to expose this config first. We can't accept plugins without tests, as we can't ask every contributor to reapond users when they

[GitHub] [skywalking-java] lv-lifeng commented on a diff in pull request #302: Add plugin to support impala jdbc driver

2022-09-02 Thread GitBox
lv-lifeng commented on code in PR #302: URL: https://github.com/apache/skywalking-java/pull/302#discussion_r962101655 ## apm-protocol/apm-network/src/main/java/org/apache/skywalking/apm/network/trace/component/ComponentsDefine.java: ## @@ -229,4 +229,6 @@ public class

[GitHub] [skywalking-java] lv-lifeng commented on pull request #302: Add plugin to support impala jdbc driver

2022-09-02 Thread GitBox
lv-lifeng commented on PR #302: URL: https://github.com/apache/skywalking-java/pull/302#issuecomment-1236045479 > I tried to add a auto test case but failed. `configuration.yml` does not seem to support impala `quickstart.yml`. > > ```yaml > version: "3" > services: > hms:

[GitHub] [skywalking-php] wu-sheng commented on pull request #7: Update docs

2022-09-02 Thread GitBox
wu-sheng commented on PR #7: URL: https://github.com/apache/skywalking-php/pull/7#issuecomment-1236045353 As you have added menu file, please update the website doc setting accordingly. Then we could check how PHP docs work on preview. -- This is an automated message from the Apache Git

[GitHub] [skywalking-php] jmjoy merged pull request #7: Update docs

2022-09-02 Thread GitBox
jmjoy merged PR #7: URL: https://github.com/apache/skywalking-php/pull/7 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[skywalking-php] branch master updated: Update docs (#7)

2022-09-02 Thread jmjoy
This is an automated email from the ASF dual-hosted git repository. jmjoy pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-php.git The following commit(s) were added to refs/heads/master by this push: new 4231063 Update docs (#7) 4231063 is

[GitHub] [skywalking] wu-sheng commented on issue #9555: [Feature] Add impala jdbc plugin

2022-09-02 Thread GitBox
wu-sheng commented on issue #9555: URL: https://github.com/apache/skywalking/issues/9555#issuecomment-1236044815 Please be clear about what you plan to do later when you submit an issue. In skywalking, issue is used for tracking on planned things.

[GitHub] [skywalking-java] wu-sheng commented on pull request #302: Add plugin to support impala jdbc driver

2022-09-02 Thread GitBox
wu-sheng commented on PR #302: URL: https://github.com/apache/skywalking-java/pull/302#issuecomment-1236044552 I will wait for the ready of test scenario. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [skywalking-java] wu-sheng commented on a diff in pull request #302: Add plugin to support impala jdbc driver

2022-09-02 Thread GitBox
wu-sheng commented on code in PR #302: URL: https://github.com/apache/skywalking-java/pull/302#discussion_r962100268 ## apm-protocol/apm-network/src/main/java/org/apache/skywalking/apm/network/trace/component/ComponentsDefine.java: ## @@ -229,4 +229,6 @@ public class

[GitHub] [skywalking-java] wu-sheng commented on pull request #302: Add plugin to support impala jdbc driver

2022-09-02 Thread GitBox
wu-sheng commented on PR #302: URL: https://github.com/apache/skywalking-java/pull/302#issuecomment-1236043520 I am not sure what do you mean not supported. The test framework is just booting a docker compose. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [skywalking-java] lv-lifeng commented on pull request #302: Add plugin to support impala jdbc driver

2022-09-02 Thread GitBox
lv-lifeng commented on PR #302: URL: https://github.com/apache/skywalking-java/pull/302#issuecomment-1236040766 ![image](https://user-images.githubusercontent.com/35800871/188254515-758ae29f-fa72-4ce9-8765-2582aa9fcb9d.png) -- This is an automated message from the Apache Git Service.

[GitHub] [skywalking-java] lv-lifeng commented on pull request #302: Add plugin to support impala jdbc driver

2022-09-02 Thread GitBox
lv-lifeng commented on PR #302: URL: https://github.com/apache/skywalking-java/pull/302#issuecomment-1236040378 I tried to add a auto test case but failed. `configuration.yml` does not seem to support impala `quickstart.yml`. ```yml version: "3" services: hms: image:

[GitHub] [skywalking-java] lv-lifeng opened a new pull request, #302: Add plugin to support impala jdbc driver

2022-09-02 Thread GitBox
lv-lifeng opened a new pull request, #302: URL: https://github.com/apache/skywalking-java/pull/302 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [ ] Update the [`CHANGES`

[GitHub] [skywalking] wu-sheng closed issue #9555: [Feature] Add impala jdbc plugin

2022-09-02 Thread GitBox
wu-sheng closed issue #9555: [Feature] Add impala jdbc plugin URL: https://github.com/apache/skywalking/issues/9555 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [skywalking] wu-sheng commented on issue #9555: [Feature] Add impala jdbc plugin

2022-09-02 Thread GitBox
wu-sheng commented on issue #9555: URL: https://github.com/apache/skywalking/issues/9555#issuecomment-1235964338 You could send a pull request to contribute new plugins for other open source projects. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [skywalking] lv-lifeng opened a new issue, #9555: [Feature] Add impala jdbc plugin

2022-09-02 Thread GitBox
lv-lifeng opened a new issue, #9555: URL: https://github.com/apache/skywalking/issues/9555 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement. ### Description

[GitHub] [skywalking-php] wu-sheng commented on pull request #7: Update docs

2022-09-02 Thread GitBox
wu-sheng commented on PR #7: URL: https://github.com/apache/skywalking-php/pull/7#issuecomment-1235598977 That should be good, let's build the scripts for the binary. Notice, we need LICENSE for binary dependencies. Rust side should be supported by skywalking-eyes, but I don't know about

[GitHub] [skywalking-php] jmjoy commented on pull request #7: Update docs

2022-09-02 Thread GitBox
jmjoy commented on PR #7: URL: https://github.com/apache/skywalking-php/pull/7#issuecomment-1235591725 > > I found `pecl` can install local package, so we can pack the code, and install it by `pecl install skywalking_agent-0.1.0.tgz`. > > Would this OS sensitive? Linux and

[GitHub] [skywalking-php] wu-sheng commented on pull request #7: Update docs

2022-09-02 Thread GitBox
wu-sheng commented on PR #7: URL: https://github.com/apache/skywalking-php/pull/7#issuecomment-1235558907 > I found `pecl` can install local package, so we can pack the code, and install it by `pecl install skywalking_agent-0.1.0.tgz`. Would this OS sensitive? -- This is an

[GitHub] [skywalking-php] jmjoy commented on pull request #7: Update docs

2022-09-02 Thread GitBox
jmjoy commented on PR #7: URL: https://github.com/apache/skywalking-php/pull/7#issuecomment-1235533986 I found `pecl` can install local package, so we can pack the code, and install it by `pecl install skywalking_agent-0.1.0.tgz`. -- This is an automated message from the Apache Git

[skywalking-website] branch master updated: Add 8.x EOL announcement. (#498)

2022-09-02 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-website.git The following commit(s) were added to refs/heads/master by this push: new e2dd5178d6 Add 8.x EOL

[GitHub] [skywalking-website] wu-sheng merged pull request #498: Add 8.x EOL announcement.

2022-09-02 Thread GitBox
wu-sheng merged PR #498: URL: https://github.com/apache/skywalking-website/pull/498 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[skywalking-website] branch deprecate-v8 updated (356715d8d1 -> 1a5c0f13a6)

2022-09-02 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch deprecate-v8 in repository https://gitbox.apache.org/repos/asf/skywalking-website.git from 356715d8d1 Add 8.x EOL announcement. add 1a5c0f13a6 Fix words. No new revisions were added

[GitHub] [skywalking-website] netlify[bot] commented on pull request #498: Add 8.x EOL announcement.

2022-09-02 Thread GitBox
netlify[bot] commented on PR #498: URL: https://github.com/apache/skywalking-website/pull/498#issuecomment-1235430662 ###  Deploy Preview for *skywalking-preview* processing. | Name | Link | |-|| | Latest commit |

[GitHub] [skywalking-website] netlify[bot] commented on pull request #498: Add 8.x EOL announcement.

2022-09-02 Thread GitBox
netlify[bot] commented on PR #498: URL: https://github.com/apache/skywalking-website/pull/498#issuecomment-1235430663 ###  Deploy Preview for *skywalking-preview* processing. | Name | Link | |-|| | Latest commit |

[skywalking-website] 01/01: Add 8.x EOL announcement.

2022-09-02 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch deprecate-v8 in repository https://gitbox.apache.org/repos/asf/skywalking-website.git commit 356715d8d1bb84376cdba2d0be9f496ae908b02c Author: Wu Sheng AuthorDate: Fri Sep 2 20:15:36 2022 +0800

[skywalking-website] branch deprecate-v8 created (now 356715d8d1)

2022-09-02 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch deprecate-v8 in repository https://gitbox.apache.org/repos/asf/skywalking-website.git at 356715d8d1 Add 8.x EOL announcement. This branch includes the following new commits: new

[GitHub] [skywalking] kezhenxu94 merged pull request #9553: Upgrade CodeQL version to v2

2022-09-02 Thread GitBox
kezhenxu94 merged PR #9553: URL: https://github.com/apache/skywalking/pull/9553 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[skywalking] branch master updated: Upgrade CodeQL version to v2 (#9553)

2022-09-02 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new f2cca32588 Upgrade CodeQL version to v2

[GitHub] [skywalking-client-js] vihoyau commented on pull request #95: fix the npm ci

2022-09-02 Thread GitBox
vihoyau commented on PR #95: URL: https://github.com/apache/skywalking-client-js/pull/95#issuecomment-1235317106 > If we want to use `yarn` replace `npm`, we need to replace all of script commands and `lock.json` file, not just `npm install`. thank you , i have done -- This is an

[skywalking-website] branch asf-site updated: deploy: efd75d06dae8c006146e2b7f835a49050eb4d6f8

2022-09-02 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/skywalking-website.git The following commit(s) were added to refs/heads/asf-site by this push: new c0fd89941b deploy:

[GitHub] [skywalking-php] wu-sheng commented on pull request #7: Update docs

2022-09-02 Thread GitBox
wu-sheng commented on PR #7: URL: https://github.com/apache/skywalking-php/pull/7#issuecomment-1235287771 I think we should keep compiling doc, because, in the release process, the PMC should check your source tar is able to compile passed or not. Also, you should have a release doc

[GitHub] [skywalking] wu-sheng commented on issue #9548: [Feature] Monitoring MySQL's Slow SQL

2022-09-02 Thread GitBox
wu-sheng commented on issue #9548: URL: https://github.com/apache/skywalking/issues/9548#issuecomment-1235283725 It is better if the agent could generate this ID, and OAP just uses it in the LAL. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [skywalking-client-js] vihoyau commented on pull request #95: fix the npm ci

2022-09-02 Thread GitBox
vihoyau commented on PR #95: URL: https://github.com/apache/skywalking-client-js/pull/95#issuecomment-1235265019 > If we want to use `yarn` replace `npm`, we need to replace all of script commands and `lock.json` file, not just `npm install`. can i need to replace all ? it’s

[GitHub] [skywalking] yswdqz commented on issue #9548: [Feature] Monitoring MySQL's Slow SQL

2022-09-02 Thread GitBox
yswdqz commented on issue #9548: URL: https://github.com/apache/skywalking/issues/9548#issuecomment-1235263132 I get it. May be need to generate a UUID. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [skywalking] damonxue opened a new pull request, #9553: Upgrade CodeQL version to v2

2022-09-02 Thread GitBox
damonxue opened a new pull request, #9553: URL: https://github.com/apache/skywalking/pull/9553 Upgrade CodeQL version to v2. [shenyu #3907](https://github.com/apache/shenyu/pull/3907) For more information, see [Code scanning: deprecation of CodeQL Action

[GitHub] [skywalking] wu-sheng commented on issue #9548: [Feature] Monitoring MySQL's Slow SQL

2022-09-02 Thread GitBox
wu-sheng commented on issue #9548: URL: https://github.com/apache/skywalking/issues/9548#issuecomment-1235239840 No, ID is required to be globally unique. Is there anything specific isourceoriginal data? Or could the agent fill a UUID tag for every row of data? -- This is an automated

[GitHub] [skywalking-client-js] vihoyau commented on pull request #95: fix the npm ci

2022-09-02 Thread GitBox
vihoyau commented on PR #95: URL: https://github.com/apache/skywalking-client-js/pull/95#issuecomment-1235231895 fix the npm ci reason: 1.npm ci have a command "npm install", it don't effective about webpack. 2.we can use the command "yarn install", it can install webpack node_moudle

[GitHub] [skywalking] yswdqz commented on issue #9548: [Feature] Monitoring MySQL's Slow SQL

2022-09-02 Thread GitBox
yswdqz commented on issue #9548: URL: https://github.com/apache/skywalking/issues/9548#issuecomment-1235198613 Does thid mean thread id? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [skywalking-client-js] wu-sheng commented on pull request #95: fix the npm ci

2022-09-02 Thread GitBox
wu-sheng commented on PR #95: URL: https://github.com/apache/skywalking-client-js/pull/95#issuecomment-1235196176 You need to describe why you want to change this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [skywalking] wu-sheng commented on issue #9548: [Feature] Monitoring MySQL's Slow SQL

2022-09-02 Thread GitBox
wu-sheng commented on issue #9548: URL: https://github.com/apache/skywalking/issues/9548#issuecomment-1235194213 I see, the thid should be changed as a generated ID if segmentID and spanID absent. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [skywalking-client-js] wu-sheng commented on a diff in pull request #94: support to "import ClientMonitor from 'skywalking-client-js'" in "typescript" and "es6"

2022-09-02 Thread GitBox
wu-sheng commented on code in PR #94: URL: https://github.com/apache/skywalking-client-js/pull/94#discussion_r961397206 ## .github/workflows/build.yml: ## @@ -34,9 +34,9 @@ jobs: uses: actions/setup-node@v1 with: node-version: ${{ matrix.node-version }}

[GitHub] [skywalking-client-js] vihoyau opened a new pull request, #95: fix the npm ci

2022-09-02 Thread GitBox
vihoyau opened a new pull request, #95: URL: https://github.com/apache/skywalking-client-js/pull/95 1.new repo PR to change the npm ci -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [skywalking-client-js] vihoyau commented on a diff in pull request #94: support to "import ClientMonitor from 'skywalking-client-js'" in "typescript" and "es6"

2022-09-02 Thread GitBox
vihoyau commented on code in PR #94: URL: https://github.com/apache/skywalking-client-js/pull/94#discussion_r961390460 ## .github/workflows/build.yml: ## @@ -34,9 +34,9 @@ jobs: uses: actions/setup-node@v1 with: node-version: ${{ matrix.node-version }} -

[skywalking] branch 9.2.0-master-tlsnoverify updated: revert

2022-09-02 Thread tanjian
This is an automated email from the ASF dual-hosted git repository. tanjian pushed a commit to branch 9.2.0-master-tlsnoverify in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/9.2.0-master-tlsnoverify by this push: new

[GitHub] [skywalking] yswdqz commented on issue #9548: [Feature] Monitoring MySQL's Slow SQL

2022-09-02 Thread GitBox
yswdqz commented on issue #9548: URL: https://github.com/apache/skywalking/issues/9548#issuecomment-1235182081 The ID is generate by traceId and spanId, such as following: ``` slowStatementBuilder.setId(segmentObject.getTraceSegmentId() + "-" + span.getSpanId()); ``` -- This is

[GitHub] [skywalking] wu-sheng commented on issue #9548: [Feature] Monitoring MySQL's Slow SQL

2022-09-02 Thread GitBox
wu-sheng commented on issue #9548: URL: https://github.com/apache/skywalking/issues/9548#issuecomment-1235179918 For the trace ID , I don't think you would have that. ID should be encoded in the TopNDatabaseStatement, could you check the source codes? -- This is an automated message

[GitHub] [skywalking-client-js] wu-sheng commented on a diff in pull request #94: support to "import ClientMonitor from 'skywalking-client-js'" in "typescript" and "es6"

2022-09-02 Thread GitBox
wu-sheng commented on code in PR #94: URL: https://github.com/apache/skywalking-client-js/pull/94#discussion_r961383334 ## .github/workflows/build.yml: ## @@ -34,9 +34,9 @@ jobs: uses: actions/setup-node@v1 with: node-version: ${{ matrix.node-version }}

[GitHub] [skywalking] yswdqz commented on issue #9548: [Feature] Monitoring MySQL's Slow SQL

2022-09-02 Thread GitBox
yswdqz commented on issue #9548: URL: https://github.com/apache/skywalking/issues/9548#issuecomment-1235174722 What should I set the `traceId` and `Id` of the `TopNDatabaseStatement`? Followings are the log of MySQL: ``` mysqld, Version: 5.7.18 (MySQL Community Server (GPL)).

[GitHub] [skywalking-client-js] vihoyau commented on a diff in pull request #94: support to "import ClientMonitor from 'skywalking-client-js'" in "typescript" and "es6"

2022-09-02 Thread GitBox
vihoyau commented on code in PR #94: URL: https://github.com/apache/skywalking-client-js/pull/94#discussion_r961378230 ## .github/workflows/build.yml: ## @@ -34,9 +34,9 @@ jobs: uses: actions/setup-node@v1 with: node-version: ${{ matrix.node-version }} -

[GitHub] [skywalking-client-js] wu-sheng commented on a diff in pull request #94: support to "import ClientMonitor from 'skywalking-client-js'" in "typescript" and "es6"

2022-09-02 Thread GitBox
wu-sheng commented on code in PR #94: URL: https://github.com/apache/skywalking-client-js/pull/94#discussion_r961375523 ## .github/workflows/build.yml: ## @@ -34,9 +34,9 @@ jobs: uses: actions/setup-node@v1 with: node-version: ${{ matrix.node-version }}

[GitHub] [skywalking] wu-sheng commented on a diff in pull request #9551: Fix the wrong watch semantics in Kubernetes watchers

2022-09-02 Thread GitBox
wu-sheng commented on code in PR #9551: URL: https://github.com/apache/skywalking/pull/9551#discussion_r961352675 ## docs/en/changes/changes.md: ## @@ -5,7 +5,9 @@ OAP Server - +* Fix the wrong watch semantics in Kubernetes watchers, which causes heavy traffic to API

[GitHub] [skywalking] kezhenxu94 commented on pull request #9551: Fix the wrong watch semantics in Kubernetes watchers

2022-09-02 Thread GitBox
kezhenxu94 commented on PR #9551: URL: https://github.com/apache/skywalking/pull/9551#issuecomment-1235143659 Adding `don't merge` until I verified this fixes the cluster in problem (it's not easy to reproduce  ) -- This is an automated message from the Apache Git Service. To respond

[GitHub] [skywalking] kezhenxu94 opened a new pull request, #9551: Fix the wrong watch semantics in Kubernetes watchers

2022-09-02 Thread GitBox
kezhenxu94 opened a new pull request, #9551: URL: https://github.com/apache/skywalking/pull/9551 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [x] Update the [`CHANGES`

[skywalking] branch 9.2.0-master-tlsnoverify created (now d42c7e29d7)

2022-09-02 Thread tanjian
This is an automated email from the ASF dual-hosted git repository. tanjian pushed a change to branch 9.2.0-master-tlsnoverify in repository https://gitbox.apache.org/repos/asf/skywalking.git at d42c7e29d7 Merge branch 'master' of https://github.com/apache/skywalking This branch

[skywalking] 01/02: tls insecure host verify

2022-09-02 Thread tanjian
This is an automated email from the ASF dual-hosted git repository. tanjian pushed a commit to branch 9.2.0-master-tlsnoverify in repository https://gitbox.apache.org/repos/asf/skywalking.git commit 8efcf8a3457c575d6092bbe6cad6fb76d3182a0a Author: jian.tan AuthorDate: Wed Jun 8 14:17:19 2022

[skywalking] 02/02: Merge branch 'master' of https://github.com/apache/skywalking

2022-09-02 Thread tanjian
This is an automated email from the ASF dual-hosted git repository. tanjian pushed a commit to branch 9.2.0-master-tlsnoverify in repository https://gitbox.apache.org/repos/asf/skywalking.git commit d42c7e29d79844bb1da32409c431efc607357ce8 Merge: 8efcf8a345 097a9e8706 Author: jian.tan

[GitHub] [skywalking-client-js] vihoyau commented on pull request #94: support to "import ClientMonitor from 'skywalking-client-js'" in "typescript" and "es6"

2022-09-02 Thread GitBox
vihoyau commented on PR #94: URL: https://github.com/apache/skywalking-client-js/pull/94#issuecomment-1235122462 i fork repo anew , it‘s error when take a command "npm install " . because the webpack version. 12.xx is ok. -- This is an automated message from the Apache Git

[GitHub] [skywalking-python] Superskyyy merged pull request #232: style: deal with B024 added to flake8 recently

2022-09-02 Thread GitBox
Superskyyy merged PR #232: URL: https://github.com/apache/skywalking-python/pull/232 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[skywalking-python] branch master updated: style: deal with B024 added to flake8 recently (#232)

2022-09-02 Thread yihaochen
This is an automated email from the ASF dual-hosted git repository. yihaochen pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-python.git The following commit(s) were added to refs/heads/master by this push: new 91a45ce style: deal with B024