[GitHub] [skywalking] sonatype-lift[bot] commented on pull request #9780: Optimize the query time of tasks in ProfileTaskCache

2022-10-12 Thread GitBox
sonatype-lift[bot] commented on PR #9780: URL: https://github.com/apache/skywalking/pull/9780#issuecomment-1277038951 :warning: **6 God Classes** were detected by Lift in this project. [Visit the Lift web console](https://lift.sonatype.com/results/github.com/apache/skywalking/01GF7SKC6QG5KW

[GitHub] [skywalking] kezhenxu94 commented on a diff in pull request #9775: Polish up APISIX metrics to follow Service concept

2022-10-12 Thread GitBox
kezhenxu94 commented on code in PR #9775: URL: https://github.com/apache/skywalking/pull/9775#discussion_r994132875 ## docs/en/setup/backend/backend-apisix-monitoring.md: ## @@ -13,33 +13,68 @@ SkyWalking leverages OpenTelemetry Collector to transfer the metrics to 2. Set up [

[GitHub] [skywalking-banyandb] codecov-commenter commented on pull request #189: Fixes some issues found by Java client updating

2022-10-12 Thread GitBox
codecov-commenter commented on PR #189: URL: https://github.com/apache/skywalking-banyandb/pull/189#issuecomment-1277021457 # [Codecov](https://codecov.io/gh/apache/skywalking-banyandb/pull/189?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[GitHub] [skywalking-banyandb] hanahmily opened a new pull request, #189: Fixes some issues found by Java client updating

2022-10-12 Thread GitBox
hanahmily opened a new pull request, #189: URL: https://github.com/apache/skywalking-banyandb/pull/189 These changes come from https://github.com/apache/skywalking-banyandb-java-client/pull/18 Signed-off-by: Gao Hongtao -- This is an automated message from the Apache Git Service.

[skywalking-banyandb] 01/01: Fixes some issues found by Java client

2022-10-12 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a commit to branch client in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git commit 8d6f1895657a1b4c2419a18686b621bbac6834f1 Author: Gao Hongtao AuthorDate: Thu Oct 13 04:27:49 2022 +

[skywalking-banyandb] branch client updated (5267d6c -> 8d6f189)

2022-10-12 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch client in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git discard 5267d6c Fixes some issues found by Java client new 8d6f189 Fixes some issues found by Java clie

[skywalking-banyandb] branch client created (now 5267d6c)

2022-10-12 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch client in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git at 5267d6c Fixes some issues found by Java client This branch includes the following new commits:

[skywalking-banyandb] 01/01: Fixes some issues found by Java client

2022-10-12 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a commit to branch client in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git commit 5267d6c13c2ef820c766cc551c371c2a82c8c823 Author: Gao Hongtao AuthorDate: Thu Oct 13 04:27:49 2022 +

[GitHub] [skywalking] xzyJavaX opened a new pull request, #9780: Optimize the query time of tasks in ProfileTaskCache

2022-10-12 Thread GitBox
xzyJavaX opened a new pull request, #9780: URL: https://github.com/apache/skywalking/pull/9780 - [x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #[9779](https://github.com/apache/skywalking/issues/9779) -

[GitHub] [skywalking] wu-sheng commented on issue #9779: [Bug] The profiling task did not work

2022-10-12 Thread GitBox
wu-sheng commented on issue #9779: URL: https://github.com/apache/skywalking/issues/9779#issuecomment-1276995862 This seems a race condition, and I believe this is a bug. FYI @mrproliu @xzyJavaX I think you are going to submit a patch to fix, right? -- This is an automated message

[GitHub] [skywalking] xzyJavaX opened a new issue, #9779: [Bug] The profiling task did not work

2022-10-12 Thread GitBox
xzyJavaX opened a new issue, #9779: URL: https://github.com/apache/skywalking/issues/9779 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar issues. ### Apache SkyWalking Component

[GitHub] [skywalking] pg-yang commented on a diff in pull request #9775: Polish up APISIX metrics to follow Service concept

2022-10-12 Thread GitBox
pg-yang commented on code in PR #9775: URL: https://github.com/apache/skywalking/pull/9775#discussion_r994031720 ## docs/en/setup/backend/backend-apisix-monitoring.md: ## @@ -13,33 +13,68 @@ SkyWalking leverages OpenTelemetry Collector to transfer the metrics to 2. Set up [Ope

[GitHub] [skywalking] pg-yang commented on pull request #9775: Polish up APISIX metrics to follow Service concept

2022-10-12 Thread GitBox
pg-yang commented on PR #9775: URL: https://github.com/apache/skywalking/pull/9775#issuecomment-1276915469 It's time to dinner . Hot pot is great > Do we need test updates due to endpoint format changed? Needn't , E2E only check whether endpoint has value rather than specif

[GitHub] [skywalking] wu-sheng commented on pull request #9775: Polish up APISIX metrics to follow Service concept

2022-10-12 Thread GitBox
wu-sheng commented on PR #9775: URL: https://github.com/apache/skywalking/pull/9775#issuecomment-1276913631 Do we need test updates due to endpoint format changed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [skywalking] wu-sheng commented on issue #9578: [Feature] Micrometer 1.10 Observation API support

2022-10-12 Thread GitBox
wu-sheng commented on issue #9578: URL: https://github.com/apache/skywalking/issues/9578#issuecomment-1276860900 > Have you deprecated that part or are you suggesting that we're deprecating it by using the new API? We are not deprecating anything. Is micrometer API unchanged? >

[GitHub] [skywalking] marcingrzejszczak commented on issue #9578: [Feature] Micrometer 1.10 Observation API support

2022-10-12 Thread GitBox
marcingrzejszczak commented on issue #9578: URL: https://github.com/apache/skywalking/issues/9578#issuecomment-1276537356 Hi! Since we're close to GA version of Micrometer (currently 1.10.0 GA is planned for 14.11 at the moment (https://github.com/micrometer-metrics/micrometer/milestone/177

[skywalking-website] branch asf-site updated: deploy: fefc71eb98a9aadc452887b8eb634373d3d39b34

2022-10-12 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/skywalking-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 23b8068e33 deploy: fefc71eb9

[skywalking] branch master updated (956a9ec973 -> e3ad2d094c)

2022-10-12 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git from 956a9ec973 Lazy load the Kubernetes metadata and switch from event-driven to polling (#9747) add e3ad2d094c

[GitHub] [skywalking] wu-sheng merged pull request #9778: Add more details on security notice

2022-10-12 Thread GitBox
wu-sheng merged PR #9778: URL: https://github.com/apache/skywalking/pull/9778 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

[skywalking-website] branch master updated: github buttons (#520)

2022-10-12 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-website.git The following commit(s) were added to refs/heads/master by this push: new fefc71eb98 github buttons (#520) fe

[GitHub] [skywalking-website] wu-sheng merged pull request #520: Update github-buttons in projects page

2022-10-12 Thread GitBox
wu-sheng merged PR #520: URL: https://github.com/apache/skywalking-website/pull/520 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubs

[GitHub] [skywalking-website] netlify[bot] commented on pull request #520: Update github-buttons in projects page

2022-10-12 Thread GitBox
netlify[bot] commented on PR #520: URL: https://github.com/apache/skywalking-website/pull/520#issuecomment-1276306952 ### 👷 Deploy Preview for *skywalking-website-preview* processing. | Name | Link | |-|| |🔨 Latest co

[GitHub] [skywalking] sonatype-lift[bot] commented on pull request #9778: Add more details on security notice

2022-10-12 Thread GitBox
sonatype-lift[bot] commented on PR #9778: URL: https://github.com/apache/skywalking/pull/9778#issuecomment-1276269940 :warning: **6 God Classes** were detected by Lift in this project. [Visit the Lift web console](https://lift.sonatype.com/results/github.com/apache/skywalking/01GF66VNE7857B

[GitHub] [skywalking] wu-sheng opened a new pull request, #9778: Add more details on security notice

2022-10-12 Thread GitBox
wu-sheng opened a new pull request, #9778: URL: https://github.com/apache/skywalking/pull/9778 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [ ] Update the [`CHANGES` log](https://github.com/apach

[skywalking] branch wu-sheng-patch-1 created (now ebcb33b1b8)

2022-10-12 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch wu-sheng-patch-1 in repository https://gitbox.apache.org/repos/asf/skywalking.git at ebcb33b1b8 Add more details on security notice This branch includes the following new commits: n

[skywalking] 01/01: Add more details on security notice

2022-10-12 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch wu-sheng-patch-1 in repository https://gitbox.apache.org/repos/asf/skywalking.git commit ebcb33b1b8b31dce514627bb62ed27c6703610c3 Author: 吴晟 Wu Sheng AuthorDate: Wed Oct 12 21:41:14 2022 +0800

[GitHub] [skywalking-website] wu-sheng closed pull request #516: Check contributors graph data

2022-10-12 Thread GitBox
wu-sheng closed pull request #516: Check contributors graph data URL: https://github.com/apache/skywalking-website/pull/516 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[skywalking-website] branch master updated: Check contributors graph data (#516)

2022-10-12 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-website.git The following commit(s) were added to refs/heads/master by this push: new 5362719265 Check contributors graph

[skywalking-php] branch master updated: Fix package.xml role error (#16)

2022-10-12 Thread jmjoy
This is an automated email from the ASF dual-hosted git repository. jmjoy pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-php.git The following commit(s) were added to refs/heads/master by this push: new b3d138a Fix package.xml role error (#16)

[GitHub] [skywalking-php] jmjoy merged pull request #16: Fix package.xml role error

2022-10-12 Thread GitBox
jmjoy merged PR #16: URL: https://github.com/apache/skywalking-php/pull/16 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@sky

[GitHub] [skywalking] wu-sheng opened a new issue, #9777: [Bug] [UI] Layout bugs of widget configuration page

2022-10-12 Thread GitBox
wu-sheng opened a new issue, #9777: URL: https://github.com/apache/skywalking/issues/9777 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar issues. ### Apache SkyWalking Component

[GitHub] [skywalking-banyandb-java-client] wu-sheng commented on pull request #18: Bump up proto files

2022-10-12 Thread GitBox
wu-sheng commented on PR #18: URL: https://github.com/apache/skywalking-banyandb-java-client/pull/18#issuecomment-1276032999 There should be some README doc update, right? We have some breaking changes in 0.2.0 APIs -- This is an automated message from the Apache Git Service. To respond

[GitHub] [skywalking] wu-sheng opened a new issue, #9776: [Feature] [UI] Support labeled value on the service/instance/endpoint table widget.

2022-10-12 Thread GitBox
wu-sheng opened a new issue, #9776: URL: https://github.com/apache/skywalking/issues/9776 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement. ### Description

[GitHub] [skywalking] wu-sheng commented on issue #9483: [Feature] Introduce a widget for metrics graph with summary table

2022-10-12 Thread GitBox
wu-sheng commented on issue #9483: URL: https://github.com/apache/skywalking/issues/9483#issuecomment-1276030457 When we use this labeled value, we should provide a policy such as `order by` + `top n` in the summary table. -- This is an automated message from the Apache Git Service. To re

[GitHub] [skywalking-banyandb-java-client] hanahmily opened a new pull request, #18: Bump up proto files

2022-10-12 Thread GitBox
hanahmily opened a new pull request, #18: URL: https://github.com/apache/skywalking-banyandb-java-client/pull/18 Fixes https://github.com/apache/skywalking/issues/9761 - [x] Update proto files - [x] Update related components - [ ] Update UTs - [ ] Update ITs Signed-off-

[GitHub] [skywalking] wu-sheng commented on issue #9483: [Feature] Introduce a widget for metrics graph with summary table

2022-10-12 Thread GitBox
wu-sheng commented on issue #9483: URL: https://github.com/apache/skywalking/issues/9483#issuecomment-1276029165 If this is for the single value type, this could be a configuration rather than a widget. The summary table is an attachment to activate. -- This is an automated message from t

[skywalking-banyandb-java-client] 01/01: Bump up proto files

2022-10-12 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a commit to branch v0.2.0 in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb-java-client.git commit c3ff3529f9edbb905ed0fe160dc54a8b44debc0c Author: Gao Hongtao AuthorDate: Wed Oct 12 19:45:2

[skywalking-banyandb-java-client] branch v0.2.0 created (now c3ff352)

2022-10-12 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch v0.2.0 in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb-java-client.git at c3ff352 Bump up proto files This branch includes the following new commits: new c

[GitHub] [skywalking] kezhenxu94 commented on a diff in pull request #9775: Polish up APISIX metrics to follow Service concept

2022-10-12 Thread GitBox
kezhenxu94 commented on code in PR #9775: URL: https://github.com/apache/skywalking/pull/9775#discussion_r993309917 ## oap-server/server-starter/src/main/resources/otel-rules/apisix.yaml: ## @@ -29,53 +29,72 @@ #"-P-6H+3M" -- parses as "+6 hours and -3 minutes" # filter

[GitHub] [skywalking-php] heyanlong commented on pull request #16: Fix package.xml role error

2022-10-12 Thread GitBox
heyanlong commented on PR #16: URL: https://github.com/apache/skywalking-php/pull/16#issuecomment-1275951671 @jmjoy Could you review it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [skywalking] wu-sheng commented on pull request #9775: Polish up APISIX metrics to follow Service concept

2022-10-12 Thread GitBox
wu-sheng commented on PR #9775: URL: https://github.com/apache/skywalking/pull/9775#issuecomment-1275932708 @pg-yang Let's continue without this. @Fine0830 Could we support labeled value? I suppose we need an issue to discuss how to show brief values if supported. -- This is an aut

[GitHub] [skywalking] pg-yang commented on pull request #9775: Polish up APISIX metrics to follow Service concept

2022-10-12 Thread GitBox
pg-yang commented on PR #9775: URL: https://github.com/apache/skywalking/pull/9775#issuecomment-1275927546 > upstream My metrics is labeled , and other similar ui-template is not labeled . Couldn't support labeled metrics ? -- This is an automated message from the Apache Gi

[GitHub] [skywalking] pg-yang commented on pull request #9775: Polish up APISIX metrics to follow Service concept

2022-10-12 Thread GitBox
pg-yang commented on PR #9775: URL: https://github.com/apache/skywalking/pull/9775#issuecomment-1275925133 > Sorry , Let's change to upstream -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [skywalking] wu-sheng commented on pull request #9775: Polish up APISIX metrics to follow Service concept

2022-10-12 Thread GitBox
wu-sheng commented on PR #9775: URL: https://github.com/apache/skywalking/pull/9775#issuecomment-1275921038 What do you mean? Isn't 172 a remote and upstream addr? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [skywalking-php] jmjoy opened a new pull request, #19: Add swoole support.

2022-10-12 Thread GitBox
jmjoy opened a new pull request, #19: URL: https://github.com/apache/skywalking-php/pull/19 Swoole is a popular coroutine library in PHP, so it is better to support swoole. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[skywalking-website] branch asf-site updated: deploy: 628b4c4792a7b26da415b39fb15750ab177e55c1

2022-10-12 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/skywalking-website.git The following commit(s) were added to refs/heads/asf-site by this push: new ca0068d5a7 deploy: 628b4c479

[GitHub] [skywalking] pg-yang commented on pull request #9775: Polish up APISIX metrics to follow Service concept

2022-10-12 Thread GitBox
pg-yang commented on PR #9775: URL: https://github.com/apache/skywalking/pull/9775#issuecomment-1275906805 > Is `upstream` better than `node`? Is the IP upstream addr? I have update the tile , keep default value . IP is apisix instance . ![image](https://user-images.githubuser

[GitHub] [skywalking] wu-sheng commented on pull request #9775: Polish up APISIX metrics to follow Service concept

2022-10-12 Thread GitBox
wu-sheng commented on PR #9775: URL: https://github.com/apache/skywalking/pull/9775#issuecomment-1275903782 Is `upstream` better than `node`? Is the IP upstream addr? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [skywalking] wu-sheng commented on pull request #9775: Polish up APISIX metrics to follow Service concept

2022-10-12 Thread GitBox
wu-sheng commented on PR #9775: URL: https://github.com/apache/skywalking/pull/9775#issuecomment-1275899610 Yes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[GitHub] [skywalking] pg-yang commented on pull request #9775: Polish up APISIX metrics to follow Service concept

2022-10-12 Thread GitBox
pg-yang commented on PR #9775: URL: https://github.com/apache/skywalking/pull/9775#issuecomment-1275895321 > Like this ? ![image](https://user-images.githubusercontent.com/3917424/195311048-a1986e7f-550d-44c4-9054-3c365f65c6e4.png) -- This is an automated message from the A

[GitHub] [skywalking] wu-sheng commented on pull request #9775: Polish up APISIX metrics to follow Service concept

2022-10-12 Thread GitBox
wu-sheng commented on PR #9775: URL: https://github.com/apache/skywalking/pull/9775#issuecomment-1275888635 One more suggestion, you could set metrics for endpoint list for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [skywalking] pg-yang commented on pull request #9775: Polish up APISIX metrics to follow Service concept

2022-10-12 Thread GitBox
pg-yang commented on PR #9775: URL: https://github.com/apache/skywalking/pull/9775#issuecomment-1275885838 > `route::` and `node::` should be updated as `route/` and `node/`. Because in ElasticSearch and BanyanDB search, it relies on word splitter, `/` is in that list, `::` is not. U

[GitHub] [skywalking] sonatype-lift[bot] commented on pull request #9775: Polish up APISIX metrics to follow Service concept

2022-10-12 Thread GitBox
sonatype-lift[bot] commented on PR #9775: URL: https://github.com/apache/skywalking/pull/9775#issuecomment-1275882176 :warning: **6 God Classes** were detected by Lift in this project. [Visit the Lift web console](https://lift.sonatype.com/results/github.com/apache/skywalking/01GF5PZ2Y9X6QP

[GitHub] [skywalking] wu-sheng commented on a diff in pull request #9775: Polish up APISIX metrics to follow Service concept

2022-10-12 Thread GitBox
wu-sheng commented on code in PR #9775: URL: https://github.com/apache/skywalking/pull/9775#discussion_r993224892 ## oap-server/server-starter/src/main/resources/otel-rules/apisix.yaml: ## @@ -29,53 +29,72 @@ #"-P-6H+3M" -- parses as "+6 hours and -3 minutes" # filter:

[GitHub] [skywalking] pg-yang commented on a diff in pull request #9775: Polish up APISIX metrics to follow Service concept

2022-10-12 Thread GitBox
pg-yang commented on code in PR #9775: URL: https://github.com/apache/skywalking/pull/9775#discussion_r993215438 ## oap-server/server-starter/src/main/resources/otel-rules/apisix.yaml: ## @@ -29,53 +29,72 @@ #"-P-6H+3M" -- parses as "+6 hours and -3 minutes" # filter: "

[GitHub] [skywalking] pg-yang commented on a diff in pull request #9775: Polish up APISIX metrics to follow Service concept

2022-10-12 Thread GitBox
pg-yang commented on code in PR #9775: URL: https://github.com/apache/skywalking/pull/9775#discussion_r993215438 ## oap-server/server-starter/src/main/resources/otel-rules/apisix.yaml: ## @@ -29,53 +29,72 @@ #"-P-6H+3M" -- parses as "+6 hours and -3 minutes" # filter: "

[GitHub] [skywalking] pg-yang commented on a diff in pull request #9775: Polish up APISIX metrics to follow Service concept

2022-10-12 Thread GitBox
pg-yang commented on code in PR #9775: URL: https://github.com/apache/skywalking/pull/9775#discussion_r993209306 ## docs/en/setup/backend/backend-apisix-monitoring.md: ## @@ -13,33 +13,68 @@ SkyWalking leverages OpenTelemetry Collector to transfer the metrics to 2. Set up [Ope

[GitHub] [skywalking] wu-sheng commented on a diff in pull request #9775: Polish up APISIX metrics to follow Service concept

2022-10-12 Thread GitBox
wu-sheng commented on code in PR #9775: URL: https://github.com/apache/skywalking/pull/9775#discussion_r993210557 ## docs/en/setup/backend/backend-apisix-monitoring.md: ## @@ -13,33 +13,68 @@ SkyWalking leverages OpenTelemetry Collector to transfer the metrics to 2. Set up [Op

[GitHub] [skywalking] wu-sheng commented on a diff in pull request #9775: Polish up APISIX metrics to follow Service concept

2022-10-12 Thread GitBox
wu-sheng commented on code in PR #9775: URL: https://github.com/apache/skywalking/pull/9775#discussion_r993207362 ## docs/en/setup/backend/backend-apisix-monitoring.md: ## @@ -13,33 +13,68 @@ SkyWalking leverages OpenTelemetry Collector to transfer the metrics to 2. Set up [Op

[GitHub] [skywalking] wu-sheng commented on a diff in pull request #9775: Polish up APISIX metrics to follow Service concept

2022-10-12 Thread GitBox
wu-sheng commented on code in PR #9775: URL: https://github.com/apache/skywalking/pull/9775#discussion_r993208566 ## oap-server/server-starter/src/main/resources/otel-rules/apisix.yaml: ## @@ -29,53 +29,72 @@ #"-P-6H+3M" -- parses as "+6 hours and -3 minutes" # filter:

[GitHub] [skywalking] wu-sheng commented on a diff in pull request #9775: Polish up APISIX metrics to follow Service concept

2022-10-12 Thread GitBox
wu-sheng commented on code in PR #9775: URL: https://github.com/apache/skywalking/pull/9775#discussion_r993207362 ## docs/en/setup/backend/backend-apisix-monitoring.md: ## @@ -13,33 +13,68 @@ SkyWalking leverages OpenTelemetry Collector to transfer the metrics to 2. Set up [Op

[GitHub] [skywalking] wu-sheng commented on a diff in pull request #9775: Polish up APISIX metrics to follow Service concept

2022-10-12 Thread GitBox
wu-sheng commented on code in PR #9775: URL: https://github.com/apache/skywalking/pull/9775#discussion_r993206827 ## docs/en/setup/backend/backend-apisix-monitoring.md: ## @@ -13,33 +13,68 @@ SkyWalking leverages OpenTelemetry Collector to transfer the metrics to 2. Set up [Op

[GitHub] [skywalking] wu-sheng commented on a diff in pull request #9775: Polish up APISIX metrics to follow Service concept

2022-10-12 Thread GitBox
wu-sheng commented on code in PR #9775: URL: https://github.com/apache/skywalking/pull/9775#discussion_r993206317 ## docs/en/setup/backend/backend-apisix-monitoring.md: ## @@ -13,33 +13,68 @@ SkyWalking leverages OpenTelemetry Collector to transfer the metrics to 2. Set up [Op

[GitHub] [skywalking] wu-sheng commented on a diff in pull request #9775: Polish up APISIX metrics to follow Service concept

2022-10-12 Thread GitBox
wu-sheng commented on code in PR #9775: URL: https://github.com/apache/skywalking/pull/9775#discussion_r993204651 ## docs/en/setup/backend/backend-apisix-monitoring.md: ## @@ -13,33 +13,68 @@ SkyWalking leverages OpenTelemetry Collector to transfer the metrics to 2. Set up [Op

[GitHub] [skywalking] wu-sheng commented on a diff in pull request #9775: Polish up APISIX metrics to follow Service concept

2022-10-12 Thread GitBox
wu-sheng commented on code in PR #9775: URL: https://github.com/apache/skywalking/pull/9775#discussion_r993204004 ## docs/en/setup/backend/backend-apisix-monitoring.md: ## @@ -13,33 +13,68 @@ SkyWalking leverages OpenTelemetry Collector to transfer the metrics to 2. Set up [Op

[GitHub] [skywalking] pg-yang commented on a diff in pull request #9775: Polish up APISIX metrics to follow Service concept

2022-10-12 Thread GitBox
pg-yang commented on code in PR #9775: URL: https://github.com/apache/skywalking/pull/9775#discussion_r993201668 ## oap-server/server-starter/src/main/resources/otel-rules/apisix.yaml: ## @@ -29,53 +29,72 @@ #"-P-6H+3M" -- parses as "+6 hours and -3 minutes" # filter: "

[GitHub] [skywalking] wu-sheng commented on pull request #9775: Polish up APISIX metrics to follow Service concept

2022-10-12 Thread GitBox
wu-sheng commented on PR #9775: URL: https://github.com/apache/skywalking/pull/9775#issuecomment-1275837794 `route::` and `node::` should be updated as `route/` and `node/`. Because in ElasticSearch and BanyanDB search, it relies on word splitter, `/` is in that list, `::` is not. -- Th

[GitHub] [skywalking] pg-yang commented on pull request #9775: Polish up APISIX metrics to follow Service concept

2022-10-12 Thread GitBox
pg-yang commented on PR #9775: URL: https://github.com/apache/skywalking/pull/9775#issuecomment-1275834984 ![image](https://user-images.githubusercontent.com/3917424/195299988-ec88ad5c-d12b-4aba-a796-890cad8e3fb8.png) ![image](https://user-images.githubusercontent.com/3917424/1953000

[GitHub] [skywalking] pg-yang opened a new pull request, #9775: Polish up APISIX metrics to follow Service concept

2022-10-12 Thread GitBox
pg-yang opened a new pull request, #9775: URL: https://github.com/apache/skywalking/pull/9775 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [ ] Update the [`CHANGES` log](https://github.com/apache

[skywalking-website] branch master updated: Update team page (#519)

2022-10-12 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-website.git The following commit(s) were added to refs/heads/master by this push: new 628b4c4792 Update team page (#519)

[GitHub] [skywalking-website] wu-sheng merged pull request #519: Update commiter list

2022-10-12 Thread GitBox
wu-sheng merged PR #519: URL: https://github.com/apache/skywalking-website/pull/519 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubs

[GitHub] [skywalking-showcase] pg-yang commented on pull request #83: add apisix case

2022-10-12 Thread GitBox
pg-yang commented on PR #83: URL: https://github.com/apache/skywalking-showcase/pull/83#issuecomment-1275746888 > I mean, we should whether tag[service name] exists, if not, MAL should fill in one, rather than keeping a blank name. Got It ,and you have repeated it many times

[GitHub] [skywalking-website] netlify[bot] commented on pull request #519: Update commiter list

2022-10-12 Thread GitBox
netlify[bot] commented on PR #519: URL: https://github.com/apache/skywalking-website/pull/519#issuecomment-1275742269 ### 👷 Deploy Preview for *skywalking-website-preview* processing. | Name | Link | |-|| |🔨 Latest co

[skywalking-website] branch master updated: Add new committer.

2022-10-12 Thread yswdqz
This is an automated email from the ASF dual-hosted git repository. yswdqz pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-website.git The following commit(s) were added to refs/heads/master by this push: new 2960afa1e5 Add new committer. 2960af

[GitHub] [skywalking-showcase] wu-sheng commented on pull request #83: add apisix case

2022-10-12 Thread GitBox
wu-sheng commented on PR #83: URL: https://github.com/apache/skywalking-showcase/pull/83#issuecomment-1275698505 > You mean we should check the tag at uniform place rather than respective MAL ? And I check the tag in my OAL I mean, we should whether tag[service name] exists, if not,

[GitHub] [skywalking-showcase] pg-yang commented on pull request #83: add apisix case

2022-10-12 Thread GitBox
pg-yang commented on PR #83: URL: https://github.com/apache/skywalking-showcase/pull/83#issuecomment-1275695324 > We should check whether this tag exists, if not, we could fill in a default value(Irrelavent from your case) You mean we should check the tag at uniform place rather than

[GitHub] [skywalking-showcase] wu-sheng commented on pull request #83: add apisix case

2022-10-12 Thread GitBox
wu-sheng commented on PR #83: URL: https://github.com/apache/skywalking-showcase/pull/83#issuecomment-1275692148 About the `1`, I have feeling that, this is made by empty service name, then the decode get this strange thing. -- This is an automated message from the Apache Git Service. To

[GitHub] [skywalking-showcase] wu-sheng commented on pull request #83: add apisix case

2022-10-12 Thread GitBox
wu-sheng commented on PR #83: URL: https://github.com/apache/skywalking-showcase/pull/83#issuecomment-1275687313 I see. We should check whether this tag exists, if not, we could fill in a default value(Irrelavent from your case) -- This is an automated message from the Apache Git Service