kezhenxu94 commented on PR #10382:
URL: https://github.com/apache/skywalking/pull/10382#issuecomment-1427505616
> Maven profile could be activated based on JDK version. Does it help your
case to inject compiler parameters? Such as through a property value.
>
> ```
>
> jdk-ver
wu-sheng commented on issue #10341:
URL: https://github.com/apache/skywalking/issues/10341#issuecomment-1427508468
Are you considering this too complex? In the transfer process, you should be
able to hardcode most of them, right?
> it will replace the key
Tag key is static and
mikechengwei commented on code in PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#discussion_r1104112643
##
.github/workflows/skywalking.yaml:
##
@@ -662,6 +662,8 @@ jobs:
config: test/e2e-v2/cases/virtual-mq/e2e.yaml
- name: AWS Cloud EKS
mufiye commented on issue #10341:
URL: https://github.com/apache/skywalking/issues/10341#issuecomment-1427519864
> Are you considering this too complex? In the transfer process, you should
be able to hardcode most of them, right?
>
> > it will replace the key
I think I just say
mufiye commented on issue #10341:
URL: https://github.com/apache/skywalking/issues/10341#issuecomment-1427521436
> replace_match would change everything, it may not be a good one. `Split`
should be good. You should have an expression to get the array and then use the
index.
>
> And I
kezhenxu94 commented on PR #10382:
URL: https://github.com/apache/skywalking/pull/10382#issuecomment-1427531861
OK I think I can remove some of the original profiles as they are always
activated by default, now I can add JDK profile, let's see
--
This is an automated message from the Apac
wu-sheng commented on PR #10382:
URL: https://github.com/apache/skywalking/pull/10382#issuecomment-1427532944
> I know that, but it is not worth to do this as we don't plan to support
both java 8 and java 17, I mean we should have only one recommended development
JDK version, right?
wu-sheng commented on issue #10341:
URL: https://github.com/apache/skywalking/issues/10341#issuecomment-1427536236
We could use this(replace ConvertCase to another function) to set the metric
name without parameter.
```
metrics:
set(metric.name, ConvertCase(metric.name, "snake
kezhenxu94 commented on PR #10382:
URL: https://github.com/apache/skywalking/pull/10382#issuecomment-1427539360
> isn't it automatically picked up in different JDK versions? I am guessing,
but otherwise, what is the point of this configuration.
It's automatically picked up, but the ot
wu-sheng commented on PR #10382:
URL: https://github.com/apache/skywalking/pull/10382#issuecomment-1427540078
OK, I see the point now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
wu-sheng commented on code in PR #10382:
URL: https://github.com/apache/skywalking/pull/10382#discussion_r1104151003
##
pom.xml:
##
@@ -33,6 +33,10 @@
apm-protocol
+oap-server
+oap-server-bom
+apm-webapp
+apm-dist
Review Comment:
kezhenxu94 commented on code in PR #10382:
URL: https://github.com/apache/skywalking/pull/10382#discussion_r1104154979
##
pom.xml:
##
@@ -33,6 +33,10 @@
apm-protocol
+oap-server
+oap-server-bom
+apm-webapp
+apm-dist
Review Commen
mufiye commented on issue #10341:
URL: https://github.com/apache/skywalking/issues/10341#issuecomment-1427561102
> We could use this(replace ConvertCase to another function) to set the
metric name without parameter.
>
> ```
> metrics:
> set(metric.name, ConvertCase(metric.name
kezhenxu94 commented on PR #10382:
URL: https://github.com/apache/skywalking/pull/10382#issuecomment-1427563601
I also remove the `backend`, `ui` profiles, we seldom rely on those two
profiles, and if users want to only package backend or UI module, there are a
bunch of maven-way to do that
wu-sheng commented on issue #10341:
URL: https://github.com/apache/skywalking/issues/10341#issuecomment-1427567635
From OTEL perspective, I think you only have to do is splitting
`local_task_job.task_exit` as metric
name with all other things as a parameter tag.
Because on the OAP s
wu-sheng commented on PR #10382:
URL: https://github.com/apache/skywalking/pull/10382#issuecomment-1427570118
> I also remove the `backend`, `ui` profiles, we seldom rely on those two
profiles, and if users want to only package backend or UI module, there are a
bunch of maven-way to do that
kezhenxu94 commented on PR #10382:
URL: https://github.com/apache/skywalking/pull/10382#issuecomment-1427579697
> > I also remove the `backend`, `ui` profiles, we seldom rely on those two
profiles, and if users want to only package backend or UI module, there are a
bunch of maven-way to do
wu-sheng commented on PR #10382:
URL: https://github.com/apache/skywalking/pull/10382#issuecomment-1427588939
> > > I also remove the `backend`, `ui` profiles, we seldom rely on those
two profiles, and if users want to only package backend or UI module, there are
a bunch of maven-way to do
devkanro commented on PR #453:
URL: https://github.com/apache/skywalking-java/pull/453#issuecomment-1427606581
Yes, at present we have three ways to go.
1. Merge this PR directly, revert #451
2. Use SPI to register `CoroutineExceptionHandler`, we can handle uncaught
exceptions in coro
devkanro commented on PR #453:
URL: https://github.com/apache/skywalking-java/pull/453#issuecomment-1427613733
`CoroutineExceptionHandler` can only handle uncaught exceptions, and when
other `CoroutineExceptionHandler` is registered in the coroutine context, the
`CoroutineExceptionHandler
devkanro commented on PR #453:
URL: https://github.com/apache/skywalking-java/pull/453#issuecomment-1427620161
For me, I may adopt method 2. It is the highest priority for me to make the
plug-in more in line with the kotlin design specification, which means that our
plug-in is stable, effic
wu-sheng commented on PR #453:
URL: https://github.com/apache/skywalking-java/pull/453#issuecomment-1427622743
> `CoroutineExceptionHandler` can only handle uncaught exceptions, and when
other `CoroutineExceptionHandler` is registered in the coroutine context, the
`CoroutineExceptionHandl
kezhenxu94 commented on PR #10382:
URL: https://github.com/apache/skywalking/pull/10382#issuecomment-1427633179
> Right now, in ./mvnw -f oap-server/pom.xml package case, how maven could
know this? I feel UI would be recompiled again too, as it is on the module list.
Hi, you can trans
kezhenxu94 commented on PR #10382:
URL: https://github.com/apache/skywalking/pull/10382#issuecomment-1427635065
Well, things become complex now, there are profiles inside `apm-dist`
module...
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
zhaidw opened a new issue, #10386:
URL: https://github.com/apache/skywalking/issues/10386
### Search before asking
- [X] I had searched in the
[issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no
similar feature requirement.
### Description
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/skywalking-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new 47cce6236cd deploy: 3c6cd23c
wu-sheng commented on issue #10386:
URL: https://github.com/apache/skywalking/issues/10386#issuecomment-1427671916
It is supported and will be in next release.
But noticet we don't respond for feature request. As a community, features
exist when someone contributed.
--
This is an autom
wu-sheng closed issue #10386: [Feature] request skywalking-agent support for
servlet5.0+ for springboot3 projects
URL: https://github.com/apache/skywalking/issues/10386
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
kezhenxu94 commented on PR #10382:
URL: https://github.com/apache/skywalking/pull/10382#issuecomment-1427691276
I've run out of ideas, just reverted back the changes, currently only Java 8
is supported out of the box.
--
This is an automated message from the Apache Git Service.
To respond
wu-sheng merged PR #10382:
URL: https://github.com/apache/skywalking/pull/10382
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr..
devkanro commented on PR #453:
URL: https://github.com/apache/skywalking-java/pull/453#issuecomment-1427748537
SPI is not available in agent code because of their classloader hierarchy.
Maybe we should drop this feature.
--
This is an automated message from the Apache Git Service.
T
wu-sheng commented on PR #453:
URL: https://github.com/apache/skywalking-java/pull/453#issuecomment-1427808555
Please update changlog to revert previous change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch jdk11-outofbox
in repository https://gitbox.apache.org/repos/asf/skywalking.git
commit 8830382aea6b0b9aaaee588e254828b508a46b74
Author: Wu Sheng
AuthorDate: Mon Feb 13 21:05:27 2023 +0800
S
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a change to branch jdk11-outofbox
in repository https://gitbox.apache.org/repos/asf/skywalking.git
at 8830382aea Support JDK 11/17 test out of box.
This branch includes the following new commits:
new
wu-sheng opened a new pull request, #10387:
URL: https://github.com/apache/skywalking/pull/10387
- [ ] If this pull request closes/resolves/fixes an existing issue, replace
the issue number. Closes #.
- [ ] Update the [`CHANGES`
log](https://github.com/apa
wu-sheng commented on PR #10387:
URL: https://github.com/apache/skywalking/pull/10387#issuecomment-1427929353
After this change, I run `./mvnw clean package -Pbackend,dist` both on JDK 8
and 17. Both passed.
--
This is an automated message from the Apache Git Service.
To respond to the m
wu-sheng closed pull request #10387: Support JDK 11/17 test out of box.
URL: https://github.com/apache/skywalking/pull/10387
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
wu-sheng commented on code in PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#discussion_r1104572888
##
test/e2e-v2/cases/win/eks-cases.yaml:
##
@@ -18,11 +18,7 @@
cases:
- query: swctl --display yaml
--base-url=http://${oap_host}:${oap_12800}/graphql se
wu-sheng commented on code in PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#discussion_r1104573507
##
test/e2e-v2/cases/win/mock-data/otel-mock-metrics.json:
##
@@ -6,7 +6,7 @@
{
"key": "service.name",
"value": {
-
wu-sheng commented on code in PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#discussion_r1104574917
##
test/e2e-v2/cases/win/eks-cases.yaml:
##
@@ -18,11 +18,7 @@
cases:
- query: swctl --display yaml
--base-url=http://${oap_host}:${oap_12800}/graphql se
wu-sheng commented on code in PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#discussion_r1104580424
##
test/e2e-v2/cases/win/e2e.yaml:
##
@@ -0,0 +1,44 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. S
mikechengwei commented on code in PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#discussion_r1104606109
##
test/e2e-v2/cases/win/eks-cases.yaml:
##
@@ -18,11 +18,7 @@
cases:
- query: swctl --display yaml
--base-url=http://${oap_host}:${oap_12800}/graphq
wu-sheng commented on code in PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#discussion_r1104610089
##
test/e2e-v2/cases/win/e2e.yaml:
##
@@ -0,0 +1,44 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. S
mikechengwei commented on code in PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#discussion_r1104699813
##
test/e2e-v2/cases/win/mock-data/otel-mock-metrics.json:
##
@@ -6,7 +6,7 @@
{
"key": "service.name",
"value": {
-
Superskyyy commented on PR #282:
URL:
https://github.com/apache/skywalking-python/pull/282#issuecomment-1428354941
@SheltonZSL Please resolve the conflict by accepting all changes in the
master branch? Tony's pr added dependency so this file has to be his version.
--
This is an automate
SheltonZSL commented on PR #282:
URL:
https://github.com/apache/skywalking-python/pull/282#issuecomment-1428452324
Ok, thank you for reminding me. I have resolved the conflict.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
wu-sheng commented on PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#issuecomment-1428880452
Your tests are still failing. Why don't you verify before submitting the
changes? I can't see the point we keep eyes on a PR of keeping updated but
failing.
--
This is an automat
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch sycn
in repository https://gitbox.apache.org/repos/asf/skywalking.git
commit 141fd57f8139aad93244a8c821eb15be1a91c302
Author: Wu Sheng
AuthorDate: Tue Feb 14 08:18:26 2023 +0800
Sync UI to
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a change to branch sycn
in repository https://gitbox.apache.org/repos/asf/skywalking.git
at 141fd57f81 Sync UI to the latest.
This branch includes the following new commits:
new 141fd57f81 Sync UI to
wu-sheng opened a new pull request, #10388:
URL: https://github.com/apache/skywalking/pull/10388
- [ ] If this pull request closes/resolves/fixes an existing issue, replace
the issue number. Closes #.
- [x] Update the [`CHANGES`
log](https://github.com/apa
Superskyyy merged PR #282:
URL: https://github.com/apache/skywalking-python/pull/282
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsub
wu-sheng merged PR #10388:
URL: https://github.com/apache/skywalking/pull/10388
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr..
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git
The following commit(s) were added to refs/heads/master by this push:
new ff94cfc4e3 Sync UI to the latest. (#10388)
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/skywalking-showcase.git
The following commit(s) were added to refs/heads/main by this push:
new 8bca9af Bump up OAP and UI versions
8
mikechengwei commented on PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#issuecomment-1428987944
> Your tests are still failing. Why don't you verify before submitting the
changes? I can't see the point we keep eyes on a PR of keeping updated but
failing.
I thought t
wu-sheng commented on PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#issuecomment-1428990483
The tests fail due to the expected data not match your mock data.
Try it on a Mac or Linux. It is easy to run.
--
This is an automated message from the Apache Git Service.
To re
wu-sheng commented on code in PR #453:
URL: https://github.com/apache/skywalking-java/pull/453#discussion_r1105255413
##
CHANGES.md:
##
@@ -12,8 +12,9 @@ Release Notes.
* Remove Powermock entirely from the test cases.
* Fix H2 instrumentation point
* Refactor pipeline in jedi
wu-sheng commented on code in PR #453:
URL: https://github.com/apache/skywalking-java/pull/453#discussion_r1105257592
##
CHANGES.md:
##
@@ -12,8 +12,9 @@ Release Notes.
* Remove Powermock entirely from the test cases.
* Fix H2 instrumentation point
* Refactor pipeline in jedi
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch sycn
in repository https://gitbox.apache.org/repos/asf/skywalking.git
commit 34939991595319234ddc896210defb2270e5a89d
Author: Wu Sheng
AuthorDate: Tue Feb 14 11:43:03 2023 +0800
Sync UI
---
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a change to branch sycn
in repository https://gitbox.apache.org/repos/asf/skywalking.git
at 3493999159 Sync UI
This branch includes the following new commits:
new 3493999159 Sync UI
The 1 revisions l
wu-sheng opened a new pull request, #10389:
URL: https://github.com/apache/skywalking/pull/10389
- [ ] If this pull request closes/resolves/fixes an existing issue, replace
the issue number. Closes #.
- [ ] Update the [`CHANGES`
log](https://github.com/apa
wu-sheng merged PR #10389:
URL: https://github.com/apache/skywalking/pull/10389
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr..
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git
The following commit(s) were added to refs/heads/master by this push:
new dbf4e864a2 Sync UI (#10389)
dbf4e864a2 is d
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/skywalking-showcase.git
The following commit(s) were added to refs/heads/main by this push:
new ed5af7d Bump up versions
ed5af7d is d
Fine0830 opened a new pull request, #233:
URL: https://github.com/apache/skywalking-booster-ui/pull/233
Optimize the attached events visualization in the trace widget.
Signed-off-by: Qiuxia Fan
--
This is an automated message from the Apache Git Service.
To respond to the messa
kezhenxu94 opened a new pull request, #10390:
URL: https://github.com/apache/skywalking/pull/10390
- [ ] If this pull request closes/resolves/fixes an existing issue, replace
the issue number. Closes #.
- [ ] Update the [`CHANGES`
log](https://github.com/a
devkanro commented on PR #453:
URL: https://github.com/apache/skywalking-java/pull/453#issuecomment-1429203619
Should I delete prev PR change log?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
This is an automated email from the ASF dual-hosted git repository.
yihaochen pushed a change to branch fix-oracle-url-parser
in repository https://gitbox.apache.org/repos/asf/skywalking-java.git
at 15eb941956 Fix oracle url parser missed case
This branch includes the following new commit
This is an automated email from the ASF dual-hosted git repository.
yihaochen pushed a commit to branch fix-oracle-url-parser
in repository https://gitbox.apache.org/repos/asf/skywalking-java.git
commit 15eb9419567f16ea351428bfae62381308f045eb
Author: Superskyyy
AuthorDate: Tue Feb 14 01:57:45 2
mrproliu commented on PR #233:
URL:
https://github.com/apache/skywalking-booster-ui/pull/233#issuecomment-1429223671
This looks great. I have two suggestions:
1. Can we change the time view on the right to match the view in the trace,
so that users can easily see the start and end times
This is an automated email from the ASF dual-hosted git repository.
yihaochen pushed a commit to branch fix-oracle-url-parser
in repository https://gitbox.apache.org/repos/asf/skywalking-java.git
The following commit(s) were added to refs/heads/fix-oracle-url-parser by this
push:
new 128f1
Superskyyy opened a new pull request, #456:
URL: https://github.com/apache/skywalking-java/pull/456
According to a user report from QQ group, when SID is not given instead of
/service, the parser ignores the provided port. Previous test was
flawed.
Fine0830 commented on PR #233:
URL:
https://github.com/apache/skywalking-booster-ui/pull/233#issuecomment-1429242692
> This looks great. I have two suggestions:
>
> 1. Can we change the time view on the right to match the view in the
trace, so that users can easily see the start and
wu-sheng commented on PR #10390:
URL: https://github.com/apache/skywalking/pull/10390#issuecomment-1429245011
So, if there is a test with tag, it won't run by default?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
wu-sheng commented on PR #233:
URL:
https://github.com/apache/skywalking-booster-ui/pull/233#issuecomment-1429249692
I think he means use that style, rather han moving in to trace page.
The key is showing the duration with order.
--
This is an automated message from the Apache Git Serv
devkanro opened a new pull request, #457:
URL: https://github.com/apache/skywalking-java/pull/457
# What's Changed?
1. Modify the Instrumentation point to the `build` function for server
builder, it can make sure the tracing interceptor has been added as latest
interceptor which been cal
mrproliu commented on PR #233:
URL:
https://github.com/apache/skywalking-booster-ui/pull/233#issuecomment-1429255175
I think he means use that style, rather han moving in to trace page.
> Yes.
--
This is an automated message from the Apache Git Service.
To respond to the m
Fine0830 commented on PR #233:
URL:
https://github.com/apache/skywalking-booster-ui/pull/233#issuecomment-1429261511
Trace graph? The events data is not a tree structure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
mrproliu commented on PR #233:
URL:
https://github.com/apache/skywalking-booster-ui/pull/233#issuecomment-1429268520
> Trace graph?
We only need the style on the right side of the trace.
> The events data is not a tree structure.
Yes, the events are only a list. we only
79 matches
Mail list logo
