[GitHub] [skywalking-client-js] wu-sheng merged pull request #108: build(deps): bump glob-parent, node-forge and webpack

2023-03-02 Thread via GitHub
wu-sheng merged PR #108: URL: https://github.com/apache/skywalking-client-js/pull/108 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [skywalking-client-js] Fine0830 opened a new pull request, #108: build(deps): bump glob-parent, node-forge and webpack

2023-03-02 Thread via GitHub
Fine0830 opened a new pull request, #108: URL: https://github.com/apache/skywalking-client-js/pull/108 Fixes https://github.com/apache/skywalking-client-js/security/dependabot/21 and https://github.com/apache/skywalking-client-js/security/dependabot/21 Signed-off-by: Qiuxia Fan

[GitHub] [skywalking-java] wu-sheng commented on pull request #466: fix tomcat-10x-plugin and add test case to support tomcat7.x-8.x-9.x

2023-03-02 Thread via GitHub
wu-sheng commented on PR #466: URL: https://github.com/apache/skywalking-java/pull/466#issuecomment-1453065925 What do these 201 and 204 mean actually? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [skywalking] FAWC438 commented on issue #10447: [Feature] Python agent performance enhancement with Confluent-Kafka

2023-03-02 Thread via GitHub
FAWC438 commented on issue #10447: URL: https://github.com/apache/skywalking/issues/10447#issuecomment-1453065348 HOWEVER, there is also a lot of serious bad news. First of all, uWSGI doesn't work at all, and according to trackback, I found that this is because of a segment error

[GitHub] [skywalking] kezhenxu94 commented on pull request #10476: Feature DCS supports global configuration

2023-03-02 Thread via GitHub
kezhenxu94 commented on PR #10476: URL: https://github.com/apache/skywalking/pull/10476#issuecomment-1453053739 I also suggest using a hardcoded key to represent global configs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [skywalking] FAWC438 commented on issue #10447: [Feature] Python agent performance enhancement with Confluent-Kafka

2023-03-02 Thread via GitHub
FAWC438 commented on issue #10447: URL: https://github.com/apache/skywalking/issues/10447#issuecomment-1453048524 Now I have some bad news and good news. The good news is that the performance improvement from confluent_kafka is substantial. Here are some of the results of my

[GitHub] [skywalking] wu-sheng commented on pull request #10476: Feature DCS supports global configuration

2023-03-02 Thread via GitHub
wu-sheng commented on PR #10476: URL: https://github.com/apache/skywalking/pull/10476#issuecomment-1453047382 Do you need a (default-config) as a hard coded key? Rather than putting things in the root? I feel the codes are more complex than I thought. -- This is an automated message

[GitHub] [skywalking] xlq20080808 opened a new pull request, #10476: Feature DCS supports global configuration

2023-03-02 Thread via GitHub
xlq20080808 opened a new pull request, #10476: URL: https://github.com/apache/skywalking/pull/10476 ### DCS supports global configuration - [ ] If this is non-trivial feature, paste the links/URLs to the design doc. - [ ] Update the documentation to include this new feature. - [x]

[GitHub] [skywalking-java] wu-sheng commented on a diff in pull request #466: fix tomcat-10x-plugin and add test case to support tomcat7.x-8.x-9.x

2023-03-02 Thread via GitHub
wu-sheng commented on code in PR #466: URL: https://github.com/apache/skywalking-java/pull/466#discussion_r1124026460 ## apm-sniffer/apm-sdk-plugin/tomcat-10x-plugin/src/main/java/org/apache/skywalking/apm/plugin/tomcat10x/TomcatInvokeInterceptor.java: ## @@ -82,9 +75,9 @@

[GitHub] [skywalking-java] zhaoxiaojie0415 commented on pull request #467: Fix thrift plugin generate duplicate traceid

2023-03-02 Thread via GitHub
zhaoxiaojie0415 commented on PR #467: URL: https://github.com/apache/skywalking-java/pull/467#issuecomment-1452961500 > > In thrift plugin,it generate span before sendBase method and stop this span after receiveBase. However, if an error occurs in sendBase method, this thrift-client span

[GitHub] [skywalking-java] lujiajing1126 commented on a diff in pull request #466: fix tomcat-10x-plugin and add test case to support tomcat7.x-8.x-9.x

2023-03-02 Thread via GitHub
lujiajing1126 commented on code in PR #466: URL: https://github.com/apache/skywalking-java/pull/466#discussion_r1124014585 ## apm-sniffer/apm-sdk-plugin/tomcat-10x-plugin/src/main/java/org/apache/skywalking/apm/plugin/tomcat10x/TomcatInvokeInterceptor.java: ## @@ -82,9 +75,9 @@

[GitHub] [skywalking-java] kezhenxu94 commented on a diff in pull request #466: fix tomcat-10x-plugin and add test case to support tomcat7.x-8.x-9.x

2023-03-02 Thread via GitHub
kezhenxu94 commented on code in PR #466: URL: https://github.com/apache/skywalking-java/pull/466#discussion_r1124011185 ## apm-sniffer/apm-sdk-plugin/tomcat-10x-plugin/src/main/java/org/apache/skywalking/apm/plugin/tomcat10x/TomcatInvokeInterceptor.java: ## @@ -82,9 +75,9 @@

[GitHub] [skywalking-java] kezhenxu94 commented on pull request #466: fix tomcat-10x-plugin and add test case to support tomcat7.x-8.x-9.x

2023-03-02 Thread via GitHub
kezhenxu94 commented on PR #466: URL: https://github.com/apache/skywalking-java/pull/466#issuecomment-1452944810 > > Somehow Spring 6 case fails? Could you recheck? > > The only issue I could find is that we expected `POST:/create` call returns status code 200, but in the actual data

[GitHub] [skywalking-java] lujiajing1126 commented on pull request #467: Fix thrift plugin generate duplicate traceid

2023-03-02 Thread via GitHub
lujiajing1126 commented on PR #467: URL: https://github.com/apache/skywalking-java/pull/467#issuecomment-1452928949 > In thrift plugin,it generate span before sendBase method and stop this span after receiveBase. However, if an error occurs in sendBase method, this thrift-client span will

[GitHub] [skywalking-java] lujiajing1126 commented on pull request #466: fix tomcat-10x-plugin and add test case to support tomcat7.x-8.x-9.x

2023-03-02 Thread via GitHub
lujiajing1126 commented on PR #466: URL: https://github.com/apache/skywalking-java/pull/466#issuecomment-1452922949 > Somehow Spring 6 case fails? Could you recheck? The only issue I could find is that we expected `POST:/create` call returns status code 200, but in the actual data is

[GitHub] [skywalking-cli] kezhenxu94 closed pull request #174: Bump github.com/Masterminds/goutils from 1.1.0 to 1.1.1

2023-03-02 Thread via GitHub
kezhenxu94 closed pull request #174: Bump github.com/Masterminds/goutils from 1.1.0 to 1.1.1 URL: https://github.com/apache/skywalking-cli/pull/174 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [skywalking-cli] dependabot[bot] commented on pull request #174: Bump github.com/Masterminds/goutils from 1.1.0 to 1.1.1

2023-03-02 Thread via GitHub
dependabot[bot] commented on PR #174: URL: https://github.com/apache/skywalking-cli/pull/174#issuecomment-1452755130 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor

[skywalking-python] branch envvar updated (dac30c8 -> 45ab81c)

2023-03-02 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch envvar in repository https://gitbox.apache.org/repos/asf/skywalking-python.git omit dac30c8 Fix wrong environment names in doc add 45ab81c Fix wrong environment names in doc This

[skywalking-cli] branch dependabot/go_modules/github.com/Masterminds/goutils-1.1.1 created (now d5397f3)

2023-03-02 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/go_modules/github.com/Masterminds/goutils-1.1.1 in repository https://gitbox.apache.org/repos/asf/skywalking-cli.git at d5397f3 Bump github.com/Masterminds/goutils from

[GitHub] [skywalking-cli] dependabot[bot] opened a new pull request, #174: Bump github.com/Masterminds/goutils from 1.1.0 to 1.1.1

2023-03-02 Thread via GitHub
dependabot[bot] opened a new pull request, #174: URL: https://github.com/apache/skywalking-cli/pull/174 Bumps [github.com/Masterminds/goutils](https://github.com/Masterminds/goutils) from 1.1.0 to 1.1.1. Release notes Sourced from

[GitHub] [skywalking-cli] wu-sheng merged pull request #173: Support continuous profiling related sub-commands

2023-03-02 Thread via GitHub
wu-sheng merged PR #173: URL: https://github.com/apache/skywalking-cli/pull/173 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[skywalking-cli] branch master updated: Support continuous profiling related command (#173)

2023-03-02 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-cli.git The following commit(s) were added to refs/heads/master by this push: new 838e222 Support continuous profiling

[GitHub] [skywalking-cli] mrproliu commented on pull request #173: Support continuous profiling related sub-commands

2023-03-02 Thread via GitHub
mrproliu commented on PR #173: URL: https://github.com/apache/skywalking-cli/pull/173#issuecomment-1452744923 Oh, update to the "scope", I typed the wrong word. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [skywalking-cli] wu-sheng commented on pull request #173: Support continuous profiling related sub-commands

2023-03-02 Thread via GitHub
wu-sheng commented on PR #173: URL: https://github.com/apache/skywalking-cli/pull/173#issuecomment-1452743325 > metrics: adopt the "range" parameter in the metrics-related sub-command. What do you mean `range`? I don't remember we changed metrics query GraphQL. -- This is an

[GitHub] [skywalking-cli] mrproliu commented on pull request #173: Support continuous profiling related sub-commands

2023-03-02 Thread via GitHub
mrproliu commented on PR #173: URL: https://github.com/apache/skywalking-cli/pull/173#issuecomment-1452721851 Yes, I have descript the commands in the PR description. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [skywalking-cli] wu-sheng commented on pull request #173: Support continuous profiling related sub-commands

2023-03-02 Thread via GitHub
wu-sheng commented on PR #173: URL: https://github.com/apache/skywalking-cli/pull/173#issuecomment-1452084421 Could you share what is the command(s) added here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [skywalking-python] Superskyyy commented on pull request #292: Fix wrong environment names in doc

2023-03-02 Thread via GitHub
Superskyyy commented on PR #292: URL: https://github.com/apache/skywalking-python/pull/292#issuecomment-1452072902 This doc is automatically generated. There must be a bug in the generator. I will check tomorrow. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [skywalking-java] wu-sheng commented on pull request #466: fix tomcat-10x-plugin and add test case to support tomcat7.x-8.x-9.x

2023-03-02 Thread via GitHub
wu-sheng commented on PR #466: URL: https://github.com/apache/skywalking-java/pull/466#issuecomment-1451940975 Somehow Spring 6 case fails? Could you recheck? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [skywalking-java] wu-sheng commented on a diff in pull request #467: Fix thrift plugin generate duplicate traceid

2023-03-02 Thread via GitHub
wu-sheng commented on code in PR #467: URL: https://github.com/apache/skywalking-java/pull/467#discussion_r1123054937 ## test/plugin/scenarios/thrift-scenario/support-version.list: ## @@ -17,3 +17,4 @@ 0.12.0 0.11.0 0.10.0 +0.9.3 Review Comment: From the test log,

[GitHub] [skywalking] mrproliu commented on a diff in pull request #10473: Support continuous profiling feature

2023-03-02 Thread via GitHub
mrproliu commented on code in PR #10473: URL: https://github.com/apache/skywalking/pull/10473#discussion_r1123048928 ##

[GitHub] [skywalking] wu-sheng commented on a diff in pull request #10473: Support continuous profiling feature

2023-03-02 Thread via GitHub
wu-sheng commented on code in PR #10473: URL: https://github.com/apache/skywalking/pull/10473#discussion_r1123045228 ##

[GitHub] [skywalking] mrproliu commented on a diff in pull request #10473: Support continuous profiling feature

2023-03-02 Thread via GitHub
mrproliu commented on code in PR #10473: URL: https://github.com/apache/skywalking/pull/10473#discussion_r1123040902 ##

[GitHub] [skywalking] mrproliu commented on pull request #10473: Support continuous profiling feature

2023-03-02 Thread via GitHub
mrproliu commented on PR #10473: URL: https://github.com/apache/skywalking/pull/10473#issuecomment-1451807129 > > I suppose `property`-related features may block due to #10442 > > Due to this, policy reading should be fail, right? > > @mrproliu Do we have e2e support for this?

[GitHub] [skywalking] mrproliu commented on a diff in pull request #10473: Support continuous profiling feature

2023-03-02 Thread via GitHub
mrproliu commented on code in PR #10473: URL: https://github.com/apache/skywalking/pull/10473#discussion_r1123035068 ##

[GitHub] [skywalking] wu-sheng commented on pull request #10473: Support continuous profiling feature

2023-03-02 Thread via GitHub
wu-sheng commented on PR #10473: URL: https://github.com/apache/skywalking/pull/10473#issuecomment-1451800962 > I suppose `property`-related features may block due to #10442 Due to this, policy reading should be fail, right? ___ @mrproliu Do we have e2e support for this? I

[GitHub] [skywalking] wu-sheng commented on a diff in pull request #10473: Support continuous profiling feature

2023-03-02 Thread via GitHub
wu-sheng commented on code in PR #10473: URL: https://github.com/apache/skywalking/pull/10473#discussion_r1123029324 ##

[GitHub] [skywalking-python] kezhenxu94 opened a new pull request, #292: Fix wrong environment names in doc

2023-03-02 Thread via GitHub
kezhenxu94 opened a new pull request, #292: URL: https://github.com/apache/skywalking-python/pull/292 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue url. Closes: - [ ] Update the

[skywalking-python] branch envvar updated: Fix wrong environment names in doc

2023-03-02 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a commit to branch envvar in repository https://gitbox.apache.org/repos/asf/skywalking-python.git The following commit(s) were added to refs/heads/envvar by this push: new dac30c8 Fix wrong environment

[skywalking-python] branch envvar created (now e1ed36b)

2023-03-02 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch envvar in repository https://gitbox.apache.org/repos/asf/skywalking-python.git at e1ed36b Fix Docker build missing required ARG (#291) No new revisions were added by this update.

[GitHub] [skywalking-java] zhaoxiaojie0415 commented on pull request #467: Fix thrift plugin generate duplicate traceid

2023-03-02 Thread via GitHub
zhaoxiaojie0415 commented on PR #467: URL: https://github.com/apache/skywalking-java/pull/467#issuecomment-1451749914 https://github.com/apache/skywalking/issues/10438 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [skywalking] zhaoxiaojie0415 commented on issue #10438: [Bug] An error during the "sendBase" phase in the thrift plugin resulted in a duplicated traceId

2023-03-02 Thread via GitHub
zhaoxiaojie0415 commented on issue #10438: URL: https://github.com/apache/skywalking/issues/10438#issuecomment-1451748143 #https://github.com/apache/skywalking-java/pull/467 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [skywalking-java] zhaoxiaojie0415 opened a new pull request, #467: Fix thrift plugin generate duplicate traceid

2023-03-02 Thread via GitHub
zhaoxiaojie0415 opened a new pull request, #467: URL: https://github.com/apache/skywalking-java/pull/467 ### Fix thrift plugin would generate duplicate traceid when an error occurs in sendBase phase In thrift plugin,it generate span before sendBase method and stop this span

[GitHub] [skywalking] wu-sheng closed issue #10474: [Feature] When can curl_multi_exec be supported about PHP agent's cUrl ?

2023-03-02 Thread via GitHub
wu-sheng closed issue #10474: [Feature] When can curl_multi_exec be supported about PHP agent's cUrl ? URL: https://github.com/apache/skywalking/issues/10474 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [skywalking] jmjoy commented on issue #10474: [Feature] When can curl_multi_exec be supported about PHP agent's cUrl ?

2023-03-02 Thread via GitHub
jmjoy commented on issue #10474: URL: https://github.com/apache/skywalking/issues/10474#issuecomment-1451526961 Will support, but not now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [skywalking] xxping opened a new issue, #10474: When can curl_multi_exec be supported about PHP agent's cUrl ?[Feature]

2023-03-02 Thread via GitHub
xxping opened a new issue, #10474: URL: https://github.com/apache/skywalking/issues/10474 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement. ### Description