[GitHub] [skywalking-kubernetes] innerpeacez commented on pull request #112: Deploy swck snapshot charts

2023-03-21 Thread via GitHub
innerpeacez commented on PR #112: URL: https://github.com/apache/skywalking-kubernetes/pull/112#issuecomment-1478955912 > > Why is the helm going to have snapshot now? I don't think we have changes for this frequently. > > * I plan to migrate our showcase repo to Helm Chart, where

[GitHub] [skywalking-kubernetes] kezhenxu94 commented on a diff in pull request #112: Deploy swck snapshot charts

2023-03-21 Thread via GitHub
kezhenxu94 commented on code in PR #112: URL: https://github.com/apache/skywalking-kubernetes/pull/112#discussion_r1144235460 ## .github/workflows/publish-helm.yaml: ## @@ -23,6 +23,7 @@ on: env: HUB: ghcr.io/apache/skywalking-kubernetes + VERSION: 0.0.0-${{ github.sha

[GitHub] [skywalking-kubernetes] wu-sheng commented on a diff in pull request #112: Deploy swck snapshot charts

2023-03-21 Thread via GitHub
wu-sheng commented on code in PR #112: URL: https://github.com/apache/skywalking-kubernetes/pull/112#discussion_r1144232905 ## .github/workflows/publish-helm.yaml: ## @@ -23,6 +23,7 @@ on: env: HUB: ghcr.io/apache/skywalking-kubernetes + VERSION: 0.0.0-${{ github.sha }}

[GitHub] [skywalking-kubernetes] kezhenxu94 commented on a diff in pull request #112: Deploy swck snapshot charts

2023-03-21 Thread via GitHub
kezhenxu94 commented on code in PR #112: URL: https://github.com/apache/skywalking-kubernetes/pull/112#discussion_r1144232352 ## .github/workflows/publish-helm.yaml: ## @@ -23,6 +23,7 @@ on: env: HUB: ghcr.io/apache/skywalking-kubernetes + VERSION: 0.0.0-${{ github.sha

[GitHub] [skywalking-kubernetes] kezhenxu94 commented on a diff in pull request #112: Deploy swck snapshot charts

2023-03-21 Thread via GitHub
kezhenxu94 commented on code in PR #112: URL: https://github.com/apache/skywalking-kubernetes/pull/112#discussion_r1144231917 ## .github/workflows/publish-helm.yaml: ## @@ -23,6 +23,7 @@ on: env: HUB: ghcr.io/apache/skywalking-kubernetes + VERSION: 0.0.0-${{ github.sha

[GitHub] [skywalking-kubernetes] wu-sheng commented on a diff in pull request #112: Deploy swck snapshot charts

2023-03-21 Thread via GitHub
wu-sheng commented on code in PR #112: URL: https://github.com/apache/skywalking-kubernetes/pull/112#discussion_r1144231421 ## .github/workflows/publish-helm.yaml: ## @@ -23,6 +23,7 @@ on: env: HUB: ghcr.io/apache/skywalking-kubernetes + VERSION: 0.0.0-${{ github.sha }}

[GitHub] [skywalking-kubernetes] kezhenxu94 commented on a diff in pull request #112: Deploy swck snapshot charts

2023-03-21 Thread via GitHub
kezhenxu94 commented on code in PR #112: URL: https://github.com/apache/skywalking-kubernetes/pull/112#discussion_r1144230103 ## chart/operator/Chart.yaml: ## @@ -14,7 +14,7 @@ # limitations under the License. apiVersion: v2 -name: skywalking-swck-operator +name:

[GitHub] [skywalking-kubernetes] wu-sheng commented on a diff in pull request #112: Deploy swck snapshot charts

2023-03-21 Thread via GitHub
wu-sheng commented on code in PR #112: URL: https://github.com/apache/skywalking-kubernetes/pull/112#discussion_r1144229499 ## chart/operator/Chart.yaml: ## @@ -14,7 +14,7 @@ # limitations under the License. apiVersion: v2 -name: skywalking-swck-operator +name:

[GitHub] [skywalking] wu-sheng closed pull request #10574: Added a Support Section in Readme.md file

2023-03-21 Thread via GitHub
wu-sheng closed pull request #10574: Added a Support Section in Readme.md file URL: https://github.com/apache/skywalking/pull/10574 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [skywalking] wu-sheng commented on pull request #10574: Added a Support Section in Readme.md file

2023-03-21 Thread via GitHub
wu-sheng commented on PR #10574: URL: https://github.com/apache/skywalking/pull/10574#issuecomment-1478914526 We don't have preferrence about the star. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [skywalking-kubernetes] kezhenxu94 commented on a diff in pull request #112: Deploy swck snapshot charts

2023-03-21 Thread via GitHub
kezhenxu94 commented on code in PR #112: URL: https://github.com/apache/skywalking-kubernetes/pull/112#discussion_r1144216689 ## chart/operator/Chart.yaml: ## @@ -14,7 +14,7 @@ # limitations under the License. apiVersion: v2 -name: skywalking-swck-operator +name:

[GitHub] [skywalking] kumarankit999 opened a new pull request, #10574: Added a Support Section in Readme.md file

2023-03-21 Thread via GitHub
kumarankit999 opened a new pull request, #10574: URL: https://github.com/apache/skywalking/pull/10574 Added a Support Section in Readme.md file - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. -

[GitHub] [skywalking-kubernetes] kezhenxu94 commented on pull request #112: Deploy swck snapshot charts

2023-03-21 Thread via GitHub
kezhenxu94 commented on PR #112: URL: https://github.com/apache/skywalking-kubernetes/pull/112#issuecomment-1478902298 > Why is the helm going to have snapshot now? I don't think we have changes for this frequently. - I plan to migrate our showcase repo to Helm Chart, where we will

[skywalking-kubernetes] branch depl updated (ad6ccbf -> 435dd76)

2023-03-21 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch depl in repository https://gitbox.apache.org/repos/asf/skywalking-kubernetes.git omit ad6ccbf Deploy swck snapshot charts add 435dd76 Deploy swck snapshot charts This update

[GitHub] [skywalking-kubernetes] wu-sheng commented on pull request #112: Deploy swck snapshot charts

2023-03-21 Thread via GitHub
wu-sheng commented on PR #112: URL: https://github.com/apache/skywalking-kubernetes/pull/112#issuecomment-1478897383 Why is the helm going to have snapshot now? I don't think we have changes for this frequently. -- This is an automated message from the Apache Git Service. To respond to

[skywalking-kubernetes] branch depl updated (81083d4 -> ad6ccbf)

2023-03-21 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch depl in repository https://gitbox.apache.org/repos/asf/skywalking-kubernetes.git omit 81083d4 Deploy swck snapshot charts add ad6ccbf Deploy swck snapshot charts This update

[skywalking-kubernetes] 01/01: Deploy swck snapshot charts

2023-03-21 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a commit to branch depl in repository https://gitbox.apache.org/repos/asf/skywalking-kubernetes.git commit 81083d4d83f89abba9043227840c427c0cedc12c Author: kezhenxu94 AuthorDate: Wed Mar 22 12:02:50 2023 +0800

[skywalking-kubernetes] branch depl created (now 81083d4)

2023-03-21 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch depl in repository https://gitbox.apache.org/repos/asf/skywalking-kubernetes.git at 81083d4 Deploy swck snapshot charts This branch includes the following new commits: new

[GitHub] [skywalking] why11xulei closed issue #10573: [Feature]

2023-03-21 Thread via GitHub
why11xulei closed issue #10573: [Feature] URL: https://github.com/apache/skywalking/issues/10573 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [skywalking] why11xulei opened a new issue, #10573: [Feature]

2023-03-21 Thread via GitHub
why11xulei opened a new issue, #10573: URL: https://github.com/apache/skywalking/issues/10573 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement. ### Description

[GitHub] [skywalking-python] kezhenxu94 commented on a diff in pull request #297: [feat]Build multi-architecture Docker images for Python agent

2023-03-21 Thread via GitHub
kezhenxu94 commented on code in PR #297: URL: https://github.com/apache/skywalking-python/pull/297#discussion_r1143499377 ## .github/workflows/publish-docker.yaml: ## @@ -0,0 +1,52 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license

[GitHub] [skywalking] ChrisssWong commented on issue #10571: [Bug] The difference in data structure of log storage between MySQL and ES causes the issue that the TraceId cannot be displayed in the UI

2023-03-21 Thread via GitHub
ChrisssWong commented on issue #10571: URL: https://github.com/apache/skywalking/issues/10571#issuecomment-1477909024 Ok, Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [skywalking] wu-sheng commented on issue #10571: [Bug] The difference in data structure of log storage between MySQL and ES causes the issue that the TraceId cannot be displayed in the UI log

2023-03-21 Thread via GitHub
wu-sheng commented on issue #10571: URL: https://github.com/apache/skywalking/issues/10571#issuecomment-1477877643 I could only say 1. 8.9.0 is too old. 8.x is EOL for a long time. 2. Endpoint ID is both in MySQL and ElasticSearch. 3. What you read is the data of the row, but not

[GitHub] [skywalking] wu-sheng closed issue #10571: [Bug] The difference in data structure of log storage between MySQL and ES causes the issue that the TraceId cannot be displayed in the UI log funct

2023-03-21 Thread via GitHub
wu-sheng closed issue #10571: [Bug] The difference in data structure of log storage between MySQL and ES causes the issue that the TraceId cannot be displayed in the UI log function of Skywalking. URL: https://github.com/apache/skywalking/issues/10571 -- This is an automated message from

[GitHub] [skywalking] ChrisssWong opened a new issue, #10571: [Bug] The difference in data structure of log storage between MySQL and ES causes the issue that the TraceId cannot be displayed in the UI

2023-03-21 Thread via GitHub
, tags_17 varchar(200) NULL, tags_18 varchar(200) NULL, tags_19 varchar(200) NULL, time_bucket bigint NULL ); ``` But in ES, it is stored like this: ``` { "_index": "skywalki

[GitHub] [skywalking] hongshuai1994 commented on issue #10570: [Bug] Endpoint "SpringCloudGateway/sendRequest" in the trace isn't included in the Endpoint tab

2023-03-21 Thread via GitHub
hongshuai1994 commented on issue #10570: URL: https://github.com/apache/skywalking/issues/10570#issuecomment-1477798488 With all due respect, just talking about the problem, all the responses to this issue are consulting and learning. The first thing to make clear is that I have read

[GitHub] [skywalking] wu-sheng commented on issue #10570: [Bug] Endpoint "SpringCloudGateway/sendRequest" in the trace isn't included in the Endpoint tab

2023-03-21 Thread via GitHub
wu-sheng commented on issue #10570: URL: https://github.com/apache/skywalking/issues/10570#issuecomment-1477740927 Have you even read what I posted? This is really no fun that you asked something, but you never read the reply. I would highlight one last time, A path in a service for

[GitHub] [skywalking] hongshuai1994 commented on issue #10570: [Bug] Endpoint "SpringCloudGateway/sendRequest" in the trace isn't included in the Endpoint tab

2023-03-21 Thread via GitHub
hongshuai1994 commented on issue #10570: URL: https://github.com/apache/skywalking/issues/10570#issuecomment-1477676660 Since the endpoint is displayed in the trace, isn’t it ambiguous not to count the endpoint tab? -- This is an automated message from the Apache Git Service. To respond

[GitHub] [skywalking] wu-sheng commented on issue #10570: [Bug] Endpoint "SpringCloudGateway/sendRequest" in the trace isn't included in the Endpoint tab

2023-03-21 Thread via GitHub
wu-sheng commented on issue #10570: URL: https://github.com/apache/skywalking/issues/10570#issuecomment-1477661090 https://skywalking.apache.org/docs/main/next/en/concepts-and-designs/overview/ Endpoint. A path in a service for incoming requests, such as an HTTP URI path or a gRPC

[GitHub] [skywalking] hongshuai1994 commented on issue #10570: [Bug] Endpoint "SpringCloudGateway/sendRequest" in the trace isn't included in the Endpoint tab

2023-03-21 Thread via GitHub
hongshuai1994 commented on issue #10570: URL: https://github.com/apache/skywalking/issues/10570#issuecomment-1477643487 Or for the above scenario, is there any other way to add monitoring? -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] hongshuai1994 commented on issue #10570: [Bug] Endpoint "SpringCloudGateway/sendRequest" in the trace isn't included in the Endpoint tab

2023-03-21 Thread via GitHub
hongshuai1994 commented on issue #10570: URL: https://github.com/apache/skywalking/issues/10570#issuecomment-1477641348 The reason why I pay attention to whether this endpoint has statistics on the endpoint tab is because we want to add the following monitoring alarms. The

[GitHub] [skywalking] hongshuai1994 commented on issue #10570: [Bug] Endpoint "SpringCloudGateway/sendRequest" in the trace isn't included in the Endpoint tab

2023-03-21 Thread via GitHub
hongshuai1994 commented on issue #10570: URL: https://github.com/apache/skywalking/issues/10570#issuecomment-1477632576 1. The endpoint is created when the span is created. Regardless of whether it is the endpoint you mentioned, as long as it is created, it should be counted in the

[GitHub] [skywalking] wu-sheng closed issue #10570: [Bug] Endpoint "SpringCloudGateway/sendRequest" in the trace isn't included in the Endpoint tab

2023-03-21 Thread via GitHub
wu-sheng closed issue #10570: [Bug] Endpoint "SpringCloudGateway/sendRequest" in the trace isn't included in the Endpoint tab URL: https://github.com/apache/skywalking/issues/10570 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [skywalking] wu-sheng commented on issue #10570: [Bug] Endpoint "SpringCloudGateway/sendRequest" in the trace isn't included in the Endpoint tab

2023-03-21 Thread via GitHub
wu-sheng commented on issue #10570: URL: https://github.com/apache/skywalking/issues/10570#issuecomment-1477615098 Learn what is an endpoint in SkyWalking. Your question is wrong. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [skywalking] hongshuai1994 opened a new issue, #10570: [Bug] Endpoint "SpringCloudGateway/sendRequest" in the trace isn't included in the Endpoint tab

2023-03-21 Thread via GitHub
hongshuai1994 opened a new issue, #10570: URL: https://github.com/apache/skywalking/issues/10570 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar issues. ### Apache SkyWalking

[skywalking] branch master updated: Fix K8sRetag reads the wrong k8s service (#10568)

2023-03-21 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new d6e7ee8ae3 Fix K8sRetag reads the wrong

[GitHub] [skywalking] wu-sheng merged pull request #10568: Fix K8sRetag reads the wrong k8s service

2023-03-21 Thread via GitHub
wu-sheng merged PR #10568: URL: https://github.com/apache/skywalking/pull/10568 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [skywalking] wu-sheng commented on a diff in pull request #10568: Fix K8sRetag reads the wrong k8s service

2023-03-21 Thread via GitHub
wu-sheng commented on code in PR #10568: URL: https://github.com/apache/skywalking/pull/10568#discussion_r1142977886 ## oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/k8s/K8sInfoRegistry.java: ## @@ -94,6 +96,8 @@ private

[GitHub] [skywalking] kezhenxu94 commented on a diff in pull request #10568: Fix K8sRetag reads the wrong k8s service

2023-03-21 Thread via GitHub
kezhenxu94 commented on code in PR #10568: URL: https://github.com/apache/skywalking/pull/10568#discussion_r1142972274 ## oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/k8s/K8sInfoRegistry.java: ## @@ -94,6 +96,8 @@ private

[GitHub] [skywalking] innerpeacez commented on a diff in pull request #10568: fix: k8s service name cache(podServiceMap) wrong

2023-03-21 Thread via GitHub
innerpeacez commented on code in PR #10568: URL: https://github.com/apache/skywalking/pull/10568#discussion_r1142962649 ## oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/k8s/K8sInfoRegistry.java: ## @@ -96,6 +98,8 @@ private

[GitHub] [skywalking] wu-sheng commented on a diff in pull request #10568: fix: k8s service name cache(podServiceMap) wrong

2023-03-21 Thread via GitHub
wu-sheng commented on code in PR #10568: URL: https://github.com/apache/skywalking/pull/10568#discussion_r1142961393 ## oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/k8s/K8sInfoRegistry.java: ## @@ -96,6 +98,8 @@ private

[GitHub] [skywalking] innerpeacez commented on a diff in pull request #10568: fix: k8s service name cache(podServiceMap) wrong

2023-03-21 Thread via GitHub
innerpeacez commented on code in PR #10568: URL: https://github.com/apache/skywalking/pull/10568#discussion_r1142960879 ## oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/k8s/K8sInfoRegistry.java: ## @@ -96,6 +98,8 @@ private

[GitHub] [skywalking] wu-sheng commented on a diff in pull request #10568: fix: k8s service name cache(podServiceMap) wrong

2023-03-21 Thread via GitHub
wu-sheng commented on code in PR #10568: URL: https://github.com/apache/skywalking/pull/10568#discussion_r1142959785 ## docs/en/changes/changes.md: ## @@ -16,6 +16,7 @@ * Fix otel k8s-cluster rule add namespace dimension for MAL aggregation calculation(Deployment

[GitHub] [skywalking] wu-sheng commented on a diff in pull request #10568: fix: k8s service name cache(podServiceMap) wrong

2023-03-21 Thread via GitHub
wu-sheng commented on code in PR #10568: URL: https://github.com/apache/skywalking/pull/10568#discussion_r1142959785 ## docs/en/changes/changes.md: ## @@ -16,6 +16,7 @@ * Fix otel k8s-cluster rule add namespace dimension for MAL aggregation calculation(Deployment

[GitHub] [skywalking] wu-sheng commented on a diff in pull request #10568: fix: k8s service name cache(podServiceMap) wrong

2023-03-21 Thread via GitHub
wu-sheng commented on code in PR #10568: URL: https://github.com/apache/skywalking/pull/10568#discussion_r1142958130 ## oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/k8s/K8sInfoRegistry.java: ## @@ -96,6 +98,8 @@ private

[GitHub] [skywalking] wu-sheng commented on a diff in pull request #10568: fix: k8s service name cache(podServiceMap) wrong

2023-03-21 Thread via GitHub
wu-sheng commented on code in PR #10568: URL: https://github.com/apache/skywalking/pull/10568#discussion_r1142957318 ## oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/k8s/K8sInfoRegistry.java: ## @@ -96,6 +98,8 @@ private

[GitHub] [skywalking] innerpeacez commented on a diff in pull request #10568: fix: k8s service name cache(podServiceMap) wrong

2023-03-21 Thread via GitHub
innerpeacez commented on code in PR #10568: URL: https://github.com/apache/skywalking/pull/10568#discussion_r1142956310 ## oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/k8s/K8sInfoRegistry.java: ## @@ -96,6 +98,8 @@ private

[GitHub] [skywalking] wu-sheng commented on a diff in pull request #10568: fix: k8s service name cache(podServiceMap) wrong

2023-03-21 Thread via GitHub
wu-sheng commented on code in PR #10568: URL: https://github.com/apache/skywalking/pull/10568#discussion_r1142951565 ## oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/k8s/K8sInfoRegistry.java: ## @@ -96,6 +98,8 @@ private

[skywalking] branch master updated: Adapt the service level component in E2E (#10530)

2023-03-21 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new c217ead555 Adapt the service level

[GitHub] [skywalking] wu-sheng merged pull request #10530: Adapt the service level component field in E2E

2023-03-21 Thread via GitHub
wu-sheng merged PR #10530: URL: https://github.com/apache/skywalking/pull/10530 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [skywalking] innerpeacez commented on issue #10230: skywalking v9.3: no data in k8s service

2023-03-21 Thread via GitHub
innerpeacez commented on issue #10230: URL: https://github.com/apache/skywalking/issues/10230#issuecomment-1477349121 Two reasons: 1. Lack of clusterRole during install causes oap to call k8s api without permission. 2. Some K8s services are missing due to service cache wroing. --

[GitHub] [skywalking] innerpeacez commented on issue #10230: skywalking v9.3: no data in k8s service

2023-03-21 Thread via GitHub
innerpeacez commented on issue #10230: URL: https://github.com/apache/skywalking/issues/10230#issuecomment-1477346769 The problem of missing service is due to cache wrong, independent of `opentelemetry-collector` and `kube-state-metrics` version.(At least the version I tested). see

[GitHub] [skywalking] innerpeacez opened a new pull request, #10568: fix: k8s service name cache(podServiceMap) wrong

2023-03-21 Thread via GitHub
innerpeacez opened a new pull request, #10568: URL: https://github.com/apache/skywalking/pull/10568 ### Fix - [ ] Add a unit test to verify that the fix works. - [x] Explain briefly why the bug exists and how to fix it. Different namespace may contain services with