[GitHub] [skywalking-swck] dashanji commented on pull request #87: Deprecate the configmap configurations of the java injector.

2023-07-22 Thread via GitHub
dashanji commented on PR #87: URL: https://github.com/apache/skywalking-swck/pull/87#issuecomment-1646736731 > FYI about how to collect logs https://github.com/apache/skywalking/blob/e0068154c1253500720651dca5c80c3ae10ca87b/.github/workflows/skywalking.yaml#L687 Make sense to me. Than

[GitHub] [skywalking-kubernetes] wu-sheng closed pull request #125: Add `extraPodLabels` to `oapInit` so Job can have additional labels

2023-07-22 Thread via GitHub
wu-sheng closed pull request #125: Add `extraPodLabels` to `oapInit` so Job can have additional labels URL: https://github.com/apache/skywalking-kubernetes/pull/125 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [skywalking-kubernetes] wu-sheng commented on pull request #125: Add `extraPodLabels` to `oapInit` so Job can have additional labels

2023-07-22 Thread via GitHub
wu-sheng commented on PR #125: URL: https://github.com/apache/skywalking-kubernetes/pull/125#issuecomment-1646725919 @eric-futureself Any update? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [skywalking-swck] kezhenxu94 commented on pull request #87: Deprecate the configmap configurations of the java injector.

2023-07-22 Thread via GitHub
kezhenxu94 commented on PR #87: URL: https://github.com/apache/skywalking-swck/pull/87#issuecomment-1646717951 FYI about how to collect logs https://github.com/apache/skywalking/blob/e0068154c1253500720651dca5c80c3ae10ca87b/.github/workflows/skywalking.yaml#L687 -- This is an automated me

[GitHub] [skywalking-swck] kezhenxu94 commented on pull request #87: Deprecate the configmap configurations of the java injector.

2023-07-22 Thread via GitHub
kezhenxu94 commented on PR #87: URL: https://github.com/apache/skywalking-swck/pull/87#issuecomment-1646717681 > @hanahmily, @wu-sheng. The e2e test can run successfully on my local machine, and I want to debug it on the CI. > > But It looks like we can't add the tmate action as http

[GitHub] [skywalking] smartboy37597 commented on a diff in pull request #11127: Apply MQE on Virtual_MQ and Infra layer UI-templates

2023-07-22 Thread via GitHub
smartboy37597 commented on code in PR #11127: URL: https://github.com/apache/skywalking/pull/11127#discussion_r1271363869 ## docs/en/changes/changes.md: ## @@ -55,6 +55,8 @@ * Move created the latest index before retrieval indexes by aliases to avoid the 404 exception. This ju

[GitHub] [skywalking] wu-sheng commented on pull request #11127: Apply MQE on Virtual_MQ and Infra layer UI-templates

2023-07-22 Thread via GitHub
wu-sheng commented on PR #11127: URL: https://github.com/apache/skywalking/pull/11127#issuecomment-1646702244 Search git submodule update. It is not adding a new commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [skywalking] smartboy37597 commented on pull request #11127: Apply MQE on Virtual_MQ and Infra layer UI-templates

2023-07-22 Thread via GitHub
smartboy37597 commented on PR #11127: URL: https://github.com/apache/skywalking/pull/11127#issuecomment-1646701197 > Please sync UI sub module as well, as you had fixed a typo for this. I only changed one part of the text in `en.ts` in submodule `skywalking-ui`. When I used `git add`

[GitHub] [skywalking] wu-sheng commented on a diff in pull request #11127: Apply MQE on Virtual_MQ and Infra layer UI-templates

2023-07-22 Thread via GitHub
wu-sheng commented on code in PR #11127: URL: https://github.com/apache/skywalking/pull/11127#discussion_r1271322457 ## docs/en/changes/changes.md: ## @@ -55,6 +55,8 @@ * Move created the latest index before retrieval indexes by aliases to avoid the 404 exception. This just pr

[GitHub] [skywalking] wu-sheng commented on a diff in pull request #11127: Apply MQE on Virtual_MQ and Infra layer UI-templates

2023-07-22 Thread via GitHub
wu-sheng commented on code in PR #11127: URL: https://github.com/apache/skywalking/pull/11127#discussion_r1271319988 ## apm-webapp/pom.xml: ## @@ -116,7 +116,7 @@ npm -in

[GitHub] [skywalking] wu-sheng commented on pull request #11127: Apply MQE on Virtual_MQ and Infra layer UI-templates

2023-07-22 Thread via GitHub
wu-sheng commented on PR #11127: URL: https://github.com/apache/skywalking/pull/11127#issuecomment-1646624799 Please sync UI sub module as well, as you had fixed a typo for this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [skywalking] smartboy37597 commented on pull request #11127: Apply MQE on Virtual_MQ and Infra layer UI-templates

2023-07-22 Thread via GitHub
smartboy37597 commented on PR #11127: URL: https://github.com/apache/skywalking/pull/11127#issuecomment-1646620907 Here are some screenshots of the modified effect. Some modules have no metric in my local environment, but I verified my expression correctly by using an **Live demo**.

[skywalking-booster-ui] branch main updated: Fix Virtual_MQ spelling mistake (#304)

2023-07-22 Thread yihaochen
This is an automated email from the ASF dual-hosted git repository. yihaochen pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/skywalking-booster-ui.git The following commit(s) were added to refs/heads/main by this push: new 90505810 Fix Virtual_MQ spelling m

[GitHub] [skywalking-booster-ui] Superskyyy merged pull request #304: Fix Virtual_MQ spelling mistake

2023-07-22 Thread via GitHub
Superskyyy merged PR #304: URL: https://github.com/apache/skywalking-booster-ui/pull/304 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-u

[GitHub] [skywalking] smartboy37597 commented on pull request #11127: Apply MQE on Virtual_MQ and Infra layer UI-templates

2023-07-22 Thread via GitHub
smartboy37597 commented on PR #11127: URL: https://github.com/apache/skywalking/pull/11127#issuecomment-1646617469 > @smartboy37597 you can put some screenshots here. Sorry about that, I'll put some screenshots in the comments. -- This is an automated message from the Apache Git

[GitHub] [skywalking-go] wu-sheng commented on pull request #81: Support enhance native `mutex` as plugin

2023-07-22 Thread via GitHub
wu-sheng commented on PR #81: URL: https://github.com/apache/skywalking-go/pull/81#issuecomment-1646605339 I noticed that, but if there are more than one lock involved, it will fail, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking-showcase] wu-sheng commented on pull request #144: MongoDB monitoring showcase

2023-07-22 Thread via GitHub
wu-sheng commented on PR #144: URL: https://github.com/apache/skywalking-showcase/pull/144#issuecomment-1646604936 @wankai123 When you have time, let's bring this to demo env as well. Doc is hosted, https://skywalking.apache.org/docs/main/next/en/setup/backend/backend-mongodb-monitor

[GitHub] [skywalking-go] mrproliu commented on pull request #81: Support enhance native `mutex` as plugin

2023-07-22 Thread via GitHub
mrproliu commented on PR #81: URL: https://github.com/apache/skywalking-go/pull/81#issuecomment-1646603514 I mean its only could calculate the metrics when have a span(tracing context) in current goroutine. -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [skywalking-showcase] wu-sheng merged pull request #144: MongoDB monitoring showcase

2023-07-22 Thread via GitHub
wu-sheng merged PR #144: URL: https://github.com/apache/skywalking-showcase/pull/144 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsub

[skywalking-showcase] branch main updated: MongoDB monitoring showcase (#144)

2023-07-22 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/skywalking-showcase.git The following commit(s) were added to refs/heads/main by this push: new e56df1c MongoDB monitoring showcase (

[GitHub] [skywalking-go] wu-sheng commented on pull request #81: Support enhance native `mutex` as plugin

2023-07-22 Thread via GitHub
wu-sheng commented on PR #81: URL: https://github.com/apache/skywalking-go/pull/81#issuecomment-1646602048 What do you nean in tracing context? What is IN? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [skywalking-go] mrproliu commented on pull request #81: Support enhance native `mutex` as plugin

2023-07-22 Thread via GitHub
mrproliu commented on PR #81: URL: https://github.com/apache/skywalking-go/pull/81#issuecomment-1646598258 Yes, that's why I say it maybe difficult to understand. For now, I just calculating the metrics that must in a tracing context. Other solution is we only calculate the lock performa

[GitHub] [skywalking-go] wu-sheng commented on pull request #81: Support enhance native `mutex` as plugin

2023-07-22 Thread via GitHub
wu-sheng commented on PR #81: URL: https://github.com/apache/skywalking-go/pull/81#issuecomment-1646596504 Then, how to distict the different lockers? I am feeling aggregating globally is not that useful. -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [skywalking-go] mrproliu commented on pull request #81: Support enhance native `mutex` as plugin

2023-07-22 Thread via GitHub
mrproliu commented on PR #81: URL: https://github.com/apache/skywalking-go/pull/81#issuecomment-1646595223 In golang code, it's just under the "sync" package, there is no name. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [skywalking-go] mrproliu commented on a diff in pull request #81: Support enhance native `mutex` as plugin

2023-07-22 Thread via GitHub
mrproliu commented on code in PR #81: URL: https://github.com/apache/skywalking-go/pull/81#discussion_r1271300716 ## CHANGES.md: ## @@ -22,6 +22,7 @@ Release Notes. * Support [Native SQL](https://pkg.go.dev/net/http) database client framework with [MySQL Driver](github.com/go-

[GitHub] [skywalking-go] wu-sheng commented on pull request #81: Support enhance native `mutex` as plugin

2023-07-22 Thread via GitHub
wu-sheng commented on PR #81: URL: https://github.com/apache/skywalking-go/pull/81#issuecomment-1646593215 Isn't lock having a name? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [skywalking-go] mrproliu commented on a diff in pull request #81: Support enhance native `mutex` as plugin

2023-07-22 Thread via GitHub
mrproliu commented on code in PR #81: URL: https://github.com/apache/skywalking-go/pull/81#discussion_r1271300740 ## CHANGES.md: ## @@ -22,6 +22,7 @@ Release Notes. * Support [Native SQL](https://pkg.go.dev/net/http) database client framework with [MySQL Driver](github.com/go-

[GitHub] [skywalking-go] mrproliu commented on a diff in pull request #81: Support enhance native `mutex` as plugin

2023-07-22 Thread via GitHub
mrproliu commented on code in PR #81: URL: https://github.com/apache/skywalking-go/pull/81#discussion_r1271300716 ## CHANGES.md: ## @@ -22,6 +22,7 @@ Release Notes. * Support [Native SQL](https://pkg.go.dev/net/http) database client framework with [MySQL Driver](github.com/go-

[GitHub] [skywalking-showcase] weixiang1862 commented on a diff in pull request #144: MongoDB monitoring showcase

2023-07-22 Thread via GitHub
weixiang1862 commented on code in PR #144: URL: https://github.com/apache/skywalking-showcase/pull/144#discussion_r1271296983 ## deploy/platform/kubernetes/templates/feature-mongodb/opentelemetry-config.yaml: ## @@ -0,0 +1,39 @@ +# Licensed to the Apache Software Foundation (AS

[GitHub] [skywalking] wankai123 commented on pull request #11127: Apply MQE on Virtual_MQ and Infra layer UI-templates

2023-07-22 Thread via GitHub
wankai123 commented on PR #11127: URL: https://github.com/apache/skywalking/pull/11127#issuecomment-1646581769 @smartboy37597 you can put some screenshots here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [skywalking-showcase] wankai123 commented on a diff in pull request #144: MongoDB monitoring showcase

2023-07-22 Thread via GitHub
wankai123 commented on code in PR #144: URL: https://github.com/apache/skywalking-showcase/pull/144#discussion_r1271294518 ## deploy/platform/kubernetes/templates/feature-mongodb/opentelemetry-config.yaml: ## @@ -0,0 +1,39 @@ +# Licensed to the Apache Software Foundation (ASF)

[GitHub] [skywalking-showcase] weixiang1862 commented on a diff in pull request #144: MongoDB monitoring showcase

2023-07-22 Thread via GitHub
weixiang1862 commented on code in PR #144: URL: https://github.com/apache/skywalking-showcase/pull/144#discussion_r1271293974 ## deploy/platform/kubernetes/templates/feature-mongodb/opentelemetry-config.yaml: ## @@ -0,0 +1,39 @@ +# Licensed to the Apache Software Foundation (AS

[GitHub] [skywalking-showcase] wankai123 commented on a diff in pull request #144: MongoDB monitoring showcase

2023-07-22 Thread via GitHub
wankai123 commented on code in PR #144: URL: https://github.com/apache/skywalking-showcase/pull/144#discussion_r1271293103 ## deploy/platform/kubernetes/templates/feature-mongodb/opentelemetry-config.yaml: ## @@ -0,0 +1,39 @@ +# Licensed to the Apache Software Foundation (ASF)

[GitHub] [skywalking-showcase] weixiang1862 commented on pull request #144: MongoDB monitoring showcase

2023-07-22 Thread via GitHub
weixiang1862 commented on PR #144: URL: https://github.com/apache/skywalking-showcase/pull/144#issuecomment-1646554978 @kezhenxu94 It looks like this, I running it on my local minikube for about 10 hours. ![image](https://github.com/apache/skywalking-showcase/assets/16346644/845f754

[GitHub] [skywalking] smartboy37597 closed pull request #11126: Apply MQE on Virtual_MQ layer UI-templates

2023-07-22 Thread via GitHub
smartboy37597 closed pull request #11126: Apply MQE on Virtual_MQ layer UI-templates URL: https://github.com/apache/skywalking/pull/11126 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [skywalking] sonatype-lift[bot] commented on pull request #11127: Apply MQE on Infra layer UI-templates

2023-07-22 Thread via GitHub
sonatype-lift[bot] commented on PR #11127: URL: https://github.com/apache/skywalking/pull/11127#issuecomment-1646551841 ## Sonatype Lift is retiring Sonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disa

[GitHub] [skywalking] smartboy37597 opened a new pull request, #11127: Apply MQE on Infra layer UI-templates

2023-07-22 Thread via GitHub
smartboy37597 opened a new pull request, #11127: URL: https://github.com/apache/skywalking/pull/11127 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [ ] Update the [`CHANGES` log](https://github.co

[GitHub] [skywalking-booster-ui] smartboy37597 opened a new pull request, #304: Fix Virtual_MQ spelling mistake

2023-07-22 Thread via GitHub
smartboy37597 opened a new pull request, #304: URL: https://github.com/apache/skywalking-booster-ui/pull/304 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [skywalking] sonatype-lift[bot] commented on pull request #11126: Apply MQE on Virtual_MQ layer UI-templates

2023-07-22 Thread via GitHub
sonatype-lift[bot] commented on PR #11126: URL: https://github.com/apache/skywalking/pull/11126#issuecomment-1646540488 ## Sonatype Lift is retiring Sonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disa

[GitHub] [skywalking] smartboy37597 opened a new pull request, #11126: Apply MQE on Virtual_MQ layer UI-templates

2023-07-22 Thread via GitHub
smartboy37597 opened a new pull request, #11126: URL: https://github.com/apache/skywalking/pull/11126 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #10914. - [ ] Update the [`CHANGES` log](https://gith