[skywalking-banyandb] branch distributed-query updated (3d512840 -> 407d3af5)

2023-09-10 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch distributed-query in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git from 3d512840 Merge branch 'main' into distributed-query add 407d3af5 Update metadata updat

[GitHub] [skywalking] wu-sheng commented on a diff in pull request #11316: Separate storage docs to different files

2023-09-10 Thread via GitHub
wu-sheng commented on code in PR #11316: URL: https://github.com/apache/skywalking/pull/11316#discussion_r1321050546 ## docs/en/setup/backend/backend-storage.md: ## @@ -8,325 +8,18 @@ storage: ``` Natively supported storage: -- H2 -- OpenSearch -- ElasticSearch 7 and 8. --

[GitHub] [skywalking] wu-sheng opened a new pull request, #11316: Separate storage docs to different files

2023-09-10 Thread via GitHub
wu-sheng opened a new pull request, #11316: URL: https://github.com/apache/skywalking/pull/11316 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [x] Update the [`CHANGES` log](https://github

[skywalking] branch storage-doc created (now 1de737dfb2)

2023-09-10 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch storage-doc in repository https://gitbox.apache.org/repos/asf/skywalking.git at 1de737dfb2 Separate storage docs to different files, and add an estimated timeline for BanyanDB(end of 2023

[skywalking] 01/01: Separate storage docs to different files, and add an estimated timeline for BanyanDB(end of 2023).

2023-09-10 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch storage-doc in repository https://gitbox.apache.org/repos/asf/skywalking.git commit 1de737dfb20017c4f728d632603a4f4f821be9d0 Author: Wu Sheng AuthorDate: Mon Sep 11 14:24:45 2023 +0800 Sepa

[GitHub] [skywalking-java] wu-sheng commented on a diff in pull request #607: Optimize ElasticSearch 6.x 7.x plugin compatibility

2023-09-10 Thread via GitHub
wu-sheng commented on code in PR #607: URL: https://github.com/apache/skywalking-java/pull/607#discussion_r1321022828 ## apm-sniffer/apm-sdk-plugin/elasticsearch-common/pom.xml: ## @@ -0,0 +1,39 @@ + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSc

[GitHub] [skywalking-java] wu-sheng commented on a diff in pull request #607: Optimize ElasticSearch 6.x 7.x plugin compatibility

2023-09-10 Thread via GitHub
wu-sheng commented on code in PR #607: URL: https://github.com/apache/skywalking-java/pull/607#discussion_r1321022940 ## apm-sniffer/apm-sdk-plugin/elasticsearch-common/pom.xml: ## @@ -0,0 +1,39 @@ + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSc

[GitHub] [skywalking-java] wu-sheng commented on pull request #603: Fix the issue of createSpan failure caused by invalid request URL in HttpClient 4.x/5.x plugin

2023-09-10 Thread via GitHub
wu-sheng commented on PR #603: URL: https://github.com/apache/skywalking-java/pull/603#issuecomment-1713189284 I am confused, URI provided a way to catch the error. Why don't you want to use it? Like we discussed, there is no performance concern as exception is only for illegal cases.

[GitHub] [skywalking-java] xiaqi1210 commented on a diff in pull request #603: Fix the issue of createSpan failure caused by invalid request URL in HttpClient 4.x/5.x plugin

2023-09-10 Thread via GitHub
xiaqi1210 commented on code in PR #603: URL: https://github.com/apache/skywalking-java/pull/603#discussion_r1320996997 ## apm-sniffer/apm-sdk-plugin/httpclient-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/httpclient/v5/HttpClientDoExecuteInterceptor.java: ## @@ -101

[GitHub] [skywalking-java] xiaqi1210 commented on pull request #603: Fix the issue of createSpan failure caused by invalid request URL in HttpClient 4.x/5.x plugin

2023-09-10 Thread via GitHub
xiaqi1210 commented on PR #603: URL: https://github.com/apache/skywalking-java/pull/603#issuecomment-171311 Or I could focus on filtering just the specific case of two port numbers that I encountered, and improve to cover other cases in the future. -- This is an automated message from

[GitHub] [skywalking-java] xiaqi1210 commented on pull request #603: Fix the issue of createSpan failure caused by invalid request URL in HttpClient 4.x/5.x plugin

2023-09-10 Thread via GitHub
xiaqi1210 commented on PR #603: URL: https://github.com/apache/skywalking-java/pull/603#issuecomment-1713165682 > @xiaqi1210 Would you able to finish this patch? The difficulty here lies in how to determine if a URL is valid. The only accurate way I can think of is trying new URL(). A

[GitHub] [skywalking] wu-sheng commented on pull request #11282: Feature kafka monitoring

2023-09-10 Thread via GitHub
wu-sheng commented on PR #11282: URL: https://github.com/apache/skywalking/pull/11282#issuecomment-1713162164 GHA has unstable issues last week. I just approved your latest commit, let's see how it goes this time. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [skywalking-go] wu-sheng merged pull request #100: fix header Sw8 in request.txt

2023-09-10 Thread via GitHub
wu-sheng merged PR #100: URL: https://github.com/apache/skywalking-go/pull/100 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...

[skywalking-go] branch main updated: fix header Sw8 in request.txt (#100)

2023-09-10 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/skywalking-go.git The following commit(s) were added to refs/heads/main by this push: new 989b03c fix header Sw8 in request.txt (#100

[GitHub] [skywalking] ZhuWang1112 commented on pull request #11282: Feature kafka monitoring

2023-09-10 Thread via GitHub
ZhuWang1112 commented on PR #11282: URL: https://github.com/apache/skywalking/pull/11282#issuecomment-1713149404 > Few tests still fail, I am not sure whether it is relative. Let's check again after you fix your mentor's comments. I have reviewed my commits and did not find any change

[GitHub] [skywalking-go] kikoroc opened a new pull request, #100: fix header Sw8 in request.txt

2023-09-10 Thread via GitHub
kikoroc opened a new pull request, #100: URL: https://github.com/apache/skywalking-go/pull/100 remove the last character(") of the last part in Sw8(AddressUsedAtClient) which cause base64 decode error. error info: ``` skywalking-go 2023/09/11 11:04:29 execute interceptor before

[GitHub] [skywalking-java] wuwen5 commented on a diff in pull request #603: Fix the issue of createSpan failure caused by invalid request URL in HttpClient 4.x/5.x plugin

2023-09-10 Thread via GitHub
wuwen5 commented on code in PR #603: URL: https://github.com/apache/skywalking-java/pull/603#discussion_r1320950019 ## apm-sniffer/apm-sdk-plugin/httpclient-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/httpclient/v5/HttpClientDoExecuteInterceptor.java: ## @@ -101,9

[GitHub] [skywalking-java] wu-sheng commented on a diff in pull request #603: Fix the issue of createSpan failure caused by invalid request URL in HttpClient 4.x/5.x plugin

2023-09-10 Thread via GitHub
wu-sheng commented on code in PR #603: URL: https://github.com/apache/skywalking-java/pull/603#discussion_r1320950520 ## apm-sniffer/apm-sdk-plugin/httpclient-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/httpclient/v5/HttpClientDoExecuteInterceptor.java: ## @@ -101,

[GitHub] [skywalking-java] wuwen5 commented on a diff in pull request #603: Fix the issue of createSpan failure caused by invalid request URL in HttpClient 4.x/5.x plugin

2023-09-10 Thread via GitHub
wuwen5 commented on code in PR #603: URL: https://github.com/apache/skywalking-java/pull/603#discussion_r1320950019 ## apm-sniffer/apm-sdk-plugin/httpclient-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/httpclient/v5/HttpClientDoExecuteInterceptor.java: ## @@ -101,9

[GitHub] [skywalking-java] wu-sheng commented on a diff in pull request #603: Fix the issue of createSpan failure caused by invalid request URL in HttpClient 4.x/5.x plugin

2023-09-10 Thread via GitHub
wu-sheng commented on code in PR #603: URL: https://github.com/apache/skywalking-java/pull/603#discussion_r1320939185 ## apm-sniffer/apm-sdk-plugin/httpclient-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/httpclient/v5/HttpClientDoExecuteInterceptor.java: ## @@ -101,

[GitHub] [skywalking-java] wuwen5 commented on a diff in pull request #603: Fix the issue of createSpan failure caused by invalid request URL in HttpClient 4.x/5.x plugin

2023-09-10 Thread via GitHub
wuwen5 commented on code in PR #603: URL: https://github.com/apache/skywalking-java/pull/603#discussion_r1320937600 ## apm-sniffer/apm-sdk-plugin/httpclient-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/httpclient/v5/HttpClientDoExecuteInterceptor.java: ## @@ -101,9

[GitHub] [skywalking-banyandb-java-client] hailin0 commented on pull request #46: Add mod revision check to write requests(measure/stream)

2023-09-10 Thread via GitHub
hailin0 commented on PR #46: URL: https://github.com/apache/skywalking-banyandb-java-client/pull/46#issuecomment-1713069154 PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [skywalking-banyandb] hailin0 commented on pull request #322: Add mod revision check to write requests(measure/stream)

2023-09-10 Thread via GitHub
hailin0 commented on PR #322: URL: https://github.com/apache/skywalking-banyandb/pull/322#issuecomment-1713068302 @hanahmily PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [skywalking-banyandb] hailin0 commented on a diff in pull request #322: Add mod revision check to write requests(measure/stream)

2023-09-10 Thread via GitHub
hailin0 commented on code in PR #322: URL: https://github.com/apache/skywalking-banyandb/pull/322#discussion_r1320934362 ## pkg/query/logical/common.go: ## @@ -72,22 +69,15 @@ func ProjectItem(ec executor.ExecutionContext, item tsdb.Item, projectionFieldRe if l

[GitHub] [skywalking-java] wu-sheng commented on pull request #607: Optimize ElasticSearch 6.x 7.x plugin compatibility

2023-09-10 Thread via GitHub
wu-sheng commented on PR #607: URL: https://github.com/apache/skywalking-java/pull/607#issuecomment-1713046004 I remember Elasticsearch 7.10 changed the license, so maybe it needs to download from a new docker hub repo? If so, you have to separate the test cases -- This is an automated m

[GitHub] [skywalking-java] wu-sheng commented on pull request #597: Add mongoDB plugin report db instance info

2023-09-10 Thread via GitHub
wu-sheng commented on PR #597: URL: https://github.com/apache/skywalking-java/pull/597#issuecomment-1713045127 Any update @hxd123456 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [skywalking-java] wu-sheng commented on pull request #603: Fix the issue of createSpan failure caused by invalid request URL in HttpClient 4.x/5.x plugin

2023-09-10 Thread via GitHub
wu-sheng commented on PR #603: URL: https://github.com/apache/skywalking-java/pull/603#issuecomment-1713044791 @xiaqi1210 Would you able to finish this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [skywalking-banyandb] hailin0 commented on pull request #322: Add mod revision check to write requests(measure/stream)

2023-09-10 Thread via GitHub
hailin0 commented on PR #322: URL: https://github.com/apache/skywalking-banyandb/pull/322#issuecomment-1713038524 show case https://github.com/apache/skywalking-banyandb/assets/14371345/22820b99-1ff5-4b21-bcd4-9ef00156d44d -- This is an automated message from the Apache Gi

[GitHub] [skywalking-banyandb] hanahmily commented on a diff in pull request #328: Add Property CRUD Function

2023-09-10 Thread via GitHub
hanahmily commented on code in PR #328: URL: https://github.com/apache/skywalking-banyandb/pull/328#discussion_r1320893057 ## ui/src/components/Property/PropertyEditror.vue: ## @@ -0,0 +1,211 @@ +

[skywalking-website] branch asf-site updated: deploy: fe1b499fc71fff7959f171bc515e060e60e53701

2023-09-10 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/skywalking-website.git The following commit(s) were added to refs/heads/asf-site by this push: new aa19cab2a7a deploy: fe1b499f

[skywalking-banyandb] branch distributed-query updated (4844a16d -> 3d512840)

2023-09-10 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch distributed-query in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git from 4844a16d Add distributed query procedure add 95fe2180 Move clients and observebility d

[skywalking-banyandb] branch main updated: Move clients and observebility docs to the bottom of menu (#327)

2023-09-10 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git The following commit(s) were added to refs/heads/main by this push: new 95fe2180 Move clients and observebil

[skywalking-banyandb] branch wu-sheng-patch-1 deleted (was 974344d8)

2023-09-10 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch wu-sheng-patch-1 in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git was 974344d8 Move clients and observebility docs to the bottom of menu The revisions that were

[GitHub] [skywalking-banyandb] hanahmily merged pull request #327: Move clients and observebility docs to the bottom of menu

2023-09-10 Thread via GitHub
hanahmily merged PR #327: URL: https://github.com/apache/skywalking-banyandb/pull/327 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsu

[GitHub] [skywalking-banyandb] codecov-commenter commented on pull request #328: Add Property CRUD Function

2023-09-10 Thread via GitHub
codecov-commenter commented on PR #328: URL: https://github.com/apache/skywalking-banyandb/pull/328#issuecomment-1712780885 ## [Codecov](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/328?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comme

[GitHub] [skywalking-banyandb] WuChuSheng1 opened a new pull request, #328: Add Property CRUD Function

2023-09-10 Thread via GitHub
WuChuSheng1 opened a new pull request, #328: URL: https://github.com/apache/skywalking-banyandb/pull/328 ### - [Add Property CRUD Function] ![image](https://github.com/apache/skywalking-banyandb/assets/10786/5d7973de-6f95-419c-a29a-e67674587cd1) ![image](https://github.com/apa

[GitHub] [skywalking-banyandb] wu-sheng commented on pull request #327: Move clients and observebility docs to the bottom of menu

2023-09-10 Thread via GitHub
wu-sheng commented on PR #327: URL: https://github.com/apache/skywalking-banyandb/pull/327#issuecomment-1712763857 @hanahmily Please notice failing tests. It seems to have utc tz issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [skywalking-banyandb] codecov-commenter commented on pull request #327: Move clients and observebility docs to the bottom of menu

2023-09-10 Thread via GitHub
codecov-commenter commented on PR #327: URL: https://github.com/apache/skywalking-banyandb/pull/327#issuecomment-1712738595 ## [Codecov](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/327?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comme

[GitHub] [skywalking-banyandb] wu-sheng opened a new pull request, #327: Move clients and observebility docs to the bottom of menu

2023-09-10 Thread via GitHub
wu-sheng opened a new pull request, #327: URL: https://github.com/apache/skywalking-banyandb/pull/327 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Fixes apache/skywalking#. - [ ] Update the [`CHANGES` log](https://g

[skywalking-banyandb] branch wu-sheng-patch-1 updated: Move clients and observebility docs to the bottom of menu

2023-09-10 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch wu-sheng-patch-1 in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git The following commit(s) were added to refs/heads/wu-sheng-patch-1 by this push: new 974344d8 Move

[skywalking-banyandb] branch wu-sheng-patch-1 created (now eecd29e7)

2023-09-10 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch wu-sheng-patch-1 in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git at eecd29e7 chore: modify http server default flag (#325) No new revisions were added by this up