[GitHub] [skywalking] wu-sheng commented on a diff in pull request #11341: docs: mark go2sky as archived

2023-09-17 Thread via GitHub
wu-sheng commented on code in PR #11341: URL: https://github.com/apache/skywalking/pull/11341#discussion_r1328288504 ## docs/en/concepts-and-designs/manual-sdk.md: ## @@ -1,9 +1,12 @@ # Manual instrument SDK Our incredible community has contributed to the manual instrument SDK

[GitHub] [skywalking] LinuxSuRen commented on a diff in pull request #11341: docs: mark go2sky as archived

2023-09-17 Thread via GitHub
LinuxSuRen commented on code in PR #11341: URL: https://github.com/apache/skywalking/pull/11341#discussion_r1328285981 ## docs/en/concepts-and-designs/manual-sdk.md: ## @@ -1,9 +1,12 @@ # Manual instrument SDK Our incredible community has contributed to the manual instrument S

[GitHub] [skywalking] wu-sheng commented on a diff in pull request #11341: docs: mark go2sky as archived

2023-09-17 Thread via GitHub
wu-sheng commented on code in PR #11341: URL: https://github.com/apache/skywalking/pull/11341#discussion_r1328284359 ## docs/en/concepts-and-designs/manual-sdk.md: ## @@ -1,9 +1,12 @@ # Manual instrument SDK Our incredible community has contributed to the manual instrument SDK

[GitHub] [skywalking] LinuxSuRen opened a new pull request, #11341: docs: mark go2sky as archived

2023-09-17 Thread via GitHub
LinuxSuRen opened a new pull request, #11341: URL: https://github.com/apache/skywalking/pull/11341 When I reading the manual sdk document, I found out the Go sdk repository is archived and there is an official one. I suggest that keeping the archived repositories exist util somedays l

[GitHub] [skywalking] wu-sheng commented on a diff in pull request #11330: [WIP][OSPP] PHP E2E

2023-09-17 Thread via GitHub
wu-sheng commented on code in PR #11330: URL: https://github.com/apache/skywalking/pull/11330#discussion_r1328263723 ## test/e2e-v2/cases/php/expected/service-instance-php.yml: ## @@ -16,7 +16,7 @@ # under the License. shadow {{- contains .}} -- id: {{ b64enc "php" }}.1_{{ b

[GitHub] [skywalking-banyandb] codecov-commenter commented on pull request #307: Unify query planner and executor

2023-09-17 Thread via GitHub
codecov-commenter commented on PR #307: URL: https://github.com/apache/skywalking-banyandb/pull/307#issuecomment-1722737835 ## [Codecov](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/307?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comme

[GitHub] [skywalking] wu-sheng closed issue #11340: [Bug] Index_not_found_exception

2023-09-17 Thread via GitHub
wu-sheng closed issue #11340: [Bug] Index_not_found_exception URL: https://github.com/apache/skywalking/issues/11340 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[GitHub] [skywalking] wu-sheng commented on issue #11340: [Bug] Index_not_found_exception

2023-09-17 Thread via GitHub
wu-sheng commented on issue #11340: URL: https://github.com/apache/skywalking/issues/11340#issuecomment-1722695672 This is either the init container fails, or you upgrade versions with old elastic server. A lot of discussions are there, no point to repeat it again. -- This is an au

[GitHub] [skywalking] khs123 opened a new issue, #11340: [Bug] Index_not_found_exception

2023-09-17 Thread via GitHub
khs123 opened a new issue, #11340: URL: https://github.com/apache/skywalking/issues/11340 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar issues. ### Apache SkyWalking Component

[skywalking-banyandb-java-client] branch property-ttl deleted (was a3cd949)

2023-09-17 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch property-ttl in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb-java-client.git was a3cd949 Update README.md The revisions that were on this branch are still contained

[skywalking-banyandb-java-client] branch main updated: Add property's ttl (#48)

2023-09-17 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb-java-client.git The following commit(s) were added to refs/heads/main by this push: new 5548fea Add property's t

[GitHub] [skywalking-banyandb-java-client] wu-sheng merged pull request #48: Add property's ttl

2023-09-17 Thread via GitHub
wu-sheng merged PR #48: URL: https://github.com/apache/skywalking-banyandb-java-client/pull/48 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificat

[skywalking-banyandb-java-client] branch property-ttl updated (76c33a5 -> a3cd949)

2023-09-17 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch property-ttl in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb-java-client.git from 76c33a5 Add property's ttl add a3cd949 Update README.md No new revisions were

[GitHub] [skywalking-banyandb-java-client] hailin0 closed pull request #47: [E2E Testing] Publish customize oap image

2023-09-17 Thread via GitHub
hailin0 closed pull request #47: [E2E Testing] Publish customize oap image URL: https://github.com/apache/skywalking-banyandb-java-client/pull/47 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [skywalking-banyandb-java-client] wu-sheng commented on a diff in pull request #48: Add property's ttl

2023-09-17 Thread via GitHub
wu-sheng commented on code in PR #48: URL: https://github.com/apache/skywalking-banyandb-java-client/pull/48#discussion_r1328195216 ## README.md: ## @@ -323,6 +323,23 @@ Property property = Property.create("default", "sw", "ui_template") this.client.apply(property); //created

[skywalking-banyandb-java-client] 01/01: Add property's ttl

2023-09-17 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a commit to branch property-ttl in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb-java-client.git commit 76c33a58f3cdf9db6b25b591c2ee3ea207740076 Author: Gao Hongtao AuthorDate: Mon Sep 18 0

[skywalking-banyandb-java-client] branch property-ttl created (now 76c33a5)

2023-09-17 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch property-ttl in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb-java-client.git at 76c33a5 Add property's ttl This branch includes the following new commits:

[GitHub] [skywalking] wu-sheng commented on pull request #11339: Feature pulsar monitoring

2023-09-17 Thread via GitHub
wu-sheng commented on PR #11339: URL: https://github.com/apache/skywalking/pull/11339#issuecomment-1722601302 CI Licence header check fails, ``` ERROR the following files don't have a valid license header: oap-server/server-starter/src/main/resources/otel-rules/pulsar/pulsar-bo

[GitHub] [skywalking] wu-sheng commented on pull request #11339: Feature pulsar monitoring

2023-09-17 Thread via GitHub
wu-sheng commented on PR #11339: URL: https://github.com/apache/skywalking/pull/11339#issuecomment-1722600764 Once this is done, please attach the screenshots. One more optional step is adding the monitoring in the showcase repository. -- This is an automated message from the Apache Git S

[GitHub] [skywalking] wu-sheng commented on pull request #11339: Feature pulsar monitoring

2023-09-17 Thread via GitHub
wu-sheng commented on PR #11339: URL: https://github.com/apache/skywalking/pull/11339#issuecomment-1722600577 Please ref https://github.com/apache/skywalking-booster-ui/pull/318 to submit PR for the translations of the menu words. -- This is an automated message from the Apache Git Servic

[GitHub] [skywalking] wu-sheng commented on a diff in pull request #11339: Feature pulsar monitoring

2023-09-17 Thread via GitHub
wu-sheng commented on code in PR #11339: URL: https://github.com/apache/skywalking/pull/11339#discussion_r1328166125 ## .github/workflows/skywalking.yaml: ## @@ -641,6 +641,9 @@ jobs: config: test/e2e-v2/cases/kafka/kafka-monitoring/e2e.yaml - name: MQE S

[skywalking-banyandb-java-client] branch main updated: Add mod revision check to write requests(measure/stream) (#46)

2023-09-17 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb-java-client.git The following commit(s) were added to refs/heads/main by this push: new 32eae17 Add mod revisi

[GitHub] [skywalking-banyandb-java-client] hanahmily merged pull request #46: Add mod revision check to write requests(measure/stream)

2023-09-17 Thread via GitHub
hanahmily merged PR #46: URL: https://github.com/apache/skywalking-banyandb-java-client/pull/46 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifica

[GitHub] [skywalking] liangyepianzhou opened a new pull request, #11339: Feature pulsar monitoring

2023-09-17 Thread via GitHub
liangyepianzhou opened a new pull request, #11339: URL: https://github.com/apache/skywalking/pull/11339 * [ ] If this is non-trivial feature, paste the links/URLs to the design doc. * [ ] Update the documentation to include this new feature. * [ ] Tests(including UT, IT, E2E) are ad

[skywalking-banyandb] branch liaison-topology updated (b1b70eaa -> 7333710c)

2023-09-17 Thread lujiajing
This is an automated email from the ASF dual-hosted git repository. lujiajing pushed a change to branch liaison-topology in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git from b1b70eaa fix lint add 7333710c fix license and refactor node API No new revisions were

[skywalking-banyandb] branch liaison-topology updated (7852938b -> b1b70eaa)

2023-09-17 Thread lujiajing
This is an automated email from the ASF dual-hosted git repository. lujiajing pushed a change to branch liaison-topology in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git from 7852938b fix lint add b1b70eaa fix lint No new revisions were added by this update. S

[skywalking-banyandb] branch liaison-topology updated (09f433b2 -> 7852938b)

2023-09-17 Thread lujiajing
This is an automated email from the ASF dual-hosted git repository. lujiajing pushed a change to branch liaison-topology in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git omit 09f433b2 fix lint omit 1b5af510 add maglev omit 40089d85 initialize discovery servic

[GitHub] [skywalking-infra-e2e] fgksgf merged pull request #117: Add : Support e2e( under 'concurrency' mode) outputting the summary of 'verify' in YAML format

2023-09-17 Thread via GitHub
fgksgf merged PR #117: URL: https://github.com/apache/skywalking-infra-e2e/pull/117 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubs

[GitHub] [skywalking-banyandb] wu-sheng merged pull request #332: Add TTL to the property

2023-09-17 Thread via GitHub
wu-sheng merged PR #332: URL: https://github.com/apache/skywalking-banyandb/pull/332 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsub

[GitHub] [skywalking] wu-sheng closed issue #10893: [Feature] [Property] Introduce TTL to properties

2023-09-17 Thread via GitHub
wu-sheng closed issue #10893: [Feature] [Property] Introduce TTL to properties URL: https://github.com/apache/skywalking/issues/10893 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [skywalking-banyandb] hanahmily commented on a diff in pull request #332: Add TTL to the property

2023-09-17 Thread via GitHub
hanahmily commented on code in PR #332: URL: https://github.com/apache/skywalking-banyandb/pull/332#discussion_r1328095142 ## docs/crud/property.md: ## @@ -111,6 +128,45 @@ List operation lists all properties in a group with a name. $ bydbctl property list -g sw -n ui_template

[skywalking-banyandb] branch property-ttl updated (c6bd7e42 -> 0ab1d62d)

2023-09-17 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch property-ttl in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git from c6bd7e42 Remove unused code add 0ab1d62d Polish examples in docs No new revisions were add

[GitHub] [skywalking-banyandb] wu-sheng commented on a diff in pull request #332: Add TTL to the property

2023-09-17 Thread via GitHub
wu-sheng commented on code in PR #332: URL: https://github.com/apache/skywalking-banyandb/pull/332#discussion_r1328093996 ## docs/crud/property.md: ## @@ -111,6 +128,45 @@ List operation lists all properties in a group with a name. $ bydbctl property list -g sw -n ui_template

[GitHub] [skywalking-banyandb] hanahmily commented on a diff in pull request #332: Add TTL to the property

2023-09-17 Thread via GitHub
hanahmily commented on code in PR #332: URL: https://github.com/apache/skywalking-banyandb/pull/332#discussion_r1328093682 ## docs/concept/data-model.md: ## @@ -198,6 +198,34 @@ tags: `Property` supports a three-level hierarchy, `group`/`name`/`id`, that is more flexible th

[GitHub] [skywalking-banyandb] hanahmily commented on a diff in pull request #332: Add TTL to the property

2023-09-17 Thread via GitHub
hanahmily commented on code in PR #332: URL: https://github.com/apache/skywalking-banyandb/pull/332#discussion_r1328093547 ## docs/concept/data-model.md: ## @@ -198,6 +198,34 @@ tags: `Property` supports a three-level hierarchy, `group`/`name`/`id`, that is more flexible th

[GitHub] [skywalking-banyandb] hanahmily commented on a diff in pull request #331: Support etcd client authentication

2023-09-17 Thread via GitHub
hanahmily commented on code in PR #331: URL: https://github.com/apache/skywalking-banyandb/pull/331#discussion_r1328091946 ## banyand/metadata/client.go: ## @@ -56,6 +71,11 @@ func (s *clientService) FlagSet() *run.FlagSet { fs := run.NewFlagSet("metadata") fs.S

[GitHub] [skywalking-banyandb] codecov-commenter commented on pull request #332: Add TTL to the property

2023-09-17 Thread via GitHub
codecov-commenter commented on PR #332: URL: https://github.com/apache/skywalking-banyandb/pull/332#issuecomment-1722465247 ## [Codecov](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/332?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comme

[GitHub] [skywalking-banyandb] wu-sheng commented on a diff in pull request #332: Add TTL to the property

2023-09-17 Thread via GitHub
wu-sheng commented on code in PR #332: URL: https://github.com/apache/skywalking-banyandb/pull/332#discussion_r1328087310 ## docs/concept/data-model.md: ## @@ -198,6 +198,34 @@ tags: `Property` supports a three-level hierarchy, `group`/`name`/`id`, that is more flexible tha

[skywalking-banyandb] branch main updated: Fix write response metadata field(measure/stream) (#330)

2023-09-17 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git The following commit(s) were added to refs/heads/main by this push: new 8996af56 Fix write response metadata

[GitHub] [skywalking-banyandb] hanahmily merged pull request #330: Fix write response metadata field(measure/stream)

2023-09-17 Thread via GitHub
hanahmily merged PR #330: URL: https://github.com/apache/skywalking-banyandb/pull/330 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsu

[skywalking-banyandb] branch property-ttl updated (3fc9abf8 -> ad9ea217)

2023-09-17 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch property-ttl in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git from 3fc9abf8 Add Keepalive add ad9ea217 Remove unused log No new revisions were added by this

[GitHub] [skywalking-banyandb] hanahmily opened a new pull request, #332: Add TTL to the property

2023-09-17 Thread via GitHub
hanahmily opened a new pull request, #332: URL: https://github.com/apache/skywalking-banyandb/pull/332 - [x] Update the documentation to include this new feature. - [x] Tests(including UT, IT, E2E) are added to verify the new feature. - [x] If this pull request closes/resolves/fixes an

[skywalking-banyandb] branch property-ttl created (now 3fc9abf8)

2023-09-17 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch property-ttl in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git at 3fc9abf8 Add Keepalive This branch includes the following new commits: new f3874f3e Apply

[skywalking-banyandb] 01/03: Apply TTL to a property

2023-09-17 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a commit to branch property-ttl in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git commit f3874f3ecfeb3eb4bb695f4b524fb53c4d1a4235 Author: Gao Hongtao AuthorDate: Sun Sep 17 02:16:04 2023

[skywalking-banyandb] 02/03: Merge remote-tracking branch 'origin/main' into property-ttl

2023-09-17 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a commit to branch property-ttl in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git commit 021a007fa0b31c7287f3e82568f1f5d5ae884624 Merge: f3874f3e 9552688d Author: Gao Hongtao AuthorDate:

[skywalking-banyandb] 03/03: Add Keepalive

2023-09-17 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a commit to branch property-ttl in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git commit 3fc9abf8bacf5414fcfb2e5eeb25c987bdede718 Author: Gao Hongtao AuthorDate: Sun Sep 17 11:43:54 2023