liangyepianzhou opened a new pull request, #329:
URL: https://github.com/apache/skywalking-booster-ui/pull/329
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
wu-sheng merged PR #329:
URL: https://github.com/apache/skywalking-booster-ui/pull/329
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-uns
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/skywalking-booster-ui.git
The following commit(s) were added to refs/heads/main by this push:
new f88c8a97 feat(pulsar): add new menu
peachisai opened a new pull request, #625:
URL: https://github.com/apache/skywalking-java/pull/625
### Add an agent plugin to support
- [x] Add a test case for the new plugin, refer to [the
doc](https://github.com/apache/skywalking-java/blob/main/docs/en/setup/service
peachisai opened a new pull request, #330:
URL: https://github.com/apache/skywalking-booster-ui/pull/330
--
This is an automated message from the Apache Git Service.
To respo
peachisai opened a new pull request, #11442:
URL: https://github.com/apache/skywalking/pull/11442
- [ ] If this pull request closes/resolves/fixes an existing issue, replace
the issue number. Closes #.
- [x] Update the [`CHANGES`
log](https://github.com/ap
wu-sheng commented on PR #625:
URL: https://github.com/apache/skywalking-java/pull/625#issuecomment-1773729672
Before any review, I think we need a clearance from you, what is netty
plugin.
Netty is a widely used TCP level framework. So in theory, there isn't a
general solution to fit it
peachisai commented on PR #625:
URL: https://github.com/apache/skywalking-java/pull/625#issuecomment-1773734175
> Before any review, I think we need a clearance from you, what is netty
plugin. Netty is a widely used TCP level framework. So in theory, there isn't a
general solution to fit it
wu-sheng commented on PR #625:
URL: https://github.com/apache/skywalking-java/pull/625#issuecomment-1773734535
Then you should be clear for all relative codes and docs.
This is only netty-http
--
This is an automated message from the Apache Git Service.
To respond to the message, please
peachisai commented on PR #625:
URL: https://github.com/apache/skywalking-java/pull/625#issuecomment-1773735370
> Then you should be clear for all relative codes and docs. This is only
netty-http
ok i will change those
--
This is an automated message from the Apache Git Service.
To
wu-sheng commented on PR #330:
URL:
https://github.com/apache/skywalking-booster-ui/pull/330#issuecomment-1773749688
This should be netty-http.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
wu-sheng commented on code in PR #11442:
URL: https://github.com/apache/skywalking/pull/11442#discussion_r1367709102
##
oap-server/server-starter/src/main/resources/component-libraries.yml:
##
@@ -502,6 +502,9 @@ Aerospike:
Nacos:
id: 150
languages: Java
+Netty:
Review C
peachisai commented on PR #330:
URL:
https://github.com/apache/skywalking-booster-ui/pull/330#issuecomment-1773767419
> This should be netty-http.
Is it okay for all the Netty traces to use the same icon? Or should it be
renamed to "netty-http"?
--
This is an automated message fro
wu-sheng commented on PR #330:
URL:
https://github.com/apache/skywalking-booster-ui/pull/330#issuecomment-1773775248
> > This should be netty-http.
>
> Is it okay for all the Netty traces to use the same icon? Or should it be
renamed to "netty-http"?
It follows the ID you add
wu-sheng commented on PR #330:
URL:
https://github.com/apache/skywalking-booster-ui/pull/330#issuecomment-1773775466
And the file name should be all in upper case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
wu-sheng commented on code in PR #625:
URL: https://github.com/apache/skywalking-java/pull/625#discussion_r1367722749
##
apm-protocol/apm-network/src/main/java/org/apache/skywalking/apm/network/trace/component/ComponentsDefine.java:
##
@@ -242,4 +242,6 @@ public class Components
wu-sheng commented on code in PR #625:
URL: https://github.com/apache/skywalking-java/pull/625#discussion_r1367722811
##
docs/en/setup/service-agent/java-agent/Supported-list.md:
##
@@ -25,6 +25,7 @@ metrics based on the tracing data.
* [Jersey REST framework](https://github.
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git
The following commit(s) were added to refs/heads/master by this push:
new fac8309e13 Add a component ID for Netty (#1
wu-sheng commented on code in PR #625:
URL: https://github.com/apache/skywalking-java/pull/625#discussion_r1367722956
##
test/plugin/scenarios/netty-http-4.1.x-scenario/support-version.list:
##
@@ -0,0 +1,19 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or
wu-sheng merged PR #11442:
URL: https://github.com/apache/skywalking/pull/11442
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr..
wu-sheng commented on PR #330:
URL:
https://github.com/apache/skywalking-booster-ui/pull/330#issuecomment-1773781904
> And the file name should be all in upper case.
You missed this, and please compress the icon. 26k is too large. We are
expecting the size < 5k.
--
This is an auto
wu-sheng commented on PR #625:
URL: https://github.com/apache/skywalking-java/pull/625#issuecomment-1773784815
The plugin name is not consistent with the doc. CI fails
```
---
/home/runner/work/skywalking-java/skywalking-java/tools/plugin/md-javaagent-plugin-list.txt
2023-10-
wu-sheng commented on PR #330:
URL:
https://github.com/apache/skywalking-booster-ui/pull/330#issuecomment-1773790912
You forget the renaming. :P
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
peachisai commented on code in PR #625:
URL: https://github.com/apache/skywalking-java/pull/625#discussion_r1367731363
##
test/plugin/scenarios/netty-http-4.1.x-scenario/support-version.list:
##
@@ -0,0 +1,19 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or
wu-sheng commented on code in PR #625:
URL: https://github.com/apache/skywalking-java/pull/625#discussion_r1367732401
##
test/plugin/scenarios/netty-http-4.1.x-scenario/support-version.list:
##
@@ -0,0 +1,19 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or
peachisai commented on code in PR #625:
URL: https://github.com/apache/skywalking-java/pull/625#discussion_r1367732424
##
apm-protocol/apm-network/src/main/java/org/apache/skywalking/apm/network/trace/component/ComponentsDefine.java:
##
@@ -242,4 +242,6 @@ public class Component
peachisai commented on PR #330:
URL:
https://github.com/apache/skywalking-booster-ui/pull/330#issuecomment-1773799525
> You forget the renaming. :P
Okay
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
peachisai commented on PR #330:
URL:
https://github.com/apache/skywalking-booster-ui/pull/330#issuecomment-1773799396
> You forget the renaming. :P
Okay
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
peachisai commented on code in PR #625:
URL: https://github.com/apache/skywalking-java/pull/625#discussion_r1367734754
##
test/plugin/scenarios/netty-http-4.1.x-scenario/support-version.list:
##
@@ -0,0 +1,19 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or
peachisai commented on code in PR #625:
URL: https://github.com/apache/skywalking-java/pull/625#discussion_r1367735476
##
docs/en/setup/service-agent/java-agent/Supported-list.md:
##
@@ -25,6 +25,7 @@ metrics based on the tracing data.
* [Jersey REST framework](https://github
wu-sheng commented on PR #330:
URL:
https://github.com/apache/skywalking-booster-ui/pull/330#issuecomment-1773802727
Could you double-check locally? Is `-` going to be removed automatically and
request the `NETTYHTTP.png` by the UI?
--
This is an automated message from the Apache Git Ser
wu-sheng commented on PR #625:
URL: https://github.com/apache/skywalking-java/pull/625#issuecomment-1773803917
I didn't check the failed test cases. I feel as many other frameworks are
using netty, you newly added a plugin for it could change the expected tracing
data(spans or something).
peachisai commented on PR #330:
URL:
https://github.com/apache/skywalking-booster-ui/pull/330#issuecomment-1773815110
> Could you double-check locally? Is `-` going to be removed automatically
and request the `NETTYHTTP.png` by the UI?
 were added to refs/heads/main by this push:
new 6fb4f074 add a netty icon (#330)
6fb
wu-sheng commented on code in PR #11339:
URL: https://github.com/apache/skywalking/pull/11339#discussion_r1367746835
##
oap-server/server-starter/src/main/resources/otel-rules/pulsar/pulsar-broker.yaml:
##
@@ -34,66 +34,14 @@ metricPrefix: meter_pulsar_broker
# Metrics Rules
liangyepianzhou commented on code in PR #11339:
URL: https://github.com/apache/skywalking/pull/11339#discussion_r1367747599
##
oap-server/server-starter/src/main/resources/otel-rules/pulsar/pulsar-broker.yaml:
##
@@ -34,66 +34,14 @@ metricPrefix: meter_pulsar_broker
# Metrics
wu-sheng commented on code in PR #11339:
URL: https://github.com/apache/skywalking/pull/11339#discussion_r1367748629
##
oap-server/server-starter/src/main/resources/otel-rules/pulsar/pulsar-broker.yaml:
##
@@ -34,66 +34,14 @@ metricPrefix: meter_pulsar_broker
# Metrics Rules
liangyepianzhou commented on code in PR #11339:
URL: https://github.com/apache/skywalking/pull/11339#discussion_r1367827685
##
oap-server/server-starter/src/main/resources/otel-rules/pulsar/pulsar-broker.yaml:
##
@@ -34,66 +34,14 @@ metricPrefix: meter_pulsar_broker
# Metrics
liangyepianzhou commented on code in PR #11339:
URL: https://github.com/apache/skywalking/pull/11339#discussion_r1367827685
##
oap-server/server-starter/src/main/resources/otel-rules/pulsar/pulsar-broker.yaml:
##
@@ -34,66 +34,14 @@ metricPrefix: meter_pulsar_broker
# Metrics
wu-sheng commented on code in PR #11339:
URL: https://github.com/apache/skywalking/pull/11339#discussion_r1367828163
##
oap-server/server-starter/src/main/resources/otel-rules/pulsar/pulsar-broker.yaml:
##
@@ -34,66 +34,14 @@ metricPrefix: meter_pulsar_broker
# Metrics Rules
peachisai commented on PR #625:
URL: https://github.com/apache/skywalking-java/pull/625#issuecomment-1773981277
> I didn't check the failed test cases. I feel as many other frameworks are
using netty, you newly added a plugin for it could change the expected tracing
data(spans or something)
wu-sheng commented on PR #625:
URL: https://github.com/apache/skywalking-java/pull/625#issuecomment-1773981541
Take your time. We are not in urgent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
43 matches
Mail list logo
