[PR] Overlay javaagent by pod annotation. [skywalking-swck]

2023-11-30 Thread via GitHub
weixiang1862 opened a new pull request, #105: URL: https://github.com/apache/skywalking-swck/pull/105 I use workload annotations to inject agent agent name and collector backend_service, I fount javaagent can not get the correct value: ``` [root@15 ~]# kubectl get javaagent -A NAMES

(skywalking-grafana-plugins) branch dependabot/npm_and_yarn/adobe/css-tools-4.3.2 created (now 10f751e)

2023-11-30 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/npm_and_yarn/adobe/css-tools-4.3.2 in repository https://gitbox.apache.org/repos/asf/skywalking-grafana-plugins.git at 10f751e build(deps): bump @adobe/css-tools from 4.3.1

[PR] build(deps): bump @adobe/css-tools from 4.3.1 to 4.3.2 [skywalking-grafana-plugins]

2023-11-30 Thread via GitHub
dependabot[bot] opened a new pull request, #31: URL: https://github.com/apache/skywalking-grafana-plugins/pull/31 Bumps [@adobe/css-tools](https://github.com/adobe/css-tools) from 4.3.1 to 4.3.2. Changelog Sourced from https://github.com/adobe/css-tools/blob/main/History.md";>@​ado

Re: [PR] fix: the service parameter is wrong when the view dump from Log to Trace widget by clicking traceID [skywalking-booster-ui]

2023-11-30 Thread via GitHub
jampsen commented on PR #343: URL: https://github.com/apache/skywalking-booster-ui/pull/343#issuecomment-1835507537 Thank you for your response,The daily package built 2 days ago from this page: https://github.com/apache/skywalking/pkgs/container/skywalking%2Fui I think it's the latest v

Re: [PR] fix: the service parameter is wrong when the view dump from Log to Trace widget by clicking traceID [skywalking-booster-ui]

2023-11-30 Thread via GitHub
Fine0830 commented on PR #343: URL: https://github.com/apache/skywalking-booster-ui/pull/343#issuecomment-1835483664 > Hi, Thank you for your contribution. We tried the daily package: skywalking/ui:33e3f28fcf13683895737ea5551af5b6a16df219 And we find that When Trace page jump to Log page ,

[PR] Add `layer` parameter to the global topology graphQL query. [skywalking]

2023-11-30 Thread via GitHub
mrproliu opened a new pull request, #11620: URL: https://github.com/apache/skywalking/pull/11620 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [x] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/d

Re: [PR] fix: the service parameter is wrong when the view dump from Log to Trace widget by clicking traceID [skywalking-booster-ui]

2023-11-30 Thread via GitHub
jampsen commented on PR #343: URL: https://github.com/apache/skywalking-booster-ui/pull/343#issuecomment-1835445795 Hi, Thank you for your contribution. We tried the daily package: skywalking/ui:33e3f28fcf13683895737ea5551af5b6a16df219 And we find that When Trace page jump to Log pag

(skywalking-cli) branch topology-global deleted (was e81a521)

2023-11-30 Thread liuhan
This is an automated email from the ASF dual-hosted git repository. liuhan pushed a change to branch topology-global in repository https://gitbox.apache.org/repos/asf/skywalking-cli.git was e81a521 Adding backend version check The revisions that were on this branch are still contained in

Re: [PR] Support global dependency query command [skywalking-cli]

2023-11-30 Thread via GitHub
wu-sheng merged PR #198: URL: https://github.com/apache/skywalking-cli/pull/198 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr..

(skywalking-cli) branch master updated: Support global dependency query command (#198)

2023-11-30 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-cli.git The following commit(s) were added to refs/heads/master by this push: new d5f3597 Support global dependency quer

(skywalking-cli) branch topology-global updated (bd6ce14 -> e81a521)

2023-11-30 Thread liuhan
This is an automated email from the ASF dual-hosted git repository. liuhan pushed a change to branch topology-global in repository https://gitbox.apache.org/repos/asf/skywalking-cli.git from bd6ce14 Support global dependency query command add e81a521 Adding backend version check No n

Re: [PR] Support global dependency query command [skywalking-cli]

2023-11-30 Thread via GitHub
mrproliu commented on PR #198: URL: https://github.com/apache/skywalking-cli/pull/198#issuecomment-1835407138 Got it, If the version is smaller than 10.0.0, we should ignore the layer parameter. I will update in this PR. -- This is an automated message from the Apache Git Service. To resp

Re: [PR] Support global dependency query command [skywalking-cli]

2023-11-30 Thread via GitHub
wu-sheng commented on PR #198: URL: https://github.com/apache/skywalking-cli/pull/198#issuecomment-1835404710 A nit, as you added layer parameter, you need the version check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Support global dependency query command [skywalking-cli]

2023-11-30 Thread via GitHub
codecov-commenter commented on PR #198: URL: https://github.com/apache/skywalking-cli/pull/198#issuecomment-1835391241 ## [Codecov](https://app.codecov.io/gh/apache/skywalking-cli/pull/198?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_ter

[PR] Support global dependency query command [skywalking-cli]

2023-11-30 Thread via GitHub
mrproliu opened a new pull request, #198: URL: https://github.com/apache/skywalking-cli/pull/198 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

(skywalking-cli) 01/01: Support global dependency query command

2023-11-30 Thread liuhan
This is an automated email from the ASF dual-hosted git repository. liuhan pushed a commit to branch topology-global in repository https://gitbox.apache.org/repos/asf/skywalking-cli.git commit bd6ce142191d61819cd5abf7367a7274e1fd2e96 Author: mrproliu <741550...@qq.com> AuthorDate: Fri Dec 1 11:12

(skywalking-cli) branch topology-global created (now bd6ce14)

2023-11-30 Thread liuhan
This is an automated email from the ASF dual-hosted git repository. liuhan pushed a change to branch topology-global in repository https://gitbox.apache.org/repos/asf/skywalking-cli.git at bd6ce14 Support global dependency query command This branch includes the following new commits:

(skywalking-java) branch main updated: Optimize plugin selector logic. (#651)

2023-11-30 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/skywalking-java.git The following commit(s) were added to refs/heads/main by this push: new 6220af1172 Optimize plugin selector logic.

Re: [PR] Optimize plugin selector logic. [skywalking-java]

2023-11-30 Thread via GitHub
wu-sheng merged PR #651: URL: https://github.com/apache/skywalking-java/pull/651 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr.

Re: [PR] Optimize plugin selector logic. [skywalking-java]

2023-11-30 Thread via GitHub
weixiang1862 commented on code in PR #651: URL: https://github.com/apache/skywalking-java/pull/651#discussion_r1411454329 ## apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/plugin/PluginCfg.java: ## @@ -52,14 +52,13 @@ void load(InputStream input) t

Re: [PR] Adding the optional layer parameter in the topology query [skywalking-query-protocol]

2023-11-30 Thread via GitHub
wu-sheng merged PR #127: URL: https://github.com/apache/skywalking-query-protocol/pull/127 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications

(skywalking-query-protocol) branch master updated: Adding the optional layer parameter in the topology query (#127)

2023-11-30 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-query-protocol.git The following commit(s) were added to refs/heads/master by this push: new e08b0a7 Adding the optional

[PR] Adding the optional layer parameter in the topology query [skywalking-query-protocol]

2023-11-30 Thread via GitHub
mrproliu opened a new pull request, #127: URL: https://github.com/apache/skywalking-query-protocol/pull/127 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [I] [Feature] Quick start shell for latest release [skywalking]

2023-11-30 Thread via GitHub
wu-sheng commented on issue #11619: URL: https://github.com/apache/skywalking/issues/11619#issuecomment-1834665197 > From my perspective, BanyanDB 0.6 will be a proper release for this combination. Is there a recommended version for this script? After 0.6, should be pick the latest s

Re: [I] [Feature] Quick start shell for latest release [skywalking]

2023-11-30 Thread via GitHub
hanahmily commented on issue #11619: URL: https://github.com/apache/skywalking/issues/11619#issuecomment-1834663646 From my perspective, BanyanDB 0.6 will be a proper release for this combination. -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [PR] fix: limit the bytes of redis args [skywalking-go]

2023-11-30 Thread via GitHub
wu-sheng commented on PR #153: URL: https://github.com/apache/skywalking-go/pull/153#issuecomment-1834317072 Did you test the codes you changed? It seems it doesn't work and runnable actually. https://github.com/apache/skywalking-go/actions/runs/7044082174/job/19171487594?pr=153 --

Re: [PR] Optimize plugin selector logic. [skywalking-java]

2023-11-30 Thread via GitHub
wu-sheng commented on code in PR #651: URL: https://github.com/apache/skywalking-java/pull/651#discussion_r1410969331 ## apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/plugin/PluginCfg.java: ## @@ -52,14 +52,13 @@ void load(InputStream input) throw

(skywalking-booster-ui) branch main updated: feat: support search on Marketplace (#350)

2023-11-30 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/skywalking-booster-ui.git The following commit(s) were added to refs/heads/main by this push: new b2ab9392 feat: support search on Mar

Re: [I] [Feature] Support search on Marketplace [skywalking]

2023-11-30 Thread via GitHub
wu-sheng closed issue #11616: [Feature] Support search on Marketplace URL: https://github.com/apache/skywalking/issues/11616 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] feat: support search on Marketplace [skywalking-booster-ui]

2023-11-30 Thread via GitHub
wu-sheng merged PR #350: URL: https://github.com/apache/skywalking-booster-ui/pull/350 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-uns

Re: [I] [Feature] Quick start shell for latest release [skywalking]

2023-11-30 Thread via GitHub
wu-sheng commented on issue #11619: URL: https://github.com/apache/skywalking/issues/11619#issuecomment-1833997352 @hanahmily Could you propose what is recommended for the version of BanyanDB? We could hard coded for now, until you have a better solution. -- This is an automated message f

[I] [Feature] Quick start shell for latest release [skywalking]

2023-11-30 Thread via GitHub
wu-sheng opened a new issue, #11619: URL: https://github.com/apache/skywalking/issues/11619 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement. ### Description

Re: [PR] fix: limit the bytes of redis args [skywalking-go]

2023-11-30 Thread via GitHub
wu-sheng commented on PR #153: URL: https://github.com/apache/skywalking-go/pull/153#issuecomment-1833693930 CI had logs, you should be able to read them, and CI is able to run locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] fix: limit the bytes of redis args [skywalking-go]

2023-11-30 Thread via GitHub
rfyiamcool commented on PR #153: URL: https://github.com/apache/skywalking-go/pull/153#issuecomment-1833476947 > Please fix the CI. I don't know how to fix this problem. 😅 give me some Pointers. -- This is an automated message from the Apache Git Service. To respond to the mess

Re: [PR] fix: limit the bytes of redis args [skywalking-go]

2023-11-30 Thread via GitHub
mrproliu commented on PR #153: URL: https://github.com/apache/skywalking-go/pull/153#issuecomment-1833368516 Please fix the CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] feat: add client ip in gin [skywalking-go]

2023-11-30 Thread via GitHub
rfyiamcool closed pull request #154: feat: add client ip in gin URL: https://github.com/apache/skywalking-go/pull/154 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

Re: [PR] fix: limit the bytes of redis args [skywalking-go]

2023-11-30 Thread via GitHub
rfyiamcool commented on PR #153: URL: https://github.com/apache/skywalking-go/pull/153#issuecomment-187327 > Could you add this feature into the [CHANGES.md](https://github.com/apache/skywalking-go/blob/main/CHANGES.md)? done. 😁 -- This is an automated message from the Apache