Re: [I] [UI Feature] Add Support for dragging in the trace panel [skywalking]

2024-03-11 Thread via GitHub
wu-sheng commented on issue #12004: URL: https://github.com/apache/skywalking/issues/12004#issuecomment-1989722865 Pop back is good, but notice, that if it keeps in auto-hidden mode, there is a chance users can't click the item in time, before the list is hidden again. -- This is an

Re: [I] [UI Feature] Add Support for dragging in the trace panel [skywalking]

2024-03-11 Thread via GitHub
CodePrometheus commented on issue #12004: URL: https://github.com/apache/skywalking/issues/12004#issuecomment-1989718388 > One more suggestion, you should make sure the segment list(left panel) showing out when users apply for the query. Otherwise, the hidden part would be confused. So,

Re: [PR] Implement GC for SeriesDatabase of TSDB [skywalking-banyandb]

2024-03-11 Thread via GitHub
wu-sheng commented on PR #409: URL: https://github.com/apache/skywalking-banyandb/pull/409#issuecomment-1989711152 Please fix the CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] [UI Feature] Add Support for dragging in the trace panel [skywalking]

2024-03-11 Thread via GitHub
wu-sheng commented on issue #12004: URL: https://github.com/apache/skywalking/issues/12004#issuecomment-1989707639 One more suggestion, you should make sure the segment list(left panel) showing out when users apply for the query. Otherwise, the hidden part would be confused. So, how to

[PR] Implement GC for SeriesDatabase of TSDB [skywalking-banyandb]

2024-03-11 Thread via GitHub
zesiar0 opened a new pull request, #409: URL: https://github.com/apache/skywalking-banyandb/pull/409 [ x ] https://github.com/apache/skywalking/issues/11494 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [I] [UI Feature] Add Support for dragging in the trace panel [skywalking]

2024-03-11 Thread via GitHub
Superskyyy commented on issue #12004: URL: https://github.com/apache/skywalking/issues/12004#issuecomment-1988948371 Looks like a good ux design + 1 from me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [I] [UI Feature] Add Support for dragging in the trace panel [skywalking]

2024-03-11 Thread via GitHub
CodePrometheus commented on issue #12004: URL: https://github.com/apache/skywalking/issues/12004#issuecomment-1988861700 Sure, the color is just for convenience of description, I will adapt it to the theme color of skywalking. -- This is an automated message from the Apache Git Service.

Re: [I] [UI Feature] Add Support for dragging in the trace panel [skywalking]

2024-03-11 Thread via GitHub
wu-sheng commented on issue #12004: URL: https://github.com/apache/skywalking/issues/12004#issuecomment-1988858079 I am not sure about the color as pink, others seem good. @Fine0830 what do you think the design? @CodePrometheus will do this on his own. -- This is an automated

[I] [UI Feature] Add Support for dragging in the trace panel [skywalking]

2024-03-11 Thread via GitHub
CodePrometheus opened a new issue, #12004: URL: https://github.com/apache/skywalking/issues/12004 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement. ###

Re: [I] [Bug] Metrics are not aggregated properly as OTEL collector targeting per node [skywalking]

2024-03-11 Thread via GitHub
wu-sheng commented on issue #11982: URL: https://github.com/apache/skywalking/issues/11982#issuecomment-1988781280 > > > Pulsar monitoring is to aggregate the cluster and node(broker) metrics together now, it should be fine. > > > > > > The question is how to aggregate the

Re: [I] [Bug] Metrics are not aggregated properly as OTEL collector targeting per node [skywalking]

2024-03-11 Thread via GitHub
CodePrometheus commented on issue #11982: URL: https://github.com/apache/skywalking/issues/11982#issuecomment-1988769602 > > Pulsar monitoring is to aggregate the cluster and node(broker) metrics together now, it should be fine. > > The question is how to aggregate the metrics of the

Re: [I] [Bug] The follow-up with skywalking-java can not coexist with other agents. #9698 [skywalking]

2024-03-11 Thread via GitHub
wranglerlmx commented on issue #9701: URL: https://github.com/apache/skywalking/issues/9701#issuecomment-1988152874 After I found out about this problem, after idea 2024. x, debug mode startup will report an error. Normal after switching to idea 2023. x. -- This is an automated message

Re: [I] How to customize traceid in skywalking? [skywalking]

2024-03-11 Thread via GitHub
wu-sheng commented on issue #1941: URL: https://github.com/apache/skywalking/issues/1941#issuecomment-1987882220 > > > I think the toolkit should have many rich APIs, so that we can easily get, modify, reset, stop traceId etc. > > > > > > There is no such thing about modify and

Re: [I] How to customize traceid in skywalking? [skywalking]

2024-03-11 Thread via GitHub
etertal commented on issue #1941: URL: https://github.com/apache/skywalking/issues/1941#issuecomment-1987873972 > > I think the toolkit should have many rich APIs, so that we can easily get, modify, reset, stop traceId etc. > > There is no such thing about modify and reset. Once we