Re: [I] Properties page not loading up in skywalking banyandb UI [skywalking]

2024-03-12 Thread via GitHub
sksDonni commented on issue #12007: URL: https://github.com/apache/skywalking/issues/12007#issuecomment-1993390987 sorry @Superskyyy, Here is the screengrab- https://github.com/apache/skywalking/assets/53624363/0b2025ed-efbe-4e75-9eed-6755d6603e1c -- This is an automated

Re: [PR] Fix chore [skywalking-website]

2024-03-12 Thread via GitHub
netlify[bot] commented on PR #686: URL: https://github.com/apache/skywalking-website/pull/686#issuecomment-1992951747 ###  Deploy Preview for *skywalking-website-preview* processing. | Name | Link | |:-:|| | Latest commit |

Re: [PR] Fix chore [skywalking-website]

2024-03-12 Thread via GitHub
wu-sheng merged PR #686: URL: https://github.com/apache/skywalking-website/pull/686 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] Fix chore [skywalking-website]

2024-03-12 Thread via GitHub
wu-sheng opened a new pull request, #686: URL: https://github.com/apache/skywalking-website/pull/686 FYI @CzyerChen -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

(skywalking-website) branch wu-sheng-patch-1 deleted (was 8fe262f4da2)

2024-03-12 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch wu-sheng-patch-1 in repository https://gitbox.apache.org/repos/asf/skywalking-website.git was 8fe262f4da2 Update index.md The revisions that were on this branch are still contained in

(skywalking-website) branch master updated: Fix chore (#686)

2024-03-12 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-website.git The following commit(s) were added to refs/heads/master by this push: new 0613efd0247 Fix chore (#686)

(skywalking-website) branch wu-sheng-patch-1 updated: Update index.md

2024-03-12 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch wu-sheng-patch-1 in repository https://gitbox.apache.org/repos/asf/skywalking-website.git The following commit(s) were added to refs/heads/wu-sheng-patch-1 by this push: new 8fe262f4da2

(skywalking-website) 01/01: Update index.md

2024-03-12 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch wu-sheng-patch-1 in repository https://gitbox.apache.org/repos/asf/skywalking-website.git commit a6e8a09406ef7b84d587b41f04073ef1cdce664e Author: 吴晟 Wu Sheng AuthorDate: Wed Mar 13 09:18:29

(skywalking-website) branch wu-sheng-patch-1 created (now a6e8a09406e)

2024-03-12 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch wu-sheng-patch-1 in repository https://gitbox.apache.org/repos/asf/skywalking-website.git at a6e8a09406e Update index.md This branch includes the following new commits: new

Re: [PR] [DRAFT] [issue-11880] support play3 [skywalking-java]

2024-03-12 Thread via GitHub
wu-sheng closed pull request #671: [DRAFT] [issue-11880] support play3 URL: https://github.com/apache/skywalking-java/pull/671 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [DRAFT] [issue-11880] support play3 [skywalking-java]

2024-03-12 Thread via GitHub
wu-sheng commented on PR #671: URL: https://github.com/apache/skywalking-java/pull/671#issuecomment-1992798669 Close as no update for weeks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Implement GC for SeriesDatabase of TSDB [skywalking-banyandb]

2024-03-12 Thread via GitHub
hanahmily commented on code in PR #409: URL: https://github.com/apache/skywalking-banyandb/pull/409#discussion_r1522122508 ## banyand/internal/storage/index.go: ## @@ -224,3 +229,84 @@ func appendSeriesList(dest, src pbv1.SeriesList, filter posting.List) pbv1.Serie func (s

Re: [I] Properties page not loading up in skywalking banyandb UI [skywalking]

2024-03-12 Thread via GitHub
Superskyyy commented on issue #12007: URL: https://github.com/apache/skywalking/issues/12007#issuecomment-1992371706 The screen grab was not uploaded in the issue. And assigned to you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [I] Properties page not loading up in skywalking banyandb UI [skywalking]

2024-03-12 Thread via GitHub
sksDonni commented on issue #12007: URL: https://github.com/apache/skywalking/issues/12007#issuecomment-1992339438 @hanahmily @wu-sheng, Have picked this up, as this is a blocker to a ticket I was earlier working on. -- This is an automated message from the Apache Git Service. To respond

[I] Properties page not loading up in skywalking banyandb UI [skywalking]

2024-03-12 Thread via GitHub
sksDonni opened a new issue, #12007: URL: https://github.com/apache/skywalking/issues/12007 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar issues. ### Apache SkyWalking Component

(skywalking-java) branch main updated: Fix not tracing in HttpClient v5 when HttpHost(arg[0]) is null but `RoutingSupport#determineHost` works. (#674)

2024-03-12 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/skywalking-java.git The following commit(s) were added to refs/heads/main by this push: new 466f173f98 Fix not tracing in HttpClient

Re: [PR] Fix not tracing in HttpClient v5 when HttpHost(arg[0]) is null but `RoutingSupport#determineHost` works. [skywalking-java]

2024-03-12 Thread via GitHub
wu-sheng merged PR #674: URL: https://github.com/apache/skywalking-java/pull/674 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Fix a bug in hc5: when the arg HttpHost of InternalHttpClient#doExecute is null, hc5 would send request but the agent don't create span [skywalking-java]

2024-03-12 Thread via GitHub
wu-sheng commented on code in PR #674: URL: https://github.com/apache/skywalking-java/pull/674#discussion_r1521592423 ## CHANGES.md: ## @@ -17,6 +17,7 @@ Release Notes. * Support for ActiveMQ-Artemis messaging tracing. * Archive the expired plugins `impala-jdbc-2.6.x-plugin`.

[PR] Fix a bug in hc5: when the arg HttpHost of InternalHttpClient#doExecute is null, hc5 would send request but the agent don't create span [skywalking-java]

2024-03-12 Thread via GitHub
cylx3126 opened a new pull request, #674: URL: https://github.com/apache/skywalking-java/pull/674 [MRE here](https://github.com/cylx3126/skywalking-hc5-losespan-mre). - [x] Add a unit test to verify that the fix works. - [x] Explain briefly why the bug exists and how to fix it.

(skywalking-booster-ui) branch main updated: fix(doc): fix the dev local port (#375)

2024-03-12 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/skywalking-booster-ui.git The following commit(s) were added to refs/heads/main by this push: new 0e0b4e1f fix(doc): fix the dev

Re: [PR] fix(doc): fix the dev local port [skywalking-booster-ui]

2024-03-12 Thread via GitHub
wu-sheng merged PR #375: URL: https://github.com/apache/skywalking-booster-ui/pull/375 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] fix(doc): fix the dev local port [skywalking-booster-ui]

2024-03-12 Thread via GitHub
CzyerChen commented on PR #375: URL: https://github.com/apache/skywalking-booster-ui/pull/375#issuecomment-1991257362 > @CzyerChen Please revert irrelevant parts, the doc fix is good. reformatted by `prettier --write` automatically when committing, and can not revert.

Re: [PR] fix(doc): fix the dev local port [skywalking-booster-ui]

2024-03-12 Thread via GitHub
wu-sheng commented on PR #375: URL: https://github.com/apache/skywalking-booster-ui/pull/375#issuecomment-1991189939 @CzyerChen Please revert irrelevant parts, the doc fix is good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] fix(doc): fix the dev local port [skywalking-booster-ui]

2024-03-12 Thread via GitHub
Fine0830 commented on code in PR #375: URL: https://github.com/apache/skywalking-booster-ui/pull/375#discussion_r1521131370 ## README.md: ## @@ -34,14 +34,15 @@ npm install npm run dev ``` -The default UI address is `http://localhost:8080`. +The default UI address is

Re: [PR] fix(doc): fix the dev local port [skywalking-booster-ui]

2024-03-12 Thread via GitHub
wu-sheng commented on code in PR #375: URL: https://github.com/apache/skywalking-booster-ui/pull/375#discussion_r1521120700 ## README.md: ## @@ -34,14 +34,15 @@ npm install npm run dev ``` -The default UI address is `http://localhost:8080`. +The default UI address is

[PR] fix(doc): fix the dev local port [skywalking-booster-ui]

2024-03-12 Thread via GitHub
CzyerChen opened a new pull request, #375: URL: https://github.com/apache/skywalking-booster-ui/pull/375 The default UI address is `http://localhost:3000`. ``` VITE v4.5.2 ready in 2551 ms ➜ Local: http://localhost:3000/ ``` -- This is an automated message from

Re: [PR] Change topN group key from `StorageId` to `entityId + timeBucket`. [skywalking]

2024-03-12 Thread via GitHub
ZhengBing520 commented on PR #11788: URL: https://github.com/apache/skywalking/pull/11788#issuecomment-1991046398 > > > So I change topN group key to entityId + timeBucket, then stash map can only reserve topN of every entity(db, cache) in the minute level. > > > > > > The

(skywalking) branch master updated: Add BanyanDB to docker-compose quickstart (#12006)

2024-03-12 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new 0fad582280 Add BanyanDB to docker-compose

Re: [PR] Add BanyanDB to docker-compose quickstart [skywalking]

2024-03-12 Thread via GitHub
wu-sheng merged PR #12006: URL: https://github.com/apache/skywalking/pull/12006 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Add BanyanDB to docker-compose quickstart [skywalking]

2024-03-12 Thread via GitHub
wu-sheng commented on code in PR #12006: URL: https://github.com/apache/skywalking/pull/12006#discussion_r1521054547 ## docker/docker-compose.yml: ## @@ -36,40 +40,74 @@ services: soft: -1 hard: -1 - oap: -image: ${OAP_IMAGE} -container_name: oap -

Re: [PR] Change topN group key from `StorageId` to `entityId + timeBucket`. [skywalking]

2024-03-12 Thread via GitHub
wu-sheng commented on PR #11788: URL: https://github.com/apache/skywalking/pull/11788#issuecomment-1991039971 > > So I change topN group key to entityId + timeBucket, then stash map can only reserve topN of every entity(db, cache) in the minute level. > > > > The timeBucket

Re: [PR] Change topN group key from `StorageId` to `entityId + timeBucket`. [skywalking]

2024-03-12 Thread via GitHub
ZhengBing520 commented on PR #11788: URL: https://github.com/apache/skywalking/pull/11788#issuecomment-1991036936 > So I change topN group key to entityId + timeBucket, then stash map can only reserve topN of every entity(db, cache) in the minute level. The timeBucket attribute in

Re: [PR] Add BanyanDB to docker-compose quickstart [skywalking]

2024-03-12 Thread via GitHub
kezhenxu94 commented on code in PR #12006: URL: https://github.com/apache/skywalking/pull/12006#discussion_r1521048721 ## docker/docker-compose.yml: ## @@ -36,40 +40,74 @@ services: soft: -1 hard: -1 - oap: -image: ${OAP_IMAGE} -container_name: oap

(skywalking-website) branch master updated: add blog for ClickHouse monitoring (#685)

2024-03-12 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-website.git The following commit(s) were added to refs/heads/master by this push: new f091bc9f86a add blog for

Re: [PR] add blog for ClickHouse monitoring [skywalking-website]

2024-03-12 Thread via GitHub
wu-sheng commented on PR #685: URL: https://github.com/apache/skywalking-website/pull/685#issuecomment-1991016179 Thanks for putting CN and EN in place for the same time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] add blog for ClickHouse monitoring [skywalking-website]

2024-03-12 Thread via GitHub
wu-sheng merged PR #685: URL: https://github.com/apache/skywalking-website/pull/685 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Add BanyanDB to docker-compose quickstart [skywalking]

2024-03-12 Thread via GitHub
wu-sheng commented on code in PR #12006: URL: https://github.com/apache/skywalking/pull/12006#discussion_r1521031230 ## docker/docker-compose.yml: ## @@ -36,40 +40,74 @@ services: soft: -1 hard: -1 - oap: -image: ${OAP_IMAGE} -container_name: oap -

[PR] Add BanyanDB to docker-compose quickstart [skywalking]

2024-03-12 Thread via GitHub
kezhenxu94 opened a new pull request, #12006: URL: https://github.com/apache/skywalking/pull/12006 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [ ] Update the [`CHANGES`

Re: [PR] Fix console warnings in dev mod, and optimize `vite` configuration for proxy, and remove unused codes [skywalking-banyandb]

2024-03-12 Thread via GitHub
Fine0830 commented on PR #408: URL: https://github.com/apache/skywalking-banyandb/pull/408#issuecomment-1990962300 This configuration is aimed at preventing accidental exposure of sensitive configuration settings every time the `Vite` configuration is modified. Now, you only need to add a

Re: [PR] Fix console warnings in dev mod, and optimize `vite` configuration for proxy, and remove unused codes [skywalking-banyandb]

2024-03-12 Thread via GitHub
Sylvie-Wxr commented on PR #408: URL: https://github.com/apache/skywalking-banyandb/pull/408#issuecomment-1990948027 Hi @Fine0830 , this is Sylvie, a student developer wishes to contribute to BanyanDB during GSOC. Nice to meet you~ I wish to ask you about the vite.config.js in this PR.

Re: [PR] add blog for ClickHouse monitoring [skywalking-website]

2024-03-12 Thread via GitHub
netlify[bot] commented on PR #685: URL: https://github.com/apache/skywalking-website/pull/685#issuecomment-1990923012 ###  Deploy Preview for *skywalking-website-preview* processing. | Name | Link | |:-:|| | Latest commit |

[PR] add blog for ClickHouse monitoring [skywalking-website]

2024-03-12 Thread via GitHub
CzyerChen opened a new pull request, #685: URL: https://github.com/apache/skywalking-website/pull/685 Add ClickHouse Monitoring blog in English and Chinese. https://github.com/apache/skywalking-website/assets/22817918/92ad2658-9ced-404a-a6a5-a90aa931290c;>

Re: [I] [Bug] banyandb web-ui console error logs [skywalking]

2024-03-12 Thread via GitHub
wu-sheng closed issue #11273: [Bug] banyandb web-ui console error logs URL: https://github.com/apache/skywalking/issues/11273 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [I] [Bug] banyandb web-ui console error logs [skywalking]

2024-03-12 Thread via GitHub
wu-sheng commented on issue #11273: URL: https://github.com/apache/skywalking/issues/11273#issuecomment-1990850927 Fixed by https://github.com/apache/skywalking-banyandb/pull/408 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Fix 11273 remove exception log is output in console [skywalking-banyandb]

2024-03-12 Thread via GitHub
Fine0830 commented on PR #396: URL: https://github.com/apache/skywalking-banyandb/pull/396#issuecomment-1990821542 I have removed the codes in https://github.com/apache/skywalking-banyandb/pull/408 -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Fix 11273 remove exception log is output in console [skywalking-banyandb]

2024-03-12 Thread via GitHub
wu-sheng commented on PR #396: URL: https://github.com/apache/skywalking-banyandb/pull/396#issuecomment-1990815336 @Fine0830 Will you use another PR to remove the codes? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Fix 11273 remove exception log is output in console [skywalking-banyandb]

2024-03-12 Thread via GitHub
Fine0830 commented on PR #396: URL: https://github.com/apache/skywalking-banyandb/pull/396#issuecomment-1990722947 While debugging this code, I noticed that it wasn't executing in development mode and encountered errors in production mode, without affecting the page interaction. As a

Re: [PR] Fix 11273 remove exception log is output in console [skywalking-banyandb]

2024-03-12 Thread via GitHub
Fine0830 closed pull request #396: Fix 11273 remove exception log is output in console URL: https://github.com/apache/skywalking-banyandb/pull/396 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to