(skywalking) branch polish-banyandb deleted (was 38f43eeb45)

2024-04-10 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch polish-banyandb in repository https://gitbox.apache.org/repos/asf/skywalking.git was 38f43eeb45 Fix changelog. The revisions that were on this branch are still contained in other

(skywalking) branch master updated: Remove unnecessary `componentIds` as series ID (#12091)

2024-04-10 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new f97fd4f6e4 Remove unnecessary

Re: [PR] Remove unnecessary `componentIds` as series ID [skywalking]

2024-04-10 Thread via GitHub
wu-sheng merged PR #12091: URL: https://github.com/apache/skywalking/pull/12091 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] Remove unnecessary `componentIds` as series ID [skywalking]

2024-04-10 Thread via GitHub
wu-sheng opened a new pull request, #12091: URL: https://github.com/apache/skywalking/pull/12091 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [x] Update the [`CHANGES`

(skywalking) branch polish-banyandb updated: Fix changelog.

2024-04-10 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch polish-banyandb in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/polish-banyandb by this push: new 38f43eeb45 Fix

(skywalking) 01/01: Remove unnecessary `componentIds` in the `ServiceRelationClientSideMetrics` and `ServiceRelationServerSideMetrics` entities.

2024-04-10 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch polish-banyandb in repository https://gitbox.apache.org/repos/asf/skywalking.git commit 07d29de7dcac1b27641202d6fd1f0e131623ce8b Author: Wu Sheng AuthorDate: Thu Apr 11 12:45:10 2024 +0800

(skywalking) branch polish-banyandb created (now 07d29de7dc)

2024-04-10 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch polish-banyandb in repository https://gitbox.apache.org/repos/asf/skywalking.git at 07d29de7dc Remove unnecessary `componentIds` in the `ServiceRelationClientSideMetrics` and

[I] [Bug] BanyanDB binary distributes as `banyand-server-static`, `-static` is not expected. [skywalking]

2024-04-10 Thread via GitHub
wu-sheng opened a new issue, #12090: URL: https://github.com/apache/skywalking/issues/12090 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar issues. ### Apache SkyWalking Component

(skywalking) branch master updated: Sync UI (#12089)

2024-04-10 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new 5a90121c82 Sync UI (#12089) 5a90121c82 is

Re: [PR] Sync UI [skywalking]

2024-04-10 Thread via GitHub
wu-sheng merged PR #12089: URL: https://github.com/apache/skywalking/pull/12089 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Add Top N Aggregation to web app [skywalking-banyandb]

2024-04-10 Thread via GitHub
hanahmily merged PR #430: URL: https://github.com/apache/skywalking-banyandb/pull/430 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(skywalking-banyandb) branch main updated: Add Top N Aggregation to web app (#430)

2024-04-10 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git The following commit(s) were added to refs/heads/main by this push: new db63f7d6 Add Top N Aggregation to

Re: [I] [BanyanDB-UI][BanyanDB-Server] Expose the TopNAggregation operations through HTTP [skywalking]

2024-04-10 Thread via GitHub
hanahmily closed issue #12017: [BanyanDB-UI][BanyanDB-Server] Expose the TopNAggregation operations through HTTP URL: https://github.com/apache/skywalking/issues/12017 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Add Apache Airflow Monitoring [skywalking]

2024-04-10 Thread via GitHub
songzhendong commented on PR #12072: URL: https://github.com/apache/skywalking/pull/12072#issuecomment-2047995724 > FYI @songzhendong We will update the MAL implementation for #11992. Then UI side will update to support multiple-label tags as well. > > You will need to update this PR

Re: [PR] Add Apache Airflow Monitoring [skywalking]

2024-04-10 Thread via GitHub
songzhendong commented on PR #12072: URL: https://github.com/apache/skywalking/pull/12072#issuecomment-2047994604 > FYI @songzhendong We will update the MAL implementation for #11992. Then UI side will update to support multiple-label tags as well. > > You will need to update this PR

(skywalking-booster-ui) branch main updated: feat: support the `SINGLE_VALUE` for table widgets (#383)

2024-04-10 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/skywalking-booster-ui.git The following commit(s) were added to refs/heads/main by this push: new 460b24f4 feat: support the

Re: [PR] feat: support the `SINGLE_VALUE` for table widgets [skywalking-booster-ui]

2024-04-10 Thread via GitHub
wu-sheng merged PR #383: URL: https://github.com/apache/skywalking-booster-ui/pull/383 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] feat: support the `SINGLE_VALUE` for table widgets [skywalking-booster-ui]

2024-04-10 Thread via GitHub
Fine0830 opened a new pull request, #383: URL: https://github.com/apache/skywalking-booster-ui/pull/383 Video https://github.com/apache/skywalking-booster-ui/assets/20871783/016b2ef5-af7c-4989-adca-9132538a55f1 Signed-off-by: Qiuxia Fan -- This is an automated

Re: [PR] Fix CHANGES.md [skywalking-java]

2024-04-10 Thread via GitHub
wu-sheng merged PR #680: URL: https://github.com/apache/skywalking-java/pull/680 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(skywalking-java) branch wu-sheng-patch-1 deleted (was 8179acca55)

2024-04-10 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch wu-sheng-patch-1 in repository https://gitbox.apache.org/repos/asf/skywalking-java.git was 8179acca55 Fix CHANGES.md The revisions that were on this branch are still contained in other

(skywalking-java) branch main updated: Fix CHANGES.md (#680)

2024-04-10 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/skywalking-java.git The following commit(s) were added to refs/heads/main by this push: new 23287f90c8 Fix CHANGES.md (#680)

[PR] Fix CHANGES.md [skywalking-java]

2024-04-10 Thread via GitHub
wu-sheng opened a new pull request, #680: URL: https://github.com/apache/skywalking-java/pull/680 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [ ] Update the [`CHANGES`

(skywalking-java) 01/01: Fix CHANGES.md

2024-04-10 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch wu-sheng-patch-1 in repository https://gitbox.apache.org/repos/asf/skywalking-java.git commit 8179acca552514b0ff69453aa0668312bb028f58 Author: 吴晟 Wu Sheng AuthorDate: Wed Apr 10 22:17:03 2024

(skywalking-java) branch wu-sheng-patch-1 created (now 8179acca55)

2024-04-10 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch wu-sheng-patch-1 in repository https://gitbox.apache.org/repos/asf/skywalking-java.git at 8179acca55 Fix CHANGES.md This branch includes the following new commits: new 8179acca55

(skywalking-java) branch main updated: remove idleCount in druid plugin (#679)

2024-04-10 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/skywalking-java.git The following commit(s) were added to refs/heads/main by this push: new bc20c6e888 remove idleCount in druid

Re: [PR] remove idleCount in druid plugin [skywalking-java]

2024-04-10 Thread via GitHub
wu-sheng merged PR #679: URL: https://github.com/apache/skywalking-java/pull/679 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(skywalking) branch master updated: Bump up kafka client to fix CVE (#12088)

2024-04-10 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new 8699ffdf28 Bump up kafka client to fix CVE

Re: [I] [Feature] Bump up Kafka Client [skywalking]

2024-04-10 Thread via GitHub
wu-sheng closed issue #12037: [Feature] Bump up Kafka Client URL: https://github.com/apache/skywalking/issues/12037 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Bump up kafka client to fix CVE [skywalking]

2024-04-10 Thread via GitHub
wu-sheng merged PR #12088: URL: https://github.com/apache/skywalking/pull/12088 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] Sync UI [skywalking]

2024-04-10 Thread via GitHub
wankai123 opened a new pull request, #12089: URL: https://github.com/apache/skywalking/pull/12089 relate:https://github.com/apache/skywalking-booster-ui/pull/382 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [X] Update

Re: [PR] remove idleCount in druid plugin [skywalking-java]

2024-04-10 Thread via GitHub
AlchemyDing commented on PR #679: URL: https://github.com/apache/skywalking-java/pull/679#issuecomment-2047539249 > > Of course, this is possible. > > But before that, I also have a question. I searched for the code of skywalking-java and found that only the druid plugin has attributes

Re: [PR] remove idleCount in druid plugin [skywalking-java]

2024-04-10 Thread via GitHub
wu-sheng commented on PR #679: URL: https://github.com/apache/skywalking-java/pull/679#issuecomment-2047540086 > Therefore, I have a proposal to standardize our semantic conventions, which can avoid potential semantic ambiguity in the future. We should consider that in a way. --

Re: [PR] remove idleCount in druid plugin [skywalking-java]

2024-04-10 Thread via GitHub
AlchemyDing commented on PR #679: URL: https://github.com/apache/skywalking-java/pull/679#issuecomment-2047538313 > > 当然,这是可能的。 > > 但在此之前,我还有一个问题。我搜索了skywalking-java的代码,发现只有druid插件有叫做poolingCount和idleCount的属性。我们是否需要在APM中改变druid对于这两个属性的原始含义,也许我们需要一个标准化的语义约定? > > 好问题。最好删除它,而不是重新计算。

Re: [PR] remove idleCount in druid plugin [skywalking-java]

2024-04-10 Thread via GitHub
AlchemyDing commented on PR #679: URL: https://github.com/apache/skywalking-java/pull/679#issuecomment-2047537804 Therefore, I have a proposal to standardize our semantic conventions, which can avoid potential semantic ambiguity in the future. -- This is an automated message from the

Re: [PR] remove idleCount in druid plugin [skywalking-java]

2024-04-10 Thread via GitHub
wu-sheng commented on PR #679: URL: https://github.com/apache/skywalking-java/pull/679#issuecomment-2047512936 > Of course, this is possible. > But before that, I also have a question. I searched for the code of skywalking-java and found that only the druid plugin has attributes called

Re: [PR] remove idleCount in druid plugin [skywalking-java]

2024-04-10 Thread via GitHub
AlchemyDing commented on PR #679: URL: https://github.com/apache/skywalking-java/pull/679#issuecomment-2047501587 > > Poolingcount represents the concept of idle > > Then why don't put `Poolingcount` to `idle`, and `idle` + `activeCount`(maybe?) as the real `poolingCount`? The reason

Re: [PR] Fix `NullPointerException` in Istio ServiceEntry registry [skywalking]

2024-04-10 Thread via GitHub
wu-sheng merged PR #12087: URL: https://github.com/apache/skywalking/pull/12087 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(skywalking) branch master updated: Fix `NullPointerException` in Istio ServiceEntry registry (#12087)

2024-04-10 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new f5cd798185 Fix `NullPointerException` in

Re: [PR] remove idleCount in druid plugin [skywalking-java]

2024-04-10 Thread via GitHub
wu-sheng commented on PR #679: URL: https://github.com/apache/skywalking-java/pull/679#issuecomment-2047422300 BTW, as a metric label is removed, the CI fails as expected. Let's focus on the above question first. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] remove idleCount in druid plugin [skywalking-java]

2024-04-10 Thread via GitHub
wu-sheng commented on PR #679: URL: https://github.com/apache/skywalking-java/pull/679#issuecomment-2047403819 > Poolingcount represents the concept of idle Then why don't put `Poolingcount` to `idle`, and `idle` + `activeCount`(maybe?) as the real `poolingCount`? The reason I am

Re: [PR] remove idleCount in druid plugin [skywalking-java]

2024-04-10 Thread via GitHub
AlchemyDing commented on PR #679: URL: https://github.com/apache/skywalking-java/pull/679#issuecomment-2047396570 Pollingcount represents the concept of idle -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[PR] Bump up kafka client to fix CVE [skywalking]

2024-04-10 Thread via GitHub
kezhenxu94 opened a new pull request, #12088: URL: https://github.com/apache/skywalking/pull/12088 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [ ] Update the [`CHANGES`

Re: [PR] remove idleCount in druid plugin [skywalking-java]

2024-04-10 Thread via GitHub
wu-sheng commented on PR #679: URL: https://github.com/apache/skywalking-java/pull/679#issuecomment-2047376377 So, Druid pool doesn't have an idle concept? Then what is the status of the connection after it is used? -- This is an automated message from the Apache Git Service. To respond

Re: [I] [Bug] Metrics are not aggregated properly as OTEL collector targeting per node [skywalking]

2024-04-10 Thread via GitHub
wu-sheng commented on issue #11982: URL: https://github.com/apache/skywalking/issues/11982#issuecomment-2047362729 @weixiang1862 @pg-yang @innerpeacez We have the new multi-label support merged. You should be good to fix this. -- This is an automated message from the Apache Git Service.

Re: [PR] [Break Change]: Labeled Metrics support multiple labels. [skywalking]

2024-04-10 Thread via GitHub
wu-sheng merged PR #12082: URL: https://github.com/apache/skywalking/pull/12082 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] [Feature] Add new metric `type=STANDARD_VALUE` [skywalking]

2024-04-10 Thread via GitHub
wu-sheng closed issue #11992: [Feature] Add new metric `type=STANDARD_VALUE` URL: https://github.com/apache/skywalking/issues/11992 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] Fix `NullPointerException` in Istio ServiceEntry registry [skywalking]

2024-04-10 Thread via GitHub
kezhenxu94 opened a new pull request, #12087: URL: https://github.com/apache/skywalking/pull/12087 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [ ] Update the [`CHANGES`

(skywalking-website) branch asf-site updated: deploy: 3445ae5015d31d1f5a5c45724918558256bf508b

2024-04-10 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/skywalking-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 13dad5a0041 deploy:

Re: [PR] remove idleCount in druid plugin [skywalking-java]

2024-04-10 Thread via GitHub
AlchemyDing commented on PR #679: URL: https://github.com/apache/skywalking-java/pull/679#issuecomment-2046949056 `idleCount` should be `druidDataSource.getPoolingCount()` But this way it's the same as `poolingCount`.

Re: [PR] feat: enhance metric labels [skywalking-booster-ui]

2024-04-10 Thread via GitHub
Fine0830 merged PR #382: URL: https://github.com/apache/skywalking-booster-ui/pull/382 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(skywalking-booster-ui) branch main updated: feat: enhance metric labels (#382)

2024-04-10 Thread qiuxiafan
This is an automated email from the ASF dual-hosted git repository. qiuxiafan pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/skywalking-booster-ui.git The following commit(s) were added to refs/heads/main by this push: new fd2c7ca7 feat: enhance metric

Re: [I] [Feature] Grey feature [skywalking]

2024-04-10 Thread via GitHub
wu-sheng closed issue #12084: [Feature] Grey feature URL: https://github.com/apache/skywalking/issues/12084 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [I] [Feature] Grey feature [skywalking]

2024-04-10 Thread via GitHub
wu-sheng commented on issue #12084: URL: https://github.com/apache/skywalking/issues/12084#issuecomment-2046874698 I am moving this to discussion as we don't have approval for this new proposal. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [I] [Feature] Grey feature [skywalking]

2024-04-10 Thread via GitHub
wu-sheng commented on issue #12084: URL: https://github.com/apache/skywalking/issues/12084#issuecomment-2046872414 I am a little confused about this asking. Are you asking for something we had verified before? Check this, https://github.com/SphereEx/cyborg-flow -- This is an automated

[I] [Feature] Grey feature with trace [skywalking]

2024-04-10 Thread via GitHub
crazychengmm opened a new issue, #12084: URL: https://github.com/apache/skywalking/issues/12084 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement. ###

Re: [PR] [Break Change]: Labeled Metrics support multiple labels. [skywalking]

2024-04-10 Thread via GitHub
wu-sheng commented on code in PR #12082: URL: https://github.com/apache/skywalking/pull/12082#discussion_r1559029122 ## docs/en/changes/changes.md: ## @@ -81,6 +81,16 @@ * Support displaying the port services listen to from OAP and UI during server start. * Refactor

Re: [PR] [Break Change]: Labeled Metrics support multiple labels. [skywalking]

2024-04-10 Thread via GitHub
wu-sheng commented on PR #12082: URL: https://github.com/apache/skywalking/pull/12082#issuecomment-2046837667 Generally, this is good. Please fix the CIs and OAL docs are about percentile, which is deprecated. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] remove idleCount in druid plugin [skywalking-java]

2024-04-10 Thread via GitHub
wu-sheng commented on PR #679: URL: https://github.com/apache/skywalking-java/pull/679#issuecomment-2046826378 Your fix at OTEL-java side seems different. Could you explain more here or need to align with that? -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] [Break Change]: Labeled Metrics support multiple labels. [skywalking]

2024-04-10 Thread via GitHub
github-advanced-security[bot] commented on code in PR #12082: URL: https://github.com/apache/skywalking/pull/12082#discussion_r1558968394 ## oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/metrics/PercentileMetrics2.java: ## @@ -0,0 +1,136 @@

[PR] [Break Change]: Labeled Metrics support multiple labels. [skywalking]

2024-04-10 Thread via GitHub
wankai123 opened a new pull request, #12082: URL: https://github.com/apache/skywalking/pull/12082 relate to https://github.com/apache/skywalking/issues/11992 - [ ] If this is non-trivial feature, paste the links/URLs to the design doc. - [X] Update the documentation to include this

[PR] feat: enhance metric labels [skywalking-booster-ui]

2024-04-10 Thread via GitHub
Fine0830 opened a new pull request, #382: URL: https://github.com/apache/skywalking-booster-ui/pull/382 Screenshots https://github.com/apache/skywalking-booster-ui/assets/20871783/41233298-1787-4cbe-a85a-2f5a79ca5498;>