wu-sheng commented on PR #712:
URL: https://github.com/apache/skywalking-java/pull/712#issuecomment-2253781807
I think yoi didn't read the document and understand how the things really
work.
What you faced is a super common case in the agent.
--
This is an automated message from the Ap
CodingMakeWordBetter commented on PR #712:
URL: https://github.com/apache/skywalking-java/pull/712#issuecomment-2253778215
> You could update config document to indicate this. bytes are not supported.
>
> I don't think this is a big issue. Encoding unexpected data could impact
the tar
CodingMakeWordBetter closed pull request #712: fix redission has not parameter
problem
URL: https://github.com/apache/skywalking-java/pull/712
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
wu-sheng commented on PR #712:
URL: https://github.com/apache/skywalking-java/pull/712#issuecomment-2253767598
You could update config document to indicate this. bytes are not supported.
I don't think this is a big issue. Encoding unexpected data could impact the
target app, that is a
CodingMakeWordBetter commented on PR #712:
URL: https://github.com/apache/skywalking-java/pull/712#issuecomment-2253766968
> What do you mean switch to true?
in the agent.config plugin.redisson.trace_redis_parameters set true,but
skywalking did not revice redis command.
--
This is
CodingMakeWordBetter commented on PR #712:
URL: https://github.com/apache/skywalking-java/pull/712#issuecomment-2253766205
> We don't have to know the answer. We just need to support versions with
string as parameters, and keep the bytes as what it is. If I understand your
point correctly,
wu-sheng commented on PR #712:
URL: https://github.com/apache/skywalking-java/pull/712#issuecomment-2253766002
> But we are not sure about the specific version number, so it feels a bit
strange to use version to split.
No, we don't. SkyWalking used class name and/or method signatures
wu-sheng commented on PR #712:
URL: https://github.com/apache/skywalking-java/pull/712#issuecomment-2253766400
What do you mean switch to true?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
CodingMakeWordBetter commented on PR #712:
URL: https://github.com/apache/skywalking-java/pull/712#issuecomment-2253765461
> If there is higher version has string as parameters, we could consider
separating two interceptors.
> > Regarding this issue, based on my personal abili
wu-sheng commented on PR #712:
URL: https://github.com/apache/skywalking-java/pull/712#issuecomment-2253764565
> Regarding this issue, based on my personal ability, I can only consult
with the official Redis to find the answer.
We don't have to know the answer. We just need to suppor
wu-sheng commented on PR #712:
URL: https://github.com/apache/skywalking-java/pull/712#issuecomment-2253758376
> Regarding this issue, based on my personal ability, I can only consult
with the official Redis to find the answer. However, I believe that the current
situation is problematic. T
CodingMakeWordBetter commented on PR #712:
URL: https://github.com/apache/skywalking-java/pull/712#issuecomment-2253757138
关于这个问题,以我个人能力,我只能去询问redission官方找寻答案,但是我认为目前情况属于有问题的,插件是3.x,但是对于3.15.6并没有通过测试且是可复现的,说明插件本身对于版本并没有兼容。
--
This is an automated message from the Apache Git Service.
To re
wu-sheng commented on PR #712:
URL: https://github.com/apache/skywalking-java/pull/712#issuecomment-2253757243
If there is higher version has string as parameters, we could consider
separating two interceptors.
--
This is an automated message from the Apache Git Service.
To respond to the
wu-sheng merged PR #711:
URL: https://github.com/apache/skywalking-java/pull/711
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr.
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/skywalking-java.git
The following commit(s) were added to refs/heads/main by this push:
new 24ec663a34 Upgrade nats plugin to expand s
wu-sheng commented on PR #712:
URL: https://github.com/apache/skywalking-java/pull/712#issuecomment-2253749019
That is what want to confirm, how could make sure the old client wouldn't be
impacted if it is using bytes can't be encoded?
--
This is an automated message from the Apache Git S
wu-sheng commented on PR #712:
URL: https://github.com/apache/skywalking-java/pull/712#issuecomment-2253749387
You can't say you don't have the problem, then other users won't.
Unless the official doc(redis) confirmed this is a string, we should not
assume that.
--
This is an automated
CodingMakeWordBetter commented on PR #712:
URL: https://github.com/apache/skywalking-java/pull/712#issuecomment-2253747686
Firstly, I packaged this code into a jar package for the Redis plugin and
tested that Skywalking can accept commands normally in my environment.
Secondly, my project us
wu-sheng commented on PR #712:
URL: https://github.com/apache/skywalking-java/pull/712#issuecomment-2253744018
We had discussed this, I think. How can you sure the bytes could be encoded
as string?
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
CodingMakeWordBetter opened a new pull request, #712:
URL: https://github.com/apache/skywalking-java/pull/712
when i use redission plugin,i found even agent.config
plugin.redisson.trace_redis_parameters set to true but skywalking ui do not
have parameter. so fix this problem.
--
This is
wu-sheng commented on PR #711:
URL: https://github.com/apache/skywalking-java/pull/711#issuecomment-2253724140
Please fix CI. You changed the plugin name.
And document(supported list) should be update.
More important, you need to add new version to test scenarios.
--
This is an a
pg-yang opened a new pull request, #711:
URL: https://github.com/apache/skywalking-java/pull/711
- [x] If this pull request closes/resolves/fixes an existing issue, replace
the issue number. Closes #.
- [x] Update the [`CHANGES`
log](https://github
This is an automated email from the ASF dual-hosted git repository.
hanahmily pushed a change to annotated tag v0.7.0-rc2
in repository
https://gitbox.apache.org/repos/asf/skywalking-banyandb-java-client.git
*** WARNING: tag v0.7.0-rc2 was modified! ***
from c99aff7 (commit)
to 3104
This is an automated email from the ASF dual-hosted git repository.
hanahmily pushed a change to annotated tag 0.7.0-rc2
in repository
https://gitbox.apache.org/repos/asf/skywalking-banyandb-java-client.git
*** WARNING: tag 0.7.0-rc2 was deleted! ***
tag was c145aa3
The revisions that wer
This is an automated email from the ASF dual-hosted git repository.
hanahmily pushed a change to tag ls
in repository
https://gitbox.apache.org/repos/asf/skywalking-banyandb-java-client.git
*** WARNING: tag ls was deleted! ***
was c99aff7 [maven-release-plugin] prepare for next developme
This is an automated email from the ASF dual-hosted git repository.
hanahmily pushed a change to tag push
in repository
https://gitbox.apache.org/repos/asf/skywalking-banyandb-java-client.git
*** WARNING: tag push was deleted! ***
was c99aff7 [maven-release-plugin] prepare for next devel
This is an automated email from the ASF dual-hosted git repository.
hanahmily pushed a change to tag ls
in repository
https://gitbox.apache.org/repos/asf/skywalking-banyandb-java-client.git
at c99aff7 (commit)
No new revisions were added by this update.
This is an automated email from the ASF dual-hosted git repository.
hanahmily pushed a change to tag push
in repository
https://gitbox.apache.org/repos/asf/skywalking-banyandb-java-client.git
at c99aff7 (commit)
No new revisions were added by this update.
This is an automated email from the ASF dual-hosted git repository.
hanahmily pushed a change to annotated tag 0.7.0-rc2
in repository
https://gitbox.apache.org/repos/asf/skywalking-banyandb-java-client.git
*** WARNING: tag 0.7.0-rc2 was modified! ***
from f506d5d (commit)
to c145aa
This is an automated email from the ASF dual-hosted git repository.
hanahmily pushed a commit to branch release-0.7.0-rc2
in repository
https://gitbox.apache.org/repos/asf/skywalking-banyandb-java-client.git
commit f506d5d8c3cc6cb55b3bd1fe018c914e5b116e7e
Author: Gao Hongtao
AuthorDate: Fri Jul
This is an automated email from the ASF dual-hosted git repository.
hanahmily pushed a commit to branch release-0.7.0-rc2
in repository
https://gitbox.apache.org/repos/asf/skywalking-banyandb-java-client.git
The following commit(s) were added to refs/heads/release-0.7.0-rc2 by this push:
n
This is an automated email from the ASF dual-hosted git repository.
hanahmily pushed a change to branch release-0.7.0-rc2
in repository
https://gitbox.apache.org/repos/asf/skywalking-banyandb-java-client.git
at f506d5d [maven-release-plugin] prepare release 0.7.0-rc2
This branch include
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a change to branch patch-series-match
in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git
was 49c17c81 Fix series match crash
The revisions that were on this branch are still contained
wu-sheng merged PR #499:
URL: https://github.com/apache/skywalking-banyandb/pull/499
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsub
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git
The following commit(s) were added to refs/heads/main by this push:
new 0145fba3 Fix series match crash (#499)
This is an automated email from the ASF dual-hosted git repository.
hanahmily pushed a change to branch patch-series-match
in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git
at 49c17c81 Fix series match crash
This branch includes the following new commits:
new
hanahmily opened a new pull request, #499:
URL: https://github.com/apache/skywalking-banyandb/pull/499
Fixes issues found by
https://github.com/apache/skywalking-banyandb/actions/runs/10107052656/job/27950224002
--
This is an automated message from the Apache Git Service.
To respond to th
This is an automated email from the ASF dual-hosted git repository.
hanahmily pushed a commit to branch patch-series-match
in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git
commit 49c17c81b689b74c9552b1fd1b28f3813844cedc
Author: Gao Hongtao
AuthorDate: Fri Jul 26 21:37:18
This is an automated email from the ASF dual-hosted git repository.
wankai pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/skywalking-showcase.git
The following commit(s) were added to refs/heads/main by this push:
new ccd0574 Update OAP/UI/Banyandb
ccd0574
wu-sheng merged PR #12483:
URL: https://github.com/apache/skywalking/pull/12483
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr..
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git
The following commit(s) were added to refs/heads/master by this push:
new 5441f58f4c MQE: check the metrics value bef
This is an automated email from the ASF dual-hosted git repository.
hanahmily pushed a change to branch doc
in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git
was fe8c6279 update docs.
The revisions that were on this branch are still contained in
other references; th
This is an automated email from the ASF dual-hosted git repository.
hanahmily pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git
The following commit(s) were added to refs/heads/main by this push:
new 6f938ccf update docs. (#498)
6f938cc
hanahmily merged PR #498:
URL: https://github.com/apache/skywalking-banyandb/pull/498
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsu
wankai123 opened a new pull request, #12483:
URL: https://github.com/apache/skywalking/pull/12483
- [ ] If this pull request closes/resolves/fixes an existing issue, replace
the issue number. Closes #.
- [X] Update the [`CHANGES`
log](https://github.com/apache/skywalking/blob/master/docs
45 matches
Mail list logo