lujiajing1126 commented on code in PR #239:
URL:
https://github.com/apache/skywalking-banyandb/pull/239#discussion_r1082603413
##
banyand/measure/measure_write.go:
##
@@ -39,17 +39,18 @@ import (
var errMalformedElement = errors.New("element is malformed")
-func (s *measur
lujiajing1126 commented on code in PR #239:
URL:
https://github.com/apache/skywalking-banyandb/pull/239#discussion_r1082600211
##
banyand/liaison/grpc/registry.go:
##
@@ -435,7 +437,37 @@ type topNAggregationRegistryServer struct {
func (ts *topNAggregationRegistryServer) Crea
lujiajing1126 commented on code in PR #239:
URL:
https://github.com/apache/skywalking-banyandb/pull/239#discussion_r1082598524
##
banyand/liaison/grpc/registry.go:
##
@@ -435,7 +437,37 @@ type topNAggregationRegistryServer struct {
func (ts *topNAggregationRegistryServer) Crea
lujiajing1126 commented on code in PR #239:
URL:
https://github.com/apache/skywalking-banyandb/pull/239#discussion_r1082550935
##
banyand/liaison/grpc/registry.go:
##
@@ -435,7 +437,37 @@ type topNAggregationRegistryServer struct {
func (ts *topNAggregationRegistryServer) Crea
mrproliu merged PR #73:
URL: https://github.com/apache/skywalking-rover/pull/73
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr..
lujiajing1126 commented on code in PR #239:
URL:
https://github.com/apache/skywalking-banyandb/pull/239#discussion_r1082551208
##
banyand/liaison/grpc/registry.go:
##
@@ -435,7 +437,37 @@ type topNAggregationRegistryServer struct {
func (ts *topNAggregationRegistryServer) Crea
lujiajing1126 commented on code in PR #239:
URL:
https://github.com/apache/skywalking-banyandb/pull/239#discussion_r1082550935
##
banyand/liaison/grpc/registry.go:
##
@@ -435,7 +437,37 @@ type topNAggregationRegistryServer struct {
func (ts *topNAggregationRegistryServer) Crea
lujiajing1126 commented on code in PR #239:
URL:
https://github.com/apache/skywalking-banyandb/pull/239#discussion_r1082550614
##
banyand/liaison/grpc/registry.go:
##
@@ -435,7 +437,37 @@ type topNAggregationRegistryServer struct {
func (ts *topNAggregationRegistryServer) Crea
wu-sheng merged PR #10296:
URL: https://github.com/apache/skywalking/pull/10296
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr..
wu-sheng commented on issue #9883:
URL: https://github.com/apache/skywalking/issues/9883#issuecomment-1398364455
> Maybe this helps.
https://github.com/bazelbuild/bazel/blob/master/src/main/java/com/google/devtools/build/lib/util/VarInt.java#L88
> Notice, we can't copy codes.
Can't
wu-sheng commented on issue #9883:
URL: https://github.com/apache/skywalking/issues/9883#issuecomment-1398354511
The process doc should be
https://developers.google.com/protocol-buffers/docs/encoding#varints
Maybe this helps.
https://github.com/bazelbuild/bazel/blob/master/src/main/j
wu-sheng commented on PR #10296:
URL: https://github.com/apache/skywalking/pull/10296#issuecomment-1398330679
> > > > In another way, our gRPC service seems to have the same issue(can't
update cert in the runtime), right? We would not call that not product-ready.
> > >
> > >
> > >
wu-sheng commented on PR #73:
URL: https://github.com/apache/skywalking-rover/pull/73#issuecomment-1398324164
I updated the PR title and change log to avoid the `intentional`-sytle word.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
spacewander commented on PR #73:
URL: https://github.com/apache/skywalking-rover/pull/73#issuecomment-1398279687
> Thanks for your contribution to support OpenSSL `3.0.x`. Could you also
update the change log?
Done
--
This is an automated message from the Apache Git Service.
To res
kezhenxu94 commented on PR #10296:
URL: https://github.com/apache/skywalking/pull/10296#issuecomment-1398246733
> > > In another way, our gRPC service seems to have the same issue(can't
update cert in the runtime), right? We would not call that not product-ready.
> >
> >
> > gRPC
pg-yang commented on issue #9883:
URL: https://github.com/apache/skywalking/issues/9883#issuecomment-1398242330
OK, vary int 32. 🔢
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
pg-yang commented on issue #9883:
URL: https://github.com/apache/skywalking/issues/9883#issuecomment-1398226560
```java
final byte[] decode = Base64.getDecoder().decode(s);
final byte[] decode2 = Base64.getDecoder().decode(s2);
final ResourceMetrics resourceMe
hanahmily commented on code in PR #241:
URL:
https://github.com/apache/skywalking-banyandb/pull/241#discussion_r1082356373
##
banyand/metadata/schema/group.go:
##
@@ -87,6 +88,9 @@ func (e *etcdSchemaRegistry) DeleteGroup(ctx context.Context,
group string) (boo
}
func (e *
hanahmily commented on code in PR #241:
URL:
https://github.com/apache/skywalking-banyandb/pull/241#discussion_r1082356373
##
banyand/metadata/schema/group.go:
##
@@ -87,6 +88,9 @@ func (e *etcdSchemaRegistry) DeleteGroup(ctx context.Context,
group string) (boo
}
func (e *
hanahmily commented on code in PR #241:
URL:
https://github.com/apache/skywalking-banyandb/pull/241#discussion_r1082346928
##
api/proto/banyandb/database/v1/schema.proto:
##
@@ -88,25 +89,25 @@ enum CompressionMethod {
// FieldSpec is the specification of field
message FieldS
wu-sheng commented on PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#issuecomment-1398149225
> If we cannot run the exporter on a Windows system, does it make sense to
mock the data and run a test, what actually is tested? The MAL engine?
We need to test MAL expressio
wu-sheng commented on PR #10296:
URL: https://github.com/apache/skywalking/pull/10296#issuecomment-1398144197
> > In another way, our gRPC service seems to have the same issue(can't
update cert in the runtime), right? We would not call that not product-ready.
>
> gRPC can reload the c
kezhenxu94 commented on PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#issuecomment-1398140149
If we cannot run the exporter on a Windows system, does it make sense to
mock the data and run a test, what actually is tested? The MAL engine?
--
This is an automated message f
kezhenxu94 commented on PR #10296:
URL: https://github.com/apache/skywalking/pull/10296#issuecomment-1398137826
> In another way, our gRPC service seems to have the same issue(can't update
cert in the runtime), right? We would not call that not product-ready.
gRPC can reload the cert
wu-sheng commented on PR #10296:
URL: https://github.com/apache/skywalking/pull/10296#issuecomment-1398122150
> > From my experience when users want to enable https they usually need a
gateway to configure domain name and the port. Adding this to OAP makes it
troublesome, for example, profe
kezhenxu94 commented on PR #10296:
URL: https://github.com/apache/skywalking/pull/10296#issuecomment-1398106425
> From my experience when users want to enable https they usually need a
gateway to configure domain name and the port. Adding this to OAP makes it
troublesome, for example, profe
kezhenxu94 commented on code in PR #10296:
URL: https://github.com/apache/skywalking/pull/10296#discussion_r1082245628
##
oap-server/server-library/library-server/src/main/java/org/apache/skywalking/oap/server/library/server/http/HTTPServer.java:
##
@@ -70,6 +74,22 @@ public voi
mikechengwei commented on PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#issuecomment-1398019334
> This is an example of OTEL data mock for EKS monitoring.
>
> *
https://github.com/apache/skywalking/tree/master/test/e2e-v2/cases/aws/eks
> * Mock sender is here,
ht
wu-sheng merged PR #48:
URL: https://github.com/apache/skywalking-php/pull/48
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
pg-yang commented on PR #10296:
URL: https://github.com/apache/skywalking/pull/10296#issuecomment-1398001600
> @pg-yang Have you tested this?
I'm using gateway(nginx) to test firehouse https, rather than OAP.
BTW, @yswdqz if you need domain,pulibc certificate, I could provide it.
jmjoy opened a new pull request, #48:
URL: https://github.com/apache/skywalking-php/pull/48
1. Add configuration option `skywalking_agent.authentication`.
2. Update document.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
wu-sheng merged PR #47:
URL: https://github.com/apache/skywalking-php/pull/47
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
jmjoy commented on code in PR #47:
URL: https://github.com/apache/skywalking-php/pull/47#discussion_r1082157765
##
docs/en/setup/service-agent/php-agent/README.md:
##
@@ -55,27 +55,31 @@ make install
## Configure php.ini
```ini
-[skywalking]
+[skywalking_agent]
Review Comme
wu-sheng commented on code in PR #47:
URL: https://github.com/apache/skywalking-php/pull/47#discussion_r1082157018
##
docs/en/setup/service-agent/php-agent/README.md:
##
@@ -55,27 +55,31 @@ make install
## Configure php.ini
```ini
-[skywalking]
+[skywalking_agent]
Review Co
Superskyyy merged PR #271:
URL: https://github.com/apache/skywalking-python/pull/271
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsub
jmjoy opened a new pull request, #47:
URL: https://github.com/apache/skywalking-php/pull/47
1. Add configuration option `skywalking_agent.runtime_dir`, indicate the
runtime directory for holding sock files now.
2. Update the document about option.
--
This is an automated message from t
wu-sheng commented on PR #271:
URL:
https://github.com/apache/skywalking-python/pull/271#issuecomment-1397945914
It is just never defined from API level, and not implemented.
Feel free to add the API and implement it.
--
This is an automated message from the Apache Git Service.
To resp
Superskyyy commented on PR #271:
URL:
https://github.com/apache/skywalking-python/pull/271#issuecomment-1397944719
@wu-sheng Btw, I remember HTTP handler (receiver) on meter is not
implemented on the OAP side, is it intentional or just a missed thing not done?
--
This is an automated me
Superskyyy commented on PR #271:
URL:
https://github.com/apache/skywalking-python/pull/271#issuecomment-1397941692
> I can't find meter and log docs, but the table shows supported. Are those
missed docs?
The log reporter doc is here, but meter is missing. It's because we didn't
add
wu-sheng commented on PR #271:
URL:
https://github.com/apache/skywalking-python/pull/271#issuecomment-1397940344
I can't find meter and log docs, but the table shows supported.
Are those missed docs?
--
This is an automated message from the Apache Git Service.
To respond to the message
wu-sheng commented on code in PR #10296:
URL: https://github.com/apache/skywalking/pull/10296#discussion_r1082121473
##
oap-server/server-library/library-server/src/main/java/org/apache/skywalking/oap/server/library/server/http/HTTPServerConfig.java:
##
@@ -39,4 +39,12 @@ public
Superskyyy opened a new pull request, #271:
URL: https://github.com/apache/skywalking-python/pull/271
As Python agent grows and syncing features with the Java agent, even myself
don't remember what was supported especially we have 3 reporter protocols that
not all of them support all teleme
yswdqz commented on code in PR #10296:
URL: https://github.com/apache/skywalking/pull/10296#discussion_r1082120917
##
oap-server/server-library/library-server/src/main/java/org/apache/skywalking/oap/server/library/server/http/HTTPServerConfig.java:
##
@@ -39,4 +39,12 @@ public c
wu-sheng commented on code in PR #10296:
URL: https://github.com/apache/skywalking/pull/10296#discussion_r1082107524
##
oap-server/server-library/library-server/src/main/java/org/apache/skywalking/oap/server/library/server/http/HTTPServerConfig.java:
##
@@ -39,4 +39,12 @@ public
wu-sheng commented on PR #10296:
URL: https://github.com/apache/skywalking/pull/10296#issuecomment-1397912275
@pg-yang Have you tested this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
yswdqz commented on PR #10296:
URL: https://github.com/apache/skywalking/pull/10296#issuecomment-1397909868
Is there anything else I should change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
wu-sheng commented on PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#issuecomment-1397894118
This is an example of OTEL data mock for EKS monitoring.
- https://github.com/apache/skywalking/tree/master/test/e2e-v2/cases/aws/eks
- Mock sender is here,
https://github.com/
kezhenxu94 commented on PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#issuecomment-1397891241
Anyway, if you have a Windows machine, just try to run the e2e and if it
fail then switch to the mocking method
--
This is an automated message from the Apache Git Service.
To r
mikechengwei commented on PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#issuecomment-1397888119
windows_exporter also use windows operate system to run e2e
wu-sheng commented on PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#issuecomment-1397882042
> In short, you can run the Windows system in a Docker container and monitor
that system inside the container, no need to run the e2e on a real Windows
system
I am afraid Win
kezhenxu94 commented on PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#issuecomment-1397881095
> You could use a window server for CI.
>
>
https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resourc
wu-sheng commented on PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#issuecomment-1397877993
I am feeling there are tools we can't support on Windows.
@pg-yang Could you share your OTEL mock service? I think we need to use that
to mock the telemetry on Windows.
--
wu-sheng commented on PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#issuecomment-1397877093
You could use a window server for CI.
https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources
mikechengwei commented on PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#issuecomment-1397875061
@wankai123 I find windows image can't build and run in linux physical
machine，it will throw exception below
```
docker: no matching manifest for linux/amd64 in the manifes
lujiajing1126 commented on code in PR #241:
URL:
https://github.com/apache/skywalking-banyandb/pull/241#discussion_r1082069269
##
api/proto/banyandb/database/v1/schema.proto:
##
@@ -88,25 +89,25 @@ enum CompressionMethod {
// FieldSpec is the specification of field
message Fi
mikechengwei commented on PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#issuecomment-1397866600
> > The E2E is running on docker, you can use the wins_exporter image to run
it.
>
> Or you can base on `windows/nanoserver` to build a image, if you can't
find a officia
wankai123 commented on PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#issuecomment-1397865868
> The E2E is running on docker, you can use the wins_exporter image to run
it.
Or you can base on `windows/nanoserver` to build a image, if you can't find
a official one.
mikechengwei commented on PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#issuecomment-1397857748
> wins_exporter
ok, i get.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
wankai123 commented on PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#issuecomment-1397856615
> > The expressions LGTM, let's wait the e2e codes and others to finish this.
>
> I have a question to ask you, i need install wins_exporter in a windows
machine implement in
mikechengwei commented on PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#issuecomment-1397855253
> The expressions LGTM, let's wait the e2e codes and others to finish this.
I have a question to ask you, i need install wins_exporter in a windows
machine implement in e2
mikechengwei commented on PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#issuecomment-1397824068
> Take your time. I just pointed out what may be missed as you have labeled
this PR ready for review. :)
Thanks for your trust, I will improve this pr as soon as possible.
Superskyyy commented on PR #46:
URL: https://github.com/apache/skywalking-php/pull/46#issuecomment-1397797583
> Yes, you are correct. I totally forgot this. 😅
😄 @jmjoy FYI the instance property will require a periodical update.
Refer to Java agent here:
https://github.dev/a
wu-sheng commented on PR #46:
URL: https://github.com/apache/skywalking-php/pull/46#issuecomment-1397755751
Yes, you are correct. I totally forgot this. 😅
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
Superskyyy commented on PR #46:
URL: https://github.com/apache/skywalking-php/pull/46#issuecomment-1397591193
I just saw this and remembered agents were supposed to resubmit instance
properties periodically as the OAP TTL mechanism would purge them. Is it still
true? @wu-sheng
--
This i
wu-sheng commented on PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#issuecomment-1397113669
FYI @Donadominic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
wu-sheng commented on PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#issuecomment-1397112050
> OK, I just successfully ran through the process, I will continue to
improve the pr. @wu-sheng
Take your time. I just pointed out which may be missed as you have labeled
thi
wankai123 commented on code in PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#discussion_r1081373409
##
oap-server/server-starter/src/main/resources/otel-rules/windows.yaml:
##
@@ -0,0 +1,72 @@
+# Licensed to the Apache Software Foundation (ASF) under one or mor
mikechengwei commented on PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#issuecomment-1397075052
https://user-images.githubusercontent.com/13257127/213469648-dd5fbf7a-e3c8-4eb4-9e8a-a3dd688f23b3.png";>
OK, I just successfully ran through the process, I will continue to
wu-sheng commented on code in PR #10296:
URL: https://github.com/apache/skywalking/pull/10296#discussion_r1081347271
##
oap-server/server-library/library-server/src/main/java/org/apache/skywalking/oap/server/library/server/http/HTTPServerConfig.java:
##
@@ -39,4 +39,14 @@ public
yswdqz commented on code in PR #10296:
URL: https://github.com/apache/skywalking/pull/10296#discussion_r1081345389
##
oap-server/server-library/library-server/src/main/java/org/apache/skywalking/oap/server/library/server/http/HTTPServerConfig.java:
##
@@ -39,4 +39,14 @@ public c
wu-sheng commented on PR #10298:
URL: https://github.com/apache/skywalking/pull/10298#issuecomment-1397067644
We should build a CI on GHA/Windows to test and verify the metrics. And we
could provide the OTEL configuration you provided.
Further, we should have a dashboard setup for Windows
mikechengwei opened a new pull request, #10298:
URL: https://github.com/apache/skywalking/pull/10298
- [ ] If this pull request closes/resolves/fixes an existing issue, replace
the issue number. Closes #10242 .
- [ ] Update the [`CHANGES`
log](https://gith
wu-sheng commented on code in PR #10296:
URL: https://github.com/apache/skywalking/pull/10296#discussion_r1081338049
##
oap-server/server-library/library-server/src/main/java/org/apache/skywalking/oap/server/library/server/http/HTTPServerConfig.java:
##
@@ -39,4 +39,14 @@ public
hanahmily commented on code in PR #239:
URL:
https://github.com/apache/skywalking-banyandb/pull/239#discussion_r1081318960
##
banyand/liaison/grpc/registry.go:
##
@@ -435,7 +437,37 @@ type topNAggregationRegistryServer struct {
func (ts *topNAggregationRegistryServer) Create(c
kezhenxu94 commented on code in PR #10296:
URL: https://github.com/apache/skywalking/pull/10296#discussion_r1081327623
##
oap-server/server-library/library-server/src/main/java/org/apache/skywalking/oap/server/library/server/http/HTTPServerConfig.java:
##
@@ -39,4 +39,14 @@ publ
kezhenxu94 commented on code in PR #10296:
URL: https://github.com/apache/skywalking/pull/10296#discussion_r1081322512
##
oap-server/server-library/library-server/src/main/java/org/apache/skywalking/oap/server/library/server/http/HTTPServerConfig.java:
##
@@ -39,4 +39,14 @@ publ
wu-sheng commented on issue #9883:
URL: https://github.com/apache/skywalking/issues/9883#issuecomment-1397040340
That is good. We should be able to have public static IP on EC2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
kezhenxu94 commented on issue #9883:
URL: https://github.com/apache/skywalking/issues/9883#issuecomment-1397037616
> By my test, the self-signed certificate will encounter errors such as:
>
> ```
>
> {
>
> "deliveryStreamARN": "",
>
> "destination": "35...
pg-yang commented on issue #9883:
URL: https://github.com/apache/skywalking/issues/9883#issuecomment-1397013267
By my test, the self-signed certificate will encounter errors such as:
```
{
"deliveryStreamARN": "",
"destination": "35",
"deliveryStreamVersion
wu-sheng commented on code in PR #10296:
URL: https://github.com/apache/skywalking/pull/10296#discussion_r1081223732
##
oap-server/server-library/library-server/src/main/java/org/apache/skywalking/oap/server/library/server/http/HTTPServerConfig.java:
##
@@ -39,4 +39,14 @@ public
kezhenxu94 commented on code in PR #10296:
URL: https://github.com/apache/skywalking/pull/10296#discussion_r1081123339
##
oap-server/server-library/library-server/src/main/java/org/apache/skywalking/oap/server/library/server/http/HTTPServerConfig.java:
##
@@ -39,4 +39,14 @@ publ
kezhenxu94 commented on code in PR #10296:
URL: https://github.com/apache/skywalking/pull/10296#discussion_r1081217976
##
oap-server/server-library/library-server/src/main/java/org/apache/skywalking/oap/server/library/server/http/HTTPServerConfig.java:
##
@@ -39,4 +39,14 @@ publ
wu-sheng commented on code in PR #10296:
URL: https://github.com/apache/skywalking/pull/10296#discussion_r1081209069
##
oap-server/server-library/library-server/src/main/java/org/apache/skywalking/oap/server/library/server/http/HTTPServerConfig.java:
##
@@ -39,4 +39,14 @@ public
kezhenxu94 commented on code in PR #10296:
URL: https://github.com/apache/skywalking/pull/10296#discussion_r1081116842
##
oap-server/server-library/library-server/src/main/java/org/apache/skywalking/oap/server/library/server/http/HTTPServer.java:
##
@@ -70,6 +78,21 @@ public voi
wu-sheng commented on PR #10296:
URL: https://github.com/apache/skywalking/pull/10296#issuecomment-1396810825
> I have not found docs about httpserver. Is there a doc I need to edit?
No, there isn't doc for a class.
But there are core and sharing server modules using this, if you ar
yswdqz commented on PR #10296:
URL: https://github.com/apache/skywalking/pull/10296#issuecomment-1396765973
I have not found docs about httpserver. Is there a doc I need to edit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
yswdqz opened a new pull request, #10296:
URL: https://github.com/apache/skywalking/pull/10296
- [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
- [] Update the documentation to include this new feature.
- [x] Tests(including UT, IT, E2E) are added to verify
lujiajing1126 commented on PR #239:
URL:
https://github.com/apache/skywalking-banyandb/pull/239#issuecomment-1396703190
I've refactored the wring path of `TopN Aggregation` results by creating new
internal writing request to the pipeline. And every TopN schema is now bounded
to a real Meas
wu-sheng merged PR #46:
URL: https://github.com/apache/skywalking-php/pull/46
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
lujiajing1126 commented on code in PR #239:
URL:
https://github.com/apache/skywalking-banyandb/pull/239#discussion_r1081016963
##
banyand/measure/measure_write.go:
##
@@ -60,7 +61,7 @@ func (s *measure) write(md *commonv1.Metadata, shardID
common.ShardID, entity []
if
jmjoy opened a new pull request, #46:
URL: https://github.com/apache/skywalking-php/pull/46
1. Report instance properties and keep alive.
2. Clearly limit the version of Skywalking (>= 8).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
wu-sheng commented on issue #9883:
URL: https://github.com/apache/skywalking/issues/9883#issuecomment-1396562092
Does this http server listener for awsreceiver only?(I assume so)? Then it
should be a new one.
--
This is an automated message from the Apache Git Service.
To respond to the m
yswdqz commented on issue #9883:
URL: https://github.com/apache/skywalking/issues/9883#issuecomment-1396556253
@wu-sheng Which port should we open as https port? Should it be defined by
the user, or should it be located on the same port as http?
--
This is an automated message from the A
mrproliu commented on PR #73:
URL: https://github.com/apache/skywalking-rover/pull/73#issuecomment-1396530028
Thanks for your contribution to support OpenSSL `3.0.x`. Could you also
update the change log?
--
This is an automated message from the Apache Git Service.
To respond to the mess
mrproliu merged PR #74:
URL: https://github.com/apache/skywalking-rover/pull/74
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr..
mrproliu commented on PR #74:
URL: https://github.com/apache/skywalking-rover/pull/74#issuecomment-1396471270
> lgtm. I am not sure whether we have docs to update here and/or main repo?
We should list which events we could collect and attach to spans.
Updated in the documentation.
wu-sheng commented on issue #10295:
URL: https://github.com/apache/skywalking/issues/10295#issuecomment-1396468297
We just need to reuse similar UI component, it doesn't need to a span.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
mrproliu opened a new issue, #10295:
URL: https://github.com/apache/skywalking/issues/10295
### Search before asking
- [X] I had searched in the
[issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no
similar feature requirement.
### Description
mufiye commented on issue #:
URL: https://github.com/apache/skywalking/issues/#issuecomment-1396418646
> I mean, as you have enhanced one class successfully, there would not be
special cases that could be enhanced or not. :) I think that was driving you to
ask. My point is, don't tr
mrproliu opened a new pull request, #74:
URL: https://github.com/apache/skywalking-rover/pull/74
Including the following summary of the event:
1. Network interface information
2. RTT metrics
3. Package Count/Size
4. Syscall function name(write, read, etc.)
--
This is an automat
1 - 100 of 1648 matches
Mail list logo
