wu-sheng commented on issue #2353: USE_QUALIFIED_NAME_AS_ENDPOINT_NAME
configuration
URL:
https://github.com/apache/incubator-skywalking/pull/2353#issuecomment-473480693
@ascrutae What is the status of the test case PR for this? I hope we could
finish that and merge both of them.
---
wu-sheng commented on issue #2353: USE_QUALIFIED_NAME_AS_ENDPOINT_NAME
configuration
URL:
https://github.com/apache/incubator-skywalking/pull/2353#issuecomment-473603058
@ascrutae please run the existed spring cases too.
Thi
wu-sheng commented on issue #2353: USE_QUALIFIED_NAME_AS_ENDPOINT_NAME
configuration
URL:
https://github.com/apache/incubator-skywalking/pull/2353#issuecomment-473603681
@BFergerson I think we changed the default operation names too in this pr,
adding get/post in it, right? Then we need t
wu-sheng commented on issue #2353: USE_QUALIFIED_NAME_AS_ENDPOINT_NAME
configuration
URL:
https://github.com/apache/incubator-skywalking/pull/2353#issuecomment-473607298
A new case should be better. How about spring-get-annotation?
-
wu-sheng commented on issue #2353: USE_QUALIFIED_NAME_AS_ENDPOINT_NAME
configuration
URL:
https://github.com/apache/incubator-skywalking/pull/2353#issuecomment-473614351
I think we should put the `get` at the first part.
`/{GET}/requestmethod/acceptGetExplicit` should make more sense. Agr
wu-sheng commented on issue #2353: USE_QUALIFIED_NAME_AS_ENDPOINT_NAME
configuration
URL:
https://github.com/apache/incubator-skywalking/pull/2353#issuecomment-473614680
For test case name, I think yours should be good.
Thi
wu-sheng commented on issue #2353: USE_QUALIFIED_NAME_AS_ENDPOINT_NAME
configuration
URL:
https://github.com/apache/incubator-skywalking/pull/2353#issuecomment-473899748
I forget to use `squash and commit` to this pull request.
@apache/skywalking-committers sorry guys.
--
