wu-sheng commented on issue #2360: Async core APIs in java agent
URL:
https://github.com/apache/incubator-skywalking/pull/2360#issuecomment-473479514
@BFergerson Yes. `isInAsyncMode` should be set in that way. Merged your
change.
wu-sheng commented on issue #2360: Async core APIs in java agent
URL:
https://github.com/apache/incubator-skywalking/pull/2360#issuecomment-473112957
@adriancole
> I think for people not working in skywalking every day, the change here is
because the span apis usually are for one
wu-sheng commented on issue #2360: Async core APIs in java agent
URL:
https://github.com/apache/incubator-skywalking/pull/2360#issuecomment-472835135
New commit
-
Finish the context based on `#stopSpan` result, rather than listener.
Because in new mode, listener is only
wu-sheng commented on issue #2360: Async core APIs in java agent
URL:
https://github.com/apache/incubator-skywalking/pull/2360#issuecomment-472757482
I think I miss to clear the trace context when stack is empty. Try to fix
this.
wu-sheng commented on issue #2360: Async core APIs in java agent
URL:
https://github.com/apache/incubator-skywalking/pull/2360#issuecomment-472741736
@liuhaoyang I used to avoid the issue in .net, now, please take a look at
this.
wu-sheng commented on issue #2360: Async core APIs in java agent
URL:
https://github.com/apache/incubator-skywalking/pull/2360#issuecomment-472741390
This is my first draft. Please review, try and provide feedback.
This is
