wu-sheng commented on issue #2386: Vert.x Core 3.x Plugin
URL:
https://github.com/apache/incubator-skywalking/pull/2386#issuecomment-483718966
@BFergerson We finally made this through 28 days.
This is an automated message fro
wu-sheng commented on issue #2386: Vert.x Core 3.x Plugin
URL:
https://github.com/apache/incubator-skywalking/pull/2386#issuecomment-483293762
@ascrutae The test results are good enough. You could review codes.
This is an aut
wu-sheng commented on issue #2386: Vert.x Core 3.x Plugin
URL:
https://github.com/apache/incubator-skywalking/pull/2386#issuecomment-483286312
@BFergerson The PR includes a comment issue, causing CI fails, please fix.
This is
wu-sheng commented on issue #2386: Vert.x Core 3.x Plugin
URL:
https://github.com/apache/incubator-skywalking/pull/2386#issuecomment-482897177
3.x in name should be fine. Can you confirm two thing?
1. This plugin wouldn't make 3.0 and 3.1 codes break
2. Supported list document includ
wu-sheng commented on issue #2386: Vert.x Core 3.x Plugin
URL:
https://github.com/apache/incubator-skywalking/pull/2386#issuecomment-482825099
3.3+, do you want 3.1 and 3.2 supported?
This is an automated message from the Apa
wu-sheng commented on issue #2386: Vert.x Core 3.x Plugin
URL:
https://github.com/apache/incubator-skywalking/pull/2386#issuecomment-481912698
@BFergerson Look like we only support 3.6+. Is that because of codebase, or
something else?
--
wu-sheng commented on issue #2386: Vert.x Core 3.x Plugin
URL:
https://github.com/apache/incubator-skywalking/pull/2386#issuecomment-481253667
@BFergerson Observability is officially available in CFP page as a catalog.
CFP close time, May 13, 2019 9:00 PM (Asia/Shanghai time). If you decid
wu-sheng commented on issue #2386: Vert.x Core 3.x Plugin
URL:
https://github.com/apache/incubator-skywalking/pull/2386#issuecomment-480916580
Yes. I will be there as a speaker and track co-chair. Look forward to see
you there.
For tests, let's wait several days. @ascrutae leave for
wu-sheng commented on issue #2386: Vert.x Core 3.x Plugin
URL:
https://github.com/apache/incubator-skywalking/pull/2386#issuecomment-480833793
@BFergerson Now, ApacheCon has opened topic of observability, I think your
case(source++) is new about how to use skywalking. if you want to share,
wu-sheng commented on issue #2386: Vert.x Core 3.x Plugin
URL:
https://github.com/apache/incubator-skywalking/pull/2386#issuecomment-480120825
> I added all versions from 3.x to the integration test. I can't get any of
them to work locally so I'm just going to wait for the SkyWalking Robot
wu-sheng commented on issue #2386: Vert.x Core 3.x Plugin
URL:
https://github.com/apache/incubator-skywalking/pull/2386#issuecomment-480090581
Let's try to add more 3.x version only. Keep 2.x out this is sensible to me.
This
wu-sheng commented on issue #2386: Vert.x Core 3.x Plugin
URL:
https://github.com/apache/incubator-skywalking/pull/2386#issuecomment-480074088
@BFergerson That test looks good. Let's wait @ascrutae review the codes.
Then would we just support one certain vert.x version? Or more?
-
wu-sheng commented on issue #2386: Vert.x Core 3.x Plugin
URL:
https://github.com/apache/incubator-skywalking/pull/2386#issuecomment-477380885
> is it necessary to open a local span when you're just closing an async
local span?
Anything else you will or plan to do when/after close a
wu-sheng commented on issue #2386: Vert.x Core 3.x Plugin
URL:
https://github.com/apache/incubator-skywalking/pull/2386#issuecomment-476930851
I think you could work on tests first. If the process is as same as we
discussed, I think in theory, should not have a big problem.
@ascrut
wu-sheng commented on issue #2386: Vert.x Core 3.x Plugin
URL:
https://github.com/apache/incubator-skywalking/pull/2386#issuecomment-476837981
What is the status of this PR?
This is an automated message from the Apache Git Se
wu-sheng commented on issue #2386: Vert.x Core 3.x Plugin
URL:
https://github.com/apache/incubator-skywalking/pull/2386#issuecomment-475841883
> I'm able to detect whether the message is going over the wire or being
routed locally pretty easily
If you can detect that, so you should
wu-sheng commented on issue #2386: Vert.x Core 3.x Plugin
URL:
https://github.com/apache/incubator-skywalking/pull/2386#issuecomment-475108892
```
If it was sent cross-thread:
- Ignore ContextCarrier and work with ContextSnapshot
If it was sent cross-process
- Use ContextC
wu-sheng commented on issue #2386: Vert.x Core 3.x Plugin
URL:
https://github.com/apache/incubator-skywalking/pull/2386#issuecomment-474649278
I am flighting to SF today. 😄
This is an automated message from the Apache Git Ser
18 matches
Mail list logo
