[GitHub] [skywalking] Duncan-tree-zhou commented on issue #9160: [Feature] [SWCK] Add Instrument CRD to config and operate instruments.

2022-06-16 Thread GitBox
Duncan-tree-zhou commented on issue #9160: URL: https://github.com/apache/skywalking/issues/9160#issuecomment-1157862751 Hi, here is the PR: https://github.com/apache/skywalking-swck/pull/66 It looks like the PR in SWCK repo cannot be associated to this issue? here are t

[GitHub] [skywalking] Duncan-tree-zhou commented on issue #9160: [Feature] [SWCK] Add Instrument CRD to config and operate instruments.

2022-06-07 Thread GitBox
Duncan-tree-zhou commented on issue #9160: URL: https://github.com/apache/skywalking/issues/9160#issuecomment-1148836369 is there a guide to debug SWCK operator locally? i had tried the common steps, but still getting error. did i miss some steps? ``` ssh # setup ~/.kube/config to

[GitHub] [skywalking] Duncan-tree-zhou commented on issue #9160: [Feature] [SWCK] Add Instrument CRD to config and operate instruments.

2022-06-06 Thread GitBox
Duncan-tree-zhou commented on issue #9160: URL: https://github.com/apache/skywalking/issues/9160#issuecomment-1147509895 @dashanji, When moving the annotation to CR spec, its not a good way to hardcode the mapping from CR spec fields to skywalking app env keys. Because the app level env key

[GitHub] [skywalking] Duncan-tree-zhou commented on issue #9160: [Feature] [SWCK] Add Instrument CRD to config and operate instruments.

2022-06-05 Thread GitBox
Duncan-tree-zhou commented on issue #9160: URL: https://github.com/apache/skywalking/issues/9160#issuecomment-1146771403 @wu-sheng @dashanji, from our discussion, i got the idea. we can create a new CR and operator. CR have the same annotations as pod level annotation for agents. And add la

[GitHub] [skywalking] Duncan-tree-zhou commented on issue #9160: [Feature] [SWCK] Add Instrument CRD to config and operate instruments.

2022-06-04 Thread GitBox
Duncan-tree-zhou commented on issue #9160: URL: https://github.com/apache/skywalking/issues/9160#issuecomment-1146656020 And here are questions to be clarified: 1. extend JavaAgent CRD or create new one? and the same question for controller. 2. where and when to operate agent injection

[GitHub] [skywalking] Duncan-tree-zhou commented on issue #9160: [Feature] [SWCK] Add Instrument CRD to config and operate instruments.

2022-06-04 Thread GitBox
Duncan-tree-zhou commented on issue #9160: URL: https://github.com/apache/skywalking/issues/9160#issuecomment-1146647938 Hi @dashanji, I looked into the implements of SWCK, and saw the javaagent CRD is already exists. The javaagent CR is created by javaagent-controller when pods get