[GitHub] [skywalking] Fine0830 edited a comment on issue #4228: Support Browser protocol at OAP

2020-02-12 Thread GitBox
Fine0830 edited a comment on issue #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#issuecomment-585121955 I add `jsErrorPv` in error log protocol to mark. When `jsErrorPv` equal true in one error log, pv with JS error will be plus 1. @arugal You n

[GitHub] [skywalking] Fine0830 edited a comment on issue #4228: Support Browser protocol at OAP

2020-02-11 Thread GitBox
Fine0830 edited a comment on issue #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#issuecomment-584998594 @wu-sheng For error logs, if backend can't cache/persistent the context, how do we query error details? Error details are needed to analyse co

[GitHub] [skywalking] Fine0830 edited a comment on issue #4228: Support Browser protocol at OAP

2020-02-11 Thread GitBox
Fine0830 edited a comment on issue #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#issuecomment-584989598 > @Fine0830 It is easy to say like that. Please take a look at the protocol, how to implement that? JS error has never been reported, we recei

[GitHub] [skywalking] Fine0830 edited a comment on issue #4228: Support Browser protocol at OAP

2020-02-11 Thread GitBox
Fine0830 edited a comment on issue #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#issuecomment-584989598 > @Fine0830 It is easy to say like that. Please take a look at the protocol, how to implement that? JS error has never been reported, we recei

[GitHub] [skywalking] Fine0830 edited a comment on issue #4228: Support Browser protocol at OAP

2020-02-10 Thread GitBox
Fine0830 edited a comment on issue #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#issuecomment-584514378 No, the value couldn't be more than 100%. JS error rate = PV(pv with JS error in specified time) / PV (total PV in specified time). -