[GitHub] [skywalking] JaredTan95 commented on issue #3370: support es https ssl config.

2019-08-29 Thread GitBox
JaredTan95 commented on issue #3370: support es https ssl config. URL: https://github.com/apache/skywalking/pull/3370#issuecomment-526418899 @hanahmily As we discussed before, we could also set SSL within JDK-JVM-Options, like this: ```bash -Djavax.net.ssl.keyStoreType=jks -Dj

[GitHub] [skywalking] JaredTan95 commented on issue #3370: support es https ssl config.

2019-08-29 Thread GitBox
JaredTan95 commented on issue #3370: support es https ssl config. URL: https://github.com/apache/skywalking/pull/3370#issuecomment-526424268 > You prefer to add the JVM things you mentioned in the document, some people may be not familiar with that. What I mean is that, if we use JVM

[GitHub] [skywalking] JaredTan95 commented on issue #3370: support es https ssl config.

2019-08-29 Thread GitBox
JaredTan95 commented on issue #3370: support es https ssl config. URL: https://github.com/apache/skywalking/pull/3370#issuecomment-526426865 As far as I know, there should be no difference. That's why I'm just talking about which way we're going to choose. @hanahmily Any suggestions? ---

[GitHub] [skywalking] JaredTan95 commented on issue #3370: support es https ssl config.

2019-08-29 Thread GitBox
JaredTan95 commented on issue #3370: support es https ssl config. URL: https://github.com/apache/skywalking/pull/3370#issuecomment-526427704 > > As far as I know, there should be no difference. That's why I'm just talking about which way we're going to choose. @hanahmily Any suggestions?