[GitHub] [skywalking] Jargon96 commented on a change in pull request #5550: add support for dbcp 2.x plugin

2020-11-03 Thread GitBox
Jargon96 commented on a change in pull request #5550: URL: https://github.com/apache/skywalking/pull/5550#discussion_r516724647 ## File path: test/plugin/scenarios/dbcp-2.x-scenario/support-version.list ## @@ -0,0 +1,20 @@ +# Licensed to the Apache Software Foundation (ASF)

[GitHub] [skywalking] Jargon96 commented on a change in pull request #5550: add support for dbcp 2.x plugin

2020-11-03 Thread GitBox
Jargon96 commented on a change in pull request #5550: URL: https://github.com/apache/skywalking/pull/5550#discussion_r516718588 ## File path: test/plugin/scenarios/dbcp-2.x-scenario/config/expectedData.yaml ## @@ -0,0 +1,240 @@ +# Licensed to the Apache Software Foundation

[GitHub] [skywalking] Jargon96 commented on a change in pull request #5550: add support for dbcp 2.x plugin

2020-11-03 Thread GitBox
Jargon96 commented on a change in pull request #5550: URL: https://github.com/apache/skywalking/pull/5550#discussion_r516394756 ## File path: test/plugin/scenarios/dbcp-2.x-scenario/config/expectedData.yaml ## @@ -0,0 +1,255 @@ +# Licensed to the Apache Software Foundation

[GitHub] [skywalking] Jargon96 commented on a change in pull request #5550: add support for dbcp 2.x plugin

2020-10-23 Thread GitBox
Jargon96 commented on a change in pull request #5550: URL: https://github.com/apache/skywalking/pull/5550#discussion_r510970387 ## File path: apm-sniffer/apm-sdk-plugin/dbcp-2.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/dbcp/v2/PoolingCloseConnectInterceptor.java

[GitHub] [skywalking] Jargon96 commented on a change in pull request #5550: add support for dbcp 2.x plugin

2020-10-23 Thread GitBox
Jargon96 commented on a change in pull request #5550: URL: https://github.com/apache/skywalking/pull/5550#discussion_r510854980 ## File path: apm-sniffer/apm-sdk-plugin/dbcp-2.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/dbcp/v2/PoolingCloseConnectInterceptor.java

[GitHub] [skywalking] Jargon96 commented on a change in pull request #5550: add support for dbcp 2.x plugin

2020-10-23 Thread GitBox
Jargon96 commented on a change in pull request #5550: URL: https://github.com/apache/skywalking/pull/5550#discussion_r510854980 ## File path: apm-sniffer/apm-sdk-plugin/dbcp-2.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/dbcp/v2/PoolingCloseConnectInterceptor.java

[GitHub] [skywalking] Jargon96 commented on a change in pull request #5550: add support for dbcp 2.x plugin

2020-10-23 Thread GitBox
Jargon96 commented on a change in pull request #5550: URL: https://github.com/apache/skywalking/pull/5550#discussion_r510834300 ## File path: apm-sniffer/apm-sdk-plugin/dbcp-2.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/dbcp/v2/PoolingCloseConnectInterceptor.java

[GitHub] [skywalking] Jargon96 commented on a change in pull request #5550: add support for dbcp 2.x plugin

2020-10-21 Thread GitBox
Jargon96 commented on a change in pull request #5550: URL: https://github.com/apache/skywalking/pull/5550#discussion_r509388661 ## File path: apm-sniffer/apm-sdk-plugin/dbcp-2.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/dbcp/v2/PoolingCloseConnectInterceptor.java

[GitHub] [skywalking] Jargon96 commented on a change in pull request #5550: add support for dbcp 2.x plugin

2020-10-21 Thread GitBox
Jargon96 commented on a change in pull request #5550: URL: https://github.com/apache/skywalking/pull/5550#discussion_r509388661 ## File path: apm-sniffer/apm-sdk-plugin/dbcp-2.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/dbcp/v2/PoolingCloseConnectInterceptor.java