Jargon96 commented on pull request #5550:
URL: https://github.com/apache/skywalking/pull/5550#issuecomment-723533887
I was very excited about the moment of code merging! ! I'm inspired and
proud to be the 281st contributor to the main repo!
Thanks to the SkyWalking community,
Jargon96 commented on pull request #5550:
URL: https://github.com/apache/skywalking/pull/5550#issuecomment-723514860
> One last thing, `CHANGES.md` is not updated. You are adding a new plugin.
Ok sir, I have updated CHANGES.md.
Jargon96 commented on pull request #5550:
URL: https://github.com/apache/skywalking/pull/5550#issuecomment-723457900
> Add `Pool` catalog.
Got it.
This is an automated message from the Apache Git Service.
To respond
Jargon96 commented on pull request #5550:
URL: https://github.com/apache/skywalking/pull/5550#issuecomment-723450985
> Seems you forgot to update this
https://github.com/apache/skywalking/blob/master/docs/en/setup/service-agent/java-agent/Supported-list.md
Dear sir, Is cache
Jargon96 commented on pull request #5550:
URL: https://github.com/apache/skywalking/pull/5550#issuecomment-723446023
@wu-sheng Thank you sir, I have updated the code.
This is an automated message from the Apache Git
Jargon96 commented on pull request #5550:
URL: https://github.com/apache/skywalking/pull/5550#issuecomment-721494083
> @Jargon96 I think you have to modify the shardingsphere's expected data
file. Because you added the DBCP plugin, and they use it in their plugin too.
As this is a new
Jargon96 commented on pull request #5550:
URL: https://github.com/apache/skywalking/pull/5550#issuecomment-715423610
I updated plugin and modified some inappropriate places, please review.
This is the statement I executed in test case：
* CREATE TABLE test_DBCP
* INSERT INTO
Jargon96 commented on pull request #5550:
URL: https://github.com/apache/skywalking/pull/5550#issuecomment-699525075
updated plugin example，This is the statement I executed：
* create table test_DBCP
* drop table test_DBCP
After the statement is executed, I closed the connection and
Jargon96 commented on pull request #5550:
URL: https://github.com/apache/skywalking/pull/5550#issuecomment-698302193
> CI has breaking. You'd better to fix it.
Thank you sir.I have updated the code.
This is an
Jargon96 commented on pull request #5550:
URL: https://github.com/apache/skywalking/pull/5550#issuecomment-698302193
> CI has breaking. You'd better to fix it.
Thank you sir.I have updated the code.
This is an
10 matches
Mail list logo
