[GitHub] [skywalking] aderm commented on a change in pull request #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario

aderm commented on a change in pull request #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario URL: https://github.com/apache/skywalking/pull/3803#discussion_r345549623 ## File path: apm-sniffer/apm-sdk-plugin/elasticsearch-6.x-plugin/src/main/java/org/apache/sky

[GitHub] [skywalking] aderm commented on a change in pull request #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario

aderm commented on a change in pull request #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario URL: https://github.com/apache/skywalking/pull/3803#discussion_r344494840 ## File path: docs/en/guides/Plugin-test.md ## @@ -612,12 +612,13 @@ stage('Run Agent

[GitHub] [skywalking] aderm commented on a change in pull request #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario

aderm commented on a change in pull request #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario URL: https://github.com/apache/skywalking/pull/3803#discussion_r344494810 ## File path: Jenkinsfile-Agent-Test-4 ## @@ -68,7 +68,7 @@ pipeline { }

[GitHub] [skywalking] aderm commented on a change in pull request #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario

aderm commented on a change in pull request #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario URL: https://github.com/apache/skywalking/pull/3803#discussion_r38751 ## File path: apm-sniffer/apm-sdk-plugin/elasticsearch-6.x-plugin/src/main/java/org/apache/sky

[GitHub] [skywalking] aderm commented on a change in pull request #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario

aderm commented on a change in pull request #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario URL: https://github.com/apache/skywalking/pull/3803#discussion_r38656 ## File path: test/plugin/scenarios/elasticsearch-6.x-scenario/bin/startup.sh ## @@ -

[GitHub] [skywalking] aderm commented on a change in pull request #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario

aderm commented on a change in pull request #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario URL: https://github.com/apache/skywalking/pull/3803#discussion_r37120 ## File path: test/plugin/scenarios/elasticsearch-6.x-scenario/bin/startup.sh ## @@ -

[GitHub] [skywalking] aderm commented on a change in pull request #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario

aderm commented on a change in pull request #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario URL: https://github.com/apache/skywalking/pull/3803#discussion_r37060 ## File path: test/plugin/scenarios/elasticsearch-6.x-scenario/bin/startup.sh ## @@ -

[GitHub] [skywalking] aderm commented on a change in pull request #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario

aderm commented on a change in pull request #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario URL: https://github.com/apache/skywalking/pull/3803#discussion_r35898 ## File path: apm-sniffer/apm-sdk-plugin/elasticsearch-6.x-plugin/src/main/java/org/apache/sky

[GitHub] [skywalking] aderm commented on a change in pull request #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario

aderm commented on a change in pull request #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario URL: https://github.com/apache/skywalking/pull/3803#discussion_r32906 ## File path: apm-sniffer/apm-sdk-plugin/elasticsearch-6.x-plugin/src/main/java/org/apache/sky

[GitHub] [skywalking] aderm commented on a change in pull request #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario

aderm commented on a change in pull request #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario URL: https://github.com/apache/skywalking/pull/3803#discussion_r32906 ## File path: apm-sniffer/apm-sdk-plugin/elasticsearch-6.x-plugin/src/main/java/org/apache/sky

[GitHub] [skywalking] aderm commented on a change in pull request #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario

aderm commented on a change in pull request #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario URL: https://github.com/apache/skywalking/pull/3803#discussion_r32566 ## File path: test/plugin/scenarios/elasticsearch-6.x-scenario/bin/startup.sh ## @@ -

[GitHub] [skywalking] aderm commented on a change in pull request #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario

aderm commented on a change in pull request #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario URL: https://github.com/apache/skywalking/pull/3803#discussion_r32654 ## File path: apm-sniffer/apm-sdk-plugin/elasticsearch-6.x-plugin/src/main/java/org/apache/sky

[GitHub] [skywalking] aderm commented on a change in pull request #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario

aderm commented on a change in pull request #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario URL: https://github.com/apache/skywalking/pull/3803#discussion_r32610 ## File path: test/plugin/scenarios/elasticsearch-6.x-scenario/pom.xml ## @@ -0,0 +1,

[GitHub] [skywalking] aderm commented on a change in pull request #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario

aderm commented on a change in pull request #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario URL: https://github.com/apache/skywalking/pull/3803#discussion_r32566 ## File path: test/plugin/scenarios/elasticsearch-6.x-scenario/bin/startup.sh ## @@ -

[GitHub] [skywalking] aderm commented on a change in pull request #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario

aderm commented on a change in pull request #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario URL: https://github.com/apache/skywalking/pull/3803#discussion_r32471 ## File path: apm-sniffer/apm-sdk-plugin/elasticsearch-6.x-plugin/src/main/java/org/apache/sky

[GitHub] [skywalking] aderm commented on a change in pull request #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario

aderm commented on a change in pull request #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario URL: https://github.com/apache/skywalking/pull/3803#discussion_r32431 ## File path: apm-sniffer/apm-sdk-plugin/elasticsearch-6.x-plugin/src/main/java/org/apache/sky

[GitHub] [skywalking] aderm commented on a change in pull request #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario

aderm commented on a change in pull request #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario URL: https://github.com/apache/skywalking/pull/3803#discussion_r32431 ## File path: apm-sniffer/apm-sdk-plugin/elasticsearch-6.x-plugin/src/main/java/org/apache/sky

[GitHub] [skywalking] aderm commented on a change in pull request #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario

aderm commented on a change in pull request #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario URL: https://github.com/apache/skywalking/pull/3803#discussion_r32424 ## File path: apm-sniffer/apm-sdk-plugin/elasticsearch-6.x-plugin/src/main/java/org/apache/sky

[GitHub] [skywalking] aderm commented on a change in pull request #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario

aderm commented on a change in pull request #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario URL: https://github.com/apache/skywalking/pull/3803#discussion_r343975636 ## File path: Jenkinsfile-Agent-Test ## @@ -82,6 +83,12 @@ pipeline { pa

[GitHub] [skywalking] aderm commented on a change in pull request #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario

aderm commented on a change in pull request #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario URL: https://github.com/apache/skywalking/pull/3803#discussion_r343975431 ## File path: apm-sniffer/apm-sdk-plugin/elasticsearch-6.x-plugin/pom.xml ## @@ -0,0

[GitHub] [skywalking] aderm commented on a change in pull request #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario

aderm commented on a change in pull request #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario URL: https://github.com/apache/skywalking/pull/3803#discussion_r343973617 ## File path: apm-protocol/apm-network/src/main/java/org/apache/skywalking/apm/network/trace/c

[GitHub] [skywalking] aderm commented on a change in pull request #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario

aderm commented on a change in pull request #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario URL: https://github.com/apache/skywalking/pull/3803#discussion_r343954478 ## File path: apm-sniffer/apm-sdk-plugin/elasticsearch-6.x-plugin/pom.xml ## @@ -0,0

[GitHub] [skywalking] aderm commented on a change in pull request #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario

aderm commented on a change in pull request #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario URL: https://github.com/apache/skywalking/pull/3803#discussion_r343951312 ## File path: docs/en/guides/Plugin-test.md ## @@ -602,12 +602,13 @@ stage('Run Agent