[GitHub] [skywalking] cuiweiwei commented on pull request #5946: fix influxdb bug while setting influxdb connection response format as InfluxDB.ResponseFormat.JSON

2020-12-04 Thread GitBox
cuiweiwei commented on pull request #5946: URL: https://github.com/apache/skywalking/pull/5946#issuecomment-739116197 ![image](https://user-images.githubusercontent.com/15830188/101232337-296b1f00-36ec-11eb-83f0-b562703352f6.png) ![image](https://user-images.githubusercontent.com/158301

[GitHub] [skywalking] cuiweiwei commented on pull request #5946: fix influxdb bug while setting influxdb connection response format as InfluxDB.ResponseFormat.JSON

2020-12-04 Thread GitBox
cuiweiwei commented on pull request #5946: URL: https://github.com/apache/skywalking/pull/5946#issuecomment-738652541 Yes, according to my tests, it is ok. I have made that part configurable. This is an automated message from

[GitHub] [skywalking] cuiweiwei commented on pull request #5946: fix influxdb bug while setting influxdb connection response format as InfluxDB.ResponseFormat.JSON

2020-12-03 Thread GitBox
cuiweiwei commented on pull request #5946: URL: https://github.com/apache/skywalking/pull/5946#issuecomment-738624763 I know you mean here. However, users may find that the default implementation will fail when they use a special version of influxDB, and error logs finally point to this :

[GitHub] [skywalking] cuiweiwei commented on pull request #5946: fix influxdb bug while setting influxdb connection response format as InfluxDB.ResponseFormat.JSON

2020-12-03 Thread GitBox
cuiweiwei commented on pull request #5946: URL: https://github.com/apache/skywalking/pull/5946#issuecomment-738554517 I have the needs to activate json ,maybe other people have the same need,so i changed the code and re-packaged the project to build image. To say the least, even if someone

[GitHub] [skywalking] cuiweiwei commented on pull request #5946: fix influxdb bug while setting influxdb connection response format as InfluxDB.ResponseFormat.JSON

2020-12-03 Thread GitBox
cuiweiwei commented on pull request #5946: URL: https://github.com/apache/skywalking/pull/5946#issuecomment-738020999 When set json as influxdb response format, it will use scientific counting to convert long type to double, but BasicTrace use String type as its startTime, then error occur