[GitHub] [skywalking] cyejing commented on issue #3945: Enhance webflux plugin, related to Spring Gateway plugin too.

2019-12-02 Thread GitBox
cyejing commented on issue #3945: Enhance webflux plugin, related to Spring Gateway plugin too. URL: https://github.com/apache/skywalking/pull/3945#issuecomment-560296989 > 1. Create a snapshot to propagate. Or 2. Create an async span to finish in another thread. I tried this way, I

[GitHub] [skywalking] cyejing commented on issue #3945: Enhance webflux plugin, related to Spring Gateway plugin too.

2019-12-03 Thread GitBox
cyejing commented on issue #3945: Enhance webflux plugin, related to Spring Gateway plugin too. URL: https://github.com/apache/skywalking/pull/3945#issuecomment-561054155 ok, I keep old operationName "WEBFLUX.handle", and set Span to ``SkyWalkingDynamicField``, so no need to modify the gat

[GitHub] [skywalking] cyejing commented on issue #3945: Enhance webflux plugin, related to Spring Gateway plugin too.

2019-12-05 Thread GitBox
cyejing commented on issue #3945: Enhance webflux plugin, related to Spring Gateway plugin too. URL: https://github.com/apache/skywalking/pull/3945#issuecomment-562404866 @wu-sheng @zhaoyuguang I try do it I would like to know , Execute in one thread `` span.prepareForAsync(); Context

[GitHub] [skywalking] cyejing commented on issue #3945: Enhance webflux plugin, related to Spring Gateway plugin too.

2019-12-05 Thread GitBox
cyejing commented on issue #3945: Enhance webflux plugin, related to Spring Gateway plugin too. URL: https://github.com/apache/skywalking/pull/3945#issuecomment-562405260 ![image](https://user-images.githubusercontent.com/6317049/70290455-e3e2f000-1812-11ea-9e3e-f337bba1b7a6.png) I see

[GitHub] [skywalking] cyejing commented on issue #3945: Enhance webflux plugin, related to Spring Gateway plugin too.

2019-12-05 Thread GitBox
cyejing commented on issue #3945: Enhance webflux plugin, related to Spring Gateway plugin too. URL: https://github.com/apache/skywalking/pull/3945#issuecomment-562406509 > > How to modify operationName in another thread . setOperationName failed. > > Could you share how fail?

[GitHub] [skywalking] cyejing commented on issue #3945: Enhance webflux plugin, related to Spring Gateway plugin too.

2019-12-05 Thread GitBox
cyejing commented on issue #3945: Enhance webflux plugin, related to Spring Gateway plugin too. URL: https://github.com/apache/skywalking/pull/3945#issuecomment-562413745 Yes, Currently, I need ``setOperationNameInAsync `` to set ``urlPattern`` . if so can I add ``setOperationNameInAsy

[GitHub] [skywalking] cyejing commented on issue #3945: Enhance webflux plugin, related to Spring Gateway plugin too.

2019-12-05 Thread GitBox
cyejing commented on issue #3945: Enhance webflux plugin, related to Spring Gateway plugin too. URL: https://github.com/apache/skywalking/pull/3945#issuecomment-562415729 ok, understand, Then I stop this PR first. submit next time

[GitHub] [skywalking] cyejing commented on issue #3945: Enhance webflux plugin, related to Spring Gateway plugin too.

2019-12-13 Thread GitBox
cyejing commented on issue #3945: Enhance webflux plugin, related to Spring Gateway plugin too. URL: https://github.com/apache/skywalking/pull/3945#issuecomment-565410399 ``OperationName`` use url pattern, and use OkHttpClient add webflux exitSpan test case -

[GitHub] [skywalking] cyejing commented on issue #3945: Enhance webflux plugin, related to Spring Gateway plugin too.

2019-12-14 Thread GitBox
cyejing commented on issue #3945: Enhance webflux plugin, related to Spring Gateway plugin too. URL: https://github.com/apache/skywalking/pull/3945#issuecomment-565708027 revert old test case, and revert test case . please recheck @wu-sheng ---

[GitHub] [skywalking] cyejing commented on issue #3945: Enhance webflux plugin, related to Spring Gateway plugin too.

2019-12-16 Thread GitBox
cyejing commented on issue #3945: Enhance webflux plugin, related to Spring Gateway plugin too. URL: https://github.com/apache/skywalking/pull/3945#issuecomment-565983869 ok, I adjust the code. This is an automated message fr

[GitHub] [skywalking] cyejing commented on issue #3945: Enhance webflux plugin, related to Spring Gateway plugin too.

2019-12-16 Thread GitBox
cyejing commented on issue #3945: Enhance webflux plugin, related to Spring Gateway plugin too. URL: https://github.com/apache/skywalking/pull/3945#issuecomment-566030836 > Hi @cyejing, there are [update submodule](https://github.com/apache/skywalking/pull/3945/files#diff-8693f16a05265e958