dagmom commented on pull request #4846:
URL: https://github.com/apache/skywalking/pull/4846#issuecomment-647130189
> Merged your other PR, but this PR still doesn't allow me to update
automatically(you closed that option). Please update the branch.
@wu-sheng Where is this option? I
dagmom commented on pull request #4846:
URL: https://github.com/apache/skywalking/pull/4846#issuecomment-647118426
@dmsolr @wu-sheng
This time it seems to be `VM
dagmom commented on pull request #4846:
URL: https://github.com/apache/skywalking/pull/4846#issuecomment-647078927
> If just influxql, why need a config item?
@wu-sheng I looked at other plugins, like `plugin.elasticsearch.trace_dsl`.
Maybe just want to show component in some
dagmom commented on pull request #4846:
URL: https://github.com/apache/skywalking/pull/4846#issuecomment-647075602
> Agent setup document, **Table of Agent Configuration Properties** should
be updated as you could collect parameters. And this feature should be tested
plugin test tool, I
dagmom commented on pull request #4846:
URL: https://github.com/apache/skywalking/pull/4846#issuecomment-646990999
@wu-sheng
`TagValueNotEqualsException `
```java
@Override
public String getCauseMessage() {
return String.format("[tag(%s) value]:
dagmom commented on pull request #4846:
URL: https://github.com/apache/skywalking/pull/4846#issuecomment-646987154
> Hi @dagmom , I got it. Because the information is thrown by assertion
which is ambiguous. In fact, the `expecteddata.yml` used a constant nano time,
but the
dagmom commented on pull request #4846:
URL: https://github.com/apache/skywalking/pull/4846#issuecomment-646921032
> I think there are some limitations of the plugin test tool. Please don't
use the same operation name, but with different tags.
@wu-sheng I left only one for each
dagmom commented on pull request #4846:
URL: https://github.com/apache/skywalking/pull/4846#issuecomment-646702175
> This time, it is purely your test failure. Please check locally.
@wu-sheng
Actually, i found follow error when run `./test/plugin/run.sh -f
dagmom commented on pull request #4846:
URL: https://github.com/apache/skywalking/pull/4846#issuecomment-646158615
@wu-sheng I've updated the submodule , but ci still blocked. Please check
it for me.
This is an automated
dagmom commented on pull request #4846:
URL: https://github.com/apache/skywalking/pull/4846#issuecomment-645690497
> > What's wrong, I push icon to another repo.
>
> That change has been included in the main repo. Submodule is not updated
one by one, it is commit-id link. You should
dagmom commented on pull request #4846:
URL: https://github.com/apache/skywalking/pull/4846#issuecomment-643765920
> 1. Your UI submodule is wrong. You are rolling back.
--> What's wrong, I push icon to another repo.
> 2. `supported-list.md` doc should be updated too.
updated.
dagmom commented on pull request #4846:
URL: https://github.com/apache/skywalking/pull/4846#issuecomment-640163389
> > CI-on-MacOS check failed on apm-agent-core module , but I haven't
changed it.
> > what should I do？ @kezhenxu94
>
> I can rerun the failed tests for you, some of
dagmom commented on pull request #4846:
URL: https://github.com/apache/skywalking/pull/4846#issuecomment-640162596
CI-on-MacOS check failed on apm-agent-core module , but I haven't changed it.
what should I do？
This is an
dagmom commented on pull request #4846:
URL: https://github.com/apache/skywalking/pull/4846#issuecomment-639996888
> @dagmom there is TODO in the new codes, when it's ready, please ping us
1. The first step ,I completed found influxDB as a component.
2. I left the TODO in order
dagmom commented on pull request #4846:
URL: https://github.com/apache/skywalking/pull/4846#issuecomment-637540907
> @dagmom Read this doc,
https://github.com/apache/skywalking/blob/master/docs/en/guides/Plugin-test.md,
and you could find many test cases in our repo,
dagmom commented on pull request #4846:
URL: https://github.com/apache/skywalking/pull/4846#issuecomment-636479395
> Thanks! The plugin-test is required. :)
@dmsolr I've already written the code for the unit tests in this plugin
module, I don't know what you mean
16 matches
Mail list logo
