[GitHub] [skywalking] devkanro commented on issue #4209: Optimize trace ignore plugin

2020-01-09 Thread GitBox
devkanro commented on issue #4209: Optimize trace ignore plugin URL: https://github.com/apache/skywalking/pull/4209#issuecomment-572903518 > CI fails, please fix. Ummm, all check failed? How can I retry for it? This is

[GitHub] [skywalking] devkanro commented on issue #4209: Optimize trace ignore plugin

2020-01-09 Thread GitBox
devkanro commented on issue #4209: Optimize trace ignore plugin URL: https://github.com/apache/skywalking/pull/4209#issuecomment-572914782 > CI fails, please fix. It fails with those errors, u... I think it not caused by this PR. ```Log 2020-01-10T07:23:05.4828509Z [ERRO

[GitHub] [skywalking] devkanro commented on issue #4209: Optimize trace ignore plugin

2020-01-11 Thread GitBox
devkanro commented on issue #4209: Optimize trace ignore plugin URL: https://github.com/apache/skywalking/pull/4209#issuecomment-573309410 > Anything rules have been abandon or changed? Any doc update? The unit test all passed, but some trivial rules changed, like: 01. continuous s

[GitHub] [skywalking] devkanro commented on issue #4209: Optimize trace ignore plugin

2020-01-11 Thread GitBox
devkanro commented on issue #4209: Optimize trace ignore plugin URL: https://github.com/apache/skywalking/pull/4209#issuecomment-573314318 > LGTM. Please fix the comment issue. This is an automated message from the Apache Git