[GitHub] [skywalking] dmsolr commented on issue #3369: ADD kafka-v2 plugin

2019-08-29 Thread GitBox
dmsolr commented on issue #3369: ADD kafka-v2 plugin URL: https://github.com/apache/skywalking/pull/3369#issuecomment-526282865 > @wu-sheng I have another problem. My local test found that using v1 plugin and kafka-client using 0.11.0.0 also appeared `Magic v1 does not support record heade

[GitHub] [skywalking] dmsolr commented on issue #3369: ADD kafka-v2 plugin

2019-08-29 Thread GitBox
dmsolr commented on issue #3369: ADD kafka-v2 plugin URL: https://github.com/apache/skywalking/pull/3369#issuecomment-526429744 I am not understand well what is your means. `ApiVersions` can be witness class, because it is in every versions. The MessageFormatVersion is none of the plugin

[GitHub] [skywalking] dmsolr commented on issue #3369: ADD kafka-v2 plugin

2019-08-29 Thread GitBox
dmsolr commented on issue #3369: ADD kafka-v2 plugin URL: https://github.com/apache/skywalking/pull/3369#issuecomment-526432930 Not really. SW plugins nevenr change the original logic. This is Kafka's businesses. I think. > I think if we delete the header we can support the old versi