[GitHub] [skywalking] innerpeacez commented on a change in pull request #4959: Configmap configuration

2020-07-10 Thread GitBox
innerpeacez commented on a change in pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#discussion_r452734438 ## File path: oap-server/server-bootstrap/src/main/resources/application.yml ## @@ -264,6 +264,10 @@ configuration: period: ${SW_CONFIG_CONSUL

[GitHub] [skywalking] innerpeacez commented on a change in pull request #4959: Configmap configuration

2020-07-15 Thread GitBox
innerpeacez commented on a change in pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#discussion_r455147160 ## File path: docs/en/setup/backend/dynamic-config.md ## @@ -102,3 +102,16 @@ configuration: appId: ${SW_CONFIG_APOLLO_APP_ID:skywalking}