[GitHub] [skywalking] kezhenxu94 commented on issue #3287: Add cached writer.

2019-08-21 Thread GitBox
kezhenxu94 commented on issue #3287: Add cached writer. URL: https://github.com/apache/skywalking/pull/3287#issuecomment-523709209 /run ci This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [skywalking] kezhenxu94 commented on issue #3287: Add cached writer.

2019-08-21 Thread GitBox
kezhenxu94 commented on issue #3287: Add cached writer. URL: https://github.com/apache/skywalking/pull/3287#issuecomment-523709184 @wu-sheng `PatternLoggerTest` this is one of the unstable unit tests AFAIK, other unstable tests like `TraceSegmentServiceClientTest` are all singletons, so I

[GitHub] [skywalking] kezhenxu94 commented on issue #3287: Add cached writer.

2019-08-19 Thread GitBox
kezhenxu94 commented on issue #3287: Add cached writer. URL: https://github.com/apache/skywalking/pull/3287#issuecomment-522817167 > > `org.apache.skywalking.apm.agent.core.conf.Config.Logging#OUTPUT` is modifiable at runtime and the real writer may change, after your patch the