[GitHub] [skywalking] kezhenxu94 commented on issue #4047: Modify query SQL for MySQLDAO

2019-12-13 Thread GitBox
kezhenxu94 commented on issue #4047: Modify query SQL for MySQLDAO URL: https://github.com/apache/skywalking/pull/4047#issuecomment-565373025 > @kezhenxu94 Do we have e2e for H2 storage? no now This is an automated mess

[GitHub] [skywalking] kezhenxu94 commented on issue #4047: Modify query SQL for MySQLDAO

2019-12-16 Thread GitBox
kezhenxu94 commented on issue #4047: Modify query SQL for MySQLDAO URL: https://github.com/apache/skywalking/pull/4047#issuecomment-566380643 > @wu-sheng Hi, i read the error log, however the error context confused me and i am not sure whether my code changes caused those exception: >

[GitHub] [skywalking] kezhenxu94 commented on issue #4047: Modify query SQL for MySQLDAO

2019-12-17 Thread GitBox
kezhenxu94 commented on issue #4047: Modify query SQL for MySQLDAO URL: https://github.com/apache/skywalking/pull/4047#issuecomment-566451059 > @kezhenxu94 Hi zhenxu, which checkstyple.xml is correct one for `checkstyple plugin`? I tried to add `/apm-checkstyle/checkStyple.xml` for `checks