[GitHub] [skywalking] kezhenxu94 commented on pull request #6686: Add Dockerfile and build script for Java agent Docker image

kezhenxu94 commented on pull request #6686: URL: https://github.com/apache/skywalking/pull/6686#issuecomment-814144172 > > > Should we make two different images or three(jdk8/jdk11 base and sidecar) in this PR? > > > > > > We don't need to do that inside this PR, the base image (

[GitHub] [skywalking] kezhenxu94 commented on pull request #6686: Add Dockerfile and build script for Java agent Docker image

kezhenxu94 commented on pull request #6686: URL: https://github.com/apache/skywalking/pull/6686#issuecomment-814124907 > Should we make two different images or three(jdk8/jdk11 base and sidecar) in this PR? We don't need to do that inside this PR, the base image (jdk8 / jdk11, etc.)

[GitHub] [skywalking] kezhenxu94 commented on pull request #6686: Add Dockerfile and build script for Java agent Docker image

kezhenxu94 commented on pull request #6686: URL: https://github.com/apache/skywalking/pull/6686#issuecomment-814118502 > > I'm just suggesting, if we want to provide agent image, we provide a useable one, instead of a simple wrapper of the agent jars. > > My idea is, the recommended

[GitHub] [skywalking] kezhenxu94 commented on pull request #6686: Add Dockerfile and build script for Java agent Docker image

kezhenxu94 commented on pull request #6686: URL: https://github.com/apache/skywalking/pull/6686#issuecomment-814108176 Also, I've mentioned in https://github.com/apache/skywalking/pull/6686#issuecomment-813799007 , it's totally possible for the users to minimize their image by using this a

[GitHub] [skywalking] kezhenxu94 commented on pull request #6686: Add Dockerfile and build script for Java agent Docker image

kezhenxu94 commented on pull request #6686: URL: https://github.com/apache/skywalking/pull/6686#issuecomment-814106384 > > > Why do we need `apache/skywalking-java-agent:-`? I mean JDK version based image? > > > > > > As I said in [#6686 (comment)](https://github.com/apache/sky

[GitHub] [skywalking] kezhenxu94 commented on pull request #6686: Add Dockerfile and build script for Java agent Docker image

kezhenxu94 commented on pull request #6686: URL: https://github.com/apache/skywalking/pull/6686#issuecomment-814085030 > What is the size of the current image? ~273MB -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [skywalking] kezhenxu94 commented on pull request #6686: Add Dockerfile and build script for Java agent Docker image

kezhenxu94 commented on pull request #6686: URL: https://github.com/apache/skywalking/pull/6686#issuecomment-814084547 > Why do we need `apache/skywalking-java-agent:-`? I mean JDK version based image? As I said in https://github.com/apache/skywalking/pull/6686#issuecomment-8137990

[GitHub] [skywalking] kezhenxu94 commented on pull request #6686: Add Dockerfile and build script for Java agent Docker image

kezhenxu94 commented on pull request #6686: URL: https://github.com/apache/skywalking/pull/6686#issuecomment-813799007 https://github.com/apache/skywalking/pull/6686#discussion_r607425217 Let me make it more clear (hopefully) We will finally have some agent images like `apache

[GitHub] [skywalking] kezhenxu94 commented on pull request #6686: Add Dockerfile and build script for Java agent Docker image

kezhenxu94 commented on pull request #6686: URL: https://github.com/apache/skywalking/pull/6686#issuecomment-813309075 > I think we should only keep the agent with plugins available in the image? It indeed only copies the `agent` folder into the image, did I misunderstand your meanin