[GitHub] [skywalking] lujiajing1126 commented on a diff in pull request #10448: Integrate BanyanDB server-side TopN

lujiajing1126 commented on code in PR #10448: URL: https://github.com/apache/skywalking/pull/10448#discussion_r1175921850 ## oap-server-bom/pom.xml: ## @@ -72,7 +72,7 @@ 3.0.0 4.4.13 1.21 - 0.4.0-SNAPSHOT +0.4.0-rc0 Review Comment:

[GitHub] [skywalking] lujiajing1126 commented on a diff in pull request #10448: Integrate BanyanDB server-side TopN

lujiajing1126 commented on code in PR #10448: URL: https://github.com/apache/skywalking/pull/10448#discussion_r1175343126 ## oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/BanyanDBAggregationQueryDAO.java:

[GitHub] [skywalking] lujiajing1126 commented on a diff in pull request #10448: Integrate BanyanDB server-side TopN

lujiajing1126 commented on code in PR #10448: URL: https://github.com/apache/skywalking/pull/10448#discussion_r1174603337 ## oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/BanyanDBAggregationQueryDAO.java:

[GitHub] [skywalking] lujiajing1126 commented on a diff in pull request #10448: Integrate BanyanDB server-side TopN

lujiajing1126 commented on code in PR #10448: URL: https://github.com/apache/skywalking/pull/10448#discussion_r1167728084 ## oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/BanyanDBAggregationQueryDAO.java:

[GitHub] [skywalking] lujiajing1126 commented on a diff in pull request #10448: Integrate BanyanDB server-side TopN

lujiajing1126 commented on code in PR #10448: URL: https://github.com/apache/skywalking/pull/10448#discussion_r1118953797 ## oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/BanyanDBAggregationQueryDAO.java:

[GitHub] [skywalking] lujiajing1126 commented on a diff in pull request #10448: Integrate BanyanDB server-side TopN

lujiajing1126 commented on code in PR #10448: URL: https://github.com/apache/skywalking/pull/10448#discussion_r1118953797 ## oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/BanyanDBAggregationQueryDAO.java:

[GitHub] [skywalking] lujiajing1126 commented on a diff in pull request #10448: Integrate BanyanDB server-side TopN

lujiajing1126 commented on code in PR #10448: URL: https://github.com/apache/skywalking/pull/10448#discussion_r1118955396 ## oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/BanyanDBAggregationQueryDAO.java:

[GitHub] [skywalking] lujiajing1126 commented on a diff in pull request #10448: Integrate BanyanDB server-side TopN

lujiajing1126 commented on code in PR #10448: URL: https://github.com/apache/skywalking/pull/10448#discussion_r1118955396 ## oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/BanyanDBAggregationQueryDAO.java:

[GitHub] [skywalking] lujiajing1126 commented on a diff in pull request #10448: Integrate BanyanDB server-side TopN

lujiajing1126 commented on code in PR #10448: URL: https://github.com/apache/skywalking/pull/10448#discussion_r1118953797 ## oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/BanyanDBAggregationQueryDAO.java:

[GitHub] [skywalking] lujiajing1126 commented on a diff in pull request #10448: Integrate BanyanDB server-side TopN

lujiajing1126 commented on code in PR #10448: URL: https://github.com/apache/skywalking/pull/10448#discussion_r1118944320 ## oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/BanyanDBAggregationQueryDAO.java:

[GitHub] [skywalking] lujiajing1126 commented on a diff in pull request #10448: Integrate BanyanDB server-side TopN

lujiajing1126 commented on code in PR #10448: URL: https://github.com/apache/skywalking/pull/10448#discussion_r1118923225 ## oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/BanyanDBAggregationQueryDAO.java:

[GitHub] [skywalking] lujiajing1126 commented on a diff in pull request #10448: Integrate BanyanDB server-side TopN

lujiajing1126 commented on code in PR #10448: URL: https://github.com/apache/skywalking/pull/10448#discussion_r1118923225 ## oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/BanyanDBAggregationQueryDAO.java:

[GitHub] [skywalking] lujiajing1126 commented on a diff in pull request #10448: Integrate BanyanDB server-side TopN

lujiajing1126 commented on code in PR #10448: URL: https://github.com/apache/skywalking/pull/10448#discussion_r1118900586 ## oap-server/oal-rt/src/main/java/org/apache/skywalking/oal/rt/OALRuntime.java: ## @@ -315,6 +326,30 @@ private Class generateMetricsClass(AnalysisResult

[GitHub] [skywalking] lujiajing1126 commented on a diff in pull request #10448: Integrate BanyanDB server-side TopN

lujiajing1126 commented on code in PR #10448: URL: https://github.com/apache/skywalking/pull/10448#discussion_r1118880408 ## oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/model/BanyanDBModelExtension.java: ## @@ -45,4 +46,23 @@ public class

[GitHub] [skywalking] lujiajing1126 commented on a diff in pull request #10448: Integrate BanyanDB server-side TopN

lujiajing1126 commented on code in PR #10448: URL: https://github.com/apache/skywalking/pull/10448#discussion_r1118877729 ## oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/MetadataRegistry.java: ##

[GitHub] [skywalking] lujiajing1126 commented on a diff in pull request #10448: Integrate BanyanDB server-side TopN

lujiajing1126 commented on code in PR #10448: URL: https://github.com/apache/skywalking/pull/10448#discussion_r1118877729 ## oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/MetadataRegistry.java: ##

[GitHub] [skywalking] lujiajing1126 commented on a diff in pull request #10448: Integrate BanyanDB server-side TopN

lujiajing1126 commented on code in PR #10448: URL: https://github.com/apache/skywalking/pull/10448#discussion_r1118877729 ## oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/MetadataRegistry.java: ##

[GitHub] [skywalking] lujiajing1126 commented on a diff in pull request #10448: Integrate BanyanDB server-side TopN

lujiajing1126 commented on code in PR #10448: URL: https://github.com/apache/skywalking/pull/10448#discussion_r1118731890 ## oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/MetadataRegistry.java: ##

[GitHub] [skywalking] lujiajing1126 commented on a diff in pull request #10448: Integrate BanyanDB server-side TopN

lujiajing1126 commented on code in PR #10448: URL: https://github.com/apache/skywalking/pull/10448#discussion_r1118095679 ## oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/BanyanDBAggregationQueryDAO.java:

[GitHub] [skywalking] lujiajing1126 commented on a diff in pull request #10448: Integrate BanyanDB server-side TopN

lujiajing1126 commented on code in PR #10448: URL: https://github.com/apache/skywalking/pull/10448#discussion_r1117939709 ## oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/BanyanDBAggregationQueryDAO.java: