[GitHub] [skywalking] qxo commented on pull request #5218: add a commons config API for get config key/value by: Config.getProperty

2020-08-05 Thread GitBox
qxo commented on pull request #5218: URL: https://github.com/apache/skywalking/pull/5218#issuecomment-669125529 > Don't need that API. All config class could be auto injected. Have you noticed all configs in file are same, but no attributes in the core config class? 此处应该有一链接,给大家给一个:

[GitHub] [skywalking] qxo commented on pull request #5218: add a commons config API for get config key/value by: Config.getProperty

2020-08-01 Thread GitBox
qxo commented on pull request #5218: URL: https://github.com/apache/skywalking/pull/5218#issuecomment-667513354 > Your concern has been removed. Config is totally isolated. Check the master and 8.1 tag. They have landed. ok, nerver mind. I'm on the master, which API for extern