[GitHub] [skywalking] stone-wlg edited a comment on issue #3330: Cassandra 3.x Plugin

2019-09-03 Thread GitBox
stone-wlg edited a comment on issue #3330: Cassandra 3.x Plugin URL: https://github.com/apache/skywalking/pull/3330#issuecomment-527756799 > @stone-wlg if it's not absolutely necessary, just push to the original branch and you don't need to open pull requests over and over again, learn how

[GitHub] [skywalking] stone-wlg edited a comment on issue #3330: Cassandra 3.x Plugin

2019-09-02 Thread GitBox
stone-wlg edited a comment on issue #3330: Cassandra 3.x Plugin URL: https://github.com/apache/skywalking/pull/3330#issuecomment-527144990 > You can't enhance abstract method or interface method. You could enhance subclass or implementor of interface. private class is ok ? -

[GitHub] [skywalking] stone-wlg edited a comment on issue #3330: Cassandra 3.x Plugin

2019-08-30 Thread GitBox
stone-wlg edited a comment on issue #3330: Cassandra 3.x Plugin URL: https://github.com/apache/skywalking/pull/3330#issuecomment-526654576 > > but finally other execute will call executeAsync(Statement var1), so i only intercept this method. > > @stone-wlg It is absolutely OK to inte

[GitHub] [skywalking] stone-wlg edited a comment on issue #3330: Cassandra 3.x Plugin

2019-08-30 Thread GitBox
stone-wlg edited a comment on issue #3330: Cassandra 3.x Plugin URL: https://github.com/apache/skywalking/pull/3330#issuecomment-526502186 > That VM is very powerful. 16U32G on GCP. How many resources do you need? We expect as little as possible, because every night, we run 700+ tests, whic

[GitHub] [skywalking] stone-wlg edited a comment on issue #3330: Cassandra 3.x Plugin

2019-08-28 Thread GitBox
stone-wlg edited a comment on issue #3330: Cassandra 3.x Plugin URL: https://github.com/apache/skywalking/pull/3330#issuecomment-526047673 > Do you finish your health check API in a real way? That is how you make sure you sever is standing by. is there a sample that is health check A

[GitHub] [skywalking] stone-wlg edited a comment on issue #3330: Cassandra 3.x Plugin

2019-08-28 Thread GitBox
stone-wlg edited a comment on issue #3330: Cassandra 3.x Plugin URL: https://github.com/apache/skywalking/pull/3330#issuecomment-525597066 > Link to your test case pull request at here, and post your local test result please. And you need to update `Supported-list.md`. https://github