tuohai666 commented on issue #4140: [Agent] Provide plugin for ShardingSphere
4.0.0-RC3
URL: https://github.com/apache/skywalking/pull/4140#issuecomment-569899849
@kezhenxu94 You are so smart. Thanks.
This is an automated
tuohai666 commented on issue #4140: [Agent] Provide plugin for ShardingSphere
4.0.0-RC3
URL: https://github.com/apache/skywalking/pull/4140#issuecomment-569896391
I have reproduced this problem in CentOS 7.6.
@kezhenxu94 I think your judgement is right. Classes are "hidden" in
tuohai666 commented on issue #4140: [Agent] Provide plugin for ShardingSphere
4.0.0-RC3
URL: https://github.com/apache/skywalking/pull/4140#issuecomment-569597655
@dmsolr Thanks for your help. I will firstly change to openjdk and then find
a Linux machine to find out the root cause.
tuohai666 commented on issue #4140: [Agent] Provide plugin for ShardingSphere
4.0.0-RC3
URL: https://github.com/apache/skywalking/pull/4140#issuecomment-569584970
@kezhenxu94 Yes, you are right, that will be better.
I checked my codes again and the test suceed again in local. Can
tuohai666 commented on issue #4140: [Agent] Provide plugin for ShardingSphere
4.0.0-RC3
URL: https://github.com/apache/skywalking/pull/4140#issuecomment-569582061
Typo, I mean I can...
I found something, let me have a test first.
tuohai666 commented on issue #4140: [Agent] Provide plugin for ShardingSphere
4.0.0-RC3
URL: https://github.com/apache/skywalking/pull/4140#issuecomment-569580087
@kezhenxu94 At the same time, can you do me a favor to test my repo in your
local? I cant pass the test in my local, now it's
tuohai666 commented on issue #4140: [Agent] Provide plugin for ShardingSphere
4.0.0-RC3
URL: https://github.com/apache/skywalking/pull/4140#issuecomment-569579288
@kezhenxu94 Thanks for your patience. I'll think about that.
tuohai666 commented on issue #4140: [Agent] Provide plugin for ShardingSphere
4.0.0-RC3
URL: https://github.com/apache/skywalking/pull/4140#issuecomment-569576063
@wu-sheng sharding-sphere-4.x-RC3-plugin.jar happened after the test finish.
To make the test success, the
tuohai666 commented on issue #4140: [Agent] Provide plugin for ShardingSphere
4.0.0-RC3
URL: https://github.com/apache/skywalking/pull/4140#issuecomment-569574271
@dmsolr That is not the root cause. Since you are here, please show me
where's the sharding-sphere-4.x-RC3-plugin.jar.
The
tuohai666 commented on issue #4140: [Agent] Provide plugin for ShardingSphere
4.0.0-RC3
URL: https://github.com/apache/skywalking/pull/4140#issuecomment-569572066
I prefer check the log or the artifact rather than YAML file. If the test
includes the new plugin, where is it?
tuohai666 commented on issue #4140: [Agent] Provide plugin for ShardingSphere
4.0.0-RC3
URL: https://github.com/apache/skywalking/pull/4140#issuecomment-569570862
From the log of ci, I found PluginsTest / Redisson_ShardingSphere_Zookeeper
(9:10) happened before CI AND IT / CI (9:36).
tuohai666 commented on issue #4140: [Agent] Provide plugin for ShardingSphere
4.0.0-RC3
URL: https://github.com/apache/skywalking/pull/4140#issuecomment-569266848
Your findings are not in the expectedData.yaml.
This is an
tuohai666 commented on issue #4140: [Agent] Provide plugin for ShardingSphere
4.0.0-RC3
URL: https://github.com/apache/skywalking/pull/4140#issuecomment-569266385
I can't see the picture. I think it doesn't matter about the order.
tuohai666 commented on issue #4140: [Agent] Provide plugin for ShardingSphere
4.0.0-RC3
URL: https://github.com/apache/skywalking/pull/4140#issuecomment-569265748
Yes, I checked this at the time when the test failed.
This is
tuohai666 commented on issue #4140: [Agent] Provide plugin for ShardingSphere
4.0.0-RC3
URL: https://github.com/apache/skywalking/pull/4140#issuecomment-569264721
I follow this procedure locally and the test passed:
1. ./mvnw clean package -Pagent,dist
2. ./test/plugin/run.sh -f
tuohai666 commented on issue #4140: [Agent] Provide plugin for ShardingSphere
4.0.0-RC3
URL: https://github.com/apache/skywalking/pull/4140#issuecomment-569259158
I've modified the interface parseSQL according to ShardingSphere 4.0.0-RC3.
But in the PluginsTest there's no parseSQL
tuohai666 commented on issue #4140: [Agent] Provide plugin for ShardingSphere
4.0.0-RC3
URL: https://github.com/apache/skywalking/pull/4140#issuecomment-569249461
I submit the plugin and its test case together, is it right?
It seems like the plugin didn't take effect when PluninsTest
17 matches
Mail list logo
