[GitHub] [skywalking] wu-sheng commented on issue #10461: [Feature] DCS supports global configuration

2023-03-20 Thread via GitHub
wu-sheng commented on issue #10461: URL: https://github.com/apache/skywalking/issues/10461#issuecomment-1476209716 Ref https://github.com/apache/skywalking/pull/10476#issuecomment-1476208961 We haven't finished this for now. -- This is an automated message from the Apache Git Service. T

[GitHub] [skywalking] wu-sheng commented on issue #10461: [Feature] DCS supports global configuration

2023-02-28 Thread via GitHub
wu-sheng commented on issue #10461: URL: https://github.com/apache/skywalking/issues/10461#issuecomment-1448090139 Notice, you should not break the existing config format. I would like to suggest the format like this ``` configurations: // NEW added global config key1 : v

[GitHub] [skywalking] wu-sheng commented on issue #10461: [Feature] DCS supports global configuration

2023-02-28 Thread via GitHub
wu-sheng commented on issue #10461: URL: https://github.com/apache/skywalking/issues/10461#issuecomment-1448087576 OK, if you want to do this, feel free to go. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [skywalking] wu-sheng commented on issue #10461: [Feature] DCS supports global configuration

2023-02-28 Thread via GitHub
wu-sheng commented on issue #10461: URL: https://github.com/apache/skywalking/issues/10461#issuecomment-1447945481 I am confused. Do we have service specific configuration on DCS? We don't plan to break existing configurations. -- This is an automated message from the Apache Git Service

[GitHub] [skywalking] wu-sheng commented on issue #10461: [Feature] DCS supports global configuration

2023-02-28 Thread via GitHub
wu-sheng commented on issue #10461: URL: https://github.com/apache/skywalking/issues/10461#issuecomment-1447908579 And this seems a discussion only. Feature is something you are going to do, or committers planned to do. -- This is an automated message from the Apache Git Service. To respo

[GitHub] [skywalking] wu-sheng commented on issue #10461: [Feature] DCS supports global configuration

2023-02-28 Thread via GitHub
wu-sheng commented on issue #10461: URL: https://github.com/apache/skywalking/issues/10461#issuecomment-1447907615 You seem to ask for `agent-analyzer.default.traceSamplingPolicy` only? If so, there is `default` for that already. https://skywalking.apache.org/docs/main/next/en/setup/b