wu-sheng commented on issue #3330: Cassandra 3.x Plugin
URL: https://github.com/apache/skywalking/pull/3330#issuecomment-529329806
> ok, but i do not want to leave unnecessary log in git log.
Check `git rebase`, you could do that then force push.
wu-sheng commented on issue #3330: Cassandra 3.x Plugin
URL: https://github.com/apache/skywalking/pull/3330#issuecomment-527148574
No limit about private or public
This is an automated message from the Apache Git Service.
To
wu-sheng commented on issue #3330: Cassandra 3.x Plugin
URL: https://github.com/apache/skywalking/pull/3330#issuecomment-527143878
You can't enhance abstract method or interface method. You could enhance
subclass or implementor of interface.
wu-sheng commented on issue #3330: Cassandra 3.x Plugin
URL: https://github.com/apache/skywalking/pull/3330#issuecomment-526788836
@stone-wlg For async, in order to make sure exit span duration accuration.
Besides intercepting callback and creating local span there, you should take a
look
wu-sheng commented on issue #3330: Cassandra 3.x Plugin
URL: https://github.com/apache/skywalking/pull/3330#issuecomment-526614940
+1 for @kezhenxu94 's review.
This is an automated message from the Apache Git Service.
To
wu-sheng commented on issue #3330: Cassandra 3.x Plugin
URL: https://github.com/apache/skywalking/pull/3330#issuecomment-526562279
I think we have already rumning in this way. Right? @zhaoyuguang
This is an automated message
wu-sheng commented on issue #3330: Cassandra 3.x Plugin
URL: https://github.com/apache/skywalking/pull/3330#issuecomment-526506594
I think the key is running all cases once because that is the case they
facing after merged.
wu-sheng commented on issue #3330: Cassandra 3.x Plugin
URL: https://github.com/apache/skywalking/pull/3330#issuecomment-526495778
That VM is very powerful. 16U32G on GCP. How many resources do you need? We
expect as little as possible, because every night, we run 700+ tests, which
have
wu-sheng commented on issue #3330: Cassandra 3.x Plugin
URL: https://github.com/apache/skywalking/pull/3330#issuecomment-526483862
@stone-wlg CI improvement is in #3308. Don't worry about that. Have you
figured out why integration test breaks?
wu-sheng commented on issue #3330: Cassandra 3.x Plugin
URL: https://github.com/apache/skywalking/pull/3330#issuecomment-526466366
/run ci
This is an automated message from the Apache Git Service.
To respond to the message,
wu-sheng commented on issue #3330: Cassandra 3.x Plugin
URL: https://github.com/apache/skywalking/pull/3330#issuecomment-526098770
Please fix conflict, we have merged a new plugin.
This is an automated message from the Apache
wu-sheng commented on issue #3330: Cassandra 3.x Plugin
URL: https://github.com/apache/skywalking/pull/3330#issuecomment-526048197
There is an API required in your test case, in there, you could use codes to
check the target server.
wu-sheng commented on issue #3330: Cassandra 3.x Plugin
URL: https://github.com/apache/skywalking/pull/3330#issuecomment-526044488
Do you finish your health check API in a real way? That is how you make sure
you sever is standing by.
wu-sheng commented on issue #3330: Cassandra 3.x Plugin
URL: https://github.com/apache/skywalking/pull/3330#issuecomment-526043166
> i have checked test report 1 and test report 2, it seems like env issue.
:) Could you re-run it several times, i suppose that will give us different
wu-sheng commented on issue #3330: Cassandra 3.x Plugin
URL: https://github.com/apache/skywalking/pull/3330#issuecomment-526038345
@stone-wlg Still 2 fails.
This is an automated message from the Apache Git Service.
To
wu-sheng commented on issue #3330: Cassandra 3.x Plugin
URL: https://github.com/apache/skywalking/pull/3330#issuecomment-525997254
Could the check the test log? There is a link there.
This is an automated message from the
wu-sheng commented on issue #3330: Cassandra 3.x Plugin
URL: https://github.com/apache/skywalking/pull/3330#issuecomment-525987545
@stone-wlg The result is 2 passed, 2 failure. Could you recheck what happen?
This is an
wu-sheng commented on issue #3330: Cassandra 3.x Plugin
URL: https://github.com/apache/skywalking/pull/3330#issuecomment-525748355
@zhaoyuguang Please run the tests in our INFRA.
This is an automated message from the Apache
wu-sheng commented on issue #3330: Cassandra 3.x Plugin
URL: https://github.com/apache/skywalking/pull/3330#issuecomment-525595244
Link to your test case pull request at here, and post your local test result
please. And you need to update `Supported-list.md`.
wu-sheng commented on issue #3330: Cassandra 3.x Plugin
URL: https://github.com/apache/skywalking/pull/3330#issuecomment-525166138
The test case is required here,
https://github.com/SkyAPMTest/agent-auto-integration-testcases
wu-sheng commented on issue #3330: Cassandra 3.x Plugin
URL: https://github.com/apache/skywalking/pull/3330#issuecomment-524851351
Please fix CI.
This is an automated message from the Apache Git Service.
To respond to the
21 matches
Mail list logo
