[GitHub] [skywalking] wu-sheng commented on issue #3370: support es https ssl config.

2019-09-01 Thread GitBox
wu-sheng commented on issue #3370: support es https ssl config. URL: https://github.com/apache/skywalking/pull/3370#issuecomment-526896512 /run ci This is an automated message from the Apache Git Service. To respond to the

[GitHub] [skywalking] wu-sheng commented on issue #3370: support es https ssl config.

2019-09-01 Thread GitBox
wu-sheng commented on issue #3370: support es https ssl config. URL: https://github.com/apache/skywalking/pull/3370#issuecomment-526895177 @hanahmily @JaredTan95 Anything needs to update? This is an automated message from the

[GitHub] [skywalking] wu-sheng commented on issue #3370: support es https ssl config.

2019-08-29 Thread GitBox
wu-sheng commented on issue #3370: support es https ssl config. URL: https://github.com/apache/skywalking/pull/3370#issuecomment-526428694 @JaredTan95 One thing crosses my mind, this is useful if SkyWalking supports multiple HTTP peers, such as ES https, export https, dynamic configuration

[GitHub] [skywalking] wu-sheng commented on issue #3370: support es https ssl config.

2019-08-29 Thread GitBox
wu-sheng commented on issue #3370: support es https ssl config. URL: https://github.com/apache/skywalking/pull/3370#issuecomment-526427122 > As far as I know, there should be no difference. That's why I'm just talking about which way we're going to choose. @hanahmily Any suggestions?

[GitHub] [skywalking] wu-sheng commented on issue #3370: support es https ssl config.

2019-08-29 Thread GitBox
wu-sheng commented on issue #3370: support es https ssl config. URL: https://github.com/apache/skywalking/pull/3370#issuecomment-526424596 Then why should we change? Is there any difference between those two ways? This is an

[GitHub] [skywalking] wu-sheng commented on issue #3370: support es https ssl config.

2019-08-29 Thread GitBox
wu-sheng commented on issue #3370: support es https ssl config. URL: https://github.com/apache/skywalking/pull/3370#issuecomment-526423399 You prefer to add the JVM things you mentioned in the document, some people may be not familiar with that.

[GitHub] [skywalking] wu-sheng commented on issue #3370: support es https ssl config.

2019-08-29 Thread GitBox
wu-sheng commented on issue #3370: support es https ssl config. URL: https://github.com/apache/skywalking/pull/3370#issuecomment-526419641 @JaredTan95 Look like we need a document update at es storage section. This is an